Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Marc Véron	c087027487	Bug 10956 - Series of OPAC searches can cause a browser crash This patch fixes the issue for bootstrap. It was earlier fixed for the prog theme. Solution: Prevent jQuery.fn.highlight = function(pat) to be called with empty pat by skipping empty values in highlight loop. To test: Without patch, do a search as in comment #1 odr #3 Result: Endless loop (Script not responding) Appply patch: No endless loop, page displays OK Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> To reproduce you need to search a string with 2 spaces. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> I didn't manage to reproduce the problem, but I couldn't find any regression either trying multiple searches. Trusting Marc's and Jonathan's testing. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Jonathan Druart	33f53e4dfd	Bug 13329: Fix create a suggestion at the OPAC The suggestion table does not contain a 'branch' column name. The script should pass 'branchcode' to C4::Suggestion::NewSuggestion. Test plan: 0/ Enable the AllowPurchaseSuggestionBranchChoice pref 1/ Create a suggestion at the OPAC should not raise a DBIx::Class error. I could reproduce the bug. With patch bug is gone. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, thx for the quick fix. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Owen Leonard	aeb86b69eb	Bug 13271 - Subject search links broken if XSLT and OPACPopupAuthorsSearch are both off This patch corrects some faults in the OPAC's bootstrap template which prevent additional author and subject searches from working correctly with OPACPopupAuthorsSearch both on and off. Some JavaScript has been removed because it was used only by the prog theme and is obsolete. Locate a title with multiple subjects and additional authors. Test the following conditions: OPACXSLTDetailsDisplay is blank and OPACPopupAuthorsSearch is off: - Clicking an additional author or subject link should directly trigger the correct search without an JavaScript error. OPACXSLTDetailsDisplay is blank and OPACPopupAuthorsSearch is on: - Clicking an additional author or subject link should trigger a modal window where you can select options for searching. Checking boxes and submitting the form should perform the correct search. OPACXSLTDetailsDisplay is set to "default" and OPACPopupAuthorsSearch is on OR off: - Clicking an additional author or subject link should directly trigger the correct search without an JavaScript error. (OPACPopupAuthorsSearch only works with the non-XSL view). For extra credit: Test with JavaScript disabled and confirm that link still work correctly. Signed-off-by: Frederic Demians <f.demians@tamil.fr> I confirm the bug and the solution. Before various JS errors: "ReferenceError: e is not defined" and "ReferenceError: showSubjects is not defined". After: Comforting silence, and functionnality. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Stéphane Delaune	45cfe50a17	Bug 13247 - Move opacuserjs at the end of opac-bottom.inc This patch makes opacuserjs compatible with tracking tools like Piwik Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Small change to enable use of opacuserjs for statistical tools like Piwik by moving it right above </body>. Works as described. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Fridolin Somers	260c423be8	Bug 11515 - Encoding problem with OpacBrowseResults When OpacBrowseResults syspref is on, the detail page contains a results browser. When search terms contains non-ASCII character, the search query is not well encoded in this browser. This patch adds the URI-coding to search terms into session to avoid any encoding problem with diacritics and URI specific characters like ?,& ... So that TT parameter 'busc' is already URI encoded and can be used to recreate seach URL. Test plan : - Set OpacBrowseResults on - At OPAC, perform a search with a diacritique. For example 'déjà' - Go to detail page of a result => You see browser under "Browser results" - Click on "Back to results" => You get same results and same search term with correct encoding Signed-off-by: Broust <jean-manuel.broust@univ-lyon2.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Bug still present on master. I note that latin characters are taken by ISO-8859-1 encoding (Perl's default) and that's why real UTF8 ones don't break (Perl notices they are UTF-8).	11 years ago
Owen Leonard	535a224b87	Bug 13234 [Follow-up] Make on-site checkouts visible in OPAC This follow-up makes a few changes to the template: 1. The "show all" / "show 50" links have been modified to show the current state. 2. The tabs are only shown if the OnSiteCheckouts preference is turned on. 3. The DataTables configuration has been modified so that title sorting ignores articles, sorting on the the first column is disabled, and sorting by date works regardless of your dateformat preference. 4. Some indentation has been corrected and markup comments added. To test the opacreadinghistory preference must be enabled. Log in to the OPAC as a patron who has some on-site checkouts as well as regular checkouts. With OnSiteCheckouts enabled, view the reading history page and confirm that the tabs work correctly. Test the table sorting controls. With OnSiteCheckouts disabled, confirm that the tabs do not appear. Test the "Show all items"/"Show last 50 items" links and confirm that the behavior is correct. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Works as described, passes tests and QA script. Good addition to the new on-site feature. Note: It would be nice to show the 'on-site' note also in the liste of checkouts on the summary page! Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Jonathan Druart	f7d31f3916	Bug 13234: On-site checkouts - OPAC This patch introduces the code lost in bug 10860 for the OPAC side. Test plan: Go on opac-readingrecord.pl and verify the tabs work as expected and the "show all items" and "show 50 items" links. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Katrin Fischer	81e4aebd0a	Bug 13227: Display856uAsImage displays images in OPAC in original size To test: - catalog a record with 856$u = URL to an image, $q = img - turn on the system preference Display856uAsImage - make sure your record has been reindexed by Zebra - verifiy the image indeed displays on the result and detail page in the bootstrap catalog. The image shows in the original size, from the code it's meant to display with a height of 100 px, but this won't work in bootstrap as the height is set to auto with CSS. Patch changes the XSLT to restore the former behaviour. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Olli-Antti Kivilahti	51f0a0b722	Bug 13116 - Make it possible to propagate errors from C4::Reserves::CanItemBeReserved() to the web-templates. This patch changes the way CanBookBeReserved() and CanItemBeReserved() return error messages and how they are dealt with in the templates. This change makes it possible to distinguish between different types of reservation failure. Currently only two types of errors are handled, all the way to the user, from the CanItemBeReserved(): -ageRestricted -tooManyReserves which translates to maxreserves ############# - TEST PLAN - ############# ((-- AGE RESTRICTION --)) STAFF CLIENT 1. Find a Record with Items, update the MARC Subfield 521a to "PEGI 16". 2. Get a Borrower who is younger than 16 years. 3. Place a hold for the underage Borrower for the ageRestricted Record. 4. You get a notification, that placing a hold on ageRestricted material is forbidden. (previously you just got a notification about maximum amount of reserves reached) ((-- MAXIMUM RESERVES REACHED --)) 0. Set the maxreserves -syspref to 3 (or any low value) STAFF CLIENT AND OPAC 1. Make a ton of reserves for one borrower. 2. Observe the notification about maximum reserves reached blocking your reservations. ((-- MULTIPLE HOLDS STAFF CLIENT --)) 3. Observe the error notification "Cannot place hold on some items" ((-- MULTIPLE HOLDS OPAC --)) 1. Make a search with many results, of which atleast one is age restricted to the current borrower. 2. Select few results and "Place hold" from to result summary header element. (Not individual results "Place hold") 3. Observe individual Biblios getting the "age restricted"-notification, where others can be reserved just fine. Updated the unit tests to match the new method return values. t/db_dependent/Holds.t & Reserves.t Followed test plan. Works as expected and displays meaningful messages for the reason why placing a hold is not possible. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Owen Leonard	9042ce4ea5	Bug 10632 [Follow-up] Enable datatables for courses and course details in the OPAC This follow-up adds some style improvements and corrects some errors in the previous patch: - The path to datatables.css has been corrected - Unused CSS has been removed from datatables.css (particularly related to pagination controls, which are currently unused in the OPAC). - Style has been added to datatables.css to make the table search form look better. - The configuration of the course details table has been enhanced to include a title sort which ignores articles and date sorting according to the "title-string" method for date format agnostic sorting. - Unrelated: A message <div> has been modified to have the correct style for the Bootstrap theme. To test you should have multiple courses and at least one course with multiple reserves. Clear your browser cache if necessary and view the list of courses in the OPAC. All table sorting should work correctly, as should the table search form. View the details of a course which has multiple reserves. All sorting should work correctly, including title sort excluding articles. Sorting by date due should work correctly for any dateformat system preference setting. View the details of a course which has no reserves. You should see a "No reserves" message box with a style consistent with similar messages in the Bootstrap OPAC. View other sorted tables in the OPAC to confirm that the CSS changes have not negatively affected their appearance: opac-user.pl for instance, or opac-detail.pl. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Kyle Hall	4413a1ac4a	Bug 10632 - Enable datatables for courses and course details in the OPAC We should use datatables for the courses and course items tables. This will make the tables sortable and searchable from the client side. Test Plan: 1) Apply this patch 2) View the courses in the OPAC, try sorting and searching 3) View the course details for a course, try sorting and searching the items. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signing off, but have a follow-up to address some missing stuff. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Owen Leonard	9b28d8fa5b	Bug 9214 [Compiled CSS] Show damaged status in the OPAC for items which are not for loan This patch contains the compiled opac.css file generated from the revised LESS file in this bug's other patch. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Owen Leonard	b197d8bf90	Bug 9214 - Show damaged status in the OPAC for items which are not for loan Item statuses in the OPAC displayed according to a cascading hierarchy: If something is lost it will appear as lost, "else if" it is checked out it will appear as checked out, etc. I don't think there is a logical reason why statuses should appear this way. This patch modifies the logic in the template so that multiple statuses can be displayed at the same time. The patch also wraps each status in its own class so that libraries can apply custom CSS if they wish. Some tweaks have been made to the LESS file adding some style to the common "item-status" class for display of item statuses. To test, apply the patch and view one or more titles in the OPAC which have items with the following statuses: lost, checked out, damaged, not for loan, waiting, on order, in transit, withdrawn, and available. Modify items to have more that one status simultaneously, in particular not for loan and damaged. Also test the display of item statuses in the OPAC cart and the OPAC's course details page (Course reserves -> [Course name]) since these pages use the same include file. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Jonathan Druart	954c2874d0	Bug 12986: Upgrade the DataTables jQuery plugin to the latest version (1.10.2) DataTables 1.10.2 is now available. The footerCallback function does not seem to work correctly with our current version. Test plan: Go on the maximum of pages where DataTables is used and try to catch a bug/regression :) Signed-off-by: Owen Leonard <oleonard@myacpl.org> I tested many many pages with DataTables, taking special care to find pages with different DataTables configurations. I found no errors in the OPAC or staff client. Tested thoroughly in Firefox (latest) on Windows 7. Tested less thoroughly in Chrome (latest) on Windows 7. Tested briefly in Internet Explorer 7 in Vista and Internet Explorer 8 and found no bugs which were related to the DataTables upgrade. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Kyle Hall	b143d68534	Bug 9043 [QA Followup] - Don't show "More options" are there aren't any Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Jonathan Druart	b1174b24a1	Bug 9043: Changes to the advanced search page This patch adds 2 new sysprefs: OpacAdvSearchOptions and OpacAdvSearchMoreOptions. These sysprefs are multivalued and you can add or remove some elements on the adv search page. This patch allows to display/hide some entries in the advanced search page at the OPAC. On this way, it is possible to configure the search options to display. Test plan: 1/ Fill OpacAdvSearchOptions with Item types and Languages. Fill OpacAdvSearchMoreOptions with Item types, Languages and Location. On the advanced search page, verify the Location is only displayed for the "More options" view. 2/ Try different settings for these prefs 3/ Remove all entries for the OpacAdvSearchMoreOptions and verify that the "More options" does not displayed additional options. 4/ Remove all entries for the OpacAdvSearchOptions and verify that the "normal view" does not displayed any options. Note that this patch only affects the bootstrap theme. Signed-off-by: Koha Team Lyon 3 <koha@univ-lyon3.fr> Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	12 years ago
Katrin Fischer	1e5097d0fa	Bug 12334: Make it easy to hide parts of material type and format information in results With the system preferences DisplayIconsXSLT and DisplayOPACiconsXSLT we control the visibility of the material type, format and audience information in staff and OPAC. Sometimes a library might only want to hide a part of that information - for example, hide audience but keep the material type icon. This patch adds CSS classes to make it easier to style this section of the page and hide parts of the information. To test: - Verify that OPAC and staff result lists for various types of materials still display nicely. - Take a look at the HTML and verify, that label and text are now wrapped into a new span with a results_* class. - Try hiding a part of the information, for example in OpacUserCSS: .results_material_type { display none; } Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works as described... but for a missing colon on example CSS .results_material_type { display: none; } No koha-qa errors Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Tomás Cohen Arazi	3fb57f34ea	Bug 12829: properly skip invalid ISBN when rendering for normal record display Currently, 020$z (and 010$z fr UNIMARC) occurences are not shown, but the XSLT logic used introduces punctuation characters for those $z occurences. This patch adds a check for the existence of subfield a, and only loops on $a subfields. To test: - Create/have a record with 020$z (or 010$z on UNIMARC) but no 020$a (no 010$a on UNIMARC). - Open the detail page for the record (on both OPAC and staff). => FAIL: the ISBN label and ';' and '.' characters incorrectly shown. - Repeat mixing with 020$a occurences to notice the bug. - Apply the patch, reload => SUCCES: ISBN label shows only on the presence of a $a, and $z are skipped. no matter how many ISBN fields you add. - Sign off :-D Regards To+ http://bugs.koha-community.org/show_bug.cgi?id=12901 Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Amit Gupta	f4bd79217c	Bug 13144: Google transliteration does not work on bootstrap To Test: Use Google Indic Transliteration API to allow users to transliterate english typed words into Indic languages. http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=6ae7b60962e7d07aa00a45a7af692939a4ce7aa6 Signed-off-by: Frederic Demians <f.demians@tamil.fr> I had been able to reproduce the bug (a regression), and I can confirm that this patch fix it. But I had to create manualy GoogleIndicTransliteration system preference, which doesn't exist in standard .pref file. It may be necessary to add it. In my opinion, it shouldn't prevent to include this patch. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixes a somewhat 'hidden' feature, no problems found. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Katrin Fischer	0402e4e636	Bug 10860: Follow-up - fix some template variable issues Fixing some simple display issues caused by missing/misnamed variables, probably consequence of the renaming before. Amended test plan: - Make sure that if OnSiteCheckoutsForce is set, you can still perform onsite checkouts and only those. - Check the detail page in staff says currently in local use by for an on-site checked out item - Check the detail page in OPAC with OPACShowCheckoutName active for the same. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Kyle Hall	ca13806073	Bug 10860 - Change "in-house use" to "on-site checkout" Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Jonathan Druart	2e72eb8880	Bug 10860: In-House Use This patch implements the In-House Use feature for Koha. It adds: - 2 new sysprefs: 'In-House Use' to enable/disable this feature 'In-House Use Forced' to enable/disable the feature for all users. - 2 new columns issues.inhouse_use and old_issues.inhouse_use - Datatable on the circulation history pages (readingrec) at the OPAC and the intranet. A new checkbox in the Circulation tab. If checked, the issue become a in-house use (in the statistics and issues tables). When you check it, the due date changes to the today date. The syspref "In-House Use Force" allows to force the in-house use to permit the checkout even if the borrower is debarred or others problems. In the issue table, a new string (in red) marks the issue as "in-house use". The circulation history contains 3 tabs : "all", "checkout" and "in-house use" (OPAC and intranet). The cronjob script: If AutomaticItemReturn if off, a library would like not to do a transit operation manually. This script (to launch each night) do returns for a specific branches. Test plan: 1/ Execute the updatedatabase entry 2/ Enable the 'In-House Use' pref. 3/ Checkout a biblio for a patron and check the 'in-house use' checkbox. 4/ Check that the due date is the today date (with 23:59) and is not modifiable. 5/ Click on the check out button and check that the new check out appears in the table bellow with the "(In-house use)" string. 6/ Go on the circulation history pages (readingrec and opac-readingrec) and try the 3 tabs. In the last one, your last checkout should appear. 7/ Check in. 8/ Check readingrec pages. 9/ Choose a debarred patron and check that you cannot checkout a biblio for him. 10/ Switch on the 'In-House Use Forced' pref 11/ You are now allowed to checkout a biblio for the debarred patron. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	11 years ago
Katrin Fischer	f8d06e1daf	Bug 11517: Braille and combination swapped in XSLT result lists http://www.loc.gov/marc/bibliographic/bd007f.html - Catalog a record: * 007 - choose 'Tactile material' * Pos. 1 - choose b = Braille or C = combination * Reindex! * Verify the result list shows the format correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Problem exist, fixed with this patch. No koha-qa errors Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Tomás Cohen Arazi	65e0fba94b	Bug 13164: Incorrect ISSN visualization on the normal view if invalid/cancelled ISSN present Currently, 022$z (and 011$z for UNIMARC) occurences are not shown, but the XSLT logic used introduces punctuation characters for those $z occurences. This patch adds a check for the existence of subfield a, and only loops on $a subfields. To test: - Create/have a record with 022$z (or 011$z on UNIMARC) but no 022$a (no 011$a on UNIMARC). - Open the detail page for the record (on both OPAC and staff). => FAIL: the ISSN label and ';' and '.' characters incorrectly shown. - Repeat mixing with 022$a occurences to notice the bug. - Apply the patch, reload => SUCCES: ISSN label shows only on the presence of a $a, and $z are skipped. no matter how many ISSN fields you add. - Sign off :-D Regards To+ Signed-off-by: Frederic Demians <f.demians@tamil.fr> Works as described on an UNIMARC DB. Mimics what's done for ISBN field. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Chris Cormack	0f41f12621	Bug 13174 : XSLT fails if, and only if you have an author, linked to an authority And only in MARC21 To test: Only for MARC21 with XSLT on for detail 1/ Find a record that has an authority linked author in it 2/ View the detail page in the opac 3/ Notice bibliographic data is missing 4/ Apply patch 5/ Refresh notice bibliographic data is back Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as describe, the details are back! Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Tomás Cohen Arazi	19d3e55032	Bug 12901: (QA followup) correct copy and paste error Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Works as described now, no problems found. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Tomás Cohen Arazi	eedc8e3543	Bug 12901: (consistency followup) add buildBiblioDefaultViewURL to MARC21 XSLT Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> http://bugs.koha-community.org/show_bug.cgi?id=9828 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Tomás Cohen Arazi	53a6369ba3	Bug 12901: BiblioDefaultView doesn't do anything with NORMARC or UNIMARC XSLT Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> http://bugs.koha-community.org/show_bug.cgi?id=9828 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Frédéric Demians	4f6d1c7ae2	Bug 13145 UNIMARC 610 tag isn't displayed in OPAC when there is no $9 subfield On OPAC detail page, subject fields are not displayed when they are not linked to authorities ($9 subfield). This is due to a misplelling in UNIMARC XSL detail page. TO TEST: (1) On a Koha UNIMARC, find out a biblio record with a 610 field, without $9 subfield. Something like: 610 1 $a Aliment -- Approvisionnement -- Europe -- Histoire Or add such a field to an existing record. (2) Check that OPACXSLTDetailsDisplay is set to 'default' (3) See this record on OPAC detail page. You must see 'Subject: ' => nothing after the 'Subject' label. If your record contains several 610 fields without $9, the \| character will appear, separating no content. (4) Apply the patch. (5) Reload the page seen at step (3): subject is displayed now. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, tested on a UNIMARC installation. Small XSLT change. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Tomás Cohen Arazi	91eb56cdc4	Bug 12233: Remove the prog and ccsr themes files Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>	10 years ago
Mark Tompsett	72fc58b15c	Bug 12653: Text file clean up _README.txt has 4 newlines removed. _COPYING.txt has 2 empty lines at the end of the file removed. This was done by copying the smallest file in an existing theme directory. TEST PLAN --------- 1) Compare files. diff koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/crystal-clear/_COPYING.txt koha-tmpl/opac-tmpl/prog/itemtypeimg/crystal-clear/_COPYING.txt diff koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/crystal-clear/_COPYING.txt koha-tmpl/opac-tmpl/ccsr/itemtypeimg/crystal-clear/_COPYING.txt diff koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/crystal-clear/_COPYING.txt koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/crystal-clear/_COPYING.txt diff koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/crystal-clear/_README.txt koha-tmpl/opac-tmpl/prog/itemtypeimg/crystal-clear/_README.txt diff koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/crystal-clear/_README.txt koha-tmpl/opac-tmpl/ccsr/itemtypeimg/crystal-clear/_README.txt diff koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/crystal-clear/_README.txt koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/crystal-clear/_README.txt -- there will be differences. 2) Apply patch 3) Compare files again. diff koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/crystal-clear/_COPYING.txt koha-tmpl/opac-tmpl/prog/itemtypeimg/crystal-clear/_COPYING.txt diff koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/crystal-clear/_COPYING.txt koha-tmpl/opac-tmpl/ccsr/itemtypeimg/crystal-clear/_COPYING.txt diff koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/crystal-clear/_COPYING.txt koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/crystal-clear/_COPYING.txt diff koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/crystal-clear/_README.txt koha-tmpl/opac-tmpl/prog/itemtypeimg/crystal-clear/_README.txt diff koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/crystal-clear/_README.txt koha-tmpl/opac-tmpl/ccsr/itemtypeimg/crystal-clear/_README.txt diff koha-tmpl/intranet-tmpl/prog/img/itemtypeimg/crystal-clear/_README.txt koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/crystal-clear/_README.txt -- there will be no differences. 4) git reset --hard origin/master 5) Apply the patch affecting the .t files. 6) Prove things. prove xt/author/icondirectories.t xt/author/translatable-templates.t xt/author/valid-templates.t xt/single_quotes.t xt/tt_valid.t -- expecting xt/author/icondirectories.t to fail 7) Apply this patch. 8) Prove things. prove xt/author/icondirectories.t xt/author/translatable-templates.t xt/author/valid-templates.t xt/single_quotes.t xt/tt_valid.t -- expecting success. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> This patch fixes some issues with files on itemtypes dirs. No koha-qa erros. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>	10 years ago
Owen Leonard	b72efe9e71	Bug 12655 [Revised] PROG/CCSR deprecation: Correct hard-coded opac-tmpl/prog path in XSLT Two XSL files in the bootstrap theme contain hard-coded paths to the prog theme directory. This patch adds a query of the opacthemes system preference and builds the path based on the returned value. To test in a MARC21 system: Create or locate a record which contains a subject which is linked to an authority record. View the detail page for that record in the bootstrap OPAC and confirm that there is a magnifying class icon next to the link for that subject heading. Inspect or right-click the image and "View image" [FF. "Open image in new tab" in Chrome] to verify that the image being shown is from the bootstrap theme directory. Also modified: The NORMARC XSL for the detail page which has been changed in the same way. I did not test it in a NORMARC catalog. Edit: Fixed copy-and-paste error causing duplicate image. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>	10 years ago
Katrin Fischer	a781391a95	Bug 12281: Display for records with RTL script in 880 in Boostrap This patch adds a missing CSS declaration to the Boostrap CSS file in order to fix the display for RTL script catalogued in tag 880. To test: - Catalog or import records using the 880 tag into your catalog - Compare the prog OPAC detail and rsult view with bootstrap - Apply patch - Verfiy now the display in bootstrap is the same as before in prog (and also in staff) Note: Some notes on how to catalog with 880 were added to the bug report. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Marcel de Rooy	1b695f7dd7	Bug 13095: An email will be sent shortly This patch adjusts two instances where Koha says that an email has been sent while it is just enqueued (put in the message queue). The crontab example still suggests to run process_message_queue once an hour and the manual even speaks about 1-4 hours. In the process of selfregistration and sharing a shelf, I have adjusted the text "has been sent" to "will be sent shortly". This covers imo the one-hour frequency. When writing this patch, I have examined all calls of EnqueueLetter; I only found these two occurrences to be of interest. Note: I would recommend to increase this frequency in the documentation, but consider that for now to be outside the scope of this report. Test plan: [1] Self-register a new user with verification by email required. Look at the text when you submit your data. [2] Share a list with someone else. Look at the text when you submit the invitation. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, small string change. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Marc Véron	8523a01f47	Bug 13112 - Add name of template file in html comment for each '.tt' file. This patch adds the name of the .tt file as a HTML comment to OPAC and Staff client pages. To test: Apply patch Open pages in OPAC and Staff client. Make sure that a comment similar to the following appears in the source code: <!-- TEMPLATE FILE: intranet-main.tt --> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Owen Leonard	b52a24efb2	Bug 13083 - Hard-coded " by " in opac-tags.pl The OPAC's list of a logged-in user's tagged titles displays title and author, which for some reason are combined in the script into one variable. I can't see any reason to do it this way. This patch modifies the script so that title and author are passed as separate variables. In addition, subtitle is now passed as well. To test you must log into the OPAC as a user who has tagged multiple titles, at least one of which should have an author and at least one with a subtitle. View the list of tagged titles and confirm that this information is being displayed correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes tests and QA script. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Owen Leonard	f13eca4234	Bug 13120 - Invalid HTML generated by MARC21slim2OPACResults.xsl This patch converts an id to a class in order to avoid duplicate id attributes on one page. To test you must have XSLT enabled with the default setting. Perform a search in the OPAC and confirm that the display of location looks correct. Run the resulting page through a validator using an in-browser tool like Firefox's Html Validator addon or using the W3C's validator.w3.org. The results should not complain of duplicate id attributes. Signed-off-by: Frederic Demians <f.demians@tamil.fr> OK for me. Obvious mistake: I can confirm FF HTML validator reports it, and stop reporting it after applying this patch. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> I can confirm this fix is correct. Also, I found that jQuery doesn't like repeated ids in some cases so this will make customizing easier. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Mark Tompsett	cf1a63cb0c	Bug 12862: OPAC bootstrap - clean up language="javascript" There was a <script language="javascript"> tag. It was cleaned up to be <script type="text/javascript">. Also, the div was being chopped because the script was in the middle of the div. Moving it to head solved the issues. This is difficult to test, since the printslip is triggered when you click Finish. TEST PLAN --------- 1) Home -> Koha administration -> Global system parameters -> OPAC 2) Set the OPAC system preference 'opacthemes' to 'bootstrap'. 3) Start the self-checkout client (/cgi-bin/koha/sco/sco-main.pl) 4) Log in. 5) Check something out. 6) Change the address url text box to .../cgi-bin/koha/sco/printslip.pl?borrowernumber=##&print=qslip Where ## is your borrower number which just checked something out. 7) Click Cancel on the print dialogue 8) View Page Source -- The HTML validation plugin will point out multiple errors. 9) Apply patch 10) Refresh page 11) View Page Source -- Much happier validation results. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Robin Sheat	ecb1e046a6	Bug 12296: make search box customisable with OpacCustomSearch This allows the search box to be replaced by some custom HTML, useful when you're needing to integrate with some other search system, and don't want to maintain a template change across upgrades. Test plan: * Install patch * Look at the OPAC, see that nothing has changed. * Change the OpacCustomSearch syspref to something like <h1>Zuul</h1> * Look at the OPAC again, you can no longer search, there is only Zuul. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Works as advertised. Seems like it would be really easy to screw up your OPAC with this feature, but since we already offer other easy ways to screw up your OPAC I guess this fits in. New patch changes: removed the bootstrap code, changed the entry in syspref.sql Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes QA script and tests. The feature has some limitations, described on the bug. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Marcel de Rooy	c4e218fe20	Bug 12726: Show RDA tag 264 on OPAC Results XSLT view (MARC21) This patch adds the same information to the Publisher line of OPAC Results as bug 12724 did on OPAC Detail. To accomplish this and reduce repeated code, two XSLT routines (named templates) are moved from OPACDetail to MARC21slimUtils. Test plan (see also bug 12742 and the rules mentioned there): [1] Add tag 260 and some 264s to your MARC21 record. [2] Check the display of OPAC Details. Should not have changed. [3] Now check also the display of this record in OPAC Results. [4] Change some indicators in the record. Check OPAC Results again. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> On top of 12724, no change on detail, more data on results. No koha-qa errors Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Change moves display logic to Utils, 260 will display as before and 264 will only display if there is no 260. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Marcel de Rooy	3151fbe689	Bug 12724: Show RDA tag 264 on OPAC Detail XSLT view This patch adds selected information from tag 264 to the Publisher line on the OPAC detail XSLT view (MARC21). This includes a label, and the subfields abc. If Publication tag 260 exists, it adds information. If tag 260 does not exist, it creates a 'publisher' line. (NOTE: Probably, both fields will not both be present, but this patch can deal with that..) Instead of showing all 264 tags, it picks the preferred one based on the following rules (using both indicators; see LOC description): [1] Try to select a Publisher -- Latest. Pick first one. [2] Else try to select a Publisher. Pick the last one. [3] Else try to select an other one (Producer, Manufacturer, ..) with Latest. Pick the first one of that. [4] Otherwise: Pick the last 264 tag. Test plan: [1] Add one 260 and multiple 264 tags to your record. [2] Check display in OPAC detail XSLT. [3] Change some indicators, subfields of the 264s. [4] Check display again, following the above rules. Go back to step 3 a couple of times. [5] Remove tag 260. Check display again. Followed test plan. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Martin Renvoize	89ee1aeab7	BUG8446, QA Followup: Cleanup tabs and license Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Martin Renvoize	3c9004357d	BUG8446, Follow up: Improve local login fallback - Local fallback was not very well implemented, this patch adds better handling for such cases allowing clearer failure messages - This patch also adds the ability to use single sign on via the top bar menu in the bootstrap theme. BUG8446, Follow up: Adds perldoc documentation - Add some documentation to the Auth_with_Shibboleth module including some guidance as to configuration. BUG8446, Follow up: Correct filenames to match guidlines - Moved Auth_with_Shibboleth.pm to Auth_with_shibboleth.pm to match other files present on the system. BUG8446, Follow up: Correct paths after file rename BUG8446, Follow up: Implemented single sign out - This follow up rebases the code against 3.16+ which managed to break some of the original logic. - As a side effect of the rebasing, we've also implemented the single sign out element. Upon logout, koha will request that the shibboleth session is destroyed, and then clear the local koha session upon return to koha. Due to the nature of shibboleth however, you will only truly be signed out of the IdP if they properly support Single Sign Out (which many do not). As a consequence, although you may appear to be logged out in koha, you might find that upon clicking 'login' the IdP does NOT request your login details again, but instead logs you silently back into your koha session. This is NOT a koha bug, but a shibboleth implementation issue that is well known. BUG8446, Follow up: Fixed bootstrap login via modal - The bootstrap theme enable login from any opac page via modal. To enable this with shibboleth we had to make some template parameters globally accessible when shibboleth is enabled. BUG8446, Follow up: Add template rules for Shibboleth and CAS - Add template rules so that CAS and Shibboleth can coexist. BUG8446, Follow up: Added default config to config file BUG8446, Follow up: Embellished perldoc documentation - Updated perldoc to correct detail about configuring shibboleth authentication. - Updated perldoc to include subroutines and their respective functions. BUG8446, Follow up: Enable configuration of match field - Added clearer, more flexible, configuration of shibboleth attribute to koha borrower field matching for authentication - Correcting of documentation to make it more clear to the current implementation - Minor refactoring of code to reduce some code duplication Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Jesse Weaver	244cfaba71	BUG8446, Follow up: Remove unnecessary sysprefs, move to config Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	11 years ago
Matthias Meusburger	400b538078	BUG8446: Adds Shibboleth authentication - Use the shibbolethAuthentication syspref to enable Shibboleth authentication - Configure the shibbolethLoginAttribute to specify which shibboleth user attribute matches the koha login - Make sure the OPACBaseURL is correctly set BUG8446, Follow-up: Adds Shibboleth authentication - Fix logout bug: shibboleth logout now occurs only when the session is a shibboleth one. - Do some refactoring: getting shibboleth username is now done in C4::Auth_with_Shibboleth.pm (get_login_shib function) BUG8446, Follow-up: Adds Shibboleth authentication - Adds redirect to opac after logout BUG8446, Follow-up: Adds Shibboleth authentication - Shibboleth is not compatible with basic http authentication in C4/Auth.pm. This patch fixes that. BUG8446, Follow-up: Adds Shibboleth authentication - Use ENV{'SERVER_NAME'} instead of syspref OpacBaseURL in order to work with multiple vhosts. BUG8446, Follow-up: Adds Shibboleth authentication - Adds missing protocol for $ENV{'SERVER_NAME'} Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jesse Weaver <pianohacker@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested with the feide idp. - LDAP login and logout are working - local login/logout are still working - CAS login/logout are still working Instructions for setup can be found on the wiki: http://wiki.koha-community.org/wiki/Shibboleth_Configuration Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	13 years ago
Owen Leonard	842913dfb8	Bug 13052 - OPAC Cart JavaScript is included twice in the footer The external JavaScript file which powers the OPAC Cart should not be included twice. The correct instance is the one which comes after the definition of MSG strings. To test you must have the opacbookbag system preference turned on. In Bootstrap OPAC, test adding some items to the Cart and confirm that Cart operations work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Cart is still working as expected, passes tests and QA script. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Marc Véron	285795d769	Bug 12974 - Argument "" isn't numeric in numeric gt (>) in opac-results.tt If an item has no star ratings you get an error message in opac-error.log: Argument "" isn't numeric in numeric gt (>) at (...) /koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt line 467. To test: In OPAC, search for a bilio that has no star ratings. Check opac-error.log for message as above Apply patch Repeat search Check opac-error.log again, there should be no more warnings (Fixed mistake with brackets, see comment #2) Signed-off-by: Magnus Enger <digitalutvikling@gmail.com> Works as advertized. Looks like you have to be logged in to trigger the error. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Works as advertised, passses xt/author/valid-templates.t	10 years ago
Jonathan Druart	d7f97e3b8a	Bug 12538: Two SolR-related templates remaining Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Jonathan Druart	cf2eb49448	Bug 12538: Remove Solr without breaking anything else Since nobody is currently working on the zebra layer introduced by bug 8233, Solr won't never work. Some code has been introduced in 3.10 to prove several search engines can cohabit into Koha but no help/fund has been found to go ahead. It is useless to keep this code and to maintain an ambiguous situation. I think the indexes configuration page could be restore later if someone else introduces a new search engine into Koha. Test plan: Look at the code introduced by bug 8233 and verify all is removed. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Marcel de Rooy	bfdd08f74e	Bug 13051: And remember, usernames are not case sensitive opac-auth contains the following statement: You entered an incorrect username or password. Please try again! And remember, usernames and passwords are case sensitive. Obviously, this is not completely true. The username can be entered in lowercase, uppercase, any mixed case. This patch simply adjusts this string. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago

1 2 3 4 5 ...

2276 Commits (0a4e24dba097dbbc99fa30eea27a09cda6cea04a)