Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Kyle Hall	0cab6f2ef3	Bug 14915: Use Font Awesome instead of Glyphicons for the staff intranet We should be using Font Awesome for our icons instead of Glyphicons, for the reasons discussed on bug 13696. Test Plan: 1) Apply this patch 2) Note all Glyphicons have been replaced with FA icons in the staff intranet 3) git grep "icon-" ./koha-tmpl/intranet-tmpl/prog/en/modules/ should give no results 4) git grep "icon-" ./koha-tmpl/intranet-tmpl/prog/en/includes/ should give no results Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> We need a follow-up to cover the files changes since this patch was written. Especially to cover the changes in the label creator modules. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>	9 years ago
Jonathan Druart	42f2d0b179	Bug 8399: Display tab number on the mandatory field alert (authority) A wrong variable scope was used here, the number value is contained in the BIG_LOOP (note for later: change this variable name...). Test plan: 1/ Define 1+ mandatory fields for an authority type 2/ Create an authority and don't fill the mandatory fields 3/ Try to save: the popup alert should display the number of the tab. Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	9 years ago
Jonathan Druart	a9ff03c2bf	Bug 8399: No need to truncate the marc field text to 22 chars The text for the marc field are truncated to 22 chars when displaying an error on mandatory fields. This limitation is useless and this patch removes it. Test plan: Create a mandatory subfield and set a long text (more than 22 chars) edit or add an authority, click on save. You should get the error displayed with the full text Note that this patch modifies the same code for biblio. Test plan is the same for biblio. Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	9 years ago
Jonathan Druart	927aedafa1	Bug 10985: [UNIMARC] Fix authority summary The problem is the template in authority type summary is not respected at all. It is only read to see which fields and subfields should appear in the summary. This patch fixes that. It also fixes a bug in auth_finder.pl plugin when summary contains fields other than 2XX. Test plan: 0/ You must use a UNIMARC setup for those tests 1/ edit an authority type summary with: NP : [200a][, 200b][ 200d][-- 152b --][ ; 200c][ (200f)] [001] [ppn: 009] 2/ create a new authority with previous fields (it is possible some fields don't exist). 3/ search this authority and verify the summary is someting like: NP : Name, D.-- NP -- 23849 ppn: my_ppn 4/ Verify some summary for existing authorities and check they are correct. 5/ Edit a biblio record and use the plugin auth_finder.pl (for example in a 7XX field) 6/ Do a search and verify the summary is correct 7/ Click on 'choose' or one of the numbered links ('1', '2', ... ; you should have multiple 2XX fields for the numbered links to show up) 8/ Verify that the biblio field is correctly filled. /!\ For the ppn, it should be defined in the zebra indexes. In MARC21 and NORMARC setups, this patch should change nothing, please verify that too (you can check that the auth_finder.pl plugin is still working and the auth type summary is correctly displayed in authorities search and auth_finder.pl plugin). Signed-off-by: Frederic Demians <f.demians@tamil.fr> It works as described, both in authority search result page, and in authority data entry plugin. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	11 years ago
Marcel de Rooy	ff5996d65e	Bug 10480: Use the framework plugin object in cataloguing This patch implements the use of Koha::FrameworkPlugin in Cataloguing, Authorities, Acquisition, Serials and Tools. The main change is architectural: see the commit message of the previous patch. No changes in behavior are expected, but the support of new events may provide additional functionality in the future. Some small bugs are resolved along the way. The change primarily focuses on the MARC and items editor in Cataloguing. But the MARC editor for Authorities and the item editor in Acquisition, Serials and Tools are touched too. This commit message gives some comments per module. NOTE FOR CATALOGUING: A new plugin without popup (or other click event code) now shows the title No popup when hovering over the tag editor image. The image alerts the user on a plugin, the title tells about its status. The noclick property allows for further style modifications in the template. Note that a follow-up patch will clean up the old style plugins too with the same effect. Some additional code in cataloging.js makes it possible to clone subfields with plugins (although only theoretically useful). The clones use the same javascript functions but event.data contains an updated id. This effectively resolves bug 13306. Note that if old plugins do not use the javascript parameter for the id but the perl variable, cloning does still operate on the wrong field (with and without this patch set). In the absence of report 12176 in master, it is not yet necessary to modify additem.tt. When it gets pushed, it should be an easy rebase. New style item plugins will no longer need an extra parameter. (The code in the FrameworkPlugin object actually takes care of that.) NOTE FOR AUTHORITIES: This patch also adds class name tag_editor to the buttonDot anchors. This effectively makes the same tag editor image appear as in Cataloguing. Futhermore it removes the button from the tab sequence if there is no click event (really effective after conversion to the new style, since the old style plugins contain empty onclicks and launchers). Both small adjustments increase consistency between auth and bib edits. NOTE FOR ACQUISITION: In Acquisition two scripts use an item editor, but in a different way. The scripts addorderiso2709 and neworderempty both rely on the routine PrepareItemrecordDisplay in C4::Items, but neworderempty creates item blocks dynamically via an ajax call to services/itemrecorddisplay.pl. In order to make the dynamic item blocks work with plugins, some code changes were needed in additem.js. (Normally the event binding is done at document ready time; now it must be done later.) At this moment the routine in Items.pm contains the html tags, and this makes changes to the following templates not necessary for now: * acqui/addorderiso2709.tt * services/itemrecorddisplay.tt Report 13397 has been opened to address moving the html to the templates. NOTE FOR SERIALS: Script serial-edit relies also on C4::Items (just as in Acquisition). This makes changes to serials/serials-edit.tt not necessary for now. NOTE FOR TOOLS: The current code in tools/batchMod.pl allows the use of plugins for batch modification of items. This patch just converts that code to use the new object. Most item plugins however may not be very useful for operating on multiple items at once. PERFORMANCE: I have benchmarked build_tabs in addbiblio to see how especially the additional processing of the javascript in the FrameworkPlugin object would impact performance. Testing default MARC21 framework with 8 plugins gave the following figures: - Old situation: 851 ms - New situation: 942 ms (+10,7%) - New situation after plugin cleanup: 881 ms (+3,4%) Note also that adding lines for event binding is compensated by removing lines for unused events. Page load should essentially be the same. TEST PLAN: Suggestion: If you also apply the next patch with the EXAMPLE plugin, you can test with a rather harmless plugin (with popup) on various places :) But your test should also include old style plugins, with[out] popups. If you want to test a new plugin without popup, rename/remove Click$id in the javascript code of the $builder definition (temporarily). [1] Test Cataloguing: - Add/Edit biblio. Try plugins with and without popup. - Add/Edit items. (EXAMPLE can be used as an item plugin with popup.) - Clone a subfield with plugin (use EXAMPLE): Verify that the plugin works on both original and clone with the respective field values. Is the value put back in the right field too? [2] Test Authorities: Edit an authority record. Try plugins with an without popup. [3] Test Acquisition: Set system preference AcqCreateItem to "placing an order". Check the item editor in the following two places: a- addorderiso2709: Open a basket, add an order from a staged file. Select a file, click Add orders, and go to tab Item information. b- neworderempty: Open a basket, add an order from a new empty record. [4] Test Serials: Check the item editor on serials-edit. Go to subscription detail. Click Receive. Choose "Click to add item". (Note that this subscription should create an item record when receiving this serial.) [5] Test Tools: Check the item editor for batch item modification. Enter a few valid barcodes and press Continue to reach the item editor. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Frédérick	eed620c773	Bug 11961 - Add a "Z39.50 search" button to the authority creation and modification pages. This button lets you replace existing authorities using a Z39.50 search. http://bugs.koha-community.org/show_bug.cgi?id=11961 Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All tests pass Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	11 years ago
Kyle Hall	5d6d9de5e7	Bug 13400 [QA Followup] - Fix tabs and quotes Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Marc Véron	8523f208f3	Bug 13400: Untranslatable "Are you sure you want to delete this authority?" This patch makes the string "Are you sure you want to delete this authority?" translatable using the function _(...) To test, apply patch and check that deleting authorities still works. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Tested successfully with the following procedure: 1. Applied the patch. 2. Ran perl translate update de-DE 3. Edited de-DE-i-staff-t-prog-v-3006000.po to add a "translation" 4. Removed "#, fuzzy" marker from po entry. 5. perl translate -v install de-DE 6. Testing deleting an authority from the authority search results page and from the detail page. My translated string appeared correctly. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
David Cook	7f8c59edaa	Bug 12708 - Unexpected behaviour in IE 9 and lower when using openWindow This patch removes the whitespace from arguments to the "name" parameter in "window.open". It also adds a trap for the "openWindow" helper function, which will use a "null" instead of a "name" if window.open isn't able to handle a name with whitespace (i.e. if it's IE <= 9). _TEST PLAN_ 1) Switch to an emulated or authentic Internet Explorer version E 9 or lower 2) Click "Help" 3) Note that it opens the page in the current window rather than as a popup 4) Apply the patch 5) Shift refresh your page 6) Click "Help" 7) Note that it now opens (correctly) as a pop-up (If you want to be more thorough, you can test in other browsers as well to make sure that it still works.) Tested with IE 10 developer tools: IE7, IE 8, IE 9 Window pops up as expected. No regression found with IE 10 / FF31.0 Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested for regressions in Firefox and Chromium. I checked the help and the duplicate authorities windows still work correctly. Passes tests and QA script. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Bernardo Gonzalez Kriegel	7d203a28fe	Bug 12177 - Remove HTML from authorities.pl This patch removes HTML code from authorities.pl To test: 1. Check no regressions on authority editor, new/edit/save 2. Check new line on translation files, update a language, look for 'Tag editor' Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Checked various features of the authority edtior: - repeating subfields - deleting subfields - changing the order of subfields - linking a subfield to an authorised value - plugins No regressions found. Passes tests and QA script. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Fridolyn SOMERS	99dbc5cdf7	Bug 7442: fix crash when selecting an authority with 200$x or 200$y (UNIMARC) From a biblio record, if one wants to add a 600$a information, a pop-up appears. On this new window, on search terms typed and validated, a table result is displayed, with a column "Get It!" allowing the selection of an authority. From here, different cases: 1) If we have a simple authority with 200$a and 200$b subfields, a link "choose" is displayed, working correctly. 2) If the authority has different occurences of 200$a/200$b, numeric links (1 2 and so on) are displayed, one for each occurence. In the example of my screenshot, the line with a "Paul, Korky -- Pauline, Korkette" summary possesses two links : "1" will add "Paul, Korky" whereas "2" will add "Pauline, Korkette" (couldn't come up with a better name ;)). 3) If the authority has 200$x or 200$y subfields defined, several links are also created, when it should not be the case. In our example, "Niclausse, Paul -- Expositions" will create a link "1" for "Niclausse, Paul" and a link "2" for "Expositions". Clicking on the 2nd link leads to the following error: Software error: Can't call method "subfields" on an undefined value at /home/asaurat/workspace/versions/community/authorities/blinddetail-biblio-search.pl line 86. Only the cases 1 and 2 should be handled. The creation of links for subfields like 200$x or 200$y should be removed. This problem is caused by the use of " -- " has separator of authorities with several headings, but also in some heading between main part and subdivisions. This patch corrects this by using an array in authorities summary so that presentation is computed in template. I've choosen to use the pipe separator between authorities with several headings. This may be changed to be configurable. Test plan : - Edit an authority type summary : for example subject (heading on 250) : summary "[250a][ -- 250x]" - Create an authority A1 with one heading and a subdivision : for example a subject : 250$a "History" 250$x "20th century" - Create an authority A2 with several headings. for example a subject : 250$a "History" 250$a "Legends" - Rebuild Zebra queue - Go to OPAC and click on "Authority search" and search on "History" => You will find A1 and A2 : History -- 20th century History \| Legends - Go to intranet autorities search and search on "History" => You will find A1 and A2 : History -- 20th century History \| Legends - Edit a record using this autorities type as thesaurus : for example on 606$a - Click on thesaurus link and search on "History" => You will find A1 and A2 : History -- 20th century ; 0 times ; choose ; Edit authority History \| Legends ; 0 times ; 1 2 ; Edit authority - Click on link "2" to chosse "Legends" => You get "Legends" in heading field : for example 606$a Signed-off-by: Frédéric Demians <f.demians@tamil.fr> I can confirm the problem and the solution. I have tested the patch on a large DB with authorities having multiples headings. There is no regression on bug 4838. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Without the patch I couldn't choose between multiple headings in the authority plugin, but with the patch it works as described. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Bernardo Gonzalez Kriegel	e64c52866b	Bug 11227: remove some JavaScript from staff PO files This patch rewrites authorities_js.inc so translate script will process it correctly. To do that I added <script></script> at the file To test: 1) Update po files for your preffered language 2) Check occurrence of mergeAuth on staff PO file or try egrep -n "Merging with authority: \|Cancel merge" strings appear in a JS func 3) Apply the patch 4) Update translations again, check again, old strings now begin with #~ (obsoleted) and there are new entries for the messages 5) Check functionality provided by script Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described and fixes a translation difficulty. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Pasi Kallinen	9e9088049c	Bug 12138 - Use placeholders in translatable Javascript strings Currently translating Javascript strings with variables in them is hard, because the strings are created from separate parts. For example: _("Are you sure you want to delete the") + " " + count + " " + _("attached items?") This is translated in two different parts, and the translator cannot affect the place where the count-variable is. Now, if the javascript strings allowed placeholders, similar to how the template strings do, the above could be written as: _("Are you sure you want to delete the %s attached items?").format(count) This would make translation much easier. Attached patch adds a Javascript string formatter, and changes all the concatenated translatable JS strings used in intranet to use that. To test: 1) cd misc/translator 2) perl translate update xx-YY 3) grep ^msgid po/xx-YY-i-staff-t-prog-v-3006000.po \| sort \| uniq > xx-YY-pre 4) apply patch 5) perl translate update xx-YY 6) grep ^msgid po/xx-YY-i-staff-t-prog-v-3006000.po \| sort \| uniq > xx-YY-post 7) compare the files: diff -Nurd xx-YY-pre xx-yy-post \| less should show the javascript strings that changed. 8) Test the UIs where the formatted js strings are used. Signed-off-by: Owen Leonard <oleonard@myacpl.org> I tested most of the changed files. There were some instances where it wasn't clear to me how to trigger the warnings which were modified, especially tags/review.tt, admin/manage-marc-import.tt, and holidays.tt. Everything I was able to test worked correctly. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, no regressions found. Thx! Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Owen Leonard	84c3587d03	Bug 12116 - Move fixFloat jQuery plugin outside of language-specific directory This patch moves the fixFloat jQuery plugin to intranet-tmpl/prog/lib/jquery/plugins so that it will not be duplicated for each set of translated templates. This patch also includes a change to staff-global.css to override some style the floating toolbar inherited when we added Bootstrap widgets. To test, apply the patch and confirm that the toolbar "sticks" to the top of the screen when scrolling down on the following pages: - System preferences - Authorities editor (Authorities -> New authority) - Cataloging editor (Cataloging -> New record) - List contents view (Lists -> View a list's contents) Followed test plan. Patch behaves as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Tomás Cohen Arazi	c62557a4fa	Bug 10691: use authority ID in see-also links in authority search results (staff) This patch changes the URL and data used to show the 'see also' links on the Staff's authority search results page. Bonus points: makes some strings translatable. To test: - On your dev setup (master) create some authority records (I created personal name authorities). - Pick one of them and link 400$a to another one, do the same with 500$a - Add some other 400$a and 500$a entries with plain text (i.e. no linking) - Make sure zebra is running and changes got indexed. - In the staff interface search for the authority that is linked to the others. - Check the 'see also:' link points to an authority search - Apply the patch - Reload/re-do the search - Check the 'see also:' link points to the authority id for linked authorities, and to an authority search result in the case of plain text entries. - Check that the authority search from the cataloguing interface still works as usual. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described. No errors Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Owen Leonard	a5c762d491	Bug 11503: fix several typos This patch corrects several typos: Some reported in Bug 11503, others found during a systematic spell check of the help files. To test, examine the changes and confirm that the spelling changes are correct. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Galen Charlton	4a2aa0e768	bug 5202: (follow-up) adjust for the move of the merge record Javascript This patch applies to change from bug 10650 to the new authority record merge feature. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Jared Camins-Esakov	adabb74aa1	Bug 5202: QA follow-up - improve merge reference selection The link on the merge reference had been wrong, and framework types were not indicated when you were merging records of two types. This patch fixes those problems. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Jared Camins-Esakov	cbd9591010	Bug 5202: QA follow-up 2 - fix overeager error message When rebasing the patch for this, I accidentally moved the line setting the mergereference when merging from breeding to before I checked whether we were merging from breeding. Needless to say, this caused problems. This patch fixes that, and: * Makes the error translatable. * Adds a missing authtypesloop argument for the template. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Jared Camins-Esakov	b5bd2b7586	Bug 5202: merge authorities from the authority file and reservoir This patch gives Koha the ability to merge authority records using the same interface used by bibliographic records, though slightly different methods for selecting which records to merge. The two ways to select records are as follows: 1) Records can be selected from authority search results by clicking the "Merge" link for two records. 2) Authority records can be merged from the reservoir by clicking the merge-related links in the Manage staged MARC batch screen. To test: 1) Apply patch. 2) Do a search for an authority record that will turn up multiple identical records (or at least two records that you don't mind merging). 3) Click the "Merge" link for the first record. 4) Click the "Merge" link for the second record. 5) Choose which fields from which record you want to appear in the resulting record. 6) Confirm that those are the fields that exist in the resulting record. 7) Stage an authority record (for example, an authority record you saved from your catalog. 8) Search for a record to merge with it using the "Search for a record to merge in a new window" link. 9) Merge these records, confirming that the resulting record (after going through the entire merging process) matches your expectations. 10) Set up a matching rule for authorities, and export an authority from your catalog that will match based on that rule. For MARC21, the following is a good choice for a rule: Matching rule code: AUTHPER Description: Personal name main entry Match threshold: 999 Record type: Authority record [Match point 1:] Search index: mainmainentry Score: 1000 Tag: 100 Subfields: a 11) Stage the record you just exported, choosing the matching rule you just created. 12) Merge the record using the "Merge" link, confirming that the resulting record (after going through the entire merging process) matches your expectations. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Testing notes on last patch in series. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Owen Leonard	9bd3a44944	Bug 10888: Don't hide authorities module from users who lack permission to edit authorities It should be possible for staff client users to search and view authority records even if they don't have permission to edit them. To test, apply the patch and view the staff client as a user with and without "editauthorities" permission. With "editauthorities" permission, authority search results should show both an edit and delete link. Viewing the details of an authority record, one should see a toolbar with edit/delete/new options. The detail view has been altered to use the term "record" in place of "biblio" ("Used in X record(s)). Without "editauthorities" permission, authority search results should show no edit or delete link. Viewing the details of an authority, the only option shown in the toolbar should be "Save." On the staff client home page and in the header's "More" menu the link to the authorities module should now appear with and without permission to edit authorities. This patch also corrects the permissions in the authority export script to allow saving of authority records by users who do not have permission to edit. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Janusz Kaczmarek	129c974fdd	Bug 5262: make authority plugin copy indicators to bib record With this patch Koha should correctly copy indicators (and create $2 subfield in MARC 21 if need) from the chosen authority record to the edited bibliographic record (according to discussion in bugzilla). UNIMARC and MARC 21 flavors are covered. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: work as described, testing in comments 9 and 12. No errors. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes QA script and tests. Tested functionality repeating some of the tests noted by Bernardo - checking mostly 1xx, 490, and 7xx. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Owen Leonard	bfe6dc88d2	Bug 2774 - Path to theme is hard-coded in many places Many templates have instances where the path to the prog template is hard-coded. Now that interface and theme template variables are available everywhere these paths should be corrected to use them. Image paths corrected: - 'Patron image missing' image on circulation pages - 'Locked' icon on fund planning page - Tag and subfield edit icons on the authority, biblio editor, and batch item modification pages (Clone tag, delete tag, clone subfield, delete subfield, move subfield) - 'Loading' icon when importing frameworks Audio file paths corrected: - Sounds for circulation.pl and returns.pl Paths to DataTables assets corrected on: - Transfers to receive report - Holds queue report - Holds awaiting pickup report - Patron detail page (moremember.pl) - Patron circulation history - Update child to adult patron page - Process offline circulations - Catalog by item type report - Serials statistics wizard - Serial claims page - Koha news - Notices - Batch patron modifications Path to progress bar assets corrected on: - Process offline circulations page - Progressbar include file - Stage MARC imports - Manage MARC imports - Local cover image upload Other image paths: - "Approved" checkmark image on tags review page - Table sort icons on lists page - Feed icon on OPAC search result page - "Loading" image for OPAC plain MARC view Path to ratings JavaScript on OPAC detail and results pages Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Checked all the pages modified by this patch, no problems noted Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Karam Qubsi	6fd6c024a4	Bug 8061: Follow up - RTL CSS overrides (staff client) I think this patch is good for th rtl langs. and based on what D.Ruth send before, I added some edits as a right to left reader. Tested on master with Arabic I used the updated po files for v. 3.8 (because the 3.12 ) need some revision ... Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	11 years ago
Owen Leonard	378e928379	Bug 9196 - authorities editor overlapping box This patch corrects a display problem in the authorities editor which can cause the contents of a tab to overflow outside the tab's boundary. To test open an authority record for editing. Confirm that tab contents do not overflow their bounds on both tabs with many lines and tabs with just one or two. Signed-off-by: Pierre Angot <tredok.pierre@mail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	11 years ago
Owen Leonard	aa6764f37e	Bug 9676 - Replace YUI buttons on authorities editor page with Bootstrap This patch converts the "Save" button on the authorities editor page to Bootstrap, replacing YUI button code with Bootstrap markup. This patch also adds the float effect to the toolbar to match that on the MARC editor page. To test, create a new authority or load an existing one. The "Save" button should look correct and work correctly. When you scroll the page down, the toolbar should "stick" to the top of the browser window so that the "Save" button stays visible. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Button works and looks good. The toolbart sticks when scrolling, but I see a gap between the box of the save button, and the top of the window (tested with chrome, opera, firefox). Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	11 years ago
Owen Leonard	47609920b7	Bug 9265 - Switch to HTML5 doctype in OPAC and staff client This patch replaces the XHTML DOCTYPE with an HTML5 one. The HTML5 validator seems to be significantly different than the XHTML one, so I'm seeing lots of new errors. This patch includes corrections for one: Deprecation of the "language" attribute of <script> tags. To test, view pages in the OPAC and staff client. They should appear as normal. Numerous validation follow-ups will be required, but I suggest these be handled incrementally. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> test on some intranet pages and I found no regression. (chromium and firefox). The w3c page about the doctype: http://www.w3.org/TR/html5-diff/#doctype Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Fridolyn SOMERS	7cf5e2e954	Bug 7455: Authority subfields are cloned in the wrong field (follow-up 2) Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Passed-QA-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Fridolyn SOMERS	2f860e36f6	Bug 7455: Authority subfields are cloned in the wrong field Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Passed-QA-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Jared Camins-Esakov	83370c519c	Bug 8523: Display auth hierarchies w/all marcflavours This commit adds support for displaying authority hierarchies for all flavours of MARC, not just UNIMARC. Display now uses the jQuery jstree plugin, selected with the help of Owen Leonard, resulting in a much faster experience for users. Be aware that the jstree file uses tabs rather than 4-space indentation, which I left as-is so as to make it easier to integrate upstream releases in the future. To test: 1) Enable the AuthDisplayHierarchy syspref 2) Create authority records with a hierarchy of see also fields (in MARC21/NORMARC, you'll be using 5xx fields for this, with a subfield $w=g for broader terms and subfield $w=h for narrower terms) 3) View the authorities in the OPAC, noting the hierarchical view at the top of the page. This initial patch does not create bidirection linkages from unidirectional links in MARC21 authorities. This means that when moving up the authority hierarchy, lower levels will disappear. This is intentional, as the first patch is intended merely to ensure that AuthDisplayHierarchy functions the same for all marcflavours. A future patch will add a cron job to generate the bidirectional linkages, once we are sure that the hierarchy functionality for UNIMARC and MARC21/NORMARC coexists peaceably. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Resolved conflicts in updatedatabase.pl, sysprefs.sql and in one of the CSS files. Test plan: 1) Run t/AuthoritiesMarc.t New tests complete without any errors. 2) Make sure updatedatabase works correctly. Update works nicely, new system preference is also added to syspref.sql 3) Make sure new terms are translatable. Created new po files for de-DE and checked for new terms. All translations appear correctly. 4) Make sure everything works with AuthDisplayHieararchy OFF - Add authority - Edit authority - Delete authority 5) Test feature with AuthDisplayHieararchy ON - Add authority - Edit authority - Delete authority 6) Add a couple of hierarchically linked authorities Note: links have to be created in both directions Example: 151 $aGermany 551 $a Baden-Württemberg $w h 151 $aBaden-Württemberg 551 $a Konstanz $w h 551 $a Germany $w g 151 $aKonstanz 551 $a Baden-Württemberg $w g 551 $a Fürstenberg $w h 551 $a Paradies $w h 151 $a Fürstenberg 551 $a Konstanz $w g 151 $a Paradies 551 $a Konstanz $w g Tree shows up nicely above the authority record - in staff - in OPAC - on the normal view tab - on the MARC view tab 7) Checking the logs for warnings - no Javascript errors or warnings - no warnings or errors in log files	12 years ago
Fridolyn SOMERS	dd2de85892	Bug 8692: Authorities search form does not correspond to current search query Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> The correct tab is now visible on load. The problem with authtypecode showing up in the search box is specific to UNIMARC, so I could not check that it was gone, but I am comfortable signing off on this. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	12 years ago
Fridolyn SOMERS	2ca3663687	Bug 8071: link between bib and authorities with the authid Do not automatically populate $9 in bibliographic headings when the $9 is set in the authorized heading field of the authority record. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	12 years ago
Jared Camins-Esakov	4f043f3f77	Bug 3462: Links in authorities should be hyperlinks Make see also links in both the OPAC and authority module search results into hyperlinks and not just textual strings. To test: 1. Do a search for an authority that will bring up a heading with a see also reference in the staff client and the OPAC. 2. Confirm that the see also references listed in the search results are now hyperlinks, which work. Also quiets an unnecessary warning about an uninitialized value. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Rebased 26 July 2012 Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Rebased on master 1 August 2012 Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Rebased on master 6 August 2012 Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Rebased on master 11 September 2012 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch works nicely and is a great improvement. Tests: - Checked links for existing and non existing "see alsos" give correct search results - Verified links show up for all "see alsos" in a result list - Verified links are properly linked with the correct names - Checked logs don't show errors Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	12 years ago
Jared Camins-Esakov	e24e3bb266	Bug 8332: Add relationships to auth_finder for authority links In addition to the work in bug 8207 that enables auth_finder use, it would be very useful when creating authorities to have the auth_finder plugin automatically fill out the relationship information in $w (in MARC21). To test (note that you must either apply the patch for bug 8207 or manually add a thesaurus to a 5xx linking field in one of the authority type frameworks): 1. Create a new authority record. 2. Go to the 5xx tab. 3. Click the authority control plugin ellipsis. 4. Do a search for an authority. 5. Select a relationship type. 6. Note that after you choose an authority, that the $w control field is automatically populated with the relationship type. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> After applying patch for bug 8207, I had been able to follow the test plan step by step, and get the expected result. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Rebased on master 1 August 2012	12 years ago
Kyle Hall	1000599eaa	Bug 4198 - deleting an authority refreshes the page Makes clicking a Delete link refresh the search that was performed so that the results are still on the screen. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Works as advertised. Very usefull. Still the issue that indexing being not in real time, the search result displays the just deleted authority. But there is no way to do better.	12 years ago
Jared Camins-Esakov	899597c826	Bug 8208 follow-up: move Clear and Create new buttons out of results Turns "Clear" and "Create new" links into buttons that are visible before a search is performed, so that the user does not have to do a search just to clear the field or create a new authority. This commit also changes the formatting from textual links to buttons. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Nicer and more logical display. Allows creating of a new authority without doing a search first or when no results were found. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	12 years ago
Jared Camins-Esakov	5ff81e2e8e	Bug 8208: Add fast-add link to auth finder plugin When performing subject analysis, it is not uncommon to find that an authority record you need does not exist. This commit adds a link in the search results to enable the cataloger to create an authority on the fly and have the heading populated by the new authority. To test: 1. Use the auth finder plugin the cataloguing module to search for a heading you do not have an authority record for. 2. Click the "Create new" link. 3. Fill in your authority and save it. 4. Note that the heading field was populated with the data you entered in the authority record. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> 1) Added a new authority using the plugin 2) Used an existing authority using the plugin 3) Created a new authority in the authority module All worked nicely.	12 years ago
Owen Leonard	6cc03670e4	Bug 8241 - Remove stray references to YUI autocomplete - Removing unused references to YUI assets in authorities/auth_finder.tt - Removing unneeded call to autocomplete JS in help-top.inc and adding new jQuery dependencies. - Minor HTML markup corrections to auth-finder-search.inc discovered in debugging the patch. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested: - help files on various pages - auth finder plugin in cataloguing - authority search in authorities module	12 years ago
Jared Camins-Esakov	3aaaf2f2e4	Bug 7943: Authority search results are untranslatable The HTML for authority search results was previously generated in C4::AuthoritiesMarc::BuildSummary, which meant that it couldn't be translated. This patch moves the HTML generation into the templates by introducing a new authorities-search-results.inc include file for both the OPAC and the Intranet which contains a Template::Toolkit BLOCK for rendering the authority results. Fixes the authority autocomplete by removing the untranslatable strings, and returning only data from the database. To test: 1. Apply patch. 2. Test authority searching in the authority module in the staff client 3. Test authority searching in the authority control plugin in the cataloguing module (and the plugin for UNIMARC field 210$c, if you can figure out how) 4. Test authority searching in the OPAC Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested with MARC21 data. 1) Applies cleanly on current HEAD. 2) Authority search in staff Patch works wonderfully, only some small notes found while testing that have not been changed by this patch: ENH note: Search terms show up nowhere. So if I want to change the sorting, I have to repeat typing in my search term. Even if the form does not keep the term, it should be visible somewhere on the screen what I searched for. ENH note: The pagination on top and at the bottom of the result list are formatted differently. Maybe some missing CSS? ENH note: Also the authority type is not shown at all in the result list. 3) Cataloguing and authority plugins The autocomplete function works nicely. ENH note: There is only one small enhancement I could imagine. If I start my search from 100 it will limit the search to 'persons' but the autocomplete will also suggest other authorities. It would be a bit cleaner, if the autocomplete could limit by the appropriate authority type too. Very nice feature. Plugins overall work nicely. Created links include the authority numbers and work correctly. 4) Authority search in OPAC Works nicely. Display is consistent, but translatability greatly improved. ENH note: In staff we use 'Details' in OPAC we use 'View full heading' - I wonder if maybe 'details' would be better understandable for users? Note: Code reveals a system preference 'AuthDisplayHierarchy' that is not available in the system preference editor. I talked to Jared and he will work on this feature later on. For now it's no regression, as the preference has never been visible.	12 years ago
Owen Leonard	68b30468c3	Bug 8143 [REVISED] Upgrade jQuery tabs to current jQueryUI version Current jQuery-driven tabs are done using a very old version of the tabs plugin. This patch upgrades jQueryUI to the latest version and adds the tabs widget dependency to the jqueryui js file and updates the syntax for existing tabs: - $("#foo > ul").tabs(); changes to $("#foo").tabs(); - Remove full URL from tab links (use #anchor only). Pages with "static" tabs (tabs which are built in the markup rather than generated by the plugin) have been modified to use their own style. Examples: pay.tt in the staff client and opac-readingrecord.tt in the OPAC. Edit: Minor revision to some uncorrected markup Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	12 years ago
Frédéric Demians	b127859c9b	Bug 4838 Fix repeated authorities selection How to test: Create an authority, with more than one heading, for example a UNIMARC multilingual author: 200 $7 da $a 原 $b 純輔 200 $7 ba $a Hara $b Junsuke In data entry form, on 700 field, you click on ... Search for the above author. In auhtority search result page, you just have a 'Choose' link, and so you just can select the first heading (in Chinesse writing). Apply the patch. Repeat. Now you have, on result page, you have two links, and can select one heading or the other. Signed-off-by: François Charbonnier <francois.charbonnier@biblibre.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	12 years ago
Kyle Hall	10861e1293	Bug 6141 - html glitches causing problems to translator * opac-topissue.pl = untranslatable string removed * authorities.pl missing _() in javascript Rewrite of patch authored by Julian Maurice. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	12 years ago
Owen Leonard	723734513b	Bug 7889 [Authorities duplicates] Use standard style for errors and messages The warning shown in the authorities editor when there is a possible duplicate is styled incorrectly. In addition the design of the warning is inconsistent with that shown in the bibliographic record editor. This patch revises the style and layout of the duplicate error box. It also corrects a problem which appears in the biblio and authority editors where a non-existent JS window function was called. I have added the function to the default JS include and revised the editor pages to use it. To test: - Create a record in both the cataloging and authorities editors which will trigger a duplicate warning. - Click the link to the existing record. A separate window should pop up. - In both editors try each option: - Confirm the duplicate and go to the existing record. - Deny that the record is duplicate and continue to save. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>	12 years ago
Owen Leonard	addb9ed527	Bug 2780 - Capitalize strings consistently (Authorities pages) Correcting capitalization in Authorities templates Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>	12 years ago
Katrin Fischer	7dec3d8aee	Bug 7760: Add unique ids and a module class to all authorities pages This is the first patch for bug 7760 and touches all pages in authorities. This adds a unique id "auth_<filename>" and a class "auth" to the body tag of each page in the authorities module. Signed-off-by: Owen Leonard <oleonard@myacpl.org>	12 years ago
Frédéric Demians	b07e603560	SIGNED-OFF Bug 7590 Cataloging authorities search result page is broken This bug occurs on UNIMARC DB with authorities linked together with TS/TG relations. To reproduce it: - Add a new biblio record - On 610 field, click on the tag editor button to search an authority - In the Authority search window, enter a large search - On the result page, for authorities having relations with other terms, in the Get it! column, you get a mess of TS/TG relations and not more Choose link. Signed-off-by: François Charbonnier <francois.charbonnier@biblibre.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	12 years ago
Matthias Meusburger	1e7437bbae	Bug 7400: Add auto-completion on auth_finder While typing an authority, will automatically propose authorities (similar to autocompletion for patron search if activated) Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Tested searching for authorities with and without autocomplete. Note that this is most useful when used in the "Main entry" box instead of the "Main entry ($a only)" box. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Corrected tabs to spaces in auth-finder-search.inc while resolving merge conflict. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	13 years ago
Owen Leonard	311dbc8bc1	Bug 7127 - Templates must be valid XHTML Replaces & with & on several template pages Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>	13 years ago
Frédérick Capovilla	6dac7273fb	Bug 6977: Follow-up patch : catch CloneSubfield errors A javascript error could occur if the CloneSubfield function failed for any reason. This would prevent the popup from disappearing. Example : Importing informations of a UNIF_TITLE authority with multiple $x subfields in the biblio's 440 field. 440$x isn't repeatable, so an error occurs when trying to clone it. http://bugs.koha-community.org/show_bug.cgi?id=6977 Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	13 years ago
Frédérick Capovilla	f977264066	Bug 6977 : Adds support for repeatable subfields when importing authorities. Before this patch, if we tried to import an authority with multiple $x subfields into a bibliographic record, only the last value get added to the form. All repeated values should now be sent to the form. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>	13 years ago

1 2 3

127 Commits (0cab6f2ef3f575b1e1dea496ae1bf4cf96815ab8)