Commit graph

9046 commits

Author SHA1 Message Date
0d3410d072 Another correction to eliminate left column from print view.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-05 21:44:05 -05:00
Ryan Higgins
1bbe1ea268 Bug 2555 : label batch_id not properly incremented after batch num 10.
This is a stop-gap fix intended for 3.0 maintenance release.
3.2 should include a label_batches table which will allow named
batches to be associated with a template & layout, and fix the
column definition of batch_id here to be an auto_incr int.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-05 21:37:12 -05:00
Michael Hafen
5e963f0fc3 More Consistant terminoligy in stage-marc-import.tmpl
Changes 'Notes about this file' to 'Comments about this file'.  It's
'Comments' in the manage-marc-import.tmpl file.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-05 21:33:52 -05:00
9ba1baec71 Hiding minimum password hint if there is no minimum password length set.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-05 21:27:31 -05:00
378e06dacb Fix for Bug 2649, "minPasswordLength Sys Pref does nothing." Adds note specifying minimum password length to patron entry form, and generates warning if submitted password is not long enough.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-05 21:27:29 -05:00
96c29c707f Corrections to manage marc import interface, including fix for inaccurate progress bar.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-05 21:18:17 -05:00
df13aeee3b Adding javascript to prevent premature submission of forms when using a barcode scanner (or by hitting the enter key). Addresses Bug 2591
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-05 21:05:07 -05:00
Michael Hafen
3a902f4bc3 bug: query squashes issues.timestamp which circulation.pl needs to sort todaysissues
Little change to the query so we get the right timestamp to sort on.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-05 21:03:21 -05:00
Michael Hafen
09e3308024 bug: chargelostitem() didn't unset onloan on the item record.
I don't think this is left set intentionally.

If an item is set lost and it's on loan it's marked returned, but it
wasn't set as not on loan.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-05 21:01:24 -05:00
Michael Hafen
6de2f89e97 bug: sticky due date isn't stick if there is a question about an issue
the stickyduedate input isn't sent on from the question dialogs.  This
causes it to un-stick if there is a question.

Also removed month, day, and year as there seems to be no use for them.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-05 20:57:35 -05:00
Michael Hafen
62a590a954 Reduce logging from rebuild_zebra.pl with a command line option
This reduces the output of the script and zebraidx, and creates a -v
command line switch which will increase the logging to their former
states.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-01 13:05:20 -05:00
5c8d22924d Eliminate left-column margin on print view
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-01 12:55:15 -05:00
paul
bd23670eaf BUGFIX missing div
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-01 12:51:42 -05:00
Pianohacker
861069e269 fix date formatting in overdue_notices.pl
This makes overdue_notices.pl format dates in fields that both start and end with 'date'.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-01 12:46:16 -05:00
Michael Hafen
5170e31ea3 bugfix: Add a message to circulation.pl if item is restricted
Don't know how this was missed.  If an item is restricted it isn't
allowed to be issued, but there is no message about why it can't be
issued, just the yellow box.

This adds a message saying "item is restricted".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-01 12:29:20 -05:00
c805939eda Bugfix #2630 2nd attempt
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-01 12:23:23 -05:00
Joe Atzberger
07d1eae7cc Remove hardcoded "Freelist" line from Auth.
Apparently a leftover debugging snippet.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-01 12:21:49 -05:00
cf56684c68 Markup and formatting improvements to Manage Staged Records interface.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-01 12:08:20 -05:00
13fca44836 Adding progress bar and some other visual enhancements to file upload interactions.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-01 11:58:21 -05:00
720b31e0b4 Bugfix #2633
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-26 09:12:29 -05:00
Joe Atzberger
fa8603bf9d Bug 2587 followup, updated test.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-26 09:10:39 -05:00
Joe Atzberger
af0fad6a4c Convert to C4::Debug, comment out unused Data::Dumper.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-26 09:10:02 -05:00
Andrew Moore
4d0b03eabe bug 2628: fixing test script to deal with DESTDIR in Makefile.PL
Recently, there were changes to the Makefile.PL to make it install in a
DESTDIR that the OS (debian) may choose. This broke the test suite.
Since we're not installing the stuff in the t/ directory, we need to
ignore the DESTDIR specifiation before we write the test-config.txt.
So, this patch adds a call to the _strip_destdir function for all
directories written to the t/test-config.txt file.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-26 09:08:35 -05:00
Joe Atzberger
9c811d13be Revising the stub for ILS/Transaction/FeePayment.pm
Obviously more implementation is needed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-26 09:07:22 -05:00
182f9df495 More fixes for Bug 2600, enabling the appearance of HTML tags in item titles. Resubmission.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-26 09:06:13 -05:00
Galen Charlton
4bf76c2d77 bug 2615: remove unneeded 'require Exporter'
Most Perl scripts (as opposed to modules) do
not need to require Exporter.

No user-visible or documentation changes.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-26 09:05:08 -05:00
Galen Charlton
e6daded166 bug 2625: finish fix by converting another array to hash
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-18 19:10:16 -05:00
Clay Fouts
53a403ee64 bug 2625
Using the barcode as an index for assigning values to an array creates problems if
the numeric value of the barcode is sufficiently large to consume enough memory to
starve other processes. This patch changes return_failed from an indexed array into
an associative one, using the barcode as the key.

Signed-off-by: Ryan Higgins <rch@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-18 19:02:13 -05:00
Galen Charlton
c83bbcbffe bug 2609: display correct requested title
In databases where biblionumber is not necessarily
the same as biblioitemnumber, the title of
certain hold requests displayed by moremember.pl
could be drawn from the wrong record.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:40:27 -05:00
Galen Charlton
c7a3b4ede9 bug 2608: let offline circ processing work in background
If an offline circulation file is large, process_koc.pl
could time out before processing all of the transactions.

To prevent this, the processing can now be run in the
background, with an AJAX loop to check the job's
status.

As a consequence of the patch, the UI for uploading offline circ files has
changed slightly.  One must select a file, click the "upload file" button, then
click the "process offline circulation file" button.

Also removed the now-superfluous upload_koc.pl, added the warnings pragma,
and fixed a typo in the template.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:40:22 -05:00
Ryan Higgins
efad22fd4d Bug 2365 : Inner counter not properly set for serials subscriptions not starting on first issue.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:40:13 -05:00
Jesse Weaver
852f75bba6 fix for bug 2556: Overlaying records sometimes creates new record
This makes "Try another search" in the Z39.50 search tool pass the biblionumber along, so that records are overlaid correctly.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:35:44 -05:00
db7daf7586 Corrections to fix javascript error in Internet Explorer.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:31:59 -05:00
1d54a98aa8 Altering system log search form to conform with other similar forms; escaping output of "info" variable.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:25:38 -05:00
Joe Atzberger
ee48f60a93 DHTMLcalendar should not be imported.
Changing these scripts as precursor to removing it from C4::Dates @EXPORT_OK

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:21:57 -05:00
Joe Atzberger
126920f470 moredetail.pl is not an Exporter.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:21:55 -05:00
Ryan Higgins
5b1f566497 Remove acquisitions permission requirement on catalogue/showmarc.pl
This script is linked to from z39.50 search as well as acquisitions.
cataloguing/z3950_search.pl requires only the 'catalogue' flag, so
requiring only that permission here.  A user without acquisitions permissions
would get a login instead of the record display without this change.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:19:37 -05:00
Ryan Higgins
bb9aeaeec8 Sort libraries by name in holds queue's select input.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:17:04 -05:00
e3fe31b50b Change missing from previous commit re:Bug 2600.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:12:37 -05:00
e71028b354 Markup correction; Fix for Bug 2600, "HTML tags in titles not escaped in list of returned items."
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:11:55 -05:00
4ed113b230 Refining keyboard shortcuts javascript.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:08:06 -05:00
62b550a0be Some formatting fixes for bookcount.tmpl and issuehistory.tmpl. Linking to moredetail.pl from issuehistory.pl (just as barcode on detail.pl links to moredetail.pl).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 22:03:39 -05:00
Galen Charlton
6133a06e96 bug 2596: remove URL escaping added by previous patch
If URL in an href comes from a MARC record, it should not
be URL-escaped - otherwise, link is interpreted as relative
to MARCdetail.pl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 21:59:08 -05:00
ebc305bddf Fix for Bug 2596, "restore ability to hyperlink URL fields in MARC detail display"
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 21:50:19 -05:00
6f1ce35d6c Fix for Bug 2592, "hyphens being added to marc view isbn." Also removing truncation of subfield descriptions.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 21:46:20 -05:00
Danny Bouman
738ac4b492 bug 2588: fixed several links to open in new window when OPACURLOpenInNewWindow is ON
Fixed several links on the OPAC Detail page to open in a new window when the OPACURLOpenInNewWindow system preference is ON.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 21:42:28 -05:00
58deb4ed0c Can't escape title variable as HTML because of search term highlighting.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 21:36:16 -05:00
0dcd876e6a Trying again: Standardizing styling of error messages; other markup corrections.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-16 21:23:54 -05:00
Henri-Damien LAURENT
89fd84c5a3 Bug Fixing : 2581 Problem With HomeBranchOrHoldingBranch (count items management)
Using $item->{$hbranch} rather than $item->{homebranch}

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-11 08:43:16 -05:00
Joe Atzberger (siptest
bd0ef37c24 Bugs 2541 and 2587 - AddIssue must return date object as intended.
SIP actually relied on the AddIssue return that was not reliable.
AddRenew also updated to return C4::Dates object for datedue.

Please note, any running SIPServer will have to be restarted
*immediately* after applying this patch, because although Koha
C4 behaves as normal, the SIP server runs as a Net::Server with
components cached.  Changes will not be applied until SIPServer
restarts, and so checkout actions may fail until then.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-09-11 08:06:04 -05:00