Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Jonathan Druart	f1f9c6dc74	Bug 26384: Fix executable flags .pm must not have -x .t must have -x .pl must have -x Test plan: Apply only the first patch, run the tests and confirm that the failures make sense Apply this patch and confirm that the test now returns green Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Katrin Fischer	ed066caf58	Bug 26015: Terminology: Fix tons more staff clients to staff interfaces This takes care of more occurences of staff client and changes it to staff interface, including in code comments. To test: - I think in this case careful code review is what we look for. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Jonathan Druart	2b90ea2cb0	Bug 17829: Move GetMember to Koha::Patron GetMember returned a patron given a borrowernumber, cardnumber or userid. All of these 3 attributes are defined as a unique key at the DB level and so we can use Koha::Patrons->find to replace this subroutine. Additionaly GetMember set category_type and description. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	7 years ago
Stefan Weil	63c1589685	Bug 14383: misc: Fix some typos in comments and documentation Most of them were found and fixed using codespell. Signed-off-by: Stefan Weil <sw@weilnetz.de> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>	9 years ago
Marcel de Rooy	1219b3153e	Bug 11124: QA Follow-up resolving a warning and three typos Resolves warning on uninitialized author in split on line 128. Just adds the same behavior for title on line 129 for completeness. Fixes typo on occurrences and two other minor typos. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Jonathan Druart	4604f595d6	Bug 11124: disallow trying to run the staff benchmark script as the DB account On step 6 (at least), the circulation and return page redirect to the select branch page and nothing is done. The script should die if the user used is the sql administrator account. Test plan: Suppose that the sql admin account is root/root and koha/koha a superlibrarian account. 1/ perl misc/load_testing/benchmark_staff.pl --steps=6 --url=http://admin.koha.local/cgi-bin/koha/ --password="koha" --user="koha" should produce: ... Step 6 ... 2/ perl misc/load_testing/benchmark_staff.pl --steps=1 --url=http://admin.koha.local/cgi-bin/koha/ --password="root" --user="root" should produce: Authentication successful You cannot use the database administrator account to launch this script Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Jonathan Druart	f2c0fe0ca1	Bug 10806: make the staff benchmark script check authentication failure. Currently, if you launch the script misc/load_testing/benchmark_staff.pl, it always displays "Authentication successful" or continue to execute the script even if nothing is done. This patch checks if the url is right and if the authentication is correctly done. Test plan: Suppose that a correct login/pwd is koha/koha 1/ perl misc/load_testing/benchmark_staff.pl --steps=1 --url=http://admin.koha.local/cgi-bin/koha/ --password="koha" --user="koha" should produce: Authentication successful ... Step 1 ... 2/ perl misc/load_testing/benchmark_staff.pl --steps=1 --url=http://admin.koha.local/cgi-bin/koha/ --password="KOHA" --user="KOHA" should produce: Authentication failure: bad login/password 3/ perl misc/load_testing/benchmark_staff.pl --steps=1 --url=http://admin.kobe.local/cgi-bin/koha/ --password="koha" --user="koha" should produce: Authentication failure: 500 Can't connect to admin.kobe.local:80 (Bad hostname) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works as described, detects bad url and user credentials. No koha-qa errors Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described and gives better error messages. There are some warnings output when running the script before and after applying the patch. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Mirko Tietgen	608402e27b	Bug 8413 Space in barcodes breaks GET request in benchmark_staff.pl GET requests in benchmark_staff.pl test 6 do not work if a space character is part of the barcode. That seems highly unlikely to happen in barcodes, but is possible if no real barcodes are used but a substitute, like a copy of the call number. Space character needs to be changed to %20 for the request to work. Also fixes a typo. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	12 years ago
Paul Poulain	df80c6358c	Bug 6015, new script for load testing This benchmark_staff.pl script is based on the previous benchmark_circulation.pl script As it does not test only circulation, the renaming was necessary. The script has many enhancement compared to the benchmark_circulation.pl one The benchmark_staff will run a benchmark on the following pages: * mainpage.pl * catalogue/detail.pl * catalogue/search.pl * members/member.pl (search on a name) * members/member.pl (search on a 1st letter) * circulation/circulation.pl and return.pl (check-out and check-in) * all those steps at the same time run the script without any parameter to get syntax	13 years ago
Paul Poulain	93e597b5ea	Revert "Bug 6015 : Improving load_testing" sorry, was not supposed to be pushed (follow-up needed) This reverts commit `47d74bb3fb`.	13 years ago
Henri-Damien LAURENT	47d74bb3fb	Bug 6015 : Improving load_testing Adding a benchmark for OPAC it tests : - mainpage - search page - detail page Staff : Adding a test on member searches	14 years ago
Joshua Ferraro	d4bde52e7a	Adding a couple benchmark scripts Signed-off-by: Joshua Ferraro <jmf@liblime.com>	16 years ago

12 Commits (0efa25c86afad07cfcb4cd8a0ffe23e0e0c50dc7)