This patch adds a small enhancement to allow printing of Fees / Fines
receipts from the Fines page.
Patch adds print links to the Fines page next to Fines or Receipts
transactions.
Clicking on the link will pop a new window and will print that with
total outstanding as on date.
You can edit koha-tmpl/intranet-tmpl/prog/en/css/printreceiptinvoice.css
to better control printing this type of material.
18-Oct-2010 Changed template and script names to match. Corrected
invalid markup in the templates.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
- Adding "readonly" class to readonly fields to guarantee
that readonly state is indicated visually
- Adding "locked" icon to the background of readonly
fields for additional visual feedback
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
This partial fix adds a complete list of values for 006/00, "Form of material,"
following the list found here: http://www.loc.gov/marc/bibliographic/bd006.html
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Re-doing Nahuel's fix so that it applies to master
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
This patch adds a new include file to handle the display of the active
currency name and a warning if no currency is active.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Fixes the doubled up display of the publisher.
This patch fixes the bug in both the OPAC and staff client
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
I can't see any good use for a back button here, so I'm taking it out.
An improvement might be to build in a method to resubmit the same batch
of barcodes/item numbers again so that you could make additional
changes to the same set.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
- Adding "Lists that include this title" links
- Also correcting minor XHTML error in the same section of opac-detail.tmpl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
- Removing 'suggestions waiting' link from left-hand menu. A plain
'suggestions' link is still shown if suggestions are enabled.
- Putting back the 'pending suggestions' box that used to appear
on the Acquisitions home page. This will show, with a count
of pending suggestions, only if suggestions are turned on and
there are pending suggestions.
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Tweaked so that the item type column is always displayed in the
checkout history in the OPAC; noItemTypeImages now just controls
whether the icon displays.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
- Auth.pm put the noItemTypeImages preference under "intranet only."
Moved it to "OPAC or intranet."
- Added check for the preference on the OPAC advanced search page.
- Improved logic for displaying images on the reading history page.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
This system preference allows the librarian to toggle on or off whether the JQuery tablesort is used on the
circ/circulation.pl page. For patrons with many checkouts, this sort may cause very slow page loading (and
therefore slow circulation transaction time), depending on the browser and local machine used. Staff can
still see a sortable list of current checkouts on the members/moremember.pl page.
My revision prevents the template from including *any* tablesorter code if the
preference is feature is turned off: both the circulation list and
the holds list will have no jQuery tablesorter.
Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
There is no visible Lists button to "attach" our warning to
as there is in the OPAC, so warning message is displayed via
a javascript alert.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
This fix adds only public notes. A div is added as a hook for styling
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
- Also corrects framework display in the case of the default
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Changes Ordering price to List price and make spelling more consistent.
Patch originally send for 3.2, still applied to HEAD without conflicts.
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Rebased to HEAD, should also apply to 3.2
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Patch rebased to HEAD, should also apply to 3.2
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Rebased to current HEAD, small error fixed.
Should also apply to 3.2
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
* Enforce the requirement that the user must have the
create_reports permission in order to delete a saved report;
closes hole where unprivileged user could delete reports
by constructing a URL maliciously
* Added another tweak of the template - don't offer option
to create a new report if the user doesn't have permission.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(includes some reindenting, there are only a few <!-- TMPL_IF name="CAN_user_reports_create_reports" --> added
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
The items table has neither a date_due nor issueddate
column.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Reports Guided : removing \n when reading columns.def
Adding some more fields to columns.def
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Thx to Brooke for helping with the wiki.
This is the last patch.
We will have to change some more links, after translate.koha.org was moved.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
For French installation of Koha using MARC21, the same issues as UNIMARC
affects handling of by translation scripts.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Also fixes the same bug on the Itemtypes administration page.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Suppress Browse Shelf link on OPAC detail page when there is no item
call number.
[3.2] Should also apply on 3.2
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Creates new curriculum index for 658 subfields a,b,c and search option in Advanced search (under More Options). Also modifies the installer files to make 658abc display (they were hidden in the frameworks) and to create the new indexes.
The 658 already displays as part of the staff/OPAC subject display line.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
This patch adds the standard date format hint used elsewhere
in the interface.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
This patch also fixes an unreported bug where switching from any
other framework to 'Default' would bring up no MARC data.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Applied Owen's patch to current head, updated de-DE translation. The pull down values are now translated.
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
* make some strings translatable
* display library name instead of code in add/edit
holiday panel
* minor textual fixes to hints
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
- Put hints, key, and existing holidays into right column
- Style entry form for added clarity and consistency with other
forms in Koha
- Change the way dynamically displayed hints are shown to better
match existing static hints in Koha's interface
- Add branch name (instead of branch code) for clarity
- Add the ability to add and edit holiday titles (previously
only description could be edited).
- Add links to the list of existing single-day holidays and
exceptions which opens the calendar to that month/year
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
* zero-pad tag numbers as needed
* handle special case for linking to UNIMARC 0XX vs. 1-8XX
* add a wrapper function
* add comment about the poor linkability of IFLA's UNIMARC documentation
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Patch from Tomás Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
on the patron attributes page if you have ExtendedPatronAttributes
turned off the error points you to the old sys prefs editor - this
patch fixes that
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
the error message if you have ExtendedPatronAttributes turned
off linked to the old sys prefs editor, link has been updated.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
This patch renames the link to budgets to say 'budgets & funds'
and removes the links to funds (which went no where).
This patch also adds the acq menu to the budget pages.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Syspref .pref file was defining a code for descending order which wasn't
expected by .tmpl files... 'desc' instead of 'dsc'.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Otherwise, can't saved new attributes set from a cloned
input or select control.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
New orders breadcrumbs were using the inappropriate term
Shopping basket whereas basket is used elsewhere
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Fixes bug where the MARC21 008 plugin was falsely
claiming that it set the illustration and nature of
contents positions by deriving it from other fields
in the bib records.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Since the merge functionality is for merging biblio
records, not items, made the language more precise.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Fixed help text on this point as well as options for
supplying dates in the input file.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
- XSLT didn't contain the class markup which acts as a hook
for the JavaScript highlighting system.
- Standard results page also contained a typo which
prevented data other than title and author from
being highlighted
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This patch adds the ability to enter items into label batches via
barcode scanning
Work sponsored by Tamil - http://www.tamil.fr
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
- Adding inline preview/import menu to match cataloging z39.50 search
- Improving behavior of inline menu on both pages
- Adding white space to ISBN/ISSN output on both pages to allow
line breaks, improving table width and horizontal scrolling.
Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
The intended functionality of this system preference was never
implemented. To avoid template changes prior to 3.2.0, put in
hard-coded string 'CSV' to (accurately) identify the type of
the output files in the affected reports.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Disabling rotating collections for 3.2.0 release; after more testing,
candidate for 3.4 as well as backport into 3.2.1.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
tmpl_process is patched to handle properly specific XML directives.
UNIMARC XSL files are modified to gain knowledge of HTML entity
which isn't the case by default. It may be necessary to do the same
thing for MARC21 XSL.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
The pull down for category in patron's advanced search was only showing any and no patron categories.
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
The template checks for a "count" variable (item count) to see
whether it should allow deletion of the biblio record. For some
reason labeledMARCdetail.pl hard-coded this as 1, which meant
the template always thought was 1 item.
This patch also adds an item count check on the display of
"Delete all items," disabling it if there are no items.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
The Green Mountain Library Consortium has updated the 'vokal' item type
image set to include new and updated icons, including:
Puzzles and Games
BLURAY
Hardware
Educational Media
Fiction, Nonfiction, New and Holiday books
ILL materials
Smaller versions of all the icons (32 px) are included as well.
Sorting of the icons has been included in this patch to group
large and small versions of these icons together, as well as make large
icon sets easier to visually scan (the 'bridge' set benefits from this,
as well) .
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
- make publication year save for MARC21
- make ISBN save
- fix small template issue with label for vendor note
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Original commit message was for 650 field, but fix works for 600. See bug report.
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Show place of puplication in
- OPAC result list
- OPAC detail
- staff detail
The normal display does already show the place of publication, but it's missing from the XSLT controlled displays.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This patch eliminates the sysprefs-menu.inc include file and changes the
systempreferences.pl and systempreferences.tmpl files to work with the
prefs-menu.inc instead. This will centralize the syspref tabs and make it
easier to modify tabs in the future if necessary.
This commit also changes the default tab to Acquisitions, since the Local Use
tab does not work with preferences.pl at present.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
- Markus Enger (asked for permission)
- Jared Camins-Esakov (asked for permission)
- Katrin Fischer
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
When the clone/unclone plus/minus were replaced with images the <span> tags were inadvertantly deleted
causing the js to loose its ability to identify the clone/unclone links and properly udpate the indexes.
The resulting incorrect indexes caused various weirdnesses to result when one attempted to clone/unclone
subfields.
This patch simply adds classes to the two links and updates the js to identify the links based on class.
Thanks to owen for his help in chasing this down.
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
- Changing input "button" to "submit" so that confirmation
dialog redirects the user as expected
- Changing non-standard message box styles to standard ones
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Squashed commit of the following:
commit d42198bfadff20f40c38b3d9bc7f210ecc372e7c
Author: Chris Nighswonger <cnighswonger@foundations.edu>
Date: Mon Jul 12 16:48:16 2010 -0400
Bug 3756 [4/?] new sys prefs - no way to add a new local use preference
Fixing Global Administration link
commit 060a52bc8d9da1d83387455967ca05292e5987b9
Author: Chris Nighswonger <cnighswonger@foundations.edu>
Date: Mon Jul 12 16:45:07 2010 -0400
Bug 3756 [3/?] new sys prefs - no way to add a new local use preference
Hiding non-local sysprefs
commit d63858e13037fa91f18bc248ab770d757e31153c
Author: Chris Nighswonger <cnighswonger@foundations.edu>
Date: Mon Jul 12 16:44:40 2010 -0400
Bug 3756 [2/?]new sys prefs - no way to add a new local use preference
Fixing a typo
commit 5b23a615018e049b1e11dbc10b131ecb30dfc6ab
Author: Chris Nighswonger <cnighswonger@foundations.edu>
Date: Mon Jul 12 15:52:04 2010 -0400
Bug 3756 new sys prefs - no way to add a new local use preference
A quick and dirty fix
Signed-off-by: Chris Cormack <chrisc@catalyst.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Staff users now only need circulation privileges to print
checkout receipts and slips; the 'borrowers' permission, which
allows editing patron records, is no longer required.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
- Correcting JavaScript so that serial enumeration / chronology is always
prepopulated in the add item form when receiving a new issue.
- Altering the behavior of the "click to add item" link so that the
"Arrived" option is automatically selected. This makes the link's
behavior mirror the <select>'s behavior so that Arrived -> Add item
and Add item -> Arrived.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
- Add <xsl:if> wrappers around the display of subfield 'n' for 76x-78x fields
This eliminates the issue in Firefox that caused the font size to grow
progressively smaller on the OPAC Details page for records with multiple
76x-78x fields
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
EUC-KR (an older character encoding for Korean) is used by the
Z39.50 server of the National Assembly Library of the Republic
of Korea.
Note that this requires that a suitable version of iconv,
one that supports mapping from EUC-KR to UTF-8,
be present on the Koha server.
Thanks to a person from the Korea Society for reporting the
issue on #koha.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
The PDF templates for purchase orders now live in the
directory koha-tmpl/intranet-tmpl/prog/pdf to separate
them from code. As no automatic translation system for
PDF files is currently implemented, I'm keeping them out
of the language subdirectories for now.
At present, there are two choices of templates for printing
purchase orders (AKA basket groups), controlled by setting
the OrderPdfFormat syspref:
pdfformat::layout2pages (two-page layout)
pdfformat::layout3pages (three-page layout)
To customize a template or to add a new one requires two steps:
* modifying the PDF; note that OpenOffice source files
are included as a way of generating the PDF
* modifying the code in acqui/pdfformat/layout*.pm to
position the order text onto the template
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Some other cosmetic and functional changes:
- "Show all/Show 50" links had been styled as tabs at some time
in the past. A CSS change somewhere broke this. Reimplementing it.
- Moving sort control to a <select> similar to the one used on
search results. Since javascript-based table sorting from the
table header is used elsewhere in the OPAC I felt the <select>
method better reflected the behavior of this re-sort.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
The logic for displaying a useful title did not take all
cases into account. This patch adds the missing case.
The patch also fixes problems with the "Cancel" link
on update and delete operations.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
removing of useless value "no tabs" in organize by combo.
removing of useless value "Sort 1" in organize by combo.
Adding combodate for suggesteddate, manageddate, accepteddate.
Adding research on dates in query.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
When we apply a filter and click on "Click here to show x items" link, there are duplicates orders which are display.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Sorted the branches select.
Modified display to "branchcode - branchname"
Fixed a bug, selection was inverted.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Note that this new include builds only the first half of the
anchor tag (<a>). Because title and subtitle are output differently
on some pages, rendering of the second half of the tag is left
to individual pages.
Includes fixes for staff client templates.
Change to basket.pl fixes a bug wherein the OPAC's bibliodefaultview
preference was being checked instead of the staff client's.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Prevent the generation of empty label spans for various
bib details fields. A construct like
<span class="results_summary"><span class="label" />contents note</span>
is consistently misinterpreted in many web browsers, leading to
CSS oddities. See the bug for more details.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This patch improves the template logic specifying a layout
based on whether the display is XSLT or normal, and whether
Amazon Content is on or off. Previously XSLT view did not
display Amazon covers when enabled.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
- Adding material type icons from the OPAC side
- Adding OPAC View link
- Copying revised handling of MU from the OPAC
- Removing OPAC-specific markup
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Patch corrected to follow HDL's suggestion that link check
for existing vendor id and conditionally redirect based
on that.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
- Also adding cancel link to the add/edit view
- Also adding message when there are no contracts to list
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This patch implements Fridolyn SOMERS' suggested change
to the .xsl file path but copies compact.xsl from the
intranet template dir and points to that instead.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
The template was originally designed so that form controls were
hidden from users who didn't have permission to modify a particular
shelf because the form controls were only used for deleting from
lists. Now that users can place holds and add tags via the check-
boxes, the controls must be available to all users.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
The usedaysmode preference was missing the option to
calculate due date by finding the next open date on the
calendar instead of ignoring all days the library is
closed.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Changes "+" and "-" controls to actively linked images giving
better feedback about their clickability and an increased click
target area.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Per the following koha-devel thread, the use of
staff user subpermissions, AKA granular permissions, is
now the default behavior in Koha. This patch removes
the GranularPermissions system preference.
[1] http://lists.koha-community.org/pipermail/koha-devel/2010-February/033670.html
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
A later patch might come that changes the text entirely, as it does not match the OPAC, and is often confusing for staff.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
The plugin was returning a 25 characters length leader rather than 24
characters. So leader was recreated automatically, removing user update,
before writing biblio record.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
A fix was submitted by Nahuel on 23 Nov 2009 and pushed, but
it combined messages for existing patrons and existing items.
This patch defines separate messages for the various cases and
corrects a typo in the original fix which left existing patrons
unreported.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
The template-side fix for Bug 3926 was overwritten by
another template change I submitted later. My bad.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
There wasn't a conditional in place to stop the planning
pull down from showing a blank 'plan by' option.
This patch also makes the other 'plan by' options look
cleaner by removing the all caps.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Strings within JavaScript onclick attributes are not getting picked
up by the translator:
onclick="return confirmDelete(_('Are you sure you want to cancel this
hold?'));"
This patch converts those to use variables defined in the main
script block:
onclick="return confirmDelete(MSG_CONFIRM_DELETE_HOLD);"
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
these prefs : FilterBeforeOverdueReport & DisplayClearScreenButton shouldn't be
lumped together - they do two very different things and have nothing to do with
each other.
this patch splits them into two individual preferences.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
search so the alert stands out. Previously no css was applied to it so
it was just plain text. Librarians weren't noticing it.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This is a replacement patch for my previous patch.
This patch insures that only unique subscriptionids are defined in the serials-edit form. Multiple ids are passed to serials-collection, but not multiple copies of the same id.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
The unAPI link is now added only in opac-detail.tmpl. More than
one unAPI link in the same page was causing a bit of indigestion
for Zotero, which interprets multiple unAPI links as specifying
more than one resource on a given page.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
- fix formatting of last renew date
- Add table zebra striping
- Other markup structure changes
- Revised template assumes that issues.branchcode == checkout library and displays
that value instead of issues.issuingbranch (which is always empty, see Bug 2806)
issues.branchcode seems to reflect the item's holding branch *after* having
been updated as part of the checkout transaction.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Script was written as though it had an array rather than
a single supplier. Replaced the excess punctuation with a single
supplier variable
replaced the C-style currency loop with a simpler perl-style one
we only need 1 loop not multiples
Changed variable name $GST to $tax_rate it's not magical and not a constant
and we all know what tax is
Fetch Contract data once rather than twice from two different modules
Correct size of discount data on display
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This patch change the way to retrieve the value to insert in the record.
The way it was done, was verry ugly.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Subfields whose contents are longer than 100 characters are represented on the
bib form using a <textarea> instead of a text <input>. The check on whether
at least one subfield for a mandatory field is populated wasn't not
checking for <textarea> subfields.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Removes the 'Search for Serial Routing' heading from the serials search result screen.
There is no code in the template that performs a routing search, and links to the routing tables are provided in the serials search results.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This system preference never worked; also, as far as I can tell,
the PINES oISBN service was experimental, not meant for production
use, and is not currently advertised.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
