Commit graph

16654 commits

Author SHA1 Message Date
Jared Camins-Esakov
255e1910ee Bug 8204: fix UNIMARC display
UNIMARC display of authorities in the OPAC wasn't working due to
changes in the BuildSummary function since the code was originally
developed.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-07-26 18:13:39 +02:00
Jared Camins-Esakov
569e3823fd Bug 8204: Add user friendly authority view to OPAC
Up until now, the only authority view in the OPAC was a
rather-unfriendly expanded MARC view. This patch adds a user-friendly
view similar to the biblio details view.

Specific features to be aware of:
* Right-to-left text in the MARC21 880 field will show up in the
  appropriate location with the appropriate alignment and wrapping
* There is very little CSS styling. Any suggestions for how to make
  the display more attractive would be gratefully received.

To test:
1) Do a search for an authority in the OPAC.
2) Choose an authority record to view.
3) Observe that the view is more user-friendly and polished.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works very nicely now. The old view is still available, but the
user is presented with a nicer non-MARC view first.
2012-07-26 18:11:44 +02:00
Jared Camins-Esakov
899597c826 Bug 8208 follow-up: move Clear and Create new buttons out of results
Turns "Clear" and "Create new" links into buttons that are visible
before a search is performed, so that the user does not have to do
a search just to clear the field or create a new authority. This
commit also changes the formatting from textual links to buttons.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Nicer and more logical display.
Allows creating of a new authority without doing a search first
or when no results were found.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-07-26 17:47:50 +02:00
Jared Camins-Esakov
5ff81e2e8e Bug 8208: Add fast-add link to auth finder plugin
When performing subject analysis, it is not uncommon to find that an
authority record you need does not exist. This commit adds a link in
the search results to enable the cataloger to create an authority on
the fly and have the heading populated by the new authority.

To test:
1. Use the auth finder plugin the cataloguing module to search for a
   heading you do not have an authority record for.
2. Click the "Create new" link.
3. Fill in your authority and save it.
4. Note that the heading field was populated with the data you entered
   in the authority record.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
1) Added a new authority using the plugin
2) Used an existing authority using the plugin
3) Created a new authority in the authority module

All worked nicely.
2012-07-26 17:47:47 +02:00
Savitra sirohi
ba8a6ed141 Bug 7153 - Show Open Library as Search Target in "More Searches" in OPAC detail page
Update syspref OPACSearchForTitleIn to include Open Library as a target in More Searches in the OPAC detail page

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-07-26 14:55:23 +02:00
9923f65dc2 Bug 8470: remove depreciated H:T:P test
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-07-26 14:53:13 +02:00
Paul Poulain
de07f00630 Bug 7420 tiny bugfix
The printing at the end, in verbose mode was not displaying variables properly because the print was '' and not ""
2012-07-25 18:35:36 +02:00
Paul Poulain
1d569bced4 Bug 7420 follow-up DBRev number 2012-07-25 18:35:36 +02:00
Elliott Davis
381794ff4e [PATCH] bug_7420: Added overduefinescap to issuingrules
Replaced existing MaxFine syspref logic with overduefinescap.
Repurposed MaxFine to be the overall overdue limit for all items
overdue. Implemented new MaxFine logic in UpdateFine().

Signed-off-by: Elliott Davis <elliott@bywatersolutions.com>
Tested according to Srdjan's test plan and everything worked like he said it would.  I set fined equal to $2 and max fine equal to $1.      When I ran the fines script for overdue items fines assessed were only $1.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-07-25 18:33:20 +02:00
Paul Poulain
54f363c0a6 bug 8486 tiny follow-up, removing ` 2012-07-25 16:55:30 +02:00
Colin Campbell
cd44ef2dc9 Bug 8486 Merge Calendar test files
Moves the tests previously in t/Kalendar.t to t/Calendar.t
and removes the old file.
Note the existing minimal test of C4/Calendar still called in
t/Calendar

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-07-25 15:52:24 +02:00
Colin Campbell
3b694b9b1c Bug 8486 Correct calculation of days_between
Thee were errors in the calculation used for days_between
which caused incorrect values to be returned
Added tests to validate calculation

NB Tests still need to be provided for the hourly
calculations
2012-07-25 15:52:16 +02:00
Paul Poulain
5432bd488f Merge remote-tracking branch 'origin/new/bug_7889' 2012-07-25 15:08:50 +02:00
ba2f90dc77 Bug 7889 - Use standard style for errors and messages
Correcting the markup of error messages in three places:
catalogue merge, CSV profile editing, and opac comments.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-07-25 15:07:47 +02:00
5e10c0ad87 7368 Adjustments for Perl dependencies
HTML::FormatText is used by Template::Plugin::HtmlToText which is called in the template for opac-sendbasket.pl.
This is not a core Perl 5.10 module. I had to install it additionally on a test server. So I am adding it to PerlDependencies.
I just picked an old version 1.23 that I still could find as min_ver.

Changed the version information for Test::Strict too (not required, only for tests).

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-07-25 14:33:03 +02:00
Paul Poulain
22842ab258 Bug 7302 tiny follow-up removing </td><td>
to have the Export as CSV in the same cell as other buttons
2012-07-24 18:34:52 +02:00
Jonathan Druart
ee58361abb Bug 7302: Followup: rename "Client number" column with "Account number"
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-07-24 18:22:09 +02:00
Jonathan Druart
a6c93961b1 Bug 7302: Export basketgroup as CSV
Adds new action export for basketgroup.
This action is available only if your basketgroup is closed.
This export generates a csv file with order informations.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested together with bug 5356.
2012-07-24 18:22:06 +02:00
Julian Maurice
30ee49ddb4 Bug 8376: New script to export borrowers misc/export_borrowers.pl
This script prints to standard output what is returned by
GetMemberDetails in CSV format.
Exported fields can be specified with option -f. If no -f option is
specified, all fields are exported.

Signed-off-by: Gaetan Boisson <gaetan.boisson@biblibre.com>
Signed-off-by: Robin Sheat <robin@catalyst.net.nz>

Amended with some code to better handle bad data.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-07-24 17:36:14 +02:00
9e948438ef Bug 8434 - Notice generation fails for Advanced Notices, Item Due, and Overdues when run in shell (due to error in Letters.pm)
Patch introduces a check for C4::Context->userenv in Letters.pm, so that script doesn't fail when it calls to C4::Context->userenv->{branch}, when run from shell.

Without the check, Advanced Notices, Item Due, and Overdues fail to generate.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-07-24 17:34:05 +02:00
Magnus Enger
70588431b6 Bug 7367 - One "the" too many
On line 123 it says "of the the last". One "the" is probably enough.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-07-24 17:33:03 +02:00
Paul Poulain
226af0485d Merge remote-tracking branch 'origin/new/bug_8062' 2012-07-24 17:31:07 +02:00
bbee374075 8062 Followup for HTML::FormatText
The dependency is not used in opac-sendbasket. But there is a require of HTML::FormatText in the code of Template::Plugin::HTMLToText.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
2012-07-24 17:28:32 +02:00
b84c772e1b Bug 8392: Avoid having an untranslatable age range
Currently, error message reports an age range in English. For example '0 to
17'. With this patch, the 'to' is not in the .pl file anymore.

Ruth could you sign-off this fix?

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-07-24 17:20:46 +02:00
D Ruth Bavousett
e6c9b20bdb Bug 8392: Category age ranges not being enforced
This patch works around the redefinition of an array that was causing the
enforcement of age ranges to not-happen.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

I can confirm the bug and the solution.
2012-07-24 17:20:42 +02:00
Fridolyn SOMERS
81823c55cc Bug 8440: Dates does not appear in suggestions management
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-07-24 17:04:32 +02:00
1106ed527a Bug 8414 - Intranet header toplinks display white rather than blue in < IE8
Removes IE7 hash hack which caused head toplinks to display white rather than dark blue against light blue background

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-07-24 16:49:49 +02:00
58b85e1df1 Bug 8448 - Holds Awaiting Pickup : Cancelling a hold on a waiting item with multiple holds displays a blank screen instead of a warning prompt
When you cancel a hold in the "Hold Waiting" tab of Holds Awaiting Pickup, you should be prompted to retain or transfer the hold for the next patron in the queue. However, instead of seeing this prompt, you are just shown white screen that fails to alert you to the fact that there are more holds on that item!

There is a missing FOREACH reference in waitingreserves.tt. The template tries to directly reference the hash within the cancel_results array, but we need to access the array before we can access the hash.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-07-24 16:39:34 +02:00
Dobrica Pavlinusic
664ecc9aca Bug 8442 - labels creator fixes for plack
- remove all exit(1) and replace them with __END__ which benefits CGI
- insert correct =cut markers at end of POD (required for CGI::Compile
  under plack to correctly parse source code and exeute it)
- scope variables with our which are used inside sub for plack

Signed-off-by: Mirko Tietgen <5p4m@gmx.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-07-24 16:21:05 +02:00
Kyle M Hall
217fef5749 BugFix - ReturnToShelvingCart
If the ReturnToShelvingCart syspref is on, and something needs to go in transit,
the shelving cart setting is overriding the transit.

What seems to be happening is this:
  * Item is checked in, and flagged as needing to go in transit from A to B.
  * Item is immediately flagged as shelving cart, though.  Current display says both shelving cart and in transit.
  * After the cart-to-shelf script runs, item comes out of transit and
    shows as being available at the destination library, although it hasn't
    arrived yet and no one has manually checked it in.

http://bugs.koha-community.org/show_bug.cgi?id=3701

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-07-24 15:05:23 +02:00
Dobrica Pavlinusic
a64ed6722b Bug 8439 - Printing basketgroup does not work on plack
scope $input CGI object with our for plack

Signed-off-by: Mirko Tietgen <5p4m@gmx.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-07-24 10:55:43 +02:00
Fridolyn SOMERS
cbfe374cd6 Bug 8476: Little bug in OPAC XSLT on OPACURLOpenInNewWindow
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

I know where it comes from: vim cut-and-paste...

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-07-23 18:29:19 +02:00
Paul Poulain
4feb0a6246 Bug 6716 tiny follow-up, mysql want a space after the -- 2012-07-23 18:26:21 +02:00
Nicole C. Engard
7f7599ea05 Bug 6716: Update z3950servers documentation
The new timeout field was not documented.
2012-07-23 18:23:38 +02:00
Nicole C. Engard
479c490676 Bug 6716: Document search_history table 2012-07-23 18:23:37 +02:00
Nicole C. Engard
98f539f7aa Bug 6716: Document saved_sql table 2012-07-23 18:23:36 +02:00
Nicole C. Engard
7b1676895a Bug 6716: Update reserves table
This table had one field that I hadn't documented
before and two new fields for hold suspensions. All
of these are now updated.
2012-07-23 18:23:35 +02:00
Nicole C. Engard
89a4ae4076 Bug 6716: Update documentation for the letter table
The letter table is now for slips and notices, and
had other changes necessary.
2012-07-23 18:23:34 +02:00
Nicole C. Engard
f3160d1005 Bug 6716: document import_record_matches table 2012-07-23 18:23:33 +02:00
Nicole C. Engard
67bd83d180 Bug 6716: Document import_batches table 2012-07-23 18:23:32 +02:00
Nicole C. Engard
929fee5f8c Bug 6716: Document tags tables
I did not document the 'tags' table in this patch
because it looks like this table is unused, so I
need confirmation of that before marking it as
'unused.'
2012-07-23 18:23:31 +02:00
Nicole C. Engard
5ab6d0ccd9 Bug 6716: Document patronimage table 2012-07-23 18:23:29 +02:00
Nicole C. Engard
f32d7e6483 Bug 6716: document issuingrules table 2012-07-23 18:23:28 +02:00
Nicole C. Engard
707d5a5e68 Bug 6716: Document branch_borrower_circ_rules table 2012-07-23 18:23:27 +02:00
Nicole C. Engard
e7816ad31e Bug 6716: Document branch_item_rules table 2012-07-23 18:23:26 +02:00
Nicole C. Engard
a3a6407e51 Bug 6716: Document the biblio_framework table 2012-07-23 18:23:25 +02:00
Nicole C. Engard
1b0e6938ad Bug 6716: Document aqbasket table 2012-07-23 18:23:24 +02:00
Nicole C. Engard
73def1a24a Bug 6716: Document action_logs table 2012-07-23 18:23:23 +02:00
Nicole C. Engard
bfaef0bb19 Bug 6716: Update ratings table documentation
This patch adds a comment to the table and updates the field
descriptions with a bit more information.
2012-07-23 18:23:22 +02:00
Nicole C. Engard
86392dde00 Bug 6716: Document branchtransfers table 2012-07-23 18:23:21 +02:00