Commit graph

12113 commits

Author SHA1 Message Date
Jane Wagner
2894555f5c Bug 3093 add syspref to turn off multiholds button
Having the place multiple holds button at the top of the OPAC and staff search results has caused problems for some sites with tight holds policies; this syspref allows those sites to turn off the button.
2010-05-11 17:09:49 +12:00
Jane Wagner
8a1cb959c6 Bug 3671 Workaround for font display problem
If there is no 007 field, parts of the OPAC results data display in a
much smaller font than normal.  Adding a blank space in the span section
fixes it.
(cherry picked from commit 2ff55ef2a2443933881186323f5dec3fe40842dd)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-10 16:40:31 -04:00
e7f8cc8f5e bug 4403: look in appropriate theme/lang for bib display XSL
Note: approach used can be described as a hack at best; the current
language should probably become a session attribute.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-08 18:59:41 -04:00
3d8e99e5ec fix disappearance of language chooser introduced in recent patch
Note that xt/author/valid-templates.t did *not* catch the
missing /TMPL_IF

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-08 18:58:36 -04:00
a6d6be8958 quell 'non-initialized variable defaulttab' warning
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-08 18:57:41 -04:00
d407c9cb7c fix malformed call of XSLTParse4Display
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-08 18:05:23 -04:00
841da504e8 Further corrections for Bug 4244, Use "checkouts" instead of "issues"
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-07 13:26:29 -04:00
1127878bdc Style changes to cart popup window more compact display: - compact holdings list - adds list bullet image from the staff client
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-07 13:18:02 -04:00
Nahuel ANGELINETTI
6626e8fcca (MT #2966) fix opac-user.pl function problem
This uncomment a uselessly commented function that is needed by opac-user. And fix this function that doesn't work properly.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-07 13:10:59 -04:00
Colin Campbell
1f56a04cad Bug 4450 Use more consistent error returns in C4/Creators/*
A lot of routines were defaulting to return -1 in error conditions
but calling code was expecting a ref or object
use return with explicit undef (or emptyness in array context)
for these cases. Extended this to cases where return was not tested
( -1 might in some cases be legit data).

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit 5cf2b78b6f)
[RM note: ... thereby undoing the revert]
2010-05-07 13:04:58 -04:00
46cbf7806c Bug 4465 Fixes translated boolean syspref inversion
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-07 10:39:14 -04:00
cbc9858323 another FSF address fix
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-06 20:31:26 -04:00
22eb0cfa1c fix two more instances of old FSF address
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-06 20:29:22 -04:00
Chris Cormack
5e2fcfd0b6 Adding new developers to the about page, need to do libraries next
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-06 19:58:27 -04:00
Chris Cormack
57e3cd67fd Adding a new developer plus 2 new meetings to the history doc
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-06 19:58:25 -04:00
0d8b67e73c exclude TinyMCE from non-UTF8 file checks
Since Koha otherwise had made no modifications to the TinyMCE,
we'll leave it alone.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-06 19:55:44 -04:00
1aebed5dc8 move misc source file test and fix scripts to xt/
The license and non-UTF8 file checks are closer to
author tests and don't really belong at the top level of the
Koha source tree.  Follow-up might be to converted them
to test cases in xt/author that can be run by prove(1).

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-06 19:46:51 -04:00
Lars Wirzenius
a2c1efa125 Add script to find source files that are not in UTF-8.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-06 18:05:07 -04:00
Lars Wirzenius
3ad74a0919 Convert to UTF-8.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-06 17:59:07 -04:00
Lars Wirzenius
6a730ce7a3 Convert to UTF-8.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-06 17:58:54 -04:00
Lars Wirzenius
1fe2b9f613 Convert to UTF-8.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-06 17:58:45 -04:00
Lars Wirzenius
d06333fb9d Convert to UTF-8.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-06 17:58:39 -04:00
Lars Wirzenius
3e7e386148 Convert to UTF-8.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-06 17:58:24 -04:00
84c2db9f6d Revert "Bug 4450 Use more consistent error returns in C4/Creators/*"
[Reverted per request of Chris Nighswonger - callers of the affected
 methods need to be updated.]

This reverts commit 5cf2b78b6f.
2010-05-06 14:41:45 -04:00
Colin Campbell
5cf2b78b6f Bug 4450 Use more consistent error returns in C4/Creators/*
A lot of routines were defaulting to return -1 in error conditions
but calling code was expecting a ref or object
use return with explicit undef (or emptyness in array context)
for these cases. Extended this to cases where return was not tested
( -1 might in some cases be legit data).

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-06 14:25:43 -04:00
5f7946e4d8 Further fixes for Bug 4208, Many submit buttons are not translatable in 3.2
Again, not a fix for a submit button problem, but for a problem with
TMPL_IFs nested inside tags, a practice which will break the
translation script.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-06 11:50:52 -04:00
46737a702c fixed Syndetics breakage
Reverts part of commit 7b12e07 that removed references
to the Syndetics sysprefs in C4::Auth for no apparent reason.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-05 12:11:30 -04:00
Ian Walls
b86e4e5700 Fixes bug 4448: &'s in itemcallnumber
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-05 11:35:34 -04:00
37e9cbc042 Fix for Bug 4416, renew all and return all buttons too close together
This patch removes the "return all" button altogether. Returning all items
is a step which one wouldn't take lightly or even regularly. Since the
interface has a means of selecting all checkboxes in the "Check in" column,
removing the "Return all" button wouldn't eliminate the means of doing so, it
would just require more deliberation.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-05 11:17:21 -04:00
7b11d2a281 Fix for Bug 4453, Improve formatting of batch item operations
- includes fix for Bug 4443
- includes some string changes, could resubmit without if these
  changes block inclusion in 3.2

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-05 11:14:07 -04:00
5d921cf51d Fix for Bug 2375, Serials holdings data does not display in opac-detail
- Removing markup to display serial data in the holdings table
  This functionality (if it worked) would seem to duplicate
  the data displayed under the 'Subscriptions' tab
- Revised again to merge item status display changes

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-05 11:14:03 -04:00
Ian Walls
74afd1ca8e Fixes bug 4452: CircControl syspref listed as ItemHomeBranch rather than ItemHomeLibrayr
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-05 10:14:48 -04:00
Koustubha Kale
1edd99e6fa Changes to kohastructure.sql to add some missing drop if exists + change in install.pl mysql show tables
[RM note: bug 4323]

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-05 10:11:00 -04:00
Koustubha Kale
e33e05c460 Web Installer -> Step 3 --> ERROR 1050 (42S01) at line 301: Table 'branch_item_rules' already exists
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-05 10:06:49 -04:00
9329c40b6b fix template translation issues
Alternative to Henri-Damien's patch that does not
require putting CSS style information in the Perl code.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-05 09:28:08 -04:00
Kyle M Hall
3a5b075c90 Fixed Patron Search Results
By default, the patron search was pulling results in *Descending* order,
then reordering the results on the page using javascript in *Ascending* order.

This was causing screwy results where the entire list of results of multiple
pages was not in complete alphabetical order.

Fixed by changing the SQL to pull in Ascending order.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-05 08:57:04 -04:00
6969fefe4c Use CSS3 box-shadow property for Cart tooltip
The OPAC Cart tooltip ("Your cart is empty," "1 item(s) added to your
Cart") currently uses a jQuery plugin to generate a drop shadow.
This works cross-browser, but has a high failure rate with regard
to hiding the shadow consistently, resulting in an orphan shadow
after the tooltip has been hidden. I propose to instead use the
new CSS3 property "box-shadow" (-moz-box-shadow and -webkit-box-
shadow for FireFox and Safari/Chrome). Currently Internet Explorer
does not support this property. I think this is an
acceptable tradeoff for more stable functionality.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-04 11:19:03 -04:00
67be4bd118 release notes updates suggested by Nicole Engard
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-04 11:13:22 -04:00
a2e6c16ecc start of release notes for 3.2
NOTE: this is not exhaustive; please send me additions for
features you have written.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-04 09:29:08 -04:00
38b16e34fd fix various errors reported by xt/author/translatable-templates.t
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-04 08:36:21 -04:00
9cb86aec3b copy new NPL icons from OPAC to staff
Fixes problem found by xt/author/icondirectories.t

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-04 07:57:51 -04:00
717223a236 fix template structure error found by xt/author/valid-templates.t
Also fixed XHTML validity error

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-04 07:50:34 -04:00
Nicole Engard
bf380b8964 bug 4442 rename batch edit tools
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-03 14:00:17 -04:00
Colin Campbell
1823eb0bbf Bug 4151 - Add DateTime to Perl dependencies
Used in Sip.pm

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-03 13:14:14 -04:00
4bfeac67ed Fix for Bug 4436, reserve should say 'hold'
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-03 10:09:29 -04:00
Garry Collum
84dada43d3 Bug 2889: Added zebra striping to the table in dictionary.tmpl.
Also fixed a couple of minor XHTML errors.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-03 09:24:03 -04:00
Colin Campbell
cb031bace9 Bug 2889 Remove toggle in boraccount display
Also remove the reverse column if no contents to be displayed
( otherwise looks like a markup error )
Rationalize the main loop now toggle not required

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-03 09:20:50 -04:00
49eb7b7a68 followup - update SCO to recognize ITEMNOTSAMEBRANCH
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-03 09:18:58 -04:00
Michael Hafen
ea0c76af7f on checkout ask for confirmation if borrower from different branch
With IndependantBranches on check that the borrower is from the same branch as
the librarian.  If not then ask for confirmation.  This check is skipped for
SuperLibrarians.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-03 09:17:19 -04:00
Ian Walls
2d3722b5a3 Fixes bug 4369: Local use does not update datelastseen
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-03 09:04:23 -04:00