Commit graph

52403 commits

Author SHA1 Message Date
2a6ac32c62
Bug 34478: Changes for suggestion/suggestion
Too much changes needed. Main functionality works again.
Some improvements can still be made.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:59:26 +01:00
af3ae06245
Bug 34478: Make plack.psgi change more comprehensive
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:59:25 +01:00
bf22d52098
Bug 34478: Classification config - Convert delete links to form POSTS
This patch converts the delete links on the classification
configuration page for sources, filing rules, and splitting rules to
POST forms.

A couple of op checks in the script are corrected to match.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:59:24 +01:00
2cfd7c4bfe
Bug 34478: Cities - Incorrect op check for cud-delete_confirm
On the cities administration page, the delete button is a GET operation
to a second form for confirmation.

This script should be checking for op=delete_confirm, not
cud-delete_confirm.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:59:23 +01:00
325b3e7c10
Bug 34478: Convert authorised value delete link to POST form
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:59:22 +01:00
09bfb81c5e
Bug 34478: Authority frameworks - first subfield delete button has incorrect op value
From the list of a tag's subfields (e.g.
/cgi-bin/koha/admin/auth_subfields_structure.pl?tagfield=245&frameworkcode=)
the delete button is a GET operation to a second form for confirmation.

This script should be checking for op=delete_confirm, not cud-delete-confirm.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:59:21 +01:00
906059fd03
Bug 34478: Frameworks - first subfield delete button has incorrect op value
From the list of a tag's subfields (e.g.
/cgi-bin/koha/admin/marc_subfields_structure.pl?tagfield=245&frameworkcode=)
the delete button is a GET operation to a second form for confirmation.

This script should be checking for op=delete_confirm, not
cud-delete-confirm.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:59:20 +01:00
8e6b95a936
Bug 34478: Convert EDIFACT messages deletion to POST
Modify DataTables rendering to put the delete button inside a POSTed
form.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:59:20 +01:00
5a333e3cfa
Bug 34478: Use op and cud in pay -> paycollect redirect
The pay to paycollect post/redirect flow here doesn't actually
consistute a state change, however it's much simpler to add the csrf
token check flow here than to refactor the code to a get (url's quickly
grow too large for a GET) or rework it in other ways.  I opted to do
this for now and work on a refactor at a future date.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:59:19 +01:00
0896724e34
Bug 34478: Re-correct account-table pay
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:59:18 +01:00
95c4f93671
Bug 34478: Basket group export CSV option should not check cud-op
The Export CSV operation is GET and uses op=export, so the script should
not check for "cud-op."

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:59:17 +01:00
62d9f73e9e
Bug 34478: Changes for authorities/searchresultlist (new delete form)
Replaces a delete with GET.
FIXME: Trouble with closing dropdown.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:59:16 +01:00
3931404cd5
Bug 34478: Regression - fix installer stuck
Installer was stuck after "Set up database" with a blank page

It also fixes 00-onboarding.t

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:59:15 +01:00
5567a1a6d4
Bug 34478: Regression - fix change auth type
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:59:15 +01:00
3f2a8ecf3c
Bug 34478: Regression - fix change framework
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:59:14 +01:00
8c35fec856
Bug 34478: (follow-up) Change invoice files delete link to POST
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:59:13 +01:00
ea6842ea21
Bug 34478: Manual fix - Fix controller op handling of self-checkout
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:59:12 +01:00
8b69d0b4d3
Bug 34478: Manual fix - Fix session cookie management of self-checkout
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:59:11 +01:00
4354a4c172
Bug 34478: Manual fix - Remove csrf_token from GET to sco-patron-image.pl
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:59:10 +01:00
768b24af78
Bug 34478: Manual fix - Remove cud-search from z3950-admin-search.inc
Convert POST to GET for z3950 server search

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:59:10 +01:00
8dc35c14b1
Bug 34478: Manual fix - change links to JS form submission - change action to op - request.pl/.tt
Bug 34478: [TO SQUASH] Manual fix - change links to JS form submission - cleanup comments and unused routine - request.pl/.tt

Bug 34478: [TO SQUASH] Manual fix - link to js post and add op to form - request.tt

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:59:09 +01:00
7c56ebade7
Bug 34478: Manual fix - change 'phase' to 'op' add cud- - mana-share-report
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:59:08 +01:00
db040fa49a
Bug 34478: Rename the cud op for the statess account redirection form
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:59:07 +01:00
4fe6021685
Bug 34478: Update op for opac-account-pay
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:59:06 +01:00
c2937c5bd0
Bug 34478: Add op cud-stateless for account-table.inc
This form calls a payment plugin to prep a new form that submits to a
the payment site external to Koha.

This form does not change state but a change to GET would cause failures
if trying to pay more than 133 fees on Chrome ( but not Firefox ).

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:59:05 +01:00
21fa3f64c3
Bug 34478: Fix link to batch patron mod from reports
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:59:04 +01:00
cf445df109
Bug 34478: Move to get for modborrowers
Bug 34478: [TO SQUASH] tools/modborrowers

We actually want to POST here to not reach the limit of a GET request.
It also fixes the following warning in the console:
  Form contains enctype=multipart/form-data, but does not contain method=post.  Submitting normally with method=GET and no enctype instead.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:59:04 +01:00
f1ecd4eef1
Bug 34478: guided_reports - run is stateless
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:59:03 +01:00
b624cc9928
Bug 34478: Manual fix - audio alerts
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:59:02 +01:00
2ca4d81846
Bug 34478: Clarify opac serial alert subscriptions
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:59:01 +01:00
b8814ff696
Bug 34478: Manual - Replace link with submit button - circu-menu
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:59:00 +01:00
3fbaf6379e
Bug 34478: Manual - change to get and remove CSRF - boraccount
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:58:59 +01:00
ebe28ee344
Bug 34478: Manual fix - change to GET - overdrive-checkout.inc
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:58:59 +01:00
1d4b275332
Bug 34478: Manual fix - convert link to form - boraccount.tt
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:58:58 +01:00
a060170d29
Bug 34478: Manual fix - change to get remove csrf token - installer/step2
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:58:57 +01:00
5472966a4b
Bug 34478: Manual fix - change to get remove csrf token - installer/step1
This form allows the user to select which language they wish to work
through the installer in, it doesn't update anything serverside.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:58:56 +01:00
0e4f0292af
Bug 34478: Manual fix - change to get remove csrf token - barcode-print
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:58:55 +01:00
accf556340
Bug 34478: Manual fix - change to get remove csrf token - downloadcard
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:58:54 +01:00
8a20e0cb6a
Bug 34478: Add 'op' to reports/guided_reports - WIP
Bug 34478: [TO SQUASH] Add 'op' to reports/guided_reports

Found bug 36071 when working on this. This is not a regression from this
patch.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:58:53 +01:00
c16e579d48
Bug 34478: Add 'op' to sendbasketform
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:58:53 +01:00
6246d9812d
Bug 34478: Manual fix - change to get remove csrf token - citites-admin-search
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:58:52 +01:00
f9f9f22559
Bug 34478: Manual fix - change to get remove csrf token - contracts-admin-search
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:58:51 +01:00
351bba2b55
Bug 34478: Manual fix - change to get remove csrf token - acquisitions-search
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:58:50 +01:00
5fcce594f6
Bug 34478: Manual fix - change to get remove csrf token - budgets-admin-search
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:58:49 +01:00
5f4d97742d
Bug 34478: Add 'op' to circ/renew.pl
Added 'cud-renew' op check to circ/renew.pl and added corresponding op
params to:

* includes/renew-search-box.tt
* circ/renew.tt

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:58:48 +01:00
f1be5a8524
Bug 34478: Changes for labels/spinelabel-print.pl (no POST)
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:58:48 +01:00
a7525cf6b7
Bug 34478: Changes for tools/cleanborrowers
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:58:47 +01:00
f3bd0e7ebd
Bug 34478: Manual fix - change to get remove csrf token - member-search-box
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:58:46 +01:00
dc5bc06163
Bug 34478: Manual fix - change to get remove csrf token - preservation-search
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:58:45 +01:00
ab38465b0d
Bug 34478: Manual fix - change to get remove csrf token - letters-search
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2024-03-01 10:58:44 +01:00