Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Author	SHA1	Message	Date
Julian Maurice	96cc447045	Bug 25898: Prohibit indirect object notation Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Owen Leonard	c2127901da	Bug 25627: Move OPAC problem reports from administration to tools This patch moves the OPAC problem report management page from the Administration section to the Tools section. I think this makes sense because management of reports is an ongoing task, not a configuration. To test, apply the patch and enable the OPACReportProblem system preference. - Go to Administration. There should be no link to OPAC problem reports. - Open an administration page which shows the Administration menu in the left-hand sidebar, e.g. Libraries. There should be no link to OPAC problem reports in the menu. - Go to Tools. There should be a link to OPAC problem reports in the "Addional tools" section. - Open the OPAC problem reports page and confirm that it works correctly. - The breadcrumbs menu should show "Tools > OPAC problem reports." - Confirm that the link in the sidebar menu works correctly. - If necessary, submit an OPAC problem report via the OPAC so that there is a pending report. Go to the staff interface home page and check that the "OPAC problem reports pending" link works correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Aleisha Amohia	3509f9cff8	Bug 4461: Fix status and borrowernumber fields in problem_reports and more status varchar(6) with readable statuses borrowernumber not null default 0 hide form if message successfully sent fixing hide viewed and hide closed filters adding recipient column Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	4 years ago
Aleisha Amohia	185adc1674	Bug 4461: Manage problem reports on the staff client Test plan: - Update database and upgrade schema files (if you haven't already). Restart memcached - Check your user's permissions and ensure the 'problem_reports' permission is ticked. Confirm the OPACReportProblem syspref is enabled - Log into the OPAC and submit a problem report - Log into the staff client - You should see a box at the bottom of the main page showing your pending problem report - Click the link and confirm it takes you to the new page for managing problem reports - Go to Administration - Confirm you can see a link to 'OPAC problem reports' under the 'Additional parameters' heading - Click 'OPAC problem reports' - Confirm your problem report is showing in the table - Open the OPAC in another tab and submit at least two more problem reports (so you should have at least three in the table after refreshing) - Try the different buttons - selecting multiple problem reports and using the big 'mark viewed', 'mark closed', 'mark new' buttons. Confirm there are no failures and that the number of selected problem reports is correct - select all, clear all, hide viewed, hide closed, hide new, show all - individual 'mark viewed', 'mark closed', 'mark new' buttons for each problem report. Confirm the status shows and the correct button is disabled while others are enabled - Confirm the problem page link works as expected Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	4 years ago
Fridolin Somers	206498dc55	Bug 22617: Fix checkout notes typo in manage_checkout_notes permission usage When logged into the staff client with an account with full circulate permissions (and therefore including the manage_checkout_notes permission) an error occurs when clicking on the Checkout notes pending link. The account is logged out automatically with the message: "Error: you do not have permission to view this page. Log in as a different user". The same error occurs for both the link on the home page dashboard and from the Circulation module button. Works as expected if Superlibrarian permission is set. This is just a typo in perl script : circulation instead of circulate Test plan : 1) Set preference "AllowCheckoutNotes" to "Allow" 2) Create a user with only permissions "catalogue" and "circulate > manage_checkout_notes" 3) Loggin with this user 4) Go to "Circulation" home page 5) Click on "Checkout notes" 6) You should be allowed to access Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	5 years ago
Jonathan Druart	d90ff21454	Bug 17698: Do not send pending_checkout_notes from all circ scripts It's safer to send what we need from C4::Auth it's needed from a whole module. The SELECT COUNT(*) query will only be done when needed (so not made from scripts outside of circ) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago
Jonathan Druart	1434d0aad0	Bug 17698: (QA follow-up) Fix minors design issues This patch includes some changes required on comment 57: 1. Bad resolution conflict, permission self_checkout is re-add 2. The IGNORE modifier is missing in the INSERT statement 4. When I hit /circ/checkout-notes.pl from the side bar, the page displays "Checkout notes", nothing else. We should add "There is no checkout notes". 7. I would display the table on the confirmation screen as well 10. html filters are missing 11. span element should surround translatable string, to help translators 14. patron-title.inc must be used to display patron's info Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago
Aleisha Amohia	4e722eda45	Bug 17698: (follow-up) Changing to Koha Objects style, adding circ sidebar Marcel, can you please have a look at this patch. I tried to implement the change my @notes = $schema->resultset('Issue')->search({ 'me.note' => { '!=', undef } }, { prefetch => [ 'borrower', { item => 'biblionumber' } ] }); to my @notes = Koha::Checkouts->search({ 'me.note' => { '!=', undef } }, { prefetch => [ 'borrower', { item => 'biblionumber' } ] }); but am having problems on the template side. I can access the item and biblio information about the issue, but not the borrower information, even though the query is definitely pulling it correctly. Any suggestions or ideas as to why this breaks? This patch also adds the implementation of the circSidebar. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	7 years ago
Aleisha Amohia	4a3eaf02e2	Bug 17698: Make patron notes show up on staff dashboard This patch adds a user permission for managing issue notes, and a 'noteseen' column to the issues table. To test: 1) Apply Bug 14224 first 2) Apply this patch, update database, rebuild schema. 3) Restart koha-common and memcached 4) Turn on AllowCheckoutNotes syspref if haven't already 5) Issue two items to two different users (one item each) 6) Log into the OPAC as one of the users and add an issue note to their issue 7) Log out and log back into the OPAC as the other user 8) Disable Javascript 9) Refresh opac-user.pl 10) Leave a checkout note on their issue 11) Enable javascript and log into the Staff Client as a superlibrarian user 12) Go to your user's account and edit their permissions to have everything ticked EXCEPT circulate->manage checkout notes. 13) Go to main intranet page. There should be no message saying 'checkout notes pending'. 14) Go to circulation home page. There should be no link to Checkout notes. 15) Go back to user's permissions and tick circulate->manage checkout notes. 16) Go back to main intranet page. There should now be a message at the bottom saying 'Checkout notes pending: 2' 17) Go to circulation home page. There should be a link to Checkout notes with a 2 next to it. Click this link 18) Attempt to mark an checkout note as seen. This should update the status of the checkout note to 'seen' and disable to 'mark as seen' button while enabling the 'mark as not seen' button. 19) Test both buttons with both issues. 20) Test select all and clear all buttons 21) Confirm that buttons at the bottom are only enabled if a checkbox is checked 22) Try selecting both issues and using the buttons at the bottom to mark multiple issue notes at once. 23) Confirm the barcode link to the item works as expected. 24) Confirm the cardnumber link to the user works as expected. 25) Confirm all table details show correctly. Sponsored-by: Catalyst IT Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Followed test plan, works as expected Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended patch: Remove self-checkout permissions Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	8 years ago