Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Lucas Gass	3b273de577	Bug 25744: replace <b> with <strong> in the staff interface This patch set attempts to replace all the <i> tags with <em> and all the <b> tags with <strong> in the staff interface. I attempted to get all the templates, includes, and xslt files. To test: 1. Review the changes as best as possible, looking for mistakes. 2. grep for <i> and <b> in the modules, includes, and xslt folders. You should get nothing/ 3. If you grep '<\/i>' you should only see instances of Font Awesome. 4. If you grep '<\/b>' you should only see instances where caret is used. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Lucas Gass	a02bd4f71c	Bug 25744: Replace <i> with <em> in staff interface Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Fridolin Somers	9db369fb58	Bug 26049: Replace li with span class results_summary in UNIMARC intranet XSLT In all XSLT for record display, fields are created with <span class="results_summary> except in UNIMARC intranet where there is just <li>. This allows a better CSS customisation and closer code in files for OPAC and intranet. Actually li gets diplayed with a dot at each line, we don't want this. Test plan : 1) For each modified file run 'xsltproc file.xsl' and see there is no error 2) Use default XSLT in all system preferences 3) Perform a search and check display with and without patch 4) Click on a record to see details and check display with and without patch Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Katrin Fischer	e5a959486f	Bug 26435: (QA follow-up) Terminology: Fix some more borrowers in other preferences Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Katrin Fischer	2baad1a39d	Bug 26435: (QA follow-up) Fix terminology: borrower to patron in new hint Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Andrew Fuerste-Henry	38be70b55d	Bug 26435: Add warning to AutoSelfCheck sysprefs To test: 1- apply patch, restart 2- look up AutoSelfCheck sysprefs 3- confirm new note in description Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Nick Clemens	692b095841	Bug 26460: Fix line ending in JSON Wrong line ending in JSON causes error: Uncaught SyntaxError: missing } after property list note: { opened at line 29579, column 15 To test: 1 - Have a title with some items not for hold in staff interface 2 - Set AllowHoldPolicyOverride to 'Allow' 3 - Attempt to place hold on the title 4 - Note JS error in the console and datatable does not load for items 5 - Apply patch 6 - Reload 7 - Error is cleared, table loads correctly Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Martin Renvoize	89716a78e9	Bug 26269: Fix variable name mismatch for cash_register in paycollect It appears that through various rebases the variable names in the form and the controller script have become mismatched. This patch corrects the situation and clarifies their intended use. Test plan: 1/ Turn on cash registers in sysprefs 2/ Define at least 2 cash registers in Admin 3/ Create a manual invoice on a patron 4/ Pay off half of your fee, selecting the first register 5/ Pay off the remaining fee, selecting the second register 6/ Query accountlines.register_id for your two payments 8/ Confirm the two accountlines.register_id's do not match (thus the passed variable was used) https://bugs.koha-community.org/show_bug.cgi?id=26469 Signed-off-by: Jessie Zairo <jzairo@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Jonathan Druart	59b79b6045	Bug 23816: Fix patron edition The patron edition was broken, we always got the pattern alert Password: Password must contain at least 8 characters, including UPPERCASE, lowercase and numbers Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Katrin Fischer	1a1402d066	Bug 23816: (QA follow-up) Use existing form validation to validate min password length The pattern check didn't work for me, but I figured we might want to use the same validation as for the other numeric fields on the form instead (upper age limit, etc.) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Agustin Moyano	52deed335e	Bug 23816: (follow-up) Fix many things This patch: * reverts changes on misc/admin/set_password.pl * makes category param mandatory for AuthUtils::is_valid_password and AuthUtils::generate_password * changes onboarding.pl to set category param in AuthUtils::is_valid_password * Completes t/db_dependent/AuthUtils.t and drops t/AuthUtils.t * Removes offending <input type="number"/> and replaces it by <input type="text" inputmode="numeric" pattern="[0-9]*"/> https://bugs.koha-community.org/show_bug.cgi?id=23826 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Agustin Moyano	5848da810e	Bug 23816: Add minimum password length and require strong password overrides by category This patch adds the capability to override minPasswordLenth and RequireStrongPassword settings by category To test: 1. koha-shell kohadev 2. koha-mysql kohadev 3. drop database koha_kohadev; 4. create database koha_kohadev; 5. go to admin page and start webinstaller. There continue the steps until onboarding. 6. reach step 3 of onboarding and create a new administrator patron CHECH => Password control woks as normal (Minimum length 3 and strong required) 7. finish Koha installation and enter admin with your new administrator 8. set minPasswordLength to 3 and RequireStrongPassword to “Don’t require” 9. Create a new category (CAT2 from now on.. CAT1 is the category you made in onboarding process) and set minimum password length to 8 and require strong password 10. Create two new patrons, one with CAT1(patron1) and one with CAT2 (patron2) CHECK => In both cases, try different combinations of length and strength. For patron1 the only requirement is to have 3 letters, but for patron2 the minimum length will be 8 and will require strong password. CHECK => Try changing patron category before saving. Password requirements will change with category change. 11. Edit CAT1 and set minimum password length to 5 12. Go to patron1 details page, and change password. CHECH => Now password minimum length is 5, but still it doesn’t require strong password 13. Edit CAT1, leave blank minimum password length and set require strong password to yes. 14. Go to patron1 details page, and change password. CHECH => Password minimum length is back to 3, but now strong password is required 15. Set minimum password length in CAT2 to 12. 16. Go to patron2 details page, and click to fill a random generated password CHECK => generated password should be 12 characters length 17. Set PatronSelfRegistration to Allow in admin settings 18. Go to OPAC and fill self registration from. CHECK => Play with patron category. For each change in category, password requirements are modified. CHECK => Set CAT1 as patron category, set ‘aA1’ as password (or another valid password for CAT1) and before hitting submit button, change to CAT2. Form should enter invalid state, and CAT2 password requirements should be displayed as error in password input. 19. Create a patron for CAT1 and another for CAT2, leaving password blank CHECK => For CAT1’s patron, generated password length is 8 (minimum length for generated passwords), but for CAT2’s patron should be 12 20. In admin set PatronSelfRegistrationVerifyByEmail to require 21. Fill self registration form again with CAT2 as category CHECK => Password requirements works as previous case. 22. Leave password blank and click submit 23. select * from message_queue; 24. Copy the link in the message and paste it in OPAC CHECH => Generated password is 12 characters long. (Copy user id for next steps) 25. In admin set OpacResetPassword to Allow 26. Go back to OPAC, reload and click on “Forgot password?” link 27. Paste user id and click submit 28. Repeat steps 23 and 24 CHECK => Info message says “Your password must contain at least 12 characters, including UPPERCASE, lowercase and numbers.” CHECK => enter an invalid password and you’ll get the same message in warning. 29. Login OPAC with the last user and your newly created password 30. Go to “Change your password” option CHECK => Info message says “Your password must contain at least 12 characters, including UPPERCASE, lowercase and numbers.” CHECK => enter an invalid password and you’ll get the same message in below “New password” input. 31. prove t/db_dependent/AuthUtils.t t/db_dependent/Koha/Patron/Category.t 32. Sign off Sponsored-by: Northeast Kansas Library - NEKLS Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
David Cook	b4d8180d82	Bug 26285: Follow E.164 pattern for validating SMS numbers Currently, Koha is not correctly validating SMS numbers using E.164. This causes Australian phone numbers without a country code to fail validation. This patch uses the E.164 pattern of 1-3 digits for country code, prefixed by a + symbol, and followed by up to 12 digits for the remainder of the phone number. To test: 0. Don't apply patch yet 1. Set "SMSSendDriver" to "Anything" 2. Go to http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=51 3. Type in 0455555555 and note "Please enter a valid phone number." message in browser 6. Apply the patch 7. Go to http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=51 8. Type in 0455555555 and note no validation error 9. Type in +61455555555 and note no validation error 10. Type in 123456789012 and note no validation error 11. Type in 1234567890123 and note "Please enter a valid phone number." error 12. Type in +900123456789012 and note no validation error 13. Type in 900123456789012 and note "Please enter a valid phone number." error Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Marcel de Rooy	c95bb26327	Bug 26007: (QA follow-up) Remove message on marc_subfields_structure Why? Since the combo has been disabled since a few releases. If you want to change this mapping, you should do it on Koha to MARC mappings. This change is no longer per framework, but over all frameworks. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Marcel de Rooy	10d8f8ba93	Bug 26007: (QA follow-up) Add index name to the q parameter The link constructed in MARC-detail is not consistent. It adds an index name but does not show in the query in the search box. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Katrin Fischer	54941f8dc5	Bug 26007: Add/fix warning for changes to the Koha to MARC mappings There are 2 pages where one can change the Koha to MARC mappings in Koha: - When editing the configuration for a MARC subfield - On administration > Koha 2 MARC mappings This patch adds a warning that the batchRebuildBiblioTables script must be run if the mapping is changed. To test: - Go to Administration > MARC bibliographic frameworks > Any framework > MARC structure > Any field > Edit subfield - ÃThe hint about the batchRebuildBiblioTables will be on "Link" instead of "Koha Link". This is wrong as the link doesn't care about the mappings. - Go to Administration > Koha to MARC mappings - Verify there is no hint - Apply patch - Verify both pages now show an appropriate message Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> This commit message is not completely accurate. See the follow-ups. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Owen Leonard	bdb64657f9	Bug 16314: Show upload link for upload plugin in basic MARC editor This patch updates the basic MARC editor to provide a plugin name variable to the template, allowing us to make a check on the name and conditionally show an upload link if the "upload.pl" cataloging plugin is selected. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go do Administration -> MARC bibliographic framework -> MARC structure -> 856 -> Edit subfields. - Edit the "u" subfield and select "upload.pl" as the plugin under "Other options." - Go to Cataloging and create or edit a MARC record. - Under tab 8 look for the 856 tag, subfield u. There should be an "Upload" link corresponding to the form field. - Click the upload link to confirm that it triggers a popup window with the upload form. - Confirm that other similar plugin links (for instance 100$a, 600$a) display the old "tag editor" icon. Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Owen Leonard	9cb89b4639	Bug 20168: Update of the OPAC bootstrap template to bootstrap v4 This patch updates the version of Bootstrap in the OPAC from 2.3.1 to 4.5.0. The Bootstrap JavaScript files have been replaced with custom builds of the 4.5.0 JavaScript source files. The Bootstrap CSS is now built into the OPAC CSS by loading the required Bootstrap 4.5.0 SCSS files in node_modules. OPAC SCSS now starts with Bootstrap customizations: /* Bootstrap variable customizations / $headings-color: #727272; ... Followed by loading the necessary Bootstrap SCSS files: / Bootstrap imports */ @import "../../../../../node_modules/bootstrap/scss/functions"; @import "../../../../../node_modules/bootstrap/scss/variables"; ... Followed by our CSS. The build process for generating compiled CSS now creates a file which bundles Bootstrap CSS and ours. Removed from the Koha source: Bootstrap CSS files, Bootstrap "glyphicons" images. The upgrade to Bootstrap 4 involved a lot of markup changes to conform with new Bootstrap classes, especially in classes related to the grid. Besides duplicating the grid we used before, this upgrade adds some new features made possible by Bootstrap 4.5's use of flexbox as a layout tool. This includes custom ordering of columns based on class names: https://getbootstrap.com/docs/4.5/layout/grid/#order-classes. Other areas where the most changes have been made: Navigation menus, breadcrumb menus, buttons, dropdowns. Bootstrap's JavaScript file is now "bootstrap.bundle.min.js" to reflect the fact that a required JavaScript asset is now distributed separately in Bootstrap 4. The "bundle" version includes Popper.js. Unrelated changes: Indentation corrections, removal of invalid "//<![CDATA[" markers, removal of invalid script type attributes. To test, apply the patch and run 'yarn install' to install Bootstrap as an npm module. Run 'yarn build --view opac' to regenerate the OPAC CSS. Test as many aspect of the OPAC as possible, viewing pages at various browser widths to confirm that everything adjusts well. Test with various OPAC interface system preferences enabled and disabled. Test self checkout and self checkin. Known issues: RTL support has not been updated. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Kyle Hall	5d05feac31	Bug 23682: (QA follow-up) Fix typo in syspref description Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Kyle Hall	d8696702ce	Bug 23682: Add ability to manually import EDI invoices as an alternative to automatic importing on download Some library would like to delay the importing of invoices until a time of their choosing. The invoices should be imported into the database as they do now, but the invoice processing should be skipped. Instead, any invoice file with a status of 'new' should have an 'Import' button to process the invoice. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable the new syspref EdifactInvoiceImport 4) Run the edi cronjob to import a new invoice file 5) View EDI messages table at /acqui/edifactmsgs.pl 6) Note the invoice files is not processes, and retains the status of 'new' 7) Use the 'import' button to process the invoice 8) Note the invoice is now marked 'received' and the 'import' button is gone 9) Verify the invoice was actually processes Signed-off-by: Debi Stears <DDStears@washoecounty.us> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	5 years ago
Nick Clemens	72deefe8cf	Bug 24197: (QA follow-up) Shorten syspref name to AddressForFailedEmailNotices If you define the address we use it, if not we fallback, it's not really a redirect, and that just makes the name longer. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Martin Renvoize	cb272f01f4	Bug 24197: (QA follow-up) Embelished syspref description As requested, I have embelished the syspref description to more accurately depict the fallback sequence for email delivery. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Alex Buckley	bed91ac8f7	Bug 24197: Changed use of 'branch' terminology to 'library' Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Alex Buckley	b48cdd227f	Bug 24197: Added new local use syspref which sets the email address that failed overdue notices are set to. Test plan: 1. Set no email addresses in patron record then checkout items to the patron making the due date in the past 2. Visit patron's home library page: Administration > Libraries Set a branch email and in global system preferences observe there is no syspref named RedirectAddressForFailedOverdueNotices 3. Manually run overdue_notices.pl 4. Check the message_queue database table and observe there is a print overdue notice and a email notice with to_address of the branch email address 5. Apply patch 6. Run database update: cd installer/data/mysql sudo koha-shell <instance_name> ./updatedb.pl 7. Confirm there is a new system preference named: RedirectAddressForFailedOverdueNotices Give it a different email address to that in the branch email. 7. Repeat steps 1,3,4 and observe that the failed overdue notices have been sent to the email defined in RedirectAddressForFailedOverdueNotices Sponsored-By: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Nick Clemens	1733944b34	Bug 26236: Fix translating interface from DB term to readable term When viewing the logs we try to swith the db values like 'cron' to friendly terms like 'Cron job' The values we use for building the selectors on the page ar eupper case, but DB values are lower case If we simply force upper case in the comparison we can ensure we always match correctly To test: 1 - Enable some 'Logs' setting in System preferences 2 - Perform some action in koha that will log Run a cronjob Change a syspref etc. 3 - Browse to Tools-> Log viewer 4 - Click 'Submit' to see all logs 5 - Note the 'Interface' column contains lower case DB values 6 - Apply patch 7 - Reload the page 8 - Values in interface are now Camel cased and more friendly Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Tomás Cohen Arazi	8da73fe428	Bug 15851: (follow-up) Only display the analytics link when required (staff) This patch replicates the introduced behaviour, for the admin interface. To test, follow the test plan from the OPAC, but on the intranet. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Katrin Fischer	8a37842e1a	Bug 26313: (follow-up) Fix OPAC and "Show volumes" links Elasticsearch requires the booleans in search requests to be uppercase. This fixes the "Show analytics" link in OPAC (same as first patch for intranet) and the "Show volume" link. To test both patches: Set UseControlNumber = Use 1) "Show analytics" - Turn SearchEngine to Elasticsearch and make sure it works - Pick any serial record in your database, make sure 001 is set - Go to new > new child record - Fill in 245 and save - For both staff and OPAC: - Click on the "In" link, it should bring you to the parent record - Click on "Show analytics", it should show your analytical record - Switch to "Zebra" - verify links still work. 2) "Show volumes" - Turn SearchEngine to Elasticsearch again - Pick any serial record in your database, make sure 001 is set - Set LDR, pos. 19 = a - Set - Note 001 value - Find another record and edit it - Set LDR, pos. 19 = a or b, LDR 7 not a or b (m will work) - Set 773$ title of set record $w 001 of set record - For both staff and OPAC: - Click on the "In: link, it should bring up your set record - Click on the "Show volumes" link, it should bring up the volume - Switch to "Zebra" - verify all links still work. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Nick Clemens	fde7bf5495	Bug 26313: "Show analytics" link must use uppercase for booleans In elasticsearch we only treat AND and OR as boolean operators if they are capitalized To test: - Turn SearchEngine to Elasticsearch and make sure it works - Pick any serial record in your database, make sure 001 is set - Go to new > new child record - Fill in 245 and save - Click on the "In" link, it should bring you to the parent record - Click on "Show analytics" => there will be no result - Apply patch - restart and reload - Try again - It works! - Switch SearchEngine syspref to 'Zebra' - Test again - It still works! Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
David Cook	b729886216	Bug 26362: Show correct libraries in overdues report Currently the overdues report does the following display: Patron library = home branch Home library = holding branch Holding library = patron branch This patch corrects the display of libraries in the overdues report. To test: 0) Do not apply patch 1) Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 2) Go to http://localhost:8081/cgi-bin/koha/circ/set-library.pl 3) Choose "Troy" 4) http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 5) Checkout "39999000004571" with due date of "09/01/2019 23:59" Note the facts: Patron library = Centerville Home library = Fairview Holding library = Troy 6) Go to http://localhost:8081/cgi-bin/koha/circ/overdue.pl 7) Change "Columns" visibility to show Holding and Home libraries 8) Note that the libraries are incorrect: Patron library appears to be: Fairview Home library appears to be: Troy Holding library appears to be: Centerville 9) Apply the patch 10) koha-plack --restart kohadev 11) Go to http://localhost:8081/cgi-bin/koha/circ/overdue.pl 12) Change "Columns" visibility to show Holding and Home libraries 13) Note that the libraries are correct: Patron library appears to be: Centerville Home library appears to be: Fairview Holding library appears to be: Troy Signed-off-by: Emmi Takkinen <emmi.takkinen@outlook.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Martin Renvoize	087af360cc	Bug 23634: Prevent non-superlibrarians from editing superlibarian emails This patchset prevents a non-superlibrarian user from editing a superlibrarians email address via memberentry. This is to prevent a privilege escalation vulnerability whereby a user could update a superlibrarians contact details to match their own and then request a password reset via the OPAC. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	5 years ago
Joonas Kylmälä	5b845b9e8a	Bug 25101: (follow-up) Tick preview checkbox on by default This would prevent any unintended batch renewals as it is easy to miss the option in the screen. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Kyle Hall	c41597add3	Bug 25101: Add ability to skip previewing results when batch extending due dates For sites with very large amounts of due dates to extend ( tens of thousands ), it can take a very long time of the results to load ( if at all ). It would be good to have a way to bypass the confirmation screen, instead directly updating the due dates before displaying the results. Test Plan: 1) Apply this patch 2) Browse to tools/batch_extend_due_dates.pl 3) Note the new "Preview results" checkbox 4) Submit form with the checkbox unchecked, due dates should be updated without previewing the checkouts 5) Submit form with the checkbox checked, tool should function as it did previously Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Bug 25101: (QA follow-up) Add hint to new option Adds a hint about the large numbers behind the new checkbox option. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Bug 25101: (QA follow-up) Fix hint for new option Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Jonathan Druart	f1658744c6	Bug 21066: Rename publicationdate with published_on Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Marcel de Rooy	75bb7b5b2e	Bug 21066: Code changes needed for replacing opac_news.timestamp Test plan: Perform some CRUD operations on the news page in staff. Verify that news on opac and staff respect publicationdate. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	6 years ago
Tomás Cohen Arazi	2a0ccf7af2	Bug 25584: Fix minor styling issue This patch makes the button present some space between the icon and the text. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Tomás Cohen Arazi	7fc7427dd4	Bug 25584: Refresh checkouts table when a return claim is added This patch triggers a checkouts table refresh when a return claim is added. I also noticed the same when a return claim is deleted so it is now also refreshed. To test: 1. Set the ClaimReturnedLostValue to some valid value (2) 2. Check something out for a patron, and choose to display all checkouts => SUCCES: There's the checkouts table, showing the checkout 3. Click on the 'Claim returned' button and confirm => SUCCESS: There's no 'Claim returned' button anymore => ERROR: The checkout row doesn't display anything about the claim 4. Go to the 'Claims' tab, delete resolve and delete the claim 5. Go to the Checkouts tab => ERROR: It doesn't reflect the changes either 6. Apply this patch and start over => SUCCESS: Once the claim returned is added, the checkouts table is refreshed and the information updated => SUCCESS: On the Claims tab, if you delete the claim and go to the Checkouts tab, you are presented the button again. 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
David Nind	024bb186e6	Bug 25630: (follow-up) Fix capitalization and terminology for system preferences Additional capitalization, punctuation, terminolgy and improvements to text for system preferences: - Punctuation (such as full stops at the end of sentences) - Capitalization - Terminology (staff interface, use of "Don't" instead of "Do not") - Rearranged/rephrased for better readability To test: - Verify that the changes listed are consistent and make sense. - Check that on the staff interface home page that the window title says "Koha staff interface". - Verify that in system preferences the name of the tab for Staff interface displays correctly, and that clicking on it brings up the staff interface preferences. - For Patrons > CollapseFieldsPatronAddForm check that the edit and add patron form works correctly (edit a patron, add a new patron, check that labels display correctly). Staff interface home page ------------------------- - Change the page title in browser from "Koha staff client" to "Koha staff interface". Administration -------------- Google OpenID Connect: . GoogleOpenIDConnectAutoRegister: change "Don't Allow" to "Don't allow" and change "users" to "patrons". . GoogleOpenIDConnectDefaultBranch: move the input field to the end of the sentence. . GoogleOpenIDConnectDefaultCategory: move the input field to the end of the sentence. . GoogleOpenIDConnectDomain: reword to "Restrict Google OpenID Connect to domain (or subdomain of this domain): ____. Leave blank for all Google domains.". Interface options: . SendAllEmailsTo: add a full stop. Share anonymous usage statistics: . UsageStatsLibrariesInfo: change "Do not share" to "Don't share"; add a full stop; for note "Don't share" should be "No". . most preferences: for note "Don't share" should be "No" (don't share) (for preferences UsageStatsCountry, UsageStatsGeolocation, UsageStatsLibrariesInfo, UsageStatsLibraryName, UsageStatsLibraryType, and UsageStatsLibraryUrl), various edits to make more readable and consistent. Authorities ----------- General . AuthorityControlledIndicators: change "biblio field" to "bibliographic field". . AutoCreateAuthorities: change "do not generate" to "don't generate". Linker: . CatalogModuleRelink: change "Do not" to "Don't". . LinkerKeepStale: change "Do not" to "Don't". . LinkerModule: change "Default" to "default". . LinkerOptions: add a full stop. . LinkerRelink: change "Do not" to "Don't". Cataloguing ----------- Display: . MergeReportFields: change "example:" to "Example:" Exporting: . BibtexExportAdditionalFields and RisExportAdditionalFields: change "Include following" to "Include the following"; add ":" at end of sentence, change "specificy" to "specify", and add full stops at end of complete sentences. Interface: . EnableAdvancedCatalogingEditor: format NOTE in bold. Record structure: . AlternateHoldingsField: change "(This" to "(this", change "; for instance" to ", for example", remove full stop. , MarcFieldForCreatorId: format NOTE in bold. . SubfieldsToAllowForRestrictedBatchmod: change "pref" to "system preference". Circulation ----------- Batch checkout: . BatchCheckoutsValidCategories: add a full stop. Checkin policy: . CalculateFinesOnReturn: only bold "NOTE", not the whole sentence (x2). . StoreLastBorrower: change "opacreadinghistory/AnonymousPatron" to "the opacreadinghistory and AnonymousPatron". . UpdateItemLocationOnCheckin: change note "for these locations only can location and permanent_location differ," to "for these locations the location and permanent_location can differ," . UpdateNotForLoanStatusOnCheckin: change "E.g.," to "For example," Checkout policy: . AgeRestrictionMarker: change "E.g.," to ". For example," . AllFinesNeedOverride: change "system preference noissuescharge" to "the noissuescharge system preference". . AllowFineOverride: add "the" before "noissuescharge". . AllowRenewalLimitOverride: change "with respect to" to "for". . AutoRemoveOverduesRestrictions: change "Do not" to "Don't". . DefaultLongOverdueChargeValue: change "user" to "patron". . ItemsDeniedRenewal: change . "e.g.," to "For example:", format the note the same as other notes with NOTE in bold. . OnSiteCheckoutsForce: change "on-site" to "on-site checkout", "(Even" to "(even", and "user" to "patron". . RentalFeesCheckoutConfirmation: change "do not ask" to "don't ask". . RestrictionBlockRenewing: change "If patron" to "If a patron", change "Allow" and "Block" to "allow" and "block". . UseTransportCostMatrix: "Transport" to "the transport". Interface: . AllowOfflineCirculation: change "Do not enable" to "Don't enable". . ExportRemoveFields: add a full stop. . ShowAllCheckins: change "Do not show" to "Don't show". . UpdateTotalIssuesOnCirc: change "Do not" to "Don't". Interlibrary loans: . CirculateILL: add a full stop. . ILLCheckAvailability: add a full stop. Self check-in module (sci-main.pl): . SelfCheckInModule: change "module. (available" to "module (available", add a full stop. Self check-out module (sco-main.pl): . AutoSelfCheckAllowed: change "automatically login" to "automatically log in". . WebBasedSelfCheck: change "system. (available" to "system (available", add a full stop. Enhanced content ---------------- Novelist Select: . NovelistSelectStaffView: change "staff" to "staff interface". Babelthèque: . Babeltheque_url_js: rewitten . from "______ Defined the URL for the Babeltheque javascript file (eg. http://www.babeltheque.com/bw_XX.js)" . to "Use this URL for the Babelthèque javascript file: ________ (e.g. http://www.babeltheque.com/bw_XX.js)." . Babeltheque_url_update: rewritten . from "______ Defined the URL for the Babeltheque update periodically (eq. http://www.babeltheque.com/.../file.csv.bz2)." . to "Use this URL for the Babelthèque periodic update: _______ (e.g. http://www.babeltheque.com/.../file.csv.bz2)." I18N/L10N --------- . dateformat and TimeFormat: Change "Note" to "NOTE" to be consistent with other notes, change <b> tag to <strong> as it is more semantically correct. Logs ---- Debugging: . DumpTemplateVarsIntranet: change "variable" to "variables" and "staff intranet" to "staff interface". . DumpTemplateVarsOpac: change "variable" to "variables". Logging: . AuthFailureLog: add full stop. . AuthSuccessLog: add full stop. OPAC ---- Appearance: . BiblioDefaultView: change "bib" to "bibliographic". . HighlightOwnItemsOnOPAC: change ". (Non-XSLT Only)" to " (non-XSLT only).". . OpacAdditionalStylesheet: change "specified" to "specific". . OPACDisplay856uAsImage: change all options in the drop down list so they start in lowercase. . OpacHighlightedWords: change ";" to a full stop, add a full stop at the end. . OPACHoldingsDefaultSortField: add a full stop. . OpacMaxItemsToDisplay: change "user" to "patron". . OPACMySummaryHTML: change "user" to "patron". . OpacSeparateHoldings: change "user's to "patron's". . OpacStarRatings: change "user" to "patron" for the drop down option. . OPACShowUnusedAuthorities: change "Do not show" to "Don't show". . OPACUserSummary: change "user's to "patron's", change "fines" to "charges". . OPACXSLT*: change "Leave" to "leave". . Remove empty row at bottom of appearance options. Features: . OpacBrowser: change "OPAC" to "the OPAC". . OpacBrowseSearch: reword as "[Enable/Disable] interface for browsing all holdings (Elasticsearch only)." . OpacCloud: change "OPAC" to "the OPAC". . OPACDetailQRCode: change "Don't enable" to "Disable". . OPACFinesTab: change "Fines" to "charges", change "the My Accouunt" to "their account". (Should now show as "..patrons to access the charges tab on their account page on the OPAC." . OpacHoldNotes: change "Do not allow" to "Don't allow", change "users" to "patrons". . OpacResetPassword: change "users" to "patrons", add full stop. . SocialNetworks: change "in opac" to "on the OPAC". Note: Also deleted lines with # in front of them for the OpacBrowser and OpacCloud system preferences in the Policy section - these look like duplicated entries to me (previously lines 600-611). Policy: . OPACFineNoRenewalsIncludeCredits: change "users" to "patrons". Self registration and modification: . PatronSelfRegistrationConfirmEmail: change "Do not require" to "Don't require", change "users" to "patrons". . PatronSelfRegistrationEmailMustBeUnique: change "Do not consider" to "Don't consider". . PatronSelfRegistrationPrefillForm: change "Do not display and prefill" to "Don't display and prefill". Patrons ------- General: . AllowPatronToControlAutorenewal: add full stop. Notices and notifications: . EnhancedMessagingPreferences: change "Staff" to "staff". - FallbackToSMSIfNoEmail: change "Send" to "sending". Patron forms: . BorrowerUnwantedField: add full stop. . CollapseFieldsPatronAddForm: . Dropdown list changes: .. "Organization/Patron identity" => "Patron identity". .. "OPAC/Staff login" to "OPAC/Staff interface login". . Requires changes to the memberentrygen.tt - check that the add and edit form for a patron dispaly correctly: .. change "Contact" to "Contact information". .. change "Library set-up" to "Library setup". .. change "OPAC/Staff login" to "OPAC/Staff interface login". Patron relationships: . PrefillGuaranteeField: change drop down list option "Main address - street number" to "Main address - Street number" to match with format of other entries. Security: . RequireStrongPassword: change "More" to "more". Searching --------- Search form: . AdvancedSearchTypes: change "staff-side" to "staff interface". . expandedSearchOption: change "staff" to "staff interface". Serials ------- . makePreviousSerialAvailable: change "Do not make" to Don't make"; "syspref" to "system preference". . PreserveSerialNotes: change "Do not" to "Don't". . RoutingListNote: change "Include following" to "Include the following" Staff interface --------------- Tab label and link: . This tab was previously labelled "Staff client". . Change tab label on the left hand side from "Staff client" to "Staff interface". . Change URL when selected from "preferences.pl?tab=staff_client" to "preferences.pl?tab=staff_interface". . Check that the link works as expected. Appearance: . IntranetFavicon: change "Staff" to "staff". Tools ----- Reports: . NumSavedReports: change "Saved reports page" to "saved reports page". Web services ------------ IdRef: . IdRef: change "allows to request" to "allows requests for". Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Katrin Fischer	17a2d57794	Bug 25630: Fix capitalization and terminology for Accounting, Administration and Serials system preferences - Punctuation (p) - Terminology - Capitalization (c) To test: - Verify: - AccountAutoReconcile (Do not to Don't for consistency with other prefs) - IndependentBranchesPatronModifications (p) - IndependentBranchesTransfers (p) - GoogleOpenIDConnect (google to Google) - UsageStatsLibrariesInfo (c) - opacSerialDefaultTab (c) - StaffSerialIssueDisplayCount (staff interface) - SubscriptionDuplicateDroppedInput (c) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Katrin Fischer	c3033ae17c	Bug 25630: Fix capitalization and terminology for Authorities and Cataloging system preferences - Punctuation (p) - Terminology - Capitalization (c) To test: - Verify: - AuthDisplayHierarchy (biblio to bibliographic) - MARCAuthorityControlField008 (p) - UNIMARCAuthorityField100 (p) - LinkerModule (c) - LinkerOptions (p) - SpineLabelShowPrintOnBibDetails (bib to bibliographic) - DefaultLanguageField008 (p) - DefaultCountryField008 (p) - SubfieldsToAllowForRestricted* (p, rephrase) - URLLinkText (added 'and items' - new with 20.05) - IntranetBiblioDefaultView (c) - MergeReportFields (rephrase) - BibtexExportAdditionalFields (marc to MARC) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Katrin Fischer	60f215b3b8	Bug 25630: Fix capitalization and terminology for Circulation system preferences - (Ending) punctuation (p) - Terminology - Capitalization (c) To test: - Verify: - CircSidebar (c) - itemBarcodeInputFilter (from to form) - HoldsToPullStartDate (preference to system preference) - NoticeCSS (c) - UpdateTotalIssuesOnCirc (issues to checkouts) - ExportRemovefields (p) - AllowItemsOnHoldCheckoutSIP (c) - OnSiteCheckoutAutoCheck (onsite to on-site) - AllowOfflineCirculation (plugin to add-on) - AllowFineOverride (add 'system preference') - AutomaticItemReturn (returned to checked in) - UseTransportCostMatrix (branches to libraries) - AllowReturnToBranch (materials to items, return to checkin) - RenewalSendNotice (clarify 'messaging preference for 'Item checkout') - TransfersMaxDaysWarning (c) - noissuescharge (books to items) - NoissuesCharge (add 'system preference') - ReturnBeforeExpiry (books to items) - NoticeBcc (p) - OverdueNoticeCalendar (c, p) - OverduesBlockCirc (p) - DefaultLongOverdueChargeValue (whitespace after :) - OPACFineNoRenewalsBlockAutoRenew (c) - RenewAccruingItemWhenPaid (p, c, syspref to system preference) - RenewAccruingItemInOpac (p, c, syspref to system preference) - HoldsSplitQueue (staff interface) - StaffSearchResultsDisplayBranch (staff interface, rephrase) - HidePersonalPatronDetailOnCirculation (rephrase) - StoreLastBorrower (add 'system preferences') - HoldsSplitQueue (& to and, staff interface) - HouseboundModule (p) - StockRotation (p) - ArticleRequests (p) - ClaimReturnedLostValue (rephrase) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Katrin Fischer	5e6f889063	Bug 25630: Fix capitalization and terminology for Logs and I18N system preferences - (Ending) punctuation (p) - Capitalization (p) - Terminology To test: - Verify: - alphabet (p) - TranslateNotics (c) - IllLog (p) - ReturnLog (returned to checked in) - DumpTemplateVars* (HTML) - read correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Katrin Fischer	cd4d732296	Bug 25630: Fix capitalization and terminology for OPAC system preferences - Ending punctuation (p) - Capitalization (c) - Terminology: library instead of branch, patron instead of borrower, system preferences instead of syspref To test: - Verify: - OPACUserSummary (p, rephrase: mainpage) - HighlightOwnItemsOnOPACWhich (library) - OPACXSLTListsDisplay (p) - OPACXSLTResultsDisplay (p) - OPACXSLTDetailsDisplay (p) - OpacNoItemTypeImages (p) - NotHighlightedWords (p) - opaclayoutstylesheet (CSS) - OPACReportProblem (c) - OpacBrowser (p) - OpacCloud (p) - SocialNetworks (p) - QuoteOfTheDay (c,p) - OpacNewsLibrarySelect (library) - OPACFineNoRenewalsIncludeCredits (p) - AllowPurchaseSuggestionBranchChoice (p) - OpacHiddenItemsExceptions (p, patron) - OpacAllowPublicListCreation (p) - OpacAllowSharingPrivateLists (p) - BlockExpiredPatronOpacActions (whitespace) - MaxOpenSuggestions (p) - AnonSuggestions (p) - OPACPrivacy (p, whitespace) - AnonymousPatron (c,p) - TrackClicks (p) - RestrictedPageLocalIPs (p) - RestrictedPageTitle (p) - OpacAdvSearchOptions (p) - OpacAdvSearchMoreOptions (p) - PayPal* (p) - OPACUserSummary (mainpage to OPAC start page) - read correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Katrin Fischer	0c30554759	Bug 25630: Fix capitalization and terminology for Patrons system preferences - Consistent use of 'staff interface' - Ending punctuation - Rearranged/rephrased for better readability To test: - Verify: - patronimages - PatronsPerPage (rearranged) - PatronQuickAddFields (rearranged) - PrefillGuaranteeField (punctuation) - borrowerRelationship (punctuation) - GDPR_Policy - CollapseFieldsPatronAddForm - read correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Katrin Fischer	10c2eb01c9	Bug 25630: Fix capitalization and terminology for Enhanced content and Web services system preferences - Fixes capitalization, including URL and OPAC - Consistent use of "staff interface" - Ending punctuation - Spelling: web service To test: - Verify: - Enhanced content page heading - Babeltheque_url_js - Babeltheque_url_update - FRBRizeEditions - BakerTaylorEnabled - NovelistSelectStaffProfile - NovelistSelectStaffEnabled - CustomCoverImages - LocalCoverImages - IntranetCoce - AutoShareWithMana - OAI-PMH:AutoUpdateSets - IdRef - read correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Katrin Fischer	9475a7db68	Bug 25630: Fix capitalization and terminology for Acquisitions and Tools system preferences - Adds some ending punctuation - Fixes capitalization - Consistent use of "staff interface" To test: - Verify: - NewsAuthorDisplay - EmailPurchaseSuggestions - UseACQFrameworkForBiblioRecords - AcqItemSetSubfieldsWhenReceived - AcqItemSetSubfieldsWhenReceiptIsCancelled - OrderPriceRounding - read correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Katrin Fischer	db47dbe56a	Bug 25630: Fix capitalization and terminology fixes for Searching system preferences - Rephrases LoadSearchHistoryToTheFirstLoggedUser system preference - Consistently use "staff interface" - Add ending punctuation to some preferences To test: - Read through the Searching system preferences - Verify consistent use of staff interface - Verify LoadSearchHistoryToTheFirstLoggedUser description is improved Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Katrin Fischer	b56ad54f49	Bug 25630: Fix capitalization and terminology for Staff interface system preferences This changes "staff client" to "staff interface" and fixes capitalization in a couple of cases. For terminology changes see: https://wiki.koha-community.org/wiki/Terminology#S To test: - Read through the preferences of the "staff interface" tab. - Staff interface should be used consistently. - Firefox "PlugIn" was changed to "add-on" reflecting Mozilla's own terminology. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Jonathan Druart	d6e72c0de2	Bug 19889: Add select2 class to the new dropdown list This is needed since bug 25727. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Agustin Moyano	2793e45580	Bug 19889: (follow-up) Fix text in moredetail.tt Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Nick Clemens	fee0b9310e	Bug 19889: (QA follow-up) use em over i and update field if unset em is better for accessibility We should set the field to 0 when it was previously unset Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago

1 2 3 4 5 ...

13661 Commits (3b273de5777ac7dd5bebac629dc8c88e6bdc962a)