Tree:
3b273de577
16.05.x
16.11.x
17.05.x
17.11.x
18.05.x
18.11.x
19.05.x
19.11.x
20.05.x
20.11.x
21.05.x
21.11.x
22.05.x
22.11.x
23.05.x
23.11.x
3.0.x
3.10.x
3.12.x
3.14.x
3.16.x
3.18.x
3.2.x
3.20.x
3.22.x
3.4.x
3.6.x
3.6.x-maint/testing
3.6.x-rmaint/testing
3.8.x
MM-OPAC/theme_dep
main
new/bootstrap-opac
new_12478_elasticsearch
3.0.5_rc1
3.02.02
R_1-1-1RC1
R_1-2-1
R_1-2-1RC6
R_1-2-2
R_1-2-2RC4
R_1-2-3
R_1-2-3RC11
R_1-2-3RC12
R_1-2-3RC13
R_1-2-3RC14
R_1-2-3RC15
R_1-2-3RC16
R_1-2-3RC17
R_1-2-3RC18
R_1-2-3RC20
R_1-2-3RC21
R_1-2-3RC22
R_1-2-3RC23
R_1-2-3RC25
R_1-2-3RC26
R_1-2-3RC5
R_1-3-0
R_1-3-1
R_1-3-2
R_1-3-3
R_1-9-0
R_1-9-1
R_1-9-2
R_1-9-3
R_2-0-0
R_2-0-0RC1
R_2-0-0RC2
R_2-0-0RC3
R_2-0-0RC4
R_2-0-0pre1
R_2-0-0pre2
R_2-0-0pre3
R_2-0-0pre4
R_2-0-0pre5
R_2-1
R_2-2-6
R_2-2-6RC2
R_2-2-6RC3
R_2-2-6RC4
R_2-2-7
R_2-2-9
R_2-3-0
R_2-4
R_2_2_4
R_2_2_5
R_2_2_6_RC
dev_week
html_template_pro
rel_3_0_5
v16.05.00
v16.05.00-beta
v16.05.01
v16.05.02
v16.05.02-01
v16.05.03
v16.05.04
v16.05.05
v16.05.05-01
v16.05.06
v16.05.06-01
v16.05.07
v16.05.08
v16.05.09
v16.05.10
v16.05.11
v16.05.12
v16.05.13
v16.05.14
v16.05.15
v16.05.16
v16.05.17
v16.05.18
v16.05.19
v16.11.00
v16.11.01
v16.11.02
v16.11.03
v16.11.04
v16.11.05
v16.11.06
v16.11.07
v16.11.08
v16.11.09
v16.11.10
v16.11.11
v16.11.11-1
v16.11.12
v16.11.13
v16.11.14
v16.11.15
v16.11.16
v17.05.00
v17.05.01
v17.05.02
v17.05.03
v17.05.04
v17.05.05
v17.05.06
v17.05.07
v17.05.08
v17.05.09
v17.05.10
v17.05.11
v17.05.12
v17.05.13
v17.05.14
v17.11.00
v17.11.01
v17.11.02
v17.11.03
v17.11.04
v17.11.05
v17.11.06
v17.11.07
v17.11.08
v17.11.09
v17.11.10
v17.11.11
v17.11.12
v17.11.13
v17.11.14
v17.11.15
v17.11.16
v17.11.17
v17.11.18
v18.05.00
v18.05.00-rc1
v18.05.00-rc2
v18.05.01
v18.05.02
v18.05.03
v18.05.04
v18.05.05
v18.05.06
v18.05.07
v18.05.08
v18.05.09
v18.05.10
v18.05.11
v18.05.12
v18.05.13
v18.05.14
v18.11.00
v18.11.01
v18.11.02
v18.11.03
v18.11.04
v18.11.05
v18.11.06
v18.11.07
v18.11.08
v18.11.09
v18.11.10
v18.11.11
v18.11.12
v18.11.13
v18.11.14
v18.11.15
v18.11.16
v19.05.00
v19.05.01
v19.05.02
v19.05.03
v19.05.04
v19.05.05
v19.05.05-1
v19.05.06
v19.05.07
v19.05.08
v19.05.09
v19.05.10
v19.05.11
v19.05.12
v19.05.13
v19.05.14
v19.05.15
v19.05.16
v19.05.17
v19.11.00
v19.11.01
v19.11.02
v19.11.03
v19.11.04
v19.11.05
v19.11.06
v19.11.07
v19.11.08
v19.11.09
v19.11.10
v19.11.11
v19.11.12
v19.11.13
v19.11.14
v19.11.15
v19.11.16
v19.11.17
v19.11.18
v19.11.18-2
v19.11.19
v19.11.20
v19.11.21
v19.11.22
v19.11.23
v19.11.24
v19.11.25
v19.11.26
v19.11.27
v19.11.28
v19.11.29
v20.05.00
v20.05.01
v20.05.02
v20.05.03
v20.05.04
v20.05.05
v20.05.06
v20.05.07
v20.05.08
v20.05.09
v20.05.10
v20.05.11
v20.05.12
v20.05.13
v20.05.14
v20.05.15
v20.05.16
v20.05.17
v20.05.18
v20.11.00
v20.11.01
v20.11.02
v20.11.03
v20.11.04
v20.11.05
v20.11.06
v20.11.07
v20.11.08
v20.11.09
v20.11.10
v20.11.11
v20.11.12
v20.11.13
v20.11.15
v20.11.16
v20.11.17
v20.11.18
v20.11.19
v21.05.00
v21.05.01
v21.05.02
v21.05.03
v21.05.04
v21.05.05
v21.05.06
v21.05.07
v21.05.08
v21.05.09
v21.05.10
v21.05.11
v21.05.12
v21.05.13
v21.05.14
v21.05.15
v21.05.16
v21.05.17
v21.05.18
v21.05.19
v21.05.20
v21.05.21
v21.05.22
v21.05.22-1
v21.05.22-2
v21.11.00
v21.11.01
v21.11.02
v21.11.03
v21.11.04
v21.11.04-1
v21.11.05
v21.11.06
v21.11.07
v21.11.08
v21.11.09
v21.11.10
v21.11.11
v21.11.12
v21.11.13
v21.11.14
v21.11.15
v21.11.16
v21.11.17
v21.11.18
v21.11.19
v21.11.20
v21.11.21
v21.11.21-1
v21.11.22
v21.11.23
v21.11.24
v21.11.25
v21.11.26
v22.05.00
v22.05.01
v22.05.02
v22.05.03
v22.05.03-1
v22.05.04
v22.05.05
v22.05.05-01
v22.05.06
v22.05.07
v22.05.08
v22.05.09
v22.05.10
v22.05.11
v22.05.12
v22.05.13
v22.05.14
v22.05.15
v22.05.16
v22.05.17
v22.05.18
v22.05.19
v22.05.20
v22.05.20-2
v22.05.21
v22.11.00
v22.11.01
v22.11.02
v22.11.03
v22.11.04
v22.11.05
v22.11.05-1
v22.11.06
v22.11.07
v22.11.08
v22.11.09
v22.11.10
v22.11.11
v22.11.12
v22.11.13
v22.11.14
v22.11.15
v22.11.15-1
v22.11.16
v22.11.16-1
v22.11.17
v23.05.00
v23.05.01
v23.05.02
v23.05.03
v23.05.04
v23.05.05
v23.05.06
v23.05.07
v23.05.08
v23.05.09
v23.05.09-01
v23.05.10
v23.05.10-02
v23.05.11
v23.11.00
v23.11.01
v23.11.02
v23.11.03
v23.11.04
v23.11.04-4
v23.11.05
v3.0.6
v3.00.00
v3.00.00-alpha
v3.00.00-beta
v3.00.00-beta2
v3.00.00-stableRC1
v3.00.01-stable
v3.00.01-stable_update
v3.00.01.005
v3.00.02-final
v3.00.02-stable
v3.00.03
v3.00.04
v3.00.04_final
v3.00.04_fixed
v3.00.05
v3.00.06
v3.02.00
v3.02.00-alpha
v3.02.00-alpha2
v3.02.00-beta
v3.02.00-rc
v3.02.01
v3.02.03
v3.02.04
v3.02.05
v3.02.06
v3.02.07
v3.02.08
v3.02.09
v3.02.10
v3.02.11
v3.04.00
v3.04.01
v3.04.02
v3.04.03
v3.04.04
v3.04.05
v3.04.06
v3.04.07
v3.04.08
v3.06.00
v3.06.01
v3.06.02
v3.06.03
v3.06.04
v3.06.05
v3.06.06
v3.06.07
v3.06.08
v3.06.09
v3.06.10
v3.06.10.000
v3.06.11
v3.06.12.000
v3.08.00
v3.08.01
v3.08.02
v3.08.03
v3.08.04
v3.08.05
v3.08.06
v3.08.07
v3.08.08
v3.08.09
v3.08.10
v3.08.11
v3.08.12
v3.08.13
v3.08.14
v3.08.15
v3.08.16
v3.08.17
v3.08.18
v3.08.19
v3.08.20
v3.08.21
v3.08.22
v3.08.23
v3.08.24
v3.10.00
v3.10.01
v3.10.02
v3.10.03
v3.10.04
v3.10.05
v3.10.06
v3.10.07
v3.10.08
v3.10.09
v3.10.10
v3.10.11
v3.10.12
v3.10.13
v3.12.00
v3.12.00-alpha
v3.12.00-alpha2
v3.12.00-beta1
v3.12.00-beta3
v3.12.00-rc1
v3.12.00-rc2
v3.12.00-rc3
v3.12.01
v3.12.02
v3.12.03
v3.12.04
v3.12.05
v3.12.06
v3.12.07
v3.12.08
v3.12.09
v3.12.10
v3.12.11
v3.12.12
v3.12.13
v3.12.14
v3.12.15
v3.14.00
v3.14.00-alpha1
v3.14.00-alpha2
v3.14.00-beta
v3.14.01
v3.14.02
v3.14.03
v3.14.04
v3.14.05
v3.14.06
v3.14.07
v3.14.08
v3.14.09
v3.14.10
v3.14.11
v3.14.12
v3.14.13
v3.14.14
v3.14.15
v3.14.16
v3.14.17
v3.16.00
v3.16.00-beta
v3.16.00-pkg
v3.16.00-rc
v3.16.01
v3.16.02
v3.16.03
v3.16.04
v3.16.05
v3.16.05.1
v3.16.06
v3.16.07
v3.16.08
v3.16.09
v3.16.10
v3.16.11
v3.16.12
v3.16.13
v3.16.14
v3.16.15
v3.18.00
v3.18.00-beta
v3.18.01
v3.18.02
v3.18.03
v3.18.04
v3.18.05
v3.18.05.1
v3.18.06
v3.18.06-3
v3.18.07
v3.18.08
v3.18.09
v3.18.10
v3.18.11
v3.18.12
v3.18.13
v3.20.00
v3.20.00-beta
v3.20.01
v3.20.02
v3.20.03
v3.20.04
v3.20.05
v3.20.06
v3.20.07
v3.20.07.1
v3.20.08
v3.20.09
v3.20.10
v3.20.11
v3.20.12
v3.20.13
v3.20.14
v3.20.15
v3.22.00
v3.22.00-beta
v3.22.01
v3.22.02
v3.22.03
v3.22.04
v3.22.05
v3.22.06
v3.22.07
v3.22.08
v3.22.09
v3.22.10
v3.22.11
v3.22.12
v3.22.13
v3.22.14
v3.22.15
v3.22.16
v3.22.17
v3.22.18
v3.22.19
v3.22.20
v3.22.21
v3.8.16
version-1-2-0
version-1-2-1
${ noResults }
1227 Commits (3b273de5777ac7dd5bebac629dc8c88e6bdc962a)
Author | SHA1 | Message | Date |
---|---|---|---|
Lucas Gass | 3b273de577 |
Bug 25744: replace <b> with <strong> in the staff interface
This patch set attempts to replace all the <i> tags with <em> and all the <b> tags with <strong> in the staff interface. I attempted to get all the templates, includes, and xslt files. To test: 1. Review the changes as best as possible, looking for mistakes. 2. grep for <i> and <b> in the modules, includes, and xslt folders. You should get nothing/ 3. If you grep '<\/i>' you should only see instances of Font Awesome. 4. If you grep '<\/b>' you should only see instances where caret is used. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Lucas Gass | a02bd4f71c |
Bug 25744: Replace <i> with <em> in staff interface
Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Martin Renvoize | 89716a78e9 |
Bug 26269: Fix variable name mismatch for cash_register in paycollect
It appears that through various rebases the variable names in the form and the controller script have become mismatched. This patch corrects the situation and clarifies their intended use. Test plan: 1/ Turn on cash registers in sysprefs 2/ Define at least 2 cash registers in Admin 3/ Create a manual invoice on a patron 4/ Pay off half of your fee, selecting the first register 5/ Pay off the remaining fee, selecting the second register 6/ Query accountlines.register_id for your two payments 8/ Confirm the two accountlines.register_id's do not match (thus the passed variable was used) https://bugs.koha-community.org/show_bug.cgi?id=26469 Signed-off-by: Jessie Zairo <jzairo@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Agustin Moyano | 5848da810e |
Bug 23816: Add minimum password length and require strong password overrides by category
This patch adds the capability to override minPasswordLenth and RequireStrongPassword settings by category To test: 1. koha-shell kohadev 2. koha-mysql kohadev 3. drop database koha_kohadev; 4. create database koha_kohadev; 5. go to admin page and start webinstaller. There continue the steps until onboarding. 6. reach step 3 of onboarding and create a new administrator patron CHECH => Password control woks as normal (Minimum length 3 and strong required) 7. finish Koha installation and enter admin with your new administrator 8. set minPasswordLength to 3 and RequireStrongPassword to “Don’t require” 9. Create a new category (CAT2 from now on.. CAT1 is the category you made in onboarding process) and set minimum password length to 8 and require strong password 10. Create two new patrons, one with CAT1(patron1) and one with CAT2 (patron2) CHECK => In both cases, try different combinations of length and strength. For patron1 the only requirement is to have 3 letters, but for patron2 the minimum length will be 8 and will require strong password. CHECK => Try changing patron category before saving. Password requirements will change with category change. 11. Edit CAT1 and set minimum password length to 5 12. Go to patron1 details page, and change password. CHECH => Now password minimum length is 5, but still it doesn’t require strong password 13. Edit CAT1, leave blank minimum password length and set require strong password to yes. 14. Go to patron1 details page, and change password. CHECH => Password minimum length is back to 3, but now strong password is required 15. Set minimum password length in CAT2 to 12. 16. Go to patron2 details page, and click to fill a random generated password CHECK => generated password should be 12 characters length 17. Set PatronSelfRegistration to Allow in admin settings 18. Go to OPAC and fill self registration from. CHECK => Play with patron category. For each change in category, password requirements are modified. CHECK => Set CAT1 as patron category, set ‘aA1’ as password (or another valid password for CAT1) and before hitting submit button, change to CAT2. Form should enter invalid state, and CAT2 password requirements should be displayed as error in password input. 19. Create a patron for CAT1 and another for CAT2, leaving password blank CHECK => For CAT1’s patron, generated password length is 8 (minimum length for generated passwords), but for CAT2’s patron should be 12 20. In admin set PatronSelfRegistrationVerifyByEmail to require 21. Fill self registration form again with CAT2 as category CHECK => Password requirements works as previous case. 22. Leave password blank and click submit 23. select * from message_queue; 24. Copy the link in the message and paste it in OPAC CHECH => Generated password is 12 characters long. (Copy user id for next steps) 25. In admin set OpacResetPassword to Allow 26. Go back to OPAC, reload and click on “Forgot password?” link 27. Paste user id and click submit 28. Repeat steps 23 and 24 CHECK => Info message says “Your password must contain at least 12 characters, including UPPERCASE, lowercase and numbers.” CHECK => enter an invalid password and you’ll get the same message in warning. 29. Login OPAC with the last user and your newly created password 30. Go to “Change your password” option CHECK => Info message says “Your password must contain at least 12 characters, including UPPERCASE, lowercase and numbers.” CHECK => enter an invalid password and you’ll get the same message in below “New password” input. 31. prove t/db_dependent/AuthUtils.t t/db_dependent/Koha/Patron/Category.t 32. Sign off Sponsored-by: Northeast Kansas Library - NEKLS Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Martin Renvoize | 087af360cc |
Bug 23634: Prevent non-superlibrarians from editing superlibarian emails
This patchset prevents a non-superlibrarian user from editing a superlibrarians email address via memberentry. This is to prevent a privilege escalation vulnerability whereby a user could update a superlibrarians contact details to match their own and then request a password reset via the OPAC. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
5 years ago |
David Nind | 024bb186e6 |
Bug 25630: (follow-up) Fix capitalization and terminology for system preferences
Additional capitalization, punctuation, terminolgy and improvements to text for system preferences: - Punctuation (such as full stops at the end of sentences) - Capitalization - Terminology (staff interface, use of "Don't" instead of "Do not") - Rearranged/rephrased for better readability To test: - Verify that the changes listed are consistent and make sense. - Check that on the staff interface home page that the window title says "Koha staff interface". - Verify that in system preferences the name of the tab for Staff interface displays correctly, and that clicking on it brings up the staff interface preferences. - For Patrons > CollapseFieldsPatronAddForm check that the edit and add patron form works correctly (edit a patron, add a new patron, check that labels display correctly). Staff interface home page ------------------------- - Change the page title in browser from "Koha staff client" to "Koha staff interface". Administration -------------- Google OpenID Connect: . GoogleOpenIDConnectAutoRegister: change "Don't Allow" to "Don't allow" and change "users" to "patrons". . GoogleOpenIDConnectDefaultBranch: move the input field to the end of the sentence. . GoogleOpenIDConnectDefaultCategory: move the input field to the end of the sentence. . GoogleOpenIDConnectDomain: reword to "Restrict Google OpenID Connect to domain (or subdomain of this domain): ____. Leave blank for all Google domains.". Interface options: . SendAllEmailsTo: add a full stop. Share anonymous usage statistics: . UsageStatsLibrariesInfo: change "Do not share" to "Don't share"; add a full stop; for note "Don't share" should be "No". . most preferences: for note "Don't share" should be "No" (don't share) (for preferences UsageStatsCountry, UsageStatsGeolocation, UsageStatsLibrariesInfo, UsageStatsLibraryName, UsageStatsLibraryType, and UsageStatsLibraryUrl), various edits to make more readable and consistent. Authorities ----------- General . AuthorityControlledIndicators: change "biblio field" to "bibliographic field". . AutoCreateAuthorities: change "do not generate" to "don't generate". Linker: . CatalogModuleRelink: change "Do not" to "Don't". . LinkerKeepStale: change "Do not" to "Don't". . LinkerModule: change "Default" to "default". . LinkerOptions: add a full stop. . LinkerRelink: change "Do not" to "Don't". Cataloguing ----------- Display: . MergeReportFields: change "example:" to "Example:" Exporting: . BibtexExportAdditionalFields and RisExportAdditionalFields: change "Include following" to "Include the following"; add ":" at end of sentence, change "specificy" to "specify", and add full stops at end of complete sentences. Interface: . EnableAdvancedCatalogingEditor: format NOTE in bold. Record structure: . AlternateHoldingsField: change "(This" to "(this", change "; for instance" to ", for example", remove full stop. , MarcFieldForCreatorId: format NOTE in bold. . SubfieldsToAllowForRestrictedBatchmod: change "pref" to "system preference". Circulation ----------- Batch checkout: . BatchCheckoutsValidCategories: add a full stop. Checkin policy: . CalculateFinesOnReturn: only bold "NOTE", not the whole sentence (x2). . StoreLastBorrower: change "opacreadinghistory/AnonymousPatron" to "the opacreadinghistory and AnonymousPatron". . UpdateItemLocationOnCheckin: change note "for these locations only can location and permanent_location differ," to "for these locations the location and permanent_location can differ," . UpdateNotForLoanStatusOnCheckin: change "E.g.," to "For example," Checkout policy: . AgeRestrictionMarker: change "E.g.," to ". For example," . AllFinesNeedOverride: change "system preference noissuescharge" to "the noissuescharge system preference". . AllowFineOverride: add "the" before "noissuescharge". . AllowRenewalLimitOverride: change "with respect to" to "for". . AutoRemoveOverduesRestrictions: change "Do not" to "Don't". . DefaultLongOverdueChargeValue: change "user" to "patron". . ItemsDeniedRenewal: change . "e.g.," to "For example:", format the note the same as other notes with NOTE in bold. . OnSiteCheckoutsForce: change "on-site" to "on-site checkout", "(Even" to "(even", and "user" to "patron". . RentalFeesCheckoutConfirmation: change "do not ask" to "don't ask". . RestrictionBlockRenewing: change "If patron" to "If a patron", change "Allow" and "Block" to "allow" and "block". . UseTransportCostMatrix: "Transport" to "the transport". Interface: . AllowOfflineCirculation: change "Do not enable" to "Don't enable". . ExportRemoveFields: add a full stop. . ShowAllCheckins: change "Do not show" to "Don't show". . UpdateTotalIssuesOnCirc: change "Do not" to "Don't". Interlibrary loans: . CirculateILL: add a full stop. . ILLCheckAvailability: add a full stop. Self check-in module (sci-main.pl): . SelfCheckInModule: change "module. (available" to "module (available", add a full stop. Self check-out module (sco-main.pl): . AutoSelfCheckAllowed: change "automatically login" to "automatically log in". . WebBasedSelfCheck: change "system. (available" to "system (available", add a full stop. Enhanced content ---------------- Novelist Select: . NovelistSelectStaffView: change "staff" to "staff interface". Babelthèque: . Babeltheque_url_js: rewitten . from "______ Defined the URL for the Babeltheque javascript file (eg. http://www.babeltheque.com/bw_XX.js)" . to "Use this URL for the Babelthèque javascript file: ________ (e.g. http://www.babeltheque.com/bw_XX.js)." . Babeltheque_url_update: rewritten . from "______ Defined the URL for the Babeltheque update periodically (eq. http://www.babeltheque.com/.../file.csv.bz2)." . to "Use this URL for the Babelthèque periodic update: _______ (e.g. http://www.babeltheque.com/.../file.csv.bz2)." I18N/L10N --------- . dateformat and TimeFormat: Change "Note" to "NOTE" to be consistent with other notes, change <b> tag to <strong> as it is more semantically correct. Logs ---- Debugging: . DumpTemplateVarsIntranet: change "variable" to "variables" and "staff intranet" to "staff interface". . DumpTemplateVarsOpac: change "variable" to "variables". Logging: . AuthFailureLog: add full stop. . AuthSuccessLog: add full stop. OPAC ---- Appearance: . BiblioDefaultView: change "bib" to "bibliographic". . HighlightOwnItemsOnOPAC: change ". (Non-XSLT Only)" to " (non-XSLT only).". . OpacAdditionalStylesheet: change "specified" to "specific". . OPACDisplay856uAsImage: change all options in the drop down list so they start in lowercase. . OpacHighlightedWords: change ";" to a full stop, add a full stop at the end. . OPACHoldingsDefaultSortField: add a full stop. . OpacMaxItemsToDisplay: change "user" to "patron". . OPACMySummaryHTML: change "user" to "patron". . OpacSeparateHoldings: change "user's to "patron's". . OpacStarRatings: change "user" to "patron" for the drop down option. . OPACShowUnusedAuthorities: change "Do not show" to "Don't show". . OPACUserSummary: change "user's to "patron's", change "fines" to "charges". . OPACXSLT*: change "Leave" to "leave". . Remove empty row at bottom of appearance options. Features: . OpacBrowser: change "OPAC" to "the OPAC". . OpacBrowseSearch: reword as "[Enable/Disable] interface for browsing all holdings (Elasticsearch only)." . OpacCloud: change "OPAC" to "the OPAC". . OPACDetailQRCode: change "Don't enable" to "Disable". . OPACFinesTab: change "Fines" to "charges", change "the My Accouunt" to "their account". (Should now show as "..patrons to access the charges tab on their account page on the OPAC." . OpacHoldNotes: change "Do not allow" to "Don't allow", change "users" to "patrons". . OpacResetPassword: change "users" to "patrons", add full stop. . SocialNetworks: change "in opac" to "on the OPAC". Note: Also deleted lines with # in front of them for the OpacBrowser and OpacCloud system preferences in the Policy section - these look like duplicated entries to me (previously lines 600-611). Policy: . OPACFineNoRenewalsIncludeCredits: change "users" to "patrons". Self registration and modification: . PatronSelfRegistrationConfirmEmail: change "Do not require" to "Don't require", change "users" to "patrons". . PatronSelfRegistrationEmailMustBeUnique: change "Do not consider" to "Don't consider". . PatronSelfRegistrationPrefillForm: change "Do not display and prefill" to "Don't display and prefill". Patrons ------- General: . AllowPatronToControlAutorenewal: add full stop. Notices and notifications: . EnhancedMessagingPreferences: change "Staff" to "staff". - FallbackToSMSIfNoEmail: change "Send" to "sending". Patron forms: . BorrowerUnwantedField: add full stop. . CollapseFieldsPatronAddForm: . Dropdown list changes: .. "Organization/Patron identity" => "Patron identity". .. "OPAC/Staff login" to "OPAC/Staff interface login". . Requires changes to the memberentrygen.tt - check that the add and edit form for a patron dispaly correctly: .. change "Contact" to "Contact information". .. change "Library set-up" to "Library setup". .. change "OPAC/Staff login" to "OPAC/Staff interface login". Patron relationships: . PrefillGuaranteeField: change drop down list option "Main address - street number" to "Main address - Street number" to match with format of other entries. Security: . RequireStrongPassword: change "More" to "more". Searching --------- Search form: . AdvancedSearchTypes: change "staff-side" to "staff interface". . expandedSearchOption: change "staff" to "staff interface". Serials ------- . makePreviousSerialAvailable: change "Do not make" to Don't make"; "syspref" to "system preference". . PreserveSerialNotes: change "Do not" to "Don't". . RoutingListNote: change "Include following" to "Include the following" Staff interface --------------- Tab label and link: . This tab was previously labelled "Staff client". . Change tab label on the left hand side from "Staff client" to "Staff interface". . Change URL when selected from "preferences.pl?tab=staff_client" to "preferences.pl?tab=staff_interface". . Check that the link works as expected. Appearance: . IntranetFavicon: change "Staff" to "staff". Tools ----- Reports: . NumSavedReports: change "Saved reports page" to "saved reports page". Web services ------------ IdRef: . IdRef: change "allows to request" to "allows requests for". Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Katrin Fischer | 9ea7907618 |
Bug 26281: (QA follow-up) Fix missing filter
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Kyle Hall | 5c161c145b |
Bug 26281: Add cancellation reason to holds history
Bug 25534 adds the ability to store the cancellation reason when a hold is cancelled and communicate it to the user. It would be great if the cancellation reason could also be shown on the holds history. Test Plan: 1) Apply this patch 2) Cancel a hold with a reason 4) Browse to holds history for the holds' patron 5) Note the reason shows in the status column if one was provided Working ok. Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Kyle Hall | 563328d3cc |
Bug 25534: (QA follow-up) Add label to reason pulldown
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Kyle Hall | af0d71b747 |
Bug 25534: Add ability to send an email specifying a reason when canceling a hold
Some libraries would like to be able to cancel a hold with the option to specify a reason. Providing a reason would generate an email to that patron. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Create new AV category "HOLD_CANCELLATION", add some cancelation reasons 5) Add new Holds module notice "HOLD_CANCELLATION", add an email version. A quick test version would be "Reason: <<reserves.cancellation_reason>>" -- [% USE AuthorisedValues %] Reason: [% AuthorisedValues.GetByCode( 'CANCELLATION_REASON', hold.cancellation_reason, 'IS_OPAC' ) %] [% IF hold.cancellation_reason == "MY_AV_VALUE" %] IF perhaps you'd like to have a much longer explanation than just the one sentence in the AV description, you can use IF blocks using Template Toolkit markup! [% END %] -- 6) Place a hold for a patron 7) On request.pl, select the 'del' option for the hold 8) Select a cancellation reason and choose "Update hold(s)" 9) Note a new message has been queue for the patron with the cancelation reason 11) Test again from circulation.pl 12) Test again from moremember.pl 10) Cancel a hold with no reason, note no email is generated 11) Delete your authorised values, not the feature is disabled 12) Reinstate the authorised values, but delete the notice, you should now be able to cancel a hold with a reason, but no email will be generated Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Martin Renvoize | 480aca366d |
Bug 19036: (QA follow-up) Fix 'out-by-one' error on table
This patch fixes the total row where the column count was out by one. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Julian Maurice | 9205d4ef45 |
Bug 19036: Add ability to auto generate a number for account credits
In some areas it's required to sequentially number payment slips / receipts. This patch adds a database column accountlines.credit_number and a system preference AutoCreditNumber to control how this number will be generated. The following options are available: - Do not automatically generate credit numbers. This is the current behaviour and the default syspref value. - Automatically generate credit numbers in the form <year>-0001 (annual) - Automatically generate credit numbers in the form <branchcode>yyyymm0001 (branchyyyymmincr) where <branchcode> is the branch where the user (staff member) is logged in - Automatically generate credit numbers in the form 1, 2, 3 (incremental) It also adds a column (hidden by default) in the table under Transactions tab to display this number. Test plan: 0. Apply patch, run updatedatabase and update_dbix_class_files 1. Go to Admin » Column settings, and uncheck the 'hidden' box for column credit_number in table account-fines. It will be easier for testing 2. Create a manual credit for a borrower. Verify in Transactions tab that this credit has no number generated 3. Change syspref 'AutoCreditNumber' to 'incremental' 4. Create more manual credits, and verify that the numbers generated are 1, 2, 3, ... 5. Change syspref 'AutoCreditNumber' to 'annual' 6. Create more manual credits, and verify that the numbers generated are '2020-0001', '2020-0002', ... 7. Change syspref to 'AutoCreditNumber' to 'branchyyyymmincr' 8. Create more manual credits, and verify that the numbers generated are 'BRANCHA2020020001', 'BRANCHA2020020002', ... (assuming you are connected to library BRANCHA, and it's February 2020) 9. Set library to another one, say BRANCHB 10. Create more manual credits, and verify that the numbers generated are 'BRANCHB2020020001', 'BRANCHB2020020002', ... 11. Edit the letter ACCOUNT_CREDIT, and add [% account.credit_number %] somewhere. Go back to Transactions tab and click on 'Print' for one line that has a credit number. Make sure the number is there. 12. prove t/db_dependent/Koha/Account.t Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Jonathan Druart | b05448311f |
Bug 25430: Use label-default for 0
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Kyle Hall | 52f91af5bc |
Bug 25430: Improve the styling of the claims returned tab
It has been suggested that it would be useful to add title attributes to the different numbers on the return claims tab in the checkouts and patron details pages. In addition, color coding them ( and removing the slash ) will make the numbers easier to read. Test Plan: 1) Set up return claims for your system 2) Apply this patch 3) View the claims tab for someone with not claims, and someone with claims 4) Note the resolved claims are green and have a "tooltip" when hovered over 5) Note the unresolved claims are green if 0, and yellow if not 0, and also have a "tooltip" Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Jonathan Druart | d3f3a55e0b |
Bug 26234: Teach our KohaTable constructor the specific th classes
We have different classes we can use to set specific behaviours on table columns: title-string, string-sort, anti-the and NoSort. We should not need to pass them to the DataTable constructor, we could teach it that we always want to apply them. It will avoid bug like bug 26233 The goal is to define them in a centralised place (columns_settings.inc) then only use the class on the th Test plan: Different behaviour and tables must be tested to confirm it works correctly. Focus must be put on table when aoColumnsDefs is passed from the template and confirm that this will add more info to aoColumnsDefs and not remove the existing ones. Note that this only work when KohaTable is used. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Martin Renvoize | b036710fea |
Bug 22393: (QA follow-up) Typos and Filters
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Martin Renvoize | 484061a44e |
Bug 22393: (follow-up) Corrections for QA feedback
We correct the behviour of 'amount' being passed back to the template and add a work around for the existance of deleted_items alongside a FK to items in the accountlines table. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Martin Renvoize | 0d19d9fa44 |
Bug 22393: Remove last remaining use of C4::Accounts::manualinvoice
This patch re-arranges the manualinvoice controller script to clarify code flow, replaces the last call to C4::Accounts::manualinvoice with a call to Koha::Accounts->add_debit wrapped in a try catch block and also adds a check on passed barcodes when the invoice type is 'LOST' so it can link the subsequently created accountline to the item and issue. Test plan 1/ Add a manual invoice (without entering a barcode) 2/ Add a manual invoice with a valid barcode (Not a LOST type) 3/ Add a manual invoice with a valid, but old, barcode (Not a LOST type) 4/ Add a manual invoice with an invalid barcode, note that an error is displayed 5/ Add a manual invoice with type 'LOST' and a valid barcode for a checkout your user has had checked out 6/ Add a manual invoice with type 'LOST' and a valid barcode, but not one that will match a checkout for your user. Note an error is displayed 7/ When errors are displayed, note the form contains data from the previous submission so you can just correct the error rather than re-enter all data. 8/ Signoff Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Katrin Fischer | 274075a63f |
Bug 25364: Undo change to 'None specified'
As this has been a little controversial, this patch undoes the change to "None specified / Prefer not to say" to be "None specified" again as before this patch set. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
David Roberts | 66e70c9201 |
Bug 25364: Add "Other" to the gender options in a patron record
This patch adds "Other" as an option, and also changes the wording of "None specified" slightly. To test: 1) Apply the patch 2) Check that there is an "Other" radio button in the patron record, and that the wording of "None specified" has changed to "None specified / Prefer not to say". 3) Check that you can save changes to the gender of this patron record, both on create and modify. 4) Check that these changes also work in the Opac Self-Registration functionality. Correct typos in previous commit Signed-off-by: Devinim <kohadevinim@devinim.com.tr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Owen Leonard | f661ecd50f |
Bug 25654: Make the contact and non-patron guarantor sections separate on patron entry form
This patch reverses what I think was an unintended change made by Bug 14570 in which the non-patron guarantor fields are shown for all patron types (not just child patrons) and grouped with the patron contact fields. This patch creates a new "Non-patron guarantor" fieldset to show along with "Patron guarantor" when adding or editing child patrons. To test, apply the patch check that the BorrowerUnwantedField system preference does not contain contactname, contactfirstname, or relationship. - Open an adult patron for editing. You should see no guarantor-related fields. - Open a child patron for editing. There should be two guarantor sections: "Patron guarantor" and "Non-patron guarantor." - Test that adding patron guarantors and non-patron guarantors works correctly. - Add "contactname|contactfirstname|relationship" to the BorrowerUnwantedField system preference. - Reload the child patron entry form. The non-patron guarantor section should now be hidden. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Owen Leonard | 95551b569f |
Bug 26194: Add link to cash register management from message about missing registers
In places where the interface warns the user about missing cash registers we should provide users with permission a direct link to the cash register management page. To test, apply the patch and enable the UseCashRegisters and EnablePointOfSale preferences. If necessary, go to Administration -> Cash registers and remove any cash registers for your library. - Log in to the staff interface as a user with "manage_cash_registers" permission. - Locate a patron who has outstanding fines. - Under Accounting -> Make a payment, click the "Pay" button next to a fine. - The page should show the message about missing cash registers with a button which take you directly to the "Add new cash register" form. - Perform the same check by selecting the checkbox next to a fine and clicking the "Pay amount" button and the "Pay selected" button. - Test the message shown at: - Tools -> Cashup registers. - Point of sale -> Register details - Point of sale -> Library details - Perform the same tests when logged in as a user without permission to manage cash registers. The messages shown in the previous steps should omit the button linking to cash register management. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Owen Leonard | 75e25c9d38 |
Bug 21345: Patron records with attached files not obvious from patron details view
This patch adds a section to the patron details page for listing files which have been attached to the patron record. To test, apply the patch and enable the EnableBorrowerFiles system preference. - If necessary, attach some files to a patron record by viewing a patron record and choosing "Files" from the sidebar menu. - View the detail page (moremember.pl) for a patron who has files attached. - You should see a new section under "Alternative contact" with the heading "Files." - Test the "Manage" button to make sure it takes you to that patron's files. - Confirm that all the attached files are listed. - Confirm that the links to each file work correctly. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> JD amended patch: replace a html filter with uri Bug 21345: (follow-up) Hide files information if EnableBorrowerFiles is disabled This patch wraps the new patron file information in a check for the EnableBorrowerFiles system preference. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Owen Leonard | 4de06b1711 |
Bug 25879: (follow-up) Update overlooked guarantor markup
This patch updates another section of guarantor markup which should have been updated with the others. To test, apply the patch and locate an adult patron. - Click "Add guarantee" - Confirm that the part of the form for adding a guarantee looks correct. - Confirm that the new patron information is saved correctly. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Owen Leonard | ec630b4b6c |
Bug 25879: Improve display of guarantor information in the patron entry form
This patch makes some changes to the patron entry template to improve the display of guarantor information. To test, apply the patch and locate a patron with a "Child" type category. - Edit the patron's record - Under "Guarantor information," click the "Search to add" button. - Search for and select a patron. - The guarantor information should be added to the patron edit form. The information should be correct and well formatted. - Click the "Remove" link. The guarantor information should be removed. - Search for an select a guarantor again and save the record. - Edit the patron record again. The saved guarantor information should look correct. Looks great! Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
David Roberts | 3abc4fb858 |
Bug 25336: Show checkouts/fines to guarantor is in the wrong section of the patron file
This patch moves the "Show checkouts to guarantor" and "Show fines to guarantor" data to display under the Contact information block To test: 1) Enable the AllowStaffToSetCheckoutsVisibilityForGuarantor and AllowStaffToSetFinesVisibilityForGuarantor system preferences to Allow 2) View a patron record. 3) The "Show checkouts to guarantor" and "Show fines to guarantor" field will be on the right hand side of the screen under the Library use block. 4) Apply patch 5) Check that this data has now moved to the Contact information block on the left hand side of the patron record. Works for me! Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Julian Maurice | f8bc001496 |
Bug 24610: Let user switch between 'Pay' and 'Write off' mode
In patron's accounting section, under 'Make a payment' tab, you have the choice between 'Pay' and 'Write off'. It takes you to another form, but once there you cannot change mode. You have to click on Cancel, re-select the lines you had selected (if you made a selection) and click on the right button. This patch adds link above the form to easily switch between the two modes. Also fixes a CSS bug to be able to use Bootstrap's nav pills inside .statictabs Test plan: 1. Create some manual invoices 2. Go to 'Make a payment' tab 3. Click on the 'Pay' button in a table row 4. Above the form you should see two links ('Pay' and 'Write off'). Click on 'Write off', confirm the write off and verify that it did make a 'write off'. 5. Go to 'Make a payment' tab 6. Click on the 'Write off' button in a table row 7. Click 'Pay', confirm the pay and verify that it did make a 'pay' 8. Go to 'Make a payment' tab 9. Select some lines and click on 'Pay selected' 10. Click on 'Write off', confirm the 'write off' and verify that it did make a 'write off' 11. Go to 'Make a payment' tab 12. Select some lines and click on 'Write off selected' 13. Click on 'Pay', confirm the pay and verify that it did make a 'pay' Signed-off-by: Christofer <christofer.zorn@ajaxlibrary.ca> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Jonathan Druart | 07d00ee029 |
Bug 22087: Move the email into the list
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Jonathan Druart | 89551241db |
Bug 22087: Prevent variable names colision
We should not use PROCESS: http://www.template-toolkit.org/docs/manual/Directives.html " The PROCESS directive is slightly faster than INCLUDE because it avoids the need to localise (i.e. copy) the variable stash before processing the template. " The 'patron' variable is reused by patron-title.inc Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Jonathan Druart | 77058c7d6b |
Bug 22087: Add a no_line_break parameter to prevent new lines
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Jonathan Druart | 33f4bc949e |
Bug 22087: Use include file to display patrons address in search result
In order to display the city and country in the patron search result, we need to use the member-display-address-style include file, to satisfy AddressFormat. Test plan: Modify some patrons and fill the different address info Search for them and notice that the city, zipcode and country are now displayed. Modify the value of AddressFormat and confirm that the display is modified according to its value Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Jonathan Druart | 810972db7a |
Bug 22844: Make the attribute mandatory when editing a patron
Note: I am not confident with this patch, I think it's not polished. I will not have time to improve it to make it ready for 19.05.00 1. Conflict with bug 20443 (which would have make this change way much easier!) 2. It does not work :) You will be able to submit the memberentry form even if the patron attribute is marked as mandatory (??) 3. What about the OPAC? 4. What about repeatable fields? We certainly will need JS code here 5. What about the "Quick add" feature? (I had trouble in the past to not introduce regression when we played with this template...) Do not forget to run updatedatabase.pl and regenerate DBIC schema if you want to play with this patchset. Signed-off-by: David Nind <david@davidnind.com> Bug 22844: (follow-up) Make the attribute mandatory when editing a patron Previous patch forgot the most important, adding the required attribute to the select/textarea Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
5 years ago |
Josef Moravec | 2cc3d05d26 |
Bug 15400: Display date of birth and age more consistantly
Test plan: 0) Apply the patch 1) Go to all of these pages Patron detail Other patron pages - look on the left side (circ-menu) Patron search Guarantor search ( go to child patron -> edit -> in guarantor section click "Set to patron" Search through "Check out" (in the header) 2) Confirm that does show date of birth and date consistantly, try it on patrons with and without date of birth set to find possible reggressions Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
6 years ago |
Petro Vashchuk | 029f41a667 |
Bug 25322: fix for not selected "relationship" defaults to father
When a user creates a patron's guarantor on /cgi-bin/koha/members/memberentry.pl but doesn't select the relationship from a dropdown, the relationship defaults to first value, which in default sysprefs is "father". This may or may not be correct as this is not a conscious choice from the user. The solution is to make the "Relationship" field mandatory when there is no empty entry in the system preferences, always starting with an empty option but not allowing the user to save an empty entry. And if there is an empty option in sysprefs, it allows to save empty, as well as makes it default choice. To reproduce with default system preferences: 1) Create a new patron who is assumed to have a guarantor or modify the existing one. 2) Under "Guarantor Information" click on "Search to add" button. After performing the search, select a user to act as guarantor. Don't use the dropdown menu to select a relationship. Save your changes. 3) Observe that relationship is set as "father". 4) Apply the patch. 5) Repeat steps 1 and 2. 6) Observe that it doesn't allow you to save the form until you pick a relationship type. To reproduce with empty entry added to system preferences: 1) Add an empty entry to borrowerRelationship at /cgi-bin/koha/admin/preferences.pl?tab=patrons in Patron relationships section (example: "|father|mother"). 2) Create a new patron who is assumed to have a guarantor or modify the existing one. 3) Under "Guarantor Information" click on "Search to add" button. After performing the search, select a user to act as guarantor. Don't use the dropdown menu to select a relationship. Save your changes. 4) Observe that relationship is set as "father". 5) Apply the patch. 6) Repeat steps 1, 2 and 3. 7) Observe when you save the empty entry it does set the relationship as empty. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Jonathan Druart | de54267510 |
Bug 24156: move ColumnsSettings to TablesSettings
We are preparing the ground with this patch. As the "Columns settings" page will now add the ability to modify settings for the whole table, it makes sense to rename the file and the variables. Note that the controller script (admin/columns_settings.pl) and the yml (admin/columns_settings.yml) files have not been moved to not break shortcuts and abits people could have. But if QA decides, it could be easy to do. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
5 years ago |
Katrin Fischer | 21cde7bd2f |
Bug 10910: (follow-up) Move the suggestions note with the other non-blocking notes
To test: - Add a credit to the patron's account - Make sure they got a pending suggestion - Try to delete - Verify you notes for both as list items Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Jonathan Druart | 85c1537bd7 |
Bug 10910: Add a warning when deleting a patron with pending suggestions
Test plan: From the OPAC, add a suggestion From the staff interface, try to delete the patron who created the suggestion => You get a warning message Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
5 years ago |
Jonathan Druart | 4a4d3ef0d8 |
Bug 25070: Centralize member-main-address-style
Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Jonathan Druart | ac973d2d44 |
Bug 25070: Centralize member-display-alt-address-style
Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Jonathan Druart | c32d71978c |
Bug 25070: Centralize member-display-address-style
Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Jonathan Druart | cfd97049a3 |
Bug 25070: Centralize member-alt-contact-style
Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Jonathan Druart | fdca61a745 |
Bug 25070: Centralize member-alt-address-style
There are 5 includes files per value of AddressFormat (us, de, fr). The code is duplicated for each language, the only thing that changes is the order. Wwith this patchset we are going to refactore them to avoid further regressions. The idea is to remove all code that is duplicated and remove the need of having 5*3 files. We are going to limit them to 5 files, 1 per use. Note that we could go even further, for instance member-display-alt-address-style and member-display-address-style are quite identical. Test plan (for the whole patchset): - Create a patron with all the address, contact and alternate info filled - Edit them and save - Look at the patron's info (top left) in the patron module, and the patron detail view. - Play with the different values of AddressFormat The order and the info must be displayed identically before and after this patchset. No change is expected. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Jonathan Druart |
635242a69a
|
Bug 25452: Restore alternate address email display
Broken since
commit
|
4 years ago |
David Roberts |
3f546c031a
|
Bug 25188: Make circulation notes more prominent on the patron details tab
This patch adds a more prominent circulation note to the moremember.pl details screen. To test: 1) Add a circulation note to a patron record. 2) Note that it displays prominently on the checkout tab, but only under the Library Use block on the details tab. 3) Apply the patch. 4) Check that the note is now displayed prominently at the top of the details (moremember.pl) screen. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> |
4 years ago |
Petro Vashchuk |
c79108e495
|
Bug 25301: removed useless URI parameter "categorycode" from template
Both "Edit details" links were sending empty query parameter "categorycode" as there is no such template parameter in "moremember.pl" defined at all, because template code block looks copy-pasted from "circulation.tt". This patch removes the parameter from "moremember.tt" template. To test: 1) You need to create or find expired or expiring patron. 2) Head to patron details page of that patron. 3) Inspect both "Edit details" links: one in the notification about expiration and other one in the "Expiration date:" field. 4) Observe empty parameter "categorycode=" in those links. 5) Apply patch. 6) Repeat step 3. 7) Check that there's no "categorycode=" in the links anymore. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> |
4 years ago |
Owen Leonard |
d6ca541b55
|
Bug 24963: Terminology: Use "auto-renewal" instead of alternatives
This patch updates terminology in the templates so that "auto-renewal" is used instead of "auto renewal" or "autorenewal." To test, apply the patch and set the 'AllowPatronToControlAutorenewal' preference to "allow patrons." - Log in to the OPAC and view the "your account" page. - At the top of the "Checked out" tab you should see controls for turning auto-renewals on and off. The labels should be correct. - Turn off auto-renewals for this patron. - In the staff interface, view the detail page for the patron you updated in the previous step. - In right-hand column of information about the patron you should see "Auto-renewal: Patron has opted out." - Add "&print=brief" to the page URL. Check that auto-renewal information displays correctly on this brief view as well. - Go to Administration -> System preferences. - Under the "Circulation" tab, check that the description of the OPACFineNoRenewalsBlockAutoRenew preference refers to "auto-renewal." - Under the "Patrons" tab, check the description of the AllowPatronToControlAutorenewal refers to "auto-renewal." Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> |
4 years ago |
Katrin Fischer |
ef55bc44fd
|
Bug 24098: Standardize Fines/Fees & Charges
This patch suggests to adopt the terminology used in the OPAC to only use charges and leave off the Fines or Fees. To test: - Add a charge to your account - Check the note on the details and checkouts tabs - Check the tab name on the details tab - Activate batch checkouts via systempreferences for your patron category: - BatchCheckouts - BatchCheckoutsValidCategories - Add a guarantee to your patron and allow to see fines (requires: AllowStaffToSetFinesVisibilityForGuarantor) - Add a manual fine for the guaranee above NoIssuesChargeGuarantee - Go to the batch checkout tab of your patron and verify note there Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> |
4 years ago |
Katrin Fischer |
0963451d65
|
Bug 24995: (QA follow-up) Terminology: Use checkin and checkout
... instead of issue and return. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> |
4 years ago |
Lucas Gass |
aca15e6253
|
Bug 24995: Add issuedate to table_account_fines and finest
TO TEST: 1. Have a patron with some fines on an item. Try accruing fines. 2. Go to the accounting tab and look at both the Tranaction tab and Make a payment Tab 3. No Issue Date 4. Apply patch 5. Check those tabs again and see the issue date displays. 6. Go to column configuration and try to hide the issuedate, make sure it hides properly. Try this for both tables. Also make sure other columns hide properly. 7. Sign off! Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> |
4 years ago |
Katrin Fischer |
d2c01b2458
|
Bug 25311: (QA follow-up) Add misssing filter
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> |
4 years ago |