Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Julian Maurice	96cc447045	Bug 25898: Prohibit indirect object notation Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Jonathan Druart	638786e719	Bug 24663: Remove authnotrequired if set to 0 It defaults to 0 in get_template_and_user Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Jenny Way	cad2db6016	Bug 20017: use Modern::Perl in Tools perl scripts Test plan: Check that the following files don't contain use strict; use warnings; and have use Modern::Perl instead. background-job-progress.pl batchMod.pl copy-holidays.pl exceptionHolidays.pl holidays.pl import_borrowers.pl koha-news.pl letter.pl manage-marc-import.pl newHolidays.pl overduerules.pl quotes-upload.pl quotes.pl quotes/quotes-upload_ajax.pl quotes/quotes_ajax.pl scheduler.pl stage-marc-import.pl upload-cover-image.pl Also the credits have been added to newHolidays.pl Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	6 years ago
Jonathan Druart	c133bedf54	Bug 16154: Fix some other occurrences Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>	8 years ago
Marc Véron	5dceb851dd	Bug 13813: Remove deprecated module C4::Dates from system Test plan: See Bugzilla. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>	9 years ago
Jonathan Druart	a6c9bd0eb5	Bug 9978: Replace license header with the correct license (GPLv3+) Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> http://bugs.koha-community.org/show_bug.cgi?id=9987 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	9 years ago
Jonathan Druart	e20270fec4	Bug 11944: use CGI( -utf8 ) everywhere Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Marcel de Rooy	e949eba409	Bug 12031: [QA Follow-up] Undefined routine and change to koha-conf.xml [1] Routine add_cron_job was added in 2007 but has not been defined. Parameter Recurring is not used. [2] Made some changes to koha-conf.xml. Instead of an example to edit, I replaced it by the SCRIPT_NONDEV_DIR install variable. [3] SCRIPT_NONDEV_DIR had to be included in rewrite-config.pl and the path had to be corrected for dev installs in Makefile.PL Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested single and dev install for supportdir change. Compared installations with and without the patches for this report. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Liz Rea	f918d29e38	Bug 12031: Task Scheduler not sending mail At some stage the runreport.pl cronjob was changed to accept longopts, but the scheduler script wasn't changed along with it. This patch fixes the mismatch. To test: 1. make sure that your user is not in at.deny, and (if applicable/necessary) is in at.allow 1.5 test this on a package install, sending mails will still not work for git installs, even with this patch. Useful, but not required step: make sure email can be sent from your server, also helpful is access to the Koha user's mail box (to see the bounce messages) 2. create a saved sql report to run 3. Go to Tools -> Task Scheduler and schedule a job to be run, and results emailed to you 4. note that you do not (without the patch) get an email. Make a note of the command it reports it is going to run. 5. apply the patch 6. schedule another job, you will notice that the command to run the scheduled job is slightly changed compared to the one in step 4. 7. Receiving an email when your job runs means the patch worked. Seeing --format= and --to= in the command also means the patch worked, as this is the command that runreport.pl is expecting. 8. Run the koha QA test tool. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: The line that changes is visible in the bottom section, "Jobs already entered", with the corrected parameters and path used. If you do not have the <supportdir> config parameter set up in koha-conf.xml, it defaults to the typical package path. If you have the parameter set up, the path given matches what you tell it. Only tested in git. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Tomás Cohen Arazi	afd2418d73	Bug 11349: Change .tmpl -> .tt in scripts using templates Since we switched to Template Toolkit we don't need to stick with the sufix we used for HTML::Template::Pro. This patch changes the occurences of '.tmpl' in favour of '.tt'. To test: - Apply the patch - Install koha, and verify that every page can be accesed Regards To+ P.S. a followup will remove the glue code. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Jonathan Druart	a469663d7b	Bug 9108: Followup: send the dateformat value from C4::Auth - the dateformat value is send to all templates (from C4::Auth::get_template_and_user) - remove all assignment of dateformat in all .pl files - the DHTMLcalendar_dateformat variable is unused Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixed conflicts: - opac/sco/sco-main.pl - reports/acquisitions_stats.pl - tools/cleanborrowers.pl All tests pass, perlcritic problems appeared in some files before and after these patches were applied. Checked sorting in following pages: - acqui/addorderiso2709.tt - list of staged imports in acq - acqui/histsearch.tt - sorting of dates in acq search result list - acqui/invoices.tt - billing date in list of invoices in acq - acqui/lateorders.tt - list of late orders in acq - acqui/ordered.tt - ordered titles and estimated costs for a fund - acqui/parcels.tt - receive shipment page - acqui/spent.tt - received titles and actual costs for a fund ... - serials-search.tt - subscription search result list ... - opac/sco/sco-main.tt - due dates in list of checked out items - reports/acquisitions-stats.tt - date searches, display of dates - tools/cleanborrowers.tt - tools.holidays.tt - different views of dates library is closed, adding dates Checked dates display according to system preference everywhere and searching, entering dates etc. still worked as expected. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Donovan Jones	44201a54e1	Bug 2505 - Add commented use warnings where missing in the tools/ directory	14 years ago
Lars Wirzenius	49e0a8fc78	Fix FSF address in directory tools/ Signed-off-by: Galen Charlton <gmcharlt@gmail.com>	14 years ago
Matthias Meusburger	ee0b0fca49	MT 2068 : Fixed scheduling guided reports	15 years ago
Jesse Weaver	b8d8a0ec5a	fix for bug 2543: report output by tabulation a bit too literal This repurposes the Reports module for general reports, and moves its functionality to a different module, Reports::Guided. It also updates all of the reports that can export to correctly treat the 'tabulation' value of the 'delimiter' syspref. Signed-off-by: Galen Charlton <galen.charlton@liblime.com>	16 years ago
DeAndre Carroll	e3e84a747f	Bug#: 1989 Changed date popups in scheduler.tmpl to a date picker element Made corresponding changes to scheduler.pl Signed-off-by: Joshua Ferraro <jmf@liblime.com>	16 years ago
Galen Charlton	d351753d4e	kohabug 1993 - task scheduler improvements [1] Removed hardcoded path to original developer's Koha configuration file; now checks KOHA_CONF. [2] Now attempts to figure out if a task was successfully added to the task queue; if it wasn't, the failure is now reported in the task scheduler page. [3] When traveling to the task scheduler page from a saved report, the report in question is now selected by default. [4] Removed the button to edit a queued task; this is not supported. This patch is essentially a bandage; I've added a BUGS section and some FIXMEs to the POD for C4::Scheduler detailing some issues - a refactoring of the task scheduler is in order at some point. Signed-off-by: Joshua Ferraro <jmf@liblime.com>	16 years ago
Galen Charlton	fc6ccb1a61	granular permissions - updated Tools Updated all scripts appearing on the tools page to respect a granular permission defined for each of them. The tools menu and home page have been changed so that only the specific tools that a user has access are displayed. This is simple, but depending on the module and circumstance, it may be better to display functions that the user has does not have access to, but disable the links and do some sort of visual styling to indicate that a function exists but requires additional privileges to access. Signed-off-by: Joshua Ferraro <jmf@liblime.com>	16 years ago
Chris Cormack	43aba83d39	Tweaks to the scheduler Signed-off-by: Chris Cormack <crc@liblime.com> Signed-off-by: Joshua Ferraro <jmf@liblime.com>	17 years ago
Chris Cormack	ea899bc559	More work on the scheduler Signed-off-by: Chris Cormack <crc@liblime.com> Signed-off-by: Joshua Ferraro <jmf@liblime.com>	17 years ago
Chris Cormack	f2c8126866	Adding scheduler Signed-off-by: Chris Cormack <crc@liblime.com> Signed-off-by: Joshua Ferraro <jmf@liblime.com>	17 years ago

21 Commits (3cb8446d760dd67c9f834eb911b6982e9b9a11ef)