Commit graph

9724 commits

Author SHA1 Message Date
Michael Hafen
451ab9e77e OPAC Advanced Search - have user's branch selected by default
If SearchMyLibraryFirst is on, and the user is logged in, then have
their branch selected in the Location And Availability drop-down.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-29 08:08:12 -05:00
Michael Hafen
d8fad2313f Checkout page - Check Out's table sortable on barcode
Add the barcode column of the Check Out's table to the tablesorter
setup.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-29 07:59:51 -05:00
Garry Collum
8c850ff3fe minPasswordLength not returning user back to systempreferences.pl?tab=Patrons. Incorrect reference MinPasswordLength fixed. Could not find bug report.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-29 07:47:37 -05:00
Joe Atzberger
a57b438df0 Bug 3126: remove comma for IE7
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-29 07:29:12 -05:00
Joe Atzberger
de38cf6df1 Bug 3130 and general cleanup
Javascript error in FF and IE when loading page and no data matches criteria.
This was because it was passing more holds than necessary to the template and
letting a template conditional inside the loop control whether to display or not.
That doesn't make sense, and it forces the table to be displayed even when all
rows FAIL the conditional.  jquery.tablesorter was confused trying to be added
on top of an empty table with nothing to sort.

There were several other errors addressed by this patch:
 ~ 13 unused variables deleted.
 ~ regexps run on user-supplied $var before checking $var defined
 ~ decimal ratio prohibited and silently replaced with "3"

I also added the hold ratio to a column display, with a jquery tweak to put it in
the ratio input box on click.  Hidden .sql div now contains the actual query run,
like the other wizard reports.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-29 07:29:10 -05:00
Chris Cormack
0501737f1c Bug 2505 adding warnings to opac-authorities-home and fixing warnings generated
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-29 07:29:02 -05:00
Jane Wagner
f9c3780def Bugs 2822, 2551, 3163 fixes to XSLT
Resent with additional comments.

Bug 2822 -- for leader6 types of i (nonmusical) or j (musical), the hitlist
uses an icon and label of Sound while the record display page uses
Music.  Modified record display to use Sound.

Bug 2551 -- for leader7 type of i says it's type Serial which is incorrect.
The bug report suggested Integrating Resource" but the latest install's
hitlist page uses Continuing Resource.  Changed the record display page
to also use Continuing Resource.

Bug 3163 -- if you have a 110 or 710 with a subfield a and a subfield b,
there's no space between them (on either hitlist or record display).
The two headings run together in the display.  Modified the utils file
to force a space.

The XSLT files referenced two icons which did not exist (globe.png and
drive_remote.png. Replaced those with icons from the same subject area
(world.png and drive_web.png).  Also, corrected spelling of icon name
from pencile.png to pencil.png.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-28 09:00:28 -05:00
Galen Charlton
978f0d5618 fix DOS newlines in MARC21slimUtils.xsl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-28 08:59:47 -05:00
Chris Catalfo
96f82b3403 bug 3156 followup Fix display of LTFL content when not displaying it in tabs.
LTFL content needs to appear in div rather than span elements.  This patch simply replaces the LTFL span elements with divs to fix Bug 3156: LTFL content not displaying if LibraryThingForLibrariesTabbedView sys pref is Off.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-28 07:57:59 -05:00
Mason James
f6571fa5c2 fix to remove blank newlines from labels
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-28 07:04:07 -05:00
Marc Chantreux
9902f24c13 don't try to resolve if WEBSERVER_IP is set and now use WEBSERVER_HOST.
as it crashed the installer when DNS doesn't respond as expected.

it will now use the WEBSERVER_HOST described in the doc but unused in the script.

TODO:

- lot of koha-httpd.conf generation is useless if you plan to use vhosts strategy
- on some recent linux distributions, $(getent hosts `hostname`) will give us
  127.0.0.1. this is to not mess up the MTA when there is no network. Don't
  you think there would be an error message in this case?
- default domain is localdomain .. this is not a good idea but i haven't a better one.
  can a network guru fix that ?

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-28 06:51:45 -05:00
Nahuel ANGELINETTI
632955332d (bug #2750) Cannot return to another branch if the independantbranch option is set as ON
The code was modified to change the holding branch ONLY if the return to the right branch is done. If you set IndependantBranch to on, you must return the document to the HomeBranch.
And verify the return is done before show the message that allow to transfert the document to another branch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-28 06:43:49 -05:00
Nahuel ANGELINETTI
70e46edf73 (bug #2961) change the workflow of the new issue
This patch change the operations, it add a new expected if no one expected exists, else it create new excepted, and set the others as "late"

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-27 18:03:30 -05:00
Galen Charlton
a2b1922b66 bug 2915 followup - small efficiency improvement
Following up on a suggestion by Joe Atzberger, save
a database query by not counting the subscriptions
to delete; instead, simply fetch a list of them.

No user-visible change.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-27 18:03:24 -05:00
Galen Charlton
46037ac61a bug 2893: tweaks to AllowNotForLoanOverride (DB rev 030)
* moved to DB rev 030
* assigned AllowNotForLoanOverride to circulation syspref category
* added a hint to the circulation operator: when the
  AllowNotForLoanOverride is ON, if the operator attempts
  to check out an item that is normally not for loan due to
  its item type or because the item is explicitly marked as
  not-for-loan, the operator is given the chance to check
  out the item anyway.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-27 14:44:09 -05:00
Nahuel ANGELINETTI
43e4976806 (bug #2893) Allow loan forcing if a syspref is set
If the syspref 'AllowNotForLoanOverride'(YESNO) is set to YES, the librarian is able to force a loan on an item set as "not for
loan".
If the item is not for loan and the syspref is set to YES, koha will ask to the librarian if he really want to check-out it, else
do nothing.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-27 14:29:30 -05:00
Marc Chantreux
6be431d79e _set_defaults_for_add easier to read
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-27 10:50:13 -05:00
f6aeeeb3c0 Bug 2920 Display AmazonReviews syspref in the enhanced content category
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-27 09:46:33 -05:00
Galen Charlton
073ebc0001 bug 2559: fix search limit on Spanish language (DB rev 029)
Fixes bug where searching with the language limit set
to Spanish would instead retrieve Russian records.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-27 07:30:55 -05:00
Joe Atzberger
8a5ac1ee97 Followup (1 of 2) to: Correct iso639_2_code for Spanish is "spa" not "rus".
updatedatabase change deferred for now.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-27 07:21:33 -05:00
Joe Atzberger
9609b8b097 Correct iso639_2_code for Spanish is "spa" not "rus".
The result of this apparent copy/paste error is that adv. search
limits by Language=Spanish would return results for Russian!

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-27 07:21:31 -05:00
Joe Atzberger
aebdecfb35 Bug 3114 - IE7 spacing needs width: 100% to avoid line collapse.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-27 06:54:44 -05:00
Galen Charlton
786a1aa36a bug 3161: don't display blank language chooser
If more than one translation is installed but only one is active, a blank div
is displayed at the bottom of all pages in the intranet (and in the OPAC if the
opacchangelanguages system preference is ON), taking a bit of vertical real
estate needlessly.

Changed so that <div> for the language chooser is output
only if there is more than one enabled language.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-27 06:54:42 -05:00
Chris Cormack
b66c900a3d Whoops missed Brendan's commit, fixed the history now
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-27 06:54:39 -05:00
Chris Cormack
2677e75bb7 bug 2505 fixing warnings, I think we have them all for opac-search.pl now
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-27 06:54:37 -05:00
ed1da7925d Bug 2920 DB Rev 028 AmazonReviews syspref
Add AmazonReviews syspref.

DOCUMENTATION:

  AmazonReviews is OPACAmazonReviews counterpart,
  except that in staff interface Editorial Review
  is displayed alone, without reader reviews.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-27 06:54:28 -05:00
33fffbcfd6 Bug 2920 Fixes Amazon content use in pro interface
This patch fixes Amazon content use in pro interface :

* Control Amazon Editorial Review by a new syspref:
  AmazonReviews.
* /catalogue/detail.tmpl doesn't display Amazon reader reviews.
  It displays only Editorial review in Description tab.
  This patch disable request for AWS reader reviews.
* Use Amazon TLD for linking book cover to local
  Amazon Search Inside.
* Minor clean up on C4::External::Amazon.pm

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-27 06:53:34 -05:00
199ec1473a Bugfix #2920 Avoid doing unecessary calls to Amazon Web Services
This patch modifies how AWS is called. AWS is now called
depending on syspref. It works completly for OPAC; it
has to be refined for intranet.

For OPAC:

  * If OPACAmazonReviews is set, AWS EditorialReview and
    Reviews (users) are grabed.
  * If OPACAmazonSimilarItems is set, AWS Similarities info
    are grabed.
  * If nothing is asked, AWS is not called anymore,
    sparing server bandwidth.

For intranet:

  It works as it used to work. AWS is called if AmazonEnabled
  is set whatever how other syspref are set.

  TODO:

    * Add a AmazonReviews syspref
    * Request Amazon content depending on AmazonSimilarities
      and AmazonReviews syspref

DOCUMENTATION:

  It should be explained that Amazon services related syspref
  have two levels:

  * AmazonEnable / OPACAmazonEnable
  * Other: OPACAmazonReviews (new), OPACAmazonSimilarProduct,
    OPACAmazonCover

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-26 10:36:14 -05:00
Galen Charlton
c101ea2379 bug 2505: fix more warnings in opac-search.pl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-26 10:24:38 -05:00
fccf91832e Bug 2505 Adding use warnings, and fixing the warnings generated
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-26 09:51:03 -05:00
Ryan Higgins
a58eb67318 Bug 3148 : Database revision to make zebraqueue.biblio_auth_number as big as auth_header.authid.
If you've never truncated your zebraqueue table, you might want to
update your index and truncate it before applying this patch and running updatedatabase.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-26 09:51:00 -05:00
Galen Charlton
716c170b5d fix warning in C4::AuthoritiesMarc::merge()
"my" variable @X masks earlier declaration in same scope at C4/AuthoritiesMarc.pm line 1200

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-26 09:50:56 -05:00
Galen Charlton
b090b1c6e8 improved POD for C4::Serials::HasSubscriptionExpired()
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-26 09:50:55 -05:00
Henri-Damien LAURENT
dd9b33f1e9 Fix :Fatal Errors occurs when date is not a regular date
When the start date or the "current date" is not a regular date
the transformation and checkdate fails because there is no
Year/Month/Date
This patch makes it fail more 'silenty' for the users and raises an
error that could be coped with.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 22:37:04 -05:00
Nahuel ANGELINETTI
c5ca4f6391 (bug #2937) use check_date in C4::Serials::hassubscriptionexpired
This patch change the date check in hassubscriptionexpired to use Date_Calc::check_date

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 22:36:35 -05:00
Henri-Damien LAURENT
6c5f9d46d8 Removing map calls in void context
Thanks Joe.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 22:34:12 -05:00
Henri-Damien LAURENT
42bebf7a21 problem saving authority with ? and other special characters [resend]
Filtering those signs in order not to have them interpreted.
Removing some warns

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 22:33:53 -05:00
Henri-Damien LAURENT
9289055703 Bug Fix : 2494
Adds some rewriting
bug fix for merging
AddAuthority had some problem with updating existing data.
ModAuthority adds a new Syspref called MergeAuthoritiesOnUpdate which is used to launch or disable biblios update when updating an authority

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 22:33:20 -05:00
Henri-Damien LAURENT
385ffe5179 Merging authorities caused an encoding problem in biblios
MARC::File::USMARC::decode is not aware of encoding as MARC::File::XML is
So it caused a problem when decoding information and updating biblios.
Now uses MARC::File::XML
Encoding is OK

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 22:32:18 -05:00
Henri-Damien LAURENT
8b10335def Bug Fix : Adding Some error proofs to HaveSubscriptionExpired
Date::Calc::CalcDays was throwing error 500 when one serial had an undefined date.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 22:26:41 -05:00
Michael Hafen
a4f1283093 Add items.itemnotes to the Notes/Comments search in Marc21
This uncomments the 952$z and assigns it to the Notes index in
marc21

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 22:16:14 -05:00
Mason James
2a1501f539 BUG:3072 small work-around patch to restore authorities searching
this is a work-around fix, until a future patch arrives to define the missing 'Heading-Main' zebra-index.

for 3.0.x

[RM note: also included in HEAD so that I can include the UNIMARC(A)
 updates by HDL]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 22:04:16 -05:00
Henri-Damien LAURENT
9f1b24c964 Improving UNIMARC(A) compliance
Adding some fields to index.
Adding also some indexes in order to be able to query specific fields.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 21:59:13 -05:00
Henri-Damien LAURENT
40ab51d8f7 Bug Fixing : searching on mainmainentry was disabled
Adding Heading-Main as new index code in order to search only on Heading-main when $a selected.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 21:59:04 -05:00
Henri-Damien LAURENT
87cef586af Minor Feature : username when cataloguing
biblios can now be added librarian name automatically when cataloguing.
add "user" in the Default value of the biblio

[RM doc note: in other words, if in the MARC framework you set
 the default value of a subfield to 'user', the username of the
 cataloger will be entered into that subfield whenever you create
 or modify that bib in the Koha bib editor.]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 21:38:02 -05:00
Ryan Higgins
dc5990b6ae Bug 2776 : emailPurchaseSuggestions syspref deprecated
This patch removes the system preference from new installations.
No db revision is supplied to remove the system pref from existing installations.
It is recommended for administrators to use the scripts provided in the misc/ directory
to ensure that their system preferences are in sync with those used in code.
Admins should remove this preference from existing installations manually.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 21:12:43 -05:00
Henri-Damien LAURENT
e5d1bced25 Adding some Error proof on GetAuthority
return undef if there is a problem

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 21:01:36 -05:00
Henri-Damien LAURENT
e7282020f7 Restoring startsby search on authorities.
[RM note: fixes bug 2792]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 20:56:58 -05:00
Mason James
866df9ce97 BUG-3160: fixes 'itemlost' check on item return.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 20:41:53 -05:00
Galen Charlton
feead03b08 fix XHTML error - duplicate tabindex
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 20:36:30 -05:00