Commit graph

9665 commits

Author SHA1 Message Date
Michael Hafen
454dd9376b New feature Number of Returned Items to Show
This adds a system preference controlled feature.  This controls how
many returned items are shown on the check-in page.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 13:23:44 -05:00
Galen Charlton
9a36429d22 DB rev 025: ceilingDueDate syspref
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 13:22:42 -05:00
Michael Hafen
398a6a7fe1 New feature ceiling Due Date - database update
This updates the database to add the syspref ceilingDueDate.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 12:49:56 -05:00
Michael Hafen
7d61fd62f5 New feature ceiling Due Date.
This adds a feature and system preference: ceilingDueDate.  If this is
set to a valid ( according to dateformat syspref ) date, then calculated
due dates will be less than this date.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 12:49:54 -05:00
Joe Atzberger
6ad369f80b Cleanup and tighten Letters module.
Subroutine arguments enforced w/ with more checks, explicit return undef where warranted.
Placeholders used in SQL where applicable.
One logical error corrected :
- next MESSAGE if ( lc( $message->{'message_transport_type'} eq 'rss' ) );
+ next MESSAGE if ( lc($message->{'message_transport_type'}) eq 'rss' );

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 11:16:50 -05:00
Joe Atzberger
424eff89dd Basic reformat of section in Search.pm
In for loops, replace all-inclusive conditional blocks like:
    for (@foo) {
        if (test) {
            block;
        }
    }

with conditional use of "next":
    for (@foo) {
        test or next;
        block;
    }

This reduces the number of unnecessarily nested blocks, and the
overall number of lines.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 10:55:53 -05:00
Chris Nighswonger
cd16f12a47 kohabug 2934 - Wrong datatype causes artificial limit to label batch id's
labels.batch_id should be int as the value is always an integer. This corrects
the problem.

[RM note: ported patch to HEAD.  DB rev 024]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 10:39:13 -05:00
Michael Hafen
34d3399149 Use biblioitems.itemtype as a default for items.itype
This correct the html select default in additem.pl, and enforces use of
biblioitems.itemtype as the default in Items::AddItem.  The code in
Items is to catch items added through MARC record staging.

Thanks to Joe Atzberger for suggestion.

[RM note: this patch means that an item's item-level item type,
 once that item is added or updated via additem.pl,
 now cannot be blank or NULL unless the biblio-level item type
 is blank.]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 10:26:57 -05:00
Galen Charlton
0a306bc28c bug 2505 followup: restored correct item type image display
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 10:04:32 -05:00
Andrew Moore
f447f8a91f Bug 2505: adding warnings to opac-detail.pl
Before starting to edit opac/opac-detail.pl, I added 'use warnings' and
eliminated all of the warnings that I could get it to produce. I also
extracted two lines that prepared an amazon ISBN into a function. They
were causing a few warnings and might as well be extracted. They should
probably be moved to a module somewhere since these two lines are copied
all over our code.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 09:50:57 -05:00
b398f9981f Modify GoogleJacket display
On detail page, when GoogleJacket is enabled,
book cover is retrieved from Google. This image
is a link to GoogleBook services: full text,
book localisation in a bookstore, etc.

This patch removes the link on book cover and
add underneath a text 'Source Google' with a
link to GoogleBook services.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 09:20:32 -05:00
Joe Atzberger
28a7b360be Block warning on detail.pl.
If Amazon doesn't have an avg. rating number defined, then we cannot multiply it
by 20 without the following warning:

    detail.pl: Use of uninitialized value in multiplication (*)
    at /home/user/kohaclone/catalogue/detail.pl line 228.

So the important part of this patch is || 0 on the $average_rating assignment.

[RM note: applying for whitespace cleanup]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 09:02:34 -05:00
Andrew Moore
b15be22620 refactor: removing a few unnecessary loops and moving HTML out of script into template
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 08:48:38 -05:00
Galen Charlton
5c6d9633b7 bug 2765: updatedatabase to increase width of ISBN columns
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 08:41:53 -05:00
Henri-Damien LAURENT
1574e45d01 bug fix 2765
Changing isbn data from 14 to 30 in order to manage friendlier,
isbn with - inside, and multiple isbns.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 08:35:41 -05:00
Joe Atzberger
6b120d34a4 Cleanup, pod fix and FIXME's added.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 08:26:37 -05:00
Galen Charlton
ffe0642658 DB rev 022: set DBrev for bug 2945 fix
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 08:18:34 -05:00
Joe Atzberger
0bd5a30708 Bug 2945: increase size of labels_conf.formatstring (DB update)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 08:15:25 -05:00
Jane Wagner
b81479fdb2 Bug 3152 OPAC reading history column headers don't line up with text
Fixed template files to make column headers and text line up; moved
the <td></td> for cover art outside the various content provider IF
statements.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 08:08:56 -05:00
Joe Atzberger
f3b5014449 Bug 3128 - followup and correction
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 07:46:34 -05:00
Joe Atzberger
173556364d Bug 3128: IE7 tweak
Again, jquery has the answer, mainly because it fails cleanly and
quietly on NULL/undef elements.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 07:46:28 -05:00
Galen Charlton
11fef5234c fixed typos in LTFL sysprefs
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 07:40:37 -05:00
Stephen Edwards
47690dbcc4 bug 3093: Enhance placing of holds in the staff interface.
This patch allows staff users to request reserves on multiple
items at one time.

Added checkboxes, select-all, clear-all, and place-hold button to
staff search results page.  Place-hold button will only appear if
the user has permission to place holds for others.  Item-level
Place-Hold button will not appear for multiple holds, nor will
the vertical detail menu.

Patron input page now shows multiple items, if applicable.

Hold confirmation page shows results for multiple items, if
applicable.  Those which cannot be reserved are highlighted and
are excluded from the reservation.  The reservation is placed at
the biblio number (i.e. next available) level.

Fixed display of item type.

Removed side menu for multiple items; removed item-oriented button for multiple items.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 06:12:06 -05:00
Galen Charlton
0a8b0f44ba bug 3155 followup: tweak OPACAmazonReviews syspref
* add to enhanced content tab of syspref editor
* during upgrade, if database has OPACAmazonEnabled
  turned on, ensure that OPACAmazonReviews is on
  as well.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 06:08:22 -05:00
13c45c4f6d DB rev 020 -> 021: OPACAmazonReviews syspref
Add new OPACAmzonReviews syspref

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 05:56:58 -05:00
29ab92d261 Bugfix #3155 Disabling Amazon Reviews
Disable Amazon reviews without disabling Amazon book cover.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-24 05:56:54 -05:00
Chris Cormack
c7b45ff064 New Developer
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 18:09:39 -05:00
Galen Charlton
c132cba2bc DB rev 019 -> 020: LTFL support
Extends Christopher Hyde's patches to add LTFL support
as follows:

* adds fr-FR system preferences
* adds updatedatabase.pl

The three new system preferences are:

LibraryThingForLibrariesEnabled - turn ON to enable LTFL support
LibraryThingForLibrariesID - client ID for LTFL service
LibraryThingForLibrariesTabbedView - put LTFL content in tabs on bib detalis page

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 16:13:39 -05:00
Galen Charlton
f5e93e0099 fix XHTML validation errors in LTFL output
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 16:13:29 -05:00
Christopher Hyde
a5d6494c62 Fixed minor error in comment code
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 15:37:15 -05:00
Christopher Hyde
b15a74c8d7 Changes Made to further optimize and condense code, include code documentation, and fix hardcoded instead of syspref'd library thing id
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 15:36:49 -05:00
Christopher Hyde
4b56532d0a Changes made: Fixed typo/bug which had wrong order for if statement checking to see whether
Committer: Christopher Hyde <chyde@ebpl.org>

	modified:   koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 15:35:02 -05:00
Christopher Hyde
1d4892cf1c Changes Added to existing LTFL code to give option of placing LTFL content in Tabs on OPAC details page
modified:   admin/systempreferences.pl
	modified:   installer/data/mysql/en/mandatory/sysprefs.sql
	modified:   koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tmpl
	modified:   opac/opac-detail.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 15:34:56 -05:00
John Beppu
286c3c3a9e bug 1546 - replacing REPLACE statements
replaced REPLACE statements with a pair of INSERT and UPDATE statements.
Hopefully, these are the last ones.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 15:00:02 -05:00
Galen Charlton
bfec1aa5ae DBrev 018 -> 019
Also corrected message upon addition of new
OPACShowCheckoutName syspref.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 14:55:08 -05:00
Jane Wagner
a966c51f1a Creates a syspref & modifies template to show checked out username in OPAC
Intended for corporate or special sites which require the name of the person
who has checked out an item to show in the OPAC.  Most libraries will want
to leave this turned off!

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 14:39:25 -05:00
Joe Atzberger
b8d6ccf845 Bug 3118: Remove comment that perturbs IE
Formatting bugs not fixed.  Class added to relevant labels.
Both CSS and jquery setting of width do not "take" in IE7.
The background-color, however, can be affected.  Go figure.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 12:05:08 -05:00
18f34a1682 Adding the dev weekend and another developer to the history docs
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 11:29:27 -05:00
Joe Atzberger
1afa403417 IE bugs 3124 and 3115: z3950 search and guided_reports
Clip trailing comma in js list argument.

Column selection improved with jquery and submit time check.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 11:28:28 -05:00
1410971711 Typo in history docs
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-23 11:28:25 -05:00
8f95ec3dbe Fix for Bug 3119: Add due date to the patron circulation history window
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-21 18:45:11 -05:00
e6076612ba Fix for Bug 1877, Link to patron record from manage suggestions
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-21 18:44:02 -05:00
Brian Harrington
fe95a8ee9b Patch to improve auto-generated MARC21 authorities
This patch makes sure that MARC21 authorities have a minimal
Leader, 008, and 040.  If an authority record is created through
BiblioAddsAuthority it generates a 670 based on information in
the bib record.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-21 14:29:15 -05:00
8c6d7c9996 Adding link back to OPAC for emailed cart and lists.
Correction to previous patch: uses "online catalog" in place of "OPAC" following the example of other text on the page

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-21 14:29:11 -05:00
Brendan A. Gallagher
a09ad1edde Bug #3101 - Changed the Print and Confirm button
Changed button to read "Print slip, Transfer and Confirm"

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-20 12:22:09 -05:00
Galen Charlton
d23a8d3069 fix to previous patch - use 'lt', not '<', to compare date strings
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-20 12:14:28 -05:00
Joe Atzberger
0ad2b08c28 Visual alert (red) on overdue return.
This was requested by a Koha user at KohaCon09.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-20 12:05:01 -05:00
Cory Jaeger
bb91778b8d Bug 2847 - Added url escaping for categorie.tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-20 12:00:01 -05:00
Cory Jaeger
9a1a332dbc Bug 2847 - Fix html escaping in categorie.tmpl (more needed)
Added escape="html" to several TMPL_VAR tags which need it in order
to deal with quotes and other special chars in user supplied data.
Many other templates still need to have escaping added to fields which
allow free form entry.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-20 09:58:15 -05:00
Nicole Engard
520d40614e Fix Bug #2925
This patch fixes the language issue on the serial full
display on the OPAC by changing 'waited' to 'waiting'.

In addition I have made it so that the Date Received
only shows if the item is 'Available'

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-19 13:08:38 -05:00