Commit graph

5471 commits

Author SHA1 Message Date
Paul POULAIN
4682f9ae39 reintroducing size for fields in addbiblio
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-17 07:10:31 -05:00
Galen Charlton
afe642bc52 fix for bug 1499 - normalize ISBN before dupe check
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-17 07:10:07 -05:00
Henri-Damien LAURENT
003c70214f BugFixing : viewlog.pl was broken (comma missing)
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-17 07:08:07 -05:00
Henri-Damien LAURENT
6dad593dee Adding Biblionumber to template param list
This enables navigating on MARC/ISBD/Normal View

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-17 07:07:39 -05:00
Henri-Damien LAURENT
ed4a7e083d Removing connexion informations from basket page.
It masked biblio information.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-17 07:07:13 -05:00
Henri-Damien LAURENT
6eeccad305 Bug Fixing ISBD parser had problems with commas
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-17 07:06:38 -05:00
Henri-Damien LAURENT
af2bfefd32 Bug Fixing : userid was blanked out in partial edit.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-17 07:06:04 -05:00
Henri-Damien LAURENT
e6e4395553 patches for members and resultlists.
--
Henri Damien LAURENT et Paul POULAIN
Consultants indépendants
en logiciels libres et bibliothéconomie (http://www.koha-fr.org)

>From 616f0a385848b9a1fee7c76ff7b1f3be090ccb66 Mon Sep 17 00:00:00 2001
From: Henri-Damien LAURENT <henridamien@koha-fr.org>
Date: Tue, 16 Oct 2007 15:20:45 +0200
Subject: [PATCH] Bug Fixing : userid was blanked out in partial edit.
Adding some checks on branch presence for independant branches

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-17 07:05:39 -05:00
Joe Atzberger
82f3a9423b Dates.pm: perl test to accompany Dates.pm functions.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-17 07:01:06 -05:00
Joe Atzberger
b73e4e924e Dates.pm: Added functions format_date and format_date_in_iso as possible drop-in replacements for
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-17 07:00:47 -05:00
Joshua Ferraro
eac81e3d8b Revert "Minor overhaul of installer WITHOUT thorough testing. Steps broken out into"
This reverts commit b9f141a592.
2007-10-17 06:58:48 -05:00
Joe Atzberger
b9f141a592 Minor overhaul of installer WITHOUT thorough testing. Steps broken out into
More revision is required: CVS variables, bad use of map in void context,
overuse of multiple index lines instead of one RegExp, etc.  Koha GPL
statement at top needed.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-17 06:56:27 -05:00
Henri-Damien LAURENT
8f67beb26d Bug Fixing : Memberentry was broken.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-15 23:54:20 -05:00
7aeb88fe20 Changing the way resident search form is displayed; Reformatting admin-home.tmpl; Updating entry form display on admin pages.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-15 23:54:04 -05:00
Paul POULAIN
b426ecb4f2 BUGfixes in availability management
- the availability status was not available on result list. This patch reintroduces that
- notforloan as itemtype was not properly managed : an itemtype that was notforloan resulted in nothing in detail. Not, the user can't place a reserve anymore, and the status is correctly displayed

the fix is for OPAC as well as staff

(owen, pls, validate cat-toolbar.inc & catalogue/detail.tmpl)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-14 19:10:53 -05:00
feea56bfd8 Change to address Bug 1471
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-12 22:24:21 -05:00
197db8d67d Fixes for Bug 1444. Trimming whitespace and correcting javascript form submit.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-12 22:24:04 -05:00
ca5185284a Fix for Bug 1480 (added items link to biblio-view-menu.inc). Cleaned up display in moredetail.tmpl
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-12 22:23:44 -05:00
b24e17a547 A couple of forgotten markup corrections.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-12 22:23:23 -05:00
ba6e7d6ccb More refinements to MARC structure pages navigation
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-12 22:23:03 -05:00
Paul POULAIN
4794cec244 #1485 (issuing rules improvement) continued
updating fines rules management :
- replacing '*' by default
- removing bottom line (*) that means nothing
- dealing correctly with .0000 fine values
- fixing fine storage

still fines.pl to do

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-12 22:22:40 -05:00
Paul POULAIN
ef27099d90 #1485 (issuing rules improvement) continued
issuing rules are working as expeced with this commit.
working on finesrules now

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-12 22:22:37 -05:00
Paul POULAIN
28257e7a98 #1485 (issuing rules improvement) continued
IMPORTANT NOTE : all existing test database for 3.0 must manually delete ALL constraints on issuingrules table
(the update22to30.pl don't contain the constraints anymore, as kohastructure.sql, so are concerned only the existing 3.0 tests databases)

Filling issuingrules table :
- the issuingrules table can't have a constraint on categorycode, as we have a '*' categorycode (=default issuingrule)
- reintroducing the "default" issuingrule column
- changing some text ('*' replaced by something more explanatory)
- handling correctly the '0' (that is different from 'undefined'

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-12 22:22:12 -05:00
Paul POULAIN
d9b7ef9903 adding . as word separator for french. Why was it not here ?
nobody probably ever enter "." on search term, but just in case...

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-12 22:21:38 -05:00
Paul POULAIN
345eaeb725 Bugfix for empty words
The \b consider only ASCCI as letter. So diacritics are considered as non word.
and a word like leçon is splitted in 2, "le" is empty word, and the search is done
on çon (which is not french [1], so has no result)

[1] con (without the cedilla) is a french word, but I won't tell you what it means...
anyway, there are probably no "con" in most catalogues ;-)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-12 22:21:07 -05:00
Paul POULAIN
9f58a48ef2 bugfix: parenthesis at wrong place
authorities could not be open in MARC editor

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-12 22:20:21 -05:00
Joe Atzberger
bd76a1fb0f Context.pm fatalsToBrowser now dependent on $ENV{USER_AGENT}.
Minor adjustments to Dates.pm and associated test.  You should be able to run a
perl test that uses Context w/o getting fatalsToBrowser output.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-12 22:19:42 -05:00
Ryan Higgins
1c2adfe7ff adding GetMarcUrls() fcn to display 856's - adding also output to opac-detail.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-12 07:24:53 -05:00
Paul POULAIN
c3e0cf6b42 #1255 : flagged patron can't renew
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-12 07:24:28 -05:00
Chris Cormack
e8528be8cb Delbiblio no longer deletes items.
It will only delete biblios that have no items attached.
You must delete the items first then delete the biblio

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-12 07:23:45 -05:00
Chris Cormack
eb8878b854 Working on a fix for 1176
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-12 07:22:59 -05:00
Joshua Ferraro
2abac6e0ec adding missing column to biblio table
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-11 15:57:33 -05:00
6c352a8129 Fixing tabs display.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-11 15:57:18 -05:00
0c454c95b7 Tweaking holds screen, trying to get additional patron information to show up in holds sidebar; Tweaks to serials interface, including overhaul of subscription-add screen
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-11 15:56:51 -05:00
Henri-Damien LAURENT
aca6ea26fe Reporting guarantor informations on guarantees.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-11 15:56:33 -05:00
Henri-Damien LAURENT
d1c03deb7e Reintroducing overdue filters.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-11 15:56:02 -05:00
Henri-Damien LAURENT
8768c6476f Bug fixing 1360 : It was a bug when no authoritytype was defined.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-11 15:55:40 -05:00
Henri-Damien LAURENT
4f54ed3792 bug fixing : 1459 + fixing a jserror in basket.tmpl
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-11 15:55:18 -05:00
Henri-Damien LAURENT
f8c6728d87 Filtering cancelled orders on History Search.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-11 15:54:56 -05:00
Paul POULAIN
1ac38782a1 #1474 : Bulkmarcimport croaks when Log is ON
set to 0 and restore at the end of the import

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-11 14:53:59 -05:00
Joshua Ferraro
e986dfb2dc Revert "IMPROVEMENT (for #1416 : Available items marked waiting as soon as hold is placed)"
This reverts commit 8d269c3dbc.

Conflicts:

	.dotest/0001
	.dotest/final-commit
	.dotest/info
	.dotest/msg
	.dotest/msg-clean
	.dotest/patch
2007-10-11 13:24:40 -05:00
Joshua Ferraro
b77e9c305f removing .dotest, not sure how it got in here
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-11 13:02:23 -05:00
Joe Atzberger
7fecc7cd41 Unnecessary "use" statements commented out.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-11 12:45:52 -05:00
a25747cf2e Change to the way the duplicate warning works and displays. Streamlines not-a-duplicate confirmation process and hopefully fixes Bug 1447.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-11 12:45:27 -05:00
Henri-Damien LAURENT
2d746bd797 Revert "Changing innerjoin to left join for mysql5"
This reverts commit c0dbeb8a3f4f9ab99109d42ea194b53a46235c00.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-11 12:45:09 -05:00
Henri-Damien LAURENT
0da5b2099b Recommitting left join for mysql5
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-11 12:33:18 -05:00
Henri-Damien LAURENT
7a7a2c1e0d Revert "Changing innerjoin to left join for mysql5"
This reverts commit c0dbeb8a3f4f9ab99109d42ea194b53a46235c00.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-11 12:32:46 -05:00
Paul POULAIN
669a146e1a Sorting Branches by Branchcode on display.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-11 12:32:04 -05:00
Paul POULAIN
8d269c3dbc IMPROVEMENT (for #1416 : Available items marked waiting as soon as hold is placed)
In fact, #1416 is not a bug, it's a feature : SAN-OP librarians place the reserve "book in hand", and confirm on phone that it's available
NPL save the reserve, but pick them from the shelves once a day only. So the item must be "to pull"

This commit improves the behaviour :
- document Reserves.pm a little, it was needed !
- add a systempreference ReservesNeedReturns, that let the library choose it's behaviour
- define the systempref in english & french systempreferences files
- add the systempref through the web installer (bumping to 3.00.00.003)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-11 12:14:32 -05:00
Paul POULAIN
94a441f57e #1485 saving issuingrules
lot of bugs to fix...
- a foreign key on patron category is stupid as we have a wildcard
- having a wildcard on itemtype is useless, removing it in template
- reindenting & removing some commented lines
- fixing some SQL bugs (insert/update lines)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-11 11:56:10 -05:00