In fact, #1416 is not a bug, it's a feature : SAN-OP librarians place the reserve "book in hand", and confirm on phone that it's available
NPL save the reserve, but pick them from the shelves once a day only. So the item must be "to pull"
This commit improves the behaviour :
- document Reserves.pm a little, it was needed !
- add a systempreference ReservesNeedReturns, that let the library choose it's behaviour
- define the systempref in english & french systempreferences files
- add the systempref through the web installer (bumping to 3.00.00.003)
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Also included is a traditional perl (t/Dates.t) test script.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
In Koha 3.0, most short code have been resized to varchar(10). This includes itemtype, branchcode, patron category
I've found some tables refering to an old-small-size definition
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
- update 22to30, that does the update from 22 to 3.0 using old mechanism.
- updatedatabase, that just does new updating stuff.
Note that there are fixes on some column size (next commit will contain fixed kohastructure.sql)
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
lot of bugs to fix...
- a foreign key on patron category is stupid as we have a wildcard
- having a wildcard on itemtype is useless, removing it in template
- reindenting & removing some commented lines
- fixing some SQL bugs (insert/update lines)
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
doesn't change anything for UNIMARC (as expected), UNTESTED for MARC21, pls test it
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
The reserve was cancelled only under certain circumstances (depending on reserve status)
cancelling everytime.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
temporary files
Need to add it to a couple more places in C4::Auth
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Fixing a SQL bug hdl introduced yesterday when updating queries & that I missed when reviewing them.
changing the look of the basket & parcel by adding & moving some link
The goal is to have the same kind of lists & links everywhere. (Will continue on monday)
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
if dateexpiry is empty, set issuingimpossible without any calculation
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
This function is used to extract strings for translator tool. It must be available everywhere, moving it to head-close.inc
& removing it elsewhere
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
