Commit graph

19779 commits

Author SHA1 Message Date
4bef47bba8
Bug 32044: Improve consistency in primary submit buttons
We currently have a mix of ways to style buttons, including some using
Bootstrap's btn-primary class and some with CSS targeting
input[type='submit']. This patch works to make these buttons more
consistent in their appearance and to improve the modularity of related
SCSS.

The patch also removes some unused CSS from login.css.

To test, apply the patch and rebuild the staff interface CSS.

Test various page to see if main submit buttons look correct in their
default, hover, and active states:

- The login page
- Circulation -> Checkouts -> Check out button (btn-primary)
- Circulation -> Set library (input[type='submit'])
- Cataloging -> Basic MARC editor (split button)

Also check "default" buttons:

- Patrons -> Sidebar filter (input[type='button'])
- Circulation -> Checkouts -> Show checkouts (btn-default)

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-11-02 19:26:29 -03:00
Katrin Fischer
c13692cc4b
Bug 31877: Fix capitalization: "Delete this Tag" and "Repeat this Tag"
To get to the string in the staff interface:
1. In the staff interface, go to Cataloging
2. Click "New record"
3. Hover the mouse cursor over one of the delete tag buttons (rectangle with a small x next to the tag title)
   --> a little popup thing (tooltip?) appears with "Delete this Tag"
4. Open the developper tools inspector in your browser
5. Click on the delete tag button
   --> the image alt text is "Delete this Tag"
6. Repeat the same check in the authorities editor
7. Apply patch
8. All tooltips and alt text should read correctly now

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-11-02 19:24:29 -03:00
Katrin Fischer
7c9760f82e
Bug 31876: Fix capitalization "Click to Expand Tag"
The string "Click to Expand this Tag" appears in addbiblio.tt a couple of times. It should be "Click to expand this tag".

To get to the string for the staff interface:
1. In the staff interface, go to Cataloging
2. Click "New record"
3. Hover the mouse cursor over one of the tag titles (e.g. CONTROL NUMBER)
   --> a little popup thing (tooltip?) appears with "Click to Expand this Tag"
4. Go to Administration > Global system preferences
5. Search for advancedMARCeditor
6. Change the value to "Don't show"
7. Click "Save all Cataloging preferences"
8. Go back to Cataloging > New record
9. Hover the mouse cursor over the tag number (e.g. 001)
   --> a little popup thing (tooltip?) appears with "<tag title> Click to Expand this Tag"
10. Go to Authorities > new record
11. Hover over the desription of a tag which subfields are collapsed
   --> verify the tooltip appears with "Click to Expand this Tag"
12. Apply patch, all occurrences should be fixed now.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-11-02 19:23:37 -03:00
8db16e6e00
Bug 32050: Add 'page-section' to calendar page
This patch adds a "page-section" div to a couple of areas on the
calendar page.

To test, apply the patch and go to Tools -> Calendar.

The content in the page's two columns should be wrapped in a white box.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-11-02 19:22:36 -03:00
3bc628d7c9
Bug 32014: Compiled CSS
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-11-02 19:21:55 -03:00
31c5563ad8
Bug 32014: Tweak style of checkout settings panel
This patch makes some minor changes to the CSS controlling the way the
checkout settings panel displays, as well as the panel showing the last
checked-out item.

To test, apply the patch and rebuild the staff interface CSS.

- Go to Circulation and locate a patron to check out to.
- On the checkout page, click the "settings" icon in the barcode field.
- The checkout settings panel should display. Confirm that the spacing
  looks good.
- Check out an item to the patron.
- Confirm that the panel showing the last checked out item information
  looks correct: A green-bordered box with a white background, no
  rounded corners.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-11-02 19:20:59 -03:00
987e1257a9
Bug 32038: Sidebar and footer style improvements on suggestions page
This patch makes some changes to the suggestions template in order to
make the sidebar filter form and bulk action table footer forms more
usable and readable.

Some global changes to <fieldset class="brief"> style are made.

To test, apply the patch and rebuild the staff interface CSS.

- Go to Suggestions.
- Confirm that the sidebar contains two sections: Organize by and Filter
  by.
- Test that the links under "Filter by" work to expand and collapse the
  different sections (bibliographic, suggestion, and acquisition).
- Below the table of existing suggestions you should see the section
  "Change selected suggestions."
- Each form should look good, with labels in bold above each form field,
  with "primary" style submit buttons.
- Because some global styles have been modified, check that fieldsets
  with the class "brief" are still displayed correctly in other areas:
  - In sidebar forms: Patrons, Acquisitions order and invoice searches,
    overdues and holds to pull in Circulation.
  - In other areas: The Quick spine label creator; the upload plugin
    form; the calendar's add holiday form.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-11-02 19:20:29 -03:00
a1edf06869
Bug 31664: Display pending transfer information on details page
If a transfer is requested, but not sent, we should display this information on biblio details for staff

This patch also removes nocancel parameter that was not used, passes transfer object directly to template

To test
1 - Manually transfer an item
2 - Note the item shows in transit on details page
3 - Remove the datesent to emulate a pending transfer
    UPDATE branchtransfers SET datesent = NULL itemnumber=1;
4 - View details page - no info on transfer
5 - Apply patch
6 - Item shows 'Transit pending'

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-11-02 19:18:01 -03:00
David Nind
83a79f0297
Bug 32035: Add "Koha" to the staff interface home page
Currently the staff interface does not include Koha before the version
number shown on the home page.

Test plan:
1. Log in and view the staff interface home page.
2. In the bottom right-hand corner "Version 22.06.00" is shown.
3. Apply the patch.
4. Refresh the staff interface home page.
5. It now shows "Koha 22.06.00" (linked to the Koha website).
6. Sign off :D (or comment on alternative options).

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Claude Demeure <claude.demeure@mailo.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-11-02 19:17:04 -03:00
3aa50f0457
Bug 32022: Compiled CSS
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-28 16:43:15 -03:00
c22dac6383
Bug 32022: (follow-up) Ensure action background takes presidence
The action class sets the background to transparent, but because it's
often used in conjunction with the fieldset which includes the card
mixin the background rule was getting overridden to white.

Test plan
1. Consider the same cases as the original patch
2. Confirm that the last test now shows the buttons outside of the card
   but nicely spaced to clearly belong to it.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-28 16:42:04 -03:00
d17775b501
Bug 32022: Style tweaks to fieldsets and page-section
This patch makes CSS changes to try to bring some consistency to
various elements which are similar in the general sense of "white box."
Fieldsets, page-section, etc.

To test apply the patch and rebuild the staff interface CSS.

Test various pages with page-section, fieldsets, etc.:

- Patron details
- Patron edit
- Patron accounting
- Check Tools -> Patron lists -> New to confirm that there is not a gap
  between the submit button's container and the rest of the form.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-28 16:41:36 -03:00
a9ea3650bd
Bug 31986: Add page-section to various administration pages
This patch adds a page-section div to some administration pages in order
to provide a consistent structure visual contrast. The following pages
are modified:

Additional fields
Funds
Authority types
Authority types -> MARC tag structure
Authority types -> MARC tag structure -> Subfields
MARC bibliographic framework
MARC bibliographic framework -> MARC tag structure
MARC bibliographic framework -> MARC tag structure -> Subfields
MARC Bibliographic framework test
Classification configuration
Currencies and exchange rates
EDI accounts
Library EANs
Item search fields
Koha to MARC mapping
Record overlay rules
Record matching rules
OAI sets configuration
SMTP servers
Z39.50/SRU servers

To test, view each page to confirm that the page-section div visibly
delineates the main content area.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-28 16:40:56 -03:00
259f549487
Bug 31760: Compiled CSS
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-28 16:40:21 -03:00
99a5aefd0f
Bug 31760: Fix contrast of 'separator'
This patch increases the contrast of the separator pipe visible in the
staff client upper right corner of the header bar.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-28 16:32:53 -03:00
fd7bc8a9b8
Bug 31993: Improve specificity of authorized values breadcrumbs
This patch adds a link back to the current authorized value category to
the breadcrumbs. The page title has also been modified to match.

To test apply the patch and go to Administration -> Authorized values.

- Click an authorized value category, e.g. CCODE.
- Click "New authorized value for CCODE"
- In the breadcrumbs menu you should see: "Home ->  Administration ->
  Authorized values -> Authorized values for category CCODE -> New
  authorized value.
- The "Authorized values for category CCODE" link should take you back
  to the correct view.
- The page title should match.
- Return to the list of CCODE authorized values and open one for
  editing.
- The breadcrumbs should include a link back to "Authorized values for
  category CCODE"

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-27 16:03:47 -03:00
Katrin Fischer
b29451176d
Bug 30407: (QA follow-up) Replace message with description
Switches "not for loan message" to "not for loan description" to
stay closer to the usual terminology for AV values also used
when managing them.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-27 13:26:05 -03:00
Katrin Fischer
690840b428
Bug 30407: (QA follow-up) Fix missing TT filter
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-27 13:26:05 -03:00
Emmi Takkinen
89e2f5bc22
Bug 30407: Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description
This can be used to instruct staff how the item should handled when
it's checked in. For example items notforloan status has been
changed as "Invoiced item" while item has been on loan. When it's
checked in staff sees that they should put item aside for further
processing.

To test:
1. Apply patch and update database if needed
2. Set items notforloan status as -1 (or create new one)
3. Add line "-1: ONLYMESSAGE" to UpdateNotForLoanStatusOnCheckin
4. Check item out for patron.
5. Check item in.
=> Description of notforloan status should be displayed.
=> Confirm notforloan status hasn't changed.

Also prove t/db_dependent/Circulation/issue.t

Sponsored-by: Koha-Suomi Oy

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-27 13:26:04 -03:00
cffb97f1ce
Bug 30036: (QA follow-up) Add explanation about default value behavior
Devs forgot to mention the default value (empty) is for the current
behavior. This is particularly important as there's really no shipped
XSLT so a niche usage enhancement until related bugs are pushed. Those
only have UNIMARC files, though.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-27 13:18:06 -03:00
8005ad6791
Bug 30036: Fix trivial typo
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-27 09:56:14 -03:00
db0e7b0fbe
Bug 30036: (QA follow-up) Move system preference to OPAC tab
* Moves the AuthorityXSLTOpacResultsDisplay from staff interface to OPAC tab
* Fixes some capitalization opac in the database pref description

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-27 09:54:35 -03:00
David Nind
4dc7293b83
Bug 30036: (follow-up) Update system preference description
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-27 09:54:35 -03:00
jeremy breuillard
c593ffd8fb
Bug 30036: Allow XSLT for authority results view in OPAC
This patch adds a syspref to allow customizing the authority results
view at OPAC with XSLT

Test plan:
1. For testing make sure to have at least one or more authorities
   defined
2. OPAC: Home > Authority search(Submit) > Authority search results
   Notice the normal view of results
3. Apply patch
4. INTRA: Home > Administration > System preferences ->find
   "AuthorityXSLTOpacResultsDisplay"
5. Write the path where your file is. You can use the one for intranet:
   .../koha/koha-tmpl/intranet-tmpl/prog/en/XSLT/UNIMARCauthResults.xsl
6. Save changes
7. Repeat step 2 and notice the xslt view of results

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-27 09:54:35 -03:00
1fc56e0e47
Bug 31421: Add a limited option to template plugin
This adds a specific 'limited' routine to the Categories plugin, and uses
it for the new patron dropdowns

To test:
1 - Limit a patron category to some branches
2 - Sign in not at one of those
3 - Confirm the new patron dropdowns don't include the category

Bug 31421: (follow-up) Add POD

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-27 09:42:57 -03:00
4aa8e9bc67
Bug 31991: Compiled CSS
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-27 09:42:21 -03:00
34fa2c8ece
Bug 31991: Restore style of sidebar forms
This patch restores the aside{} section of staff-global.scss from before
the staff redesign and makes some tweaks to make it consisten with the
redesign. The goal is to make the spacing of the form more compact but
still readable, and to correct some layout inconsistencies.

The patch also modifies the order filter form to fix the layout of some
checkboxes.

To test, apply the patch and rebuild the staff interface CSS.

Test various pages with sidebar forms to confirm that the form looks
readable and usable. For example:

- Patrons
- Acquisitions -> Invoices
- Tools -> Tags
- Serials -> Subscription search results
- Overdues
- Holds to pull

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-27 09:41:39 -03:00
a4530e5fa5
Bug 31996: Compiled CSS
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-27 09:40:35 -03:00
5a16db903a
Bug 31996: Make note-style messages consistent with dialogs
This patch modifies the style of divs with the class "note," making them
have the same background color as message dialogs as proposed in Bug
31973.

To test, apply the patch and rebuild the staff interface CSS.

Confirm that the updated style looks good. Some pages where you can find
examples:

- Administration -> Authorized values -> View a categories values.
- Administration -> Search engine cofiguration (with Elasticsearch
  enabled).
- Cataloging -> Batch record deletion -> Submit a list of biblionumbers.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-27 09:39:46 -03:00
934b2bf1d9
Bug 31973: Compiled CSS
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-27 09:39:15 -03:00
a60b7f5ed0
Bug 31973: Restore background color to message-style alerts
This patch restores the background color to message-style alerts, those
which use the markup <div class="dialog message">. These alerts should
stand out more to the user.

To test, apply the patch and rebuild the staff interface CSS.

- Test areas which use the message-style dialog. Perhaps the easiest
  example is to try to view a bibliographic record which doesn't exist:

  /cgi-bin/koha/catalogue/detail.pl?biblionumber=1234567890

- It can also be found as a confirmation when deleting a basket in
  Acquisitions, deleting a patron attribute type in Administration,
  updating a Z39.50 server in Administration, etc.

- Confirm that the alert looks correct and is suitable visible.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-27 09:37:46 -03:00
Katrin Fischer
63b9824892
Bug 31952: (QA follow-up) Fix capitalization: Local Use
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-27 09:36:44 -03:00
4a87004c1d
Bug 31952: Fix broken layout on system pref search
TO test:
1. Do an empty system pref search
2. Layout is broken.
3. Apply patch, restart_all
4. Do another empty system pref search, the layout should be fixed.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-27 09:36:43 -03:00
7e4d03cd1d
Bug 31910: Fix list and add page-section to request-article.tt
To test:
1. Apply patch
2. Look at article request form and ensure the fields and labels look good.
3. Ensure there are no more bullet points on the list.
4. Make sure the page-section div around the item selection looks good.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-27 09:36:07 -03:00
d4b6fcc0f3
Bug 31905: Fix button spacing on holds page
This patch makes minor modifications to the holds template in order to
improve the display of the hold buttons related to existing holds.

The patch also adds "display:none" to the hold cancellation fieldset so
there isn't a flash of content before JavaScript hides it.

To test, apply the patch and locate a record in the catalog.

- Place one or more holds on the record.
- View the holds for that record.
- Under the "Existing holds" heading there should be a toolbar of
  buttons which sits above the page-section div. The buttons should be
  well spaced.
- If you have cancellation reasons defined in authorized values, the
  "Cancel selected" button should correctly trigger a modal with the
  option to specify a cancellation reason.
- The display should work well for any setting of the HoldsSplitQueue
  system preference.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-27 09:35:10 -03:00
Marion Durand
fadf26c430
Bug 25387: The order of authority subfield is not sent over to bibliographic record
When creating an authority record there is the possibility to reorder
the subfield. However this order is not sent back to the bibliographic
records when using this authority in a bibliographic record.

This patch make the order of subfield be sent back to bibliographic
record when the autority is used.
Field that are fill are sent to the begining of the bibliographic record
in the same order as in the authority record.

Test plan:
1- Find or create an authority record and reorder some subfield
2- Use this authority in a bibliographic record
3- Observe that the order of the subfield is not transferred from the
   authority record to the bibliographic record
4- Apply the patch
5- Repeat step 1 and 2 again
6- Observe that the order of the subfield is now transferred from the
   authority record to the bibliographic record

https://bugs.koha-community.org/show_bug.cgi?id=22666

Signed-off-by: George Veranis <gveranis@dataly.gr>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-25 11:17:54 -03:00
13ad213273
Bug 31609: JavaScript error on Additional contents main page
This patch makes a minor modification to the JavaScript
on the Additional contents page to prevent an error when
there are no tabs present on the page.

The JS needs an additional check so that it doesn't run
when there are no tabs.

To test you should have more than one language installed.

- Before the patch, you would see a JavaScript error in
  the console: "Uncaught TypeError: can't access property
  "hash", firstTab[0] is undefined."
- Apply the patch and go to Tools -> Additional
  contents.
- With the patch applied there should be no error on the
  additional contents main page.
- Try creating or editing additional contents entries to
  confirm that the interface still works correctly.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-25 09:42:22 -03:00
Aleisha Amohia
d4556b786d
Bug 23012: Apply processing fee return policy when lost item found
This enhancement gives the ability to set a policy for the lost item
processing fee that may get charged additional to the lost item
replacement cost. The processing fee can be:
- refunded
- refunded if unpaid
- kept

To test:

Set-up

1. Find an item, Item A. Go to Administration -> Item types and edit the
item type for Item A. Add a default replacement cost and a processing
fee and Save.
2. Go to Administration -> system preferences and set the following:
- WhenLostChargeReplacementFee: Charge
- BlockReturnOfLostItems: Don't block
3. Scroll down to the default lost item fee refund on return policy. Set
the refund lost item replacement fee policy to 'refund lost item charge'.
4. Edit Item A and set a replacement cost.

Reproduce

5. Check out Item A to Patron A.
6. Click the barcode to view Item A's information. Edit Item A and set
the Lost status to 'lost'.
7. Go back to Patron A's checkouts. The item should now be checked in
with two new charges applied - a lost item fee (the item's replacement
cost) and a lost item processing fee (set in item types).
8. Check in Item A to mark it as found.
9. Go back to Patron A's account. Notice the lost item fee has been
refunded, but the processing fee remains.
10. Manually pay or write off the processing fee. This enhancement
removes the need for this manual step.

11. Apply the patch and restart services

Test with lost item - refund

12. Go to Administration -> circulation and fines rules. Scroll down to
the default lost item fee refund on return policy. Notice there is now a
refund lost item processing fee policy. Set this to 'refund lost item
processing charge'.
13. Repeat steps 6 to 9.
14. Go back to Patron A's account. Both the lost item fee and processing
fee should have been refunded.

15. Repeat steps 6 to 8 (do not check it yet).
16. Go back to Patron A's account. Pay the processing fee.
17. Repeat step 9.
18. Go back to Patron A's account. Both the lost item fee and processing
fee should have been refunded (you'll now be in a credit because the
paid processing fee was also refunded).

Test with lost item - refund_unpaid

19. Go to Administration -> circulation and fines rules. Scroll down to
the default lost item fee refund on return policy. Notice there is now a
refund lost item processing fee policy. Set this to 'refund lost item
processing charge (only if unpaid)'.
20. Repeat steps 6 to 9.
21. Go back to Patron A's account. Both the lost item fee and processing
fee should have been refunded.

22. Repeat steps 16 to 19.
23. Go back to Patron A's account. The lost item fee should have been
refunded but not the processing fee, as this was already paid.

Test with lost item - leave

24. Go to Administration -> circulation and fines rules. Scroll down to
the default lost item fee refund on return policy. Notice there is now a
refund lost item processing fee policy. Set this to 'leave lost item
processing charge'.
25. Repeat steps 6 to 9.
26. Go back to Patron A's account. The lost item fee and processing fee
should have been refunded but not the processing fee.

Other tests

27. Confirm tests pass
- t/db_dependent/Koha/Item.t
- t/db_dependent/Koha/CirculationRules.t

Sponsored-by: Auckland University of Technology

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-24 17:43:29 -03:00
Aleisha Amohia
ea8c2959da
Bug 23012: Set policy for lost item processing fee
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-24 17:43:29 -03:00
Aleisha Amohia
974359ed85
Bug 23012: Show the PROCESSING_FOUND account credit type
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-24 17:43:28 -03:00
Lari Taskula
d718ac8dbd
Bug 22321: Allow managing the borrowernumber tied to ILL request
Sometimes an ILL request is connected to the wrong borrower, and it
would be nice to be able to connect it to the right one.

In Swedish ILL the cardnumber of the patron connected with an ILL
request is entered into the central Libris system and then propagated
to Koha through the Libris API. This can lead to errors, and we have
created a dummy "ILL patron" to catch these. It would then be good
to be able to connect the ILL to the right patron in Koha.

This commit makes it possible to edit illrequests.borrowernumber.

To test:
1. Apply patch
2. Create two patrons, A and B
3. Create a new ILL request for patron A
4. Add a hold for patron A where biblionumber is the biblio tied
   to this ILL request
5. Go to
cgi-bin/koha/ill/ill-requests.pl?method=edit_action&illrequest_id=161
6. Observe Patron ID is editable
7. Change borrowernumber to patron B's borrowernumber
8. Click save
9. Observe ILL request is now for patron B
10. Go to patron B's details at
cgi-bin/koha/members/moremember.pl?borrowernumber=B_borrowernumber
11. At the bottom section of the page, click 1 Hold(s)
12. Observe the hold you placed at step 4 has transferred to
    patron b

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-24 17:33:16 -03:00
246658a04a
Bug 31553: Ensure news item content field is always editable
Set a padding at the bottom of the news item editor body.

This is a tricky bug to replicate.

Test plan:
1. Set 'AdditionalContentsEditor' syspref = 'a WYSIWYG editor
(TinyMCE)'.

2. Select multiple languages in the 'OPACLanguages' system preference.

3. Go to: Tools > News.

4. Create a new news item. Switch between the different language tabs.

5. Confirm you can always input into the content field in all languages.

6. Edit an exiting news item. Switch between different language tabs.

7. Confirm you can always input into the content field in all languages.

Sponsored-by: Toi Ohomai Institute of Technology, New Zealand

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-24 17:32:35 -03:00
Katrin Fischer
7c4dfc6d6c
Bug 31730: (QA follow-up) Only link category name
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-24 17:31:11 -03:00
8e739ab00c
Bug 31730: Link to authorized value interface when an authval is mentioned in preferences
This patch adds links to the authorized value interface anywhere an
authorized value category is mentioned in a system preference
description.

To test, apply the patch and go to Administration -> System preferences.

- Check these preferences:
  Circulation -> ILLHiddenRequestStatuses
  Circulation -> BundleLostValue
  Circulation -> BundleNotLoanValue
  Circulation -> ClaimReturnedLostValue
  Accounting -> RequirePaymentType
- Confirm that the link in the description of each preference takes you
  to the correct authorized value category.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-24 17:31:11 -03:00
Aleisha Amohia
ffe47b2cb0
Bug 7960: Add class to item type descriptions so they can be hidden with CSS
This patch adds the class "itypetext" around item type descriptions so
they can easily be hidden with CSS.

To test:
1. Navigate to the pages listed below to confirm that the text
descriptions do show.
2. Add
.itypetext { display:none; }
to IntranetUserCSS and OPACUserCSS system preferences and save.
3. Go back to the pages listed below and confirm that the text
descriptions DO NOT show.

= STAFF CLIENT =
 - catalogue/advsearch.tt
 - catalogue/detail.tt
 - catalogue/results.tt
 - reserve/request.tt
 - virtualshelves/shelves.tt
= OPAC =
 - opac-advsearch.tt
 - opac-detail.tt
 - opac-readingrecord.tt
 - opac-reserve.tt
 - opac-shelves.tt
 - opac-user.tt

Refer to David Nind's test notes from Comment 23 for a more detailed
plan for acessing these pages.

Sponsored-by: Catalyst IT

Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-24 17:27:50 -03:00
eeead6443f
Bug 31940: Add page-section to library-groups
This patch adds the page-section div around each library-groups table.

Test plan
1) Check that the 'card' views appear appropriates on the library groups
   maangement page

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-24 17:25:54 -03:00
Caroline Cyr La Rose
1ccf21159b
Bug 31923: Add warning sign and span
This patch adds a small warning sign before the sentence and also puts
the sentence inside a span.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-24 17:25:01 -03:00
Caroline Cyr La Rose
0890413d27
Bug 31923: 'Ignore' tab description is misleading
This patch modifies the description of the 'Ignore' tab in
MARC bibliographic and authority framework administration
to add that not only does the 'ignored' subfield not appear
in the editor, but the subfield will also be deleted from the
record.

To test:
1. Go to Administration > MARC bibliographic framework
2. Click 'Actions' next to any framework and choose 'MARC structure'
3. Click 'Actions' next to any field and choose 'Edit subfields'
4. Check the hint/description under 'Managed in tab' and make sure it
   - makes sense
   - is written in correct english (syntax and spelling)
   - mentions that the subfield's value will be deleted from the record
5. Go to Administration > Authority types
6. Redo steps 2-4 for authority frameworks

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-24 17:25:00 -03:00
David Nind
fea57940dd
Bug 31931: Terminology for HoldsSplitQueue - use staff interface
Rename "..staff client.." to "..staff interface.." in the description for the
HoldsSplit Queue system preference, as per the terminology guidelines.

Test plan.
1. View the description for the HoldsSplitQueue system preference.
2. Note that the description says "..staff client..".
3. Apply the patch.
4. Note that the description now says "..staff interface.." as per the
   terminology guidelines (https://wiki.koha-community.org/wiki/Terminology#S).
5. Sign off :D

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-24 17:16:28 -03:00
7d33066caa
Bug 31906: Compiled CSS
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-10-24 17:12:05 -03:00