Commit graph

11534 commits

Author SHA1 Message Date
Colin Campbell
5a087678da Bug 4133 Amend kohastructure to reflect earlier patch
updatedatebase is now setting aqorders.quantityreceived to NOT NULL
kohastructure needs bringing into line

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 11:47:05 -05:00
Colin Campbell
d3e2de3625 Bug 3810 Mail::Sendmail should not fail silently
The return from Mail::Sendmail should always be checked
Output the error message if it fails so we have some
indication of where to start looking if it fails

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 11:39:22 -05:00
a8564dbcf1 Fix for Bug 4093, OPAC Suggestions List has extra column
- This code was added to opac-suggestions.pl at one point by
  Garry Collum and was subsequently removed. Adding it back.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 11:37:05 -05:00
Chris Nighswonger
7b1a3d1ae8 Bugfix: Fixing issues with the patron card pdf rendering code
This patch fixes two bugs:

1. Correcting the text alignment alogrithms for center and right alignment

2. Changes a reference to layout to a copy of the layout to avoid performing
operations on the layout.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 11:25:49 -05:00
Colin Campbell
745ac87c20 Bug 4133 Ensure that orders have a valid quantity received
quantityreceived drives other parts of acq noticeably budget balances
ensure that a number (usually 0) is set in NewOrder
give field a valid default and set as not null
reinterpret exsting nulls in table as zero

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 11:21:48 -05:00
dd4f7a87d5 Fix for Bug 2869, 'do not delete' marc framework tag - reverts to 'default' framework
- "Do not delete" form was missing hidden framework code input.
- Also added details to breadcrumb navigation

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 10:50:21 -05:00
dae8244a03 Fix for Bug 4136, Invalid XHTML in spinelabel-print view
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 10:39:08 -05:00
b6b6be8e23 Markup error, closing tag missing
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 10:17:03 -05:00
Colin Campbell
55e9ac2ad3 Bug 3697 Return due date (SIP Field AH) in item info
Although the due date of an on loan item was being retrieved
the appropriate field in the Item object was not set
causing the due date not to be returned in the item
information response

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 10:13:43 -05:00
Colin Campbell
fb3f7966b4 Cleanup date handling in routing.pl
Remove dead code
Clarify the loop assigning dates
Remove the cause of undef warnings in the log

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 10:12:35 -05:00
Colin Campbell
d7c4412741 Add dependency Authen::CAS::Client
Required CPAN module was missing from deoendency list

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 10:00:59 -05:00
Colin Campbell
db511d897b Fix count in supplier dropdown in serials/claims.pl
Previous patch still used old variable name to get count causing
incorrect value to be returned

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 10:00:06 -05:00
Colin Campbell
e2e7f0d050 Correct misleading text
Some koha acq terminology is confusing to new users so lets at least
be consistent in our usages we are adding to the basket here not an order

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 09:54:59 -05:00
d4678b363a bug 2576 - fix XHTML validation errors generated by previous commit
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 09:14:59 -05:00
Jane Wagner
0e7fa3edbd Bug 2576 reopened -- turn off fines elsewhere in OPAC account
The original patch allowed use of the OPACFinesTab syspref to turn off
the Fines tab in the OPAC patron record.  However, a column for fines
still appears in the listing of overdues, and as a tab on the line with
Overdues, Holds, Fines, etc.  This patch turns off the other instances of
fine columns/displays if the syspref is off.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 09:12:33 -05:00
372ebb8bdd set koha_login_context in order to get auto-login for SCO working
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 09:01:25 -05:00
5c88458217 DB rev 114 - tweak AutoSelfCheckAllowed, AutoSelfCheckID, and AutoShelfCheckPass
* made AutoSelfCheckID and AUtoSelfCheckPass type free instead of textarea
* consolidated DB updates into one

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 08:47:13 -05:00
Jane Wagner
f52c54eb35 Bug 3738 Automate login to web-based self-check system
Some small, single-branch corporate and special libraries use unattended self-checkout stations, and would like to automate the staff login, so that just going to the sco/sco-main.pl URL would bring the self-check up ready for patron use.  This patch create three sysprefs, AutoSelfCheckAllowed, and AutoSelfCheckID/AutoSelfCheckPass. If the site wants to allow automated login, staff would then need to create the selfcheck user record and enter that login ID and password into the sysprefs.  The kohaclone/opac/sco/sco-main.pl script has been modified to check these sysprefs and pass values (if present and allowed) into the self-check URL.  The URL then bypasses the staff login page and comes up ready for checkout, waiting for the first patron barcode.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 08:43:07 -05:00
ff4d456072 Bug 3920 - Add 2 syspref to activate XSLT use in OPAC/Intranet
- Add two syspref:
  - OPACXSLTResultsDisplay
  - OPACXSLDetailsDispay
- Add them to .pref files and dispatch them beetween OPAC and Search
  tab.
- Upgrade DB version to 3.2 .113
- Fix something wrong in UNIMARCslim2intranetDetail.xsl
- Display OPAC result and detail pages using those syspref.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 08:08:44 -05:00
Matthias Meusburger
88e99d1c29 BZ4104: Removes tagging in staff client
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 07:59:46 -05:00
Garry Collum
fd2bf6043b Bug 3752: Fixed XHTML errors in opac-MARCdetail.tmpl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 07:48:44 -05:00
Garry Collum
c6805cea9d Bugs 3646 and 2651: Changes the output of compact.xsl from html to xhtml.
Changes the output of compact.xsl to XHTML for catalogue/showmarc.pl?viewas=card.

Adds <title> element in <head>.
Removes link to nonexistent css file (bug 2651).

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 07:48:39 -05:00
Nicole Engard
96e4e27b42 bug 4129 fix display of html on the overdue report
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 07:39:57 -05:00
Garry Collum
2e6ea2d4cd Bug 3662: Invalid XHTML in update-child.tmpl - resubmission.
Missing </td> closing tag.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 07:39:55 -05:00
Nicole Engard
1f5d1299b0 bug 3923 OrderPdfFormat default was wrong on update
I went back and updated updatedatabase so that anyone else who updates
doesn't end up with the wrong value, this does not fix those who
upgraded and have the wrong value in there already.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 07:39:52 -05:00
Chris Cormack
a319a402f7 Removing noisy warn in C4/XSLT.pm
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 07:39:50 -05:00
Chris Nighswonger
0be8d0ac9d Bugfix: Correcting conditional for branch code check
Also removing needless conditionals on redirects.

Thanks to Braedon Vickers for catching the incorrect conditional.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 07:39:48 -05:00
Colin Campbell
c3d1b33a2a Remove cause of some warnings in order display
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-08 07:39:46 -05:00
5916908e35 Bug 4125 - Reformat with perldoc bulkmarcimport.pl doc
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-06 08:06:07 -05:00
e1b19d70d0 Fix for Bug 4113, Failed renewal from circulation screen results in malformed table
Renewal failure message should appear in renewal checkbox column just
like it does in moremember.tmpl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-05 19:00:27 -05:00
Garry Collum
0f51522c08 Bug 4114: Follow-up patch for duplicate id in opac-detail.
Adds the id back in <body>.  Renames the id in <div>.

The only reference to this id was in sanop.css, to which opac-detail.tmpl does not link.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-05 19:00:25 -05:00
Garry Collum
bcb675ea82 Bug: 4124 - Submit button in csv-profile.tmpl floats to the right.
Typo - class='actin' should be class='action' in the <form> tag.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-05 19:00:23 -05:00
Nicole Engard
d5becca661 bugs 3989, 3990, 3996, 3997 - sys prefs resolved
bug 3989 - RoutingSerials & RenewSerialAddsSuggestion
moved to serials tab and descriptions updated

bug 3990 - add RoutingListAddReserves pref to serials tab

bug 3996 - add intranetbookbag pref to staff client tab

but 3997 - add ReservesControlBranch to circulation tab

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-05 10:14:55 -05:00
Nicole Engard
43999254e0 bug 3993 & 4119 add WebBasedSelfCheck pref to interface
bug 4119 - add WebBasedSelfCheck to sys pref interface
bug 3993 - added quotes around OpacMaintenance description so it appears

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-05 10:14:48 -05:00
Nicole Engard
2424e90f5c bug 4033 add missing OverdueNoticeBcc to the interface
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-05 10:14:43 -05:00
Nicole Engard
2a3e2ed341 bug 3994 & 3995 add missing OPAC privacy preferences to interface
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-05 10:14:37 -05:00
Nicole Engard
9e12b8ed70 bug 4087 add missing OpacAddMastheadLibraryPulldown to prefs interface
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-05 08:55:52 -05:00
Nicole Engard
4f50aa20da bug 3986 add CAS preferences to interface
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-05 08:55:50 -05:00
43e10c37d7 added subscription.enddate to kohastructure.sql
kohastructure.sql update missed in DB rev 3.01.00.071

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-05 08:48:10 -05:00
Colin Campbell
c3c732f4bc Bug 4117 Fix system error in routing slip recepients popup
order_by parameter should be an arrayref of hashrefs
Have made order surname, firstname asc (see bug 4067)
do not generate logged warnings by manipulating undef

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-05 08:31:39 -05:00
Nicole Engard
8b9cf29057 bug 3985 add missing acq preferences
This patch adds AcqCreateItem, CurrencyFormat, gist, and OrderPdfFormat back into the sys prefs interface.

Still missing are acquisitions, OrderPdfTemplate, and emailPurchaseSuggestions.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-05 08:31:38 -05:00
740814d951 corrected POD for GetMember()
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-05 08:24:11 -05:00
513c76121c fixed remaining calls to GetMember() that used old argument style
New way, correct way to use GetMember is

GetMember(field => fieldvalue[, field2 => field2value ...]);

e.g.,

GetMember(borrowernumber => $borrowernumber);

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-05 08:24:05 -05:00
b0f4d7104c removed unconditional warn
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-05 08:23:55 -05:00
Colin Campbell
e321fc9184 Bug 4108 Catch cases when GetMember is generating errors
Fixed two calls where new interface was not used
Arguably new syntax allows more options than we require but it was not catching
error cases (when 0 or undef is passed). It also can now be called in ways
which would validly return multiple hits but explicitly does not
(nor does calling code expect this)
This patch should quieten the flood of errors

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-05 07:57:26 -05:00
f93ee104de finished add SpineLabelShowPrintOnBibDetails (DBrev 112)
* improve wording
* add to new system preferences editor

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-05 07:36:23 -05:00
Kyle M Hall
879d7f0e6b Bug 1248 - Add a "quick spine label" print to the bib item page in cataloging
Turn on the system preference SpineLabelShowPrintOnBibDetails and a link for the spinelabel printer will appear for each item on catalogue/detail.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-05 07:36:09 -05:00
1ba0fd9d7c added two new intranet directories to installation list
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-05 06:50:06 -05:00
Chris Nighswonger
822c2d21e1 Bugfix: Fixing a broken link in the patron card layout editor
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-05 06:37:10 -05:00
Garry Collum
5bf6409939 Bug 4114: Fixes duplicate id definition in opac-detail.tmpl
Removes "id=opac-detail" from <body> tag.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-05 06:37:09 -05:00