There was a missing ' in the value of the NoZebraIndexes syspref. This
patch fixes it.
It's not necessary to fix the existing settings because
C4::Biblio::GetNoZebraIndexes is liberal enough to be able to parse even
the deformed value.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Various fixes to meet coding standards, template
design, and basic functionality:
* (bug 2505) turned on warnings
* use correct loop names when populating
$template
* put all TMPL_FOO in HTML comments
* assign UseBranchTransferLimits to circulation tab
* change template to use "library" instead of "branch"
* use standard YUI scripting for toolbar buttons
* add new script to admin menu
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This patch cleans up kohastructure.sql a bit:
* moved the table definition to above the ending comments
* added a "drop table..." statement
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Added syspref to updatedatabase.
Updated kohastructure.sql with the limits table.
Signed-off-by: Andrew Moore <andrew.moore@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Fixed invalid test for the existence of CGI parameter; if it
is possible that the value of a parameter can be 0, it is
not sufficient to test like this:
if ($input->param('foo')) { ...
since the test will fail for *any* value that evaluates
to Perl false.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This allows the user to edit system preferences from the main system
preferences screen, rather than having to dig down into each
preference.
[This patch includes some modifications by Galen Charlton
to fix XHTML validation errors and a couple errors that
would crop up under warnings.]
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This patch adds two warning messages to places in the test suite that
may fail. I don't think it changes any functionality, but it sure makes
it easier to figure out what has gone wrong.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
The problem was that the TmplTokenizer create global symbols to store file
handlers so the objects aren't destroyed by the garbage collector.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
As rss.pl is not a CGI script, moved it to join the
other cronjobs. Full documentation of the script
is in misc/cronjobs/rss/rss.pl, but to summarize:
[1] rss.pl is run on the command line to produce
an RSS XML document. The output should be
placed in a directory accessible to the OPAC
(or staff) web interface so that users can download
the RSS feed. An example of usage:
misc/cronjobs/rss.pl lastAcquired.conf
Normally rss.pl should be run periodically (e.g., daily)
to keep the feed up-to-date.
[2] The configuration file (e.g., lastAcquired.conf) lists
* name of the template file to use
* path of output file
* SQL query
rss.pl runs the SQL query, then feeds the output of the
query through the template to produce the output file.
[3] The template file (e.g., lastAcquired.tmpl) uses
HTML::Template syntax like any of the HTML
templates for the web interface.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Restored basic functionality of rss/rss.pl:
[1] Reverted "Add support for itemtypes. Still need to hardcode 'reservable'"
Revert commit e7575b00ed, which had
replace the script with one of its templates.
[2] Minor fixes to update it, including using HTML::Template::Pro instead
of HTML::Template, perltidy, and turning on warnings.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Because of a query on biblioitems.issn in
C4::Breeding::ImportBreeding(), libraries doing a lot
of bib imports were experiencing performance problems,
which adding an index will alleviate.
A possible longer term solution is to index all
reservoir/import batch records in a Zebra database.
[LL bug 232]
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
The bug throw because the booksellerid is not in the request, and the newordersuggestion.pl need this one to import
it in a new order.
So I just added an hidden input in the search form.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This plugin use the 'ISBN' field(010$a) to search the "publishercode"(editor) and set it in as 210$c.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Add the phrase 'if ( $verbose_logging )' to the two print statements
concerning the skipping of biblio or authority records.
I recently had to split biblio and authority index updating in my cron
script ( had some really big records so had to add the -x switch which
should only be used on biblios accourding to the help ). So I noticed
that rebuild_zebra.pl printed messages that it was skipping biblios or
authorities.
This patch is to conditionalize those prints based on the verbose
logging switch.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
first part of this patch is the manual history must be checked if in database its checked.
Then, when you do not enter a value "Next issue publication date", a null value was set in the database, now, if empty, the "first issue date" is set as "next issue".
And finally, We check that "manual history" is checked to show the "Subscription history" part. Actually its never shown.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This patch fix a missing ; in javascript, that open the renew popup. Instead it open it in the current window.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
this patch delete the last char of the returned string, that is not conform to unimarc, only one blankchar must be at the end of
the leader string.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
svc/bib and svc/new_bib had two problems related to UTF-8 character conversion:
[1] Couple instances of "Wide character" warnings
[2] When saving a new (MARC21) bib whose Leader/09 was not 'a', did not apply
default character conversion and set the Leader/09 to 'a'.
Fix includes two parts:
[1] Setting :utf8 on STDOUT
[2] Doing default MARC-8 to UTF-8 conversion if applicable
This patch also turns on warnings in all scripts under svc per bug 2505.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Also fixed case where HTML could have unclosed <form> elements,
leading to warnings in the error log when accepting pending
or rejected suggestions.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This adds notification code to Reserves.pm to send notifications through email
or SMS to patrons when their hold is filled. It does not send the letter
directly, but instead uses EnqueueLetter. Also, it relies on
EnhancedPatronMessaging being on and the hold notification being turned on for
the specific patron through the 'Messaging' tab.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Code changes to display the priority level on holds in OPAC. Turned on/off based on System Preference. Database changes to systempreferences for both English and French
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Use 'patronid' instead of 'userid' as the query parameter
for passing the patron userid or barcode around; 'userid'
is claimed by C4::Auth and should be used only for
authentication pages.
Fixes the problem where entering a patron's card
number would cause a redirect to the OPAC login
page.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Patch also removes a hard-coded English string from the script and some unused functions from sco.js.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Two recent changes to updatedatabase.pl don't include newlines at the
end of their status messages. This patch adds them. This is only useful
if you're running this from the command line.
Note: there is an opportunity here to extract some of the simlar logic
from each of these blocks to a function.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Code change actually occurs in opac-addbybiblionumber.pl accessed via opac-detail.pl.
Bug fix allows for users to select the 'save to lists' link and add item
to their private, public and all open lists. Previously, only private
and open lists were retrieved and listed.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
The conditional assignment previously was:
$norequests = 0 && $norequests if ....
The execution of "0" served no purpose.
Also consolidated RequestOnOpac logic to the one line that cared about it.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Fixes problem where if the IssuingInProcess preference is ON,
the operator is always required to confirm a checkout if
the patron has had any fine transactions at all, even if
the patron's balance is 0.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
