Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Tomás Cohen Arazi	870ef9e2d9	Bug 26577: Make basket.pl and cancelorder.pl use ->cancel This patch makes the mentioned controller scripts use the new $order->cancel method instead of DelOrder. To test: 1. Apply this patches 2. Have a basket with some orders 3. Play with cancelling orders and removing baskets => SUCCESS: No behaviour change! => SUCCESS: No errors! 4. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Julian Maurice	96cc447045	Bug 25898: Prohibit indirect object notation Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Jonathan Druart	638786e719	Bug 24663: Remove authnotrequired if set to 0 It defaults to 0 in get_template_and_user Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Aleisha Amohia	3bdee4a05f	Bug 13208: [FOLLOW-UP] Creating and implementing new Koha::Acquisition::Basket[s] modules Test plan remains the same. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Bourgault <david.bourgault@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	7 years ago
Aleisha Amohia	639d7f308f	Bug 13208: Improving breadcrumbs for when cancelling an order To test: 1) Go to Acquisitions -> Find a vendor -> View a basket with orders in it (or make a new basket and add an order) 2) Click Cancel order 3) Notice incomplete breadcrumbs, and 'Acquisition' typo 4) Apply patch and refresh page 5) Breadcrumbs should be fixed. Confirm links to vendor and basket work as expected Sponsored-by: Catalyst IT Signed-off-by: severine.queune <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Bourgault <david.bourgault@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	7 years ago
Julian Maurice	59bcdb0b25	Bug 7162: Factorize code for order cancellation (QA fixes) Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Julian Maurice	d3b2c85df8	Bug 7162; Factorize code for order cancellation (QA fixes) * Remove tab characters in acqui/addorder.pl * Remove FIXME in acqui/cancelorder.pl * Fix typos: "canceled" -> "cancelled", "occured" -> "occurred" * Replace "Click here" link by "OK" * Add a column to aqorders to store cancellation reason instead of having it in aqorders.notes, to avoid having untranslatable strings in database Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Julian Maurice	c4aaca9496	Bug 7162: Factorize code for order cancellation Some code was duplicated, all is now in cancelorder.pl Added possibility to provide a reason for cancellation (or other things, this is saved in aqorders.notes) Signed-off-by: Corinne Bulac <corinne.hayet@bulac.fr> Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	13 years ago
Tomás Cohen Arazi	afd2418d73	Bug 11349: Change .tmpl -> .tt in scripts using templates Since we switched to Template Toolkit we don't need to stick with the sufix we used for HTML::Template::Pro. This patch changes the occurences of '.tmpl' in favour of '.tt'. To test: - Apply the patch - Install koha, and verify that every page can be accesed Regards To+ P.S. a followup will remove the glue code. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Mathieu Saby	36074fba65	Bug 9416: add new order vendor note field Currently, there is a single note field in each order. It would be useful to have 2 notes fields: - one for the staff (ex: "catalog this book as soon as possible") - one for the vendor (ex: "urgent", "only the 2d volume"...), which could later be printed in basketgroup pdf for example This patch adds a new note made for vendor in each order. The existing note is renamed "internal note". The behavior of the 2 notes are the same Changes in database structure: - new column aqorders.order_vendornote - column aqorders.notes renamed aqorders.order_internalnote To test : [1] Make a complete acquisiton process (creating the order > looking at the basket > looking the order > receiving); and try to use the 2 notes (internal note / vendor note) [2] Check the changes made on one page (eg detail of the order) are saved and visible on an other page (eg receipt page) Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Testing notes on last patch. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Jonathan Druart	692ee0e9da	Bug 7166: Adds edit order notes when the basket is closed When you are on parcel.pl or basket.pl you can now add or edit a note for each order. To test: Create orders with and without note. Edit/Add the note on basket.pl page Close the basket. Check you can add/edit the order note on parcel.pl page + From Owen: Correcting markup issues with modordernotes.pl: - Adding "rows" and "cols" attributes to <textarea> (required) - Converting cancel button to link to stay consistent with other pages - Changing page layout to fixed & centered (not sidebar needed) - Expanding information in breadcrumbs to match information on basket.pl Changing markup around note add and edit links: Moving output of order note to the end of the table cell, putting it in its own paragraph, and adding a "Note:" label Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	12 years ago

8 Commits (6a403dec40fd89f08d9fcb478e27e5fb23ec6d73)