Commit graph

8228 commits

Author SHA1 Message Date
Joe Atzberger
70829660c2 Bugfix 2026 - Comments handling overhauled. Scrubber and Error feedback added.
Note: we CANNOT rely on window.close in onSubmit or $().submit to close our popups.
On a relatively slow connection with a relatively large POST, commonly the close finishes
*before* the POST completes, as reported with our New Zealand clients.  Despite success in
trivial cases, this should be obvious, since the event is necessarily before the submission.
It also assumes success and prevents any kind of error feedback.  Other popups are likely
to exhibit this same defective behavior.

Some FIXME's outstanding: need to allow users to delete their own comments,
need to enforce and feedback on max comment length.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 06:51:58 -05:00
Joe Atzberger
74d3dc35ee Bugfix 1978 - if invalid duedate specified, return error, do not issue.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 06:40:06 -05:00
Michael Hafen
e08e6a01c3 fixed session cookie name in opac-logout.pl
Session Cookie name is CGISESSID in Auth.pm

Signed-off-by: Michael Hafen <mdhafen@washk12.org>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 06:32:52 -05:00
Joe Atzberger
1ebc373d18 Unescape Comment, now that we trust Scrubber to block bad markup.
Obviously if we are going to allow good markup, we can't then escape it.
Documentation reference: allowed tags for comments are:
	br b i em big small strong

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 06:30:51 -05:00
Joe Atzberger
7ca4d31e82 Tags AJAX and JSON for OPAC side.
Note, all Tags js will live under KOHA.Tags namespace.
See opac-tags.pl perldoc for AJAX/JSON examples.  The capability is already
there to be very web-servicey, even moreso than the current OPAC implementation
will utilize.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 06:25:17 -05:00
Joe Atzberger
1e50ed05cb Single slash added in test text string.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 06:22:50 -05:00
Joe Atzberger
0626e743ec Add error feedback and Scrubber to OPAC tags page. Beginnings of ajax code.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 06:22:47 -05:00
Joe Atzberger
bbb3f00955 Initial commit for Tags back-end moderation. Requires AJAX functions from Output.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 06:22:44 -05:00
Joe Atzberger
cbabfaaa5f New subs for moderation, fixed bug to allow multiple sort fields, added POD.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 06:22:43 -05:00
Joe Atzberger
ec5c3d0ee2 Add AJAX output sub, EXPORT_TAGS and enable loop_context_vars for HTML::Template::Pro.
The loop_context_vars will be very useful in display.  They are:
__first__, __last__, __inner__, __odd__, __counter__.
Note: apparently __even__ does not exist, so instead use something like:
<!-- TMPL_UNLESS NAME="__odd__" -->

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 06:22:41 -05:00
Ryan Higgins
c64f8f8bac Add cn_source to authorised values dropdown in marc structure editor.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-29 06:17:55 -05:00
Paul POULAIN
62fe8fde13 small update to french translation
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 07:37:22 -05:00
Paul POULAIN
895153cfd8 fixing the css property for tablesorter js
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 07:37:21 -05:00
Paul POULAIN
c07939757f BUGFIXING authority link in detail.pl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 07:37:20 -05:00
Paul POULAIN
94a3a247f1 small fix for UNIMARC 600$a that is also subject
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 07:37:19 -05:00
Paul POULAIN
778f3f3a24 Adding Image::Magick version info
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 07:37:18 -05:00
Ryan Higgins
dc7a542deb Update Catalog Stats report: / Remove lccn/loc filter, which seems to conflate marc21 010 and 050. / Update labels to reflect 3.0 terminology.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 07:33:32 -05:00
Ryan Higgins
302da68ce5 Fill statistics table properly for renewals; and issue->checkout, return->checkin
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 07:33:30 -05:00
Ryan Higgins
561e9437eb Add ANSCR to default cn_source list.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 07:33:23 -05:00
Ryan Higgins
1aa00400c4 Fix pagination error on subfield structure editor
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 07:33:22 -05:00
Ryan Higgins
f924ff5fe7 add URLLinkText syspref to opac detail, and add some extra handling for MARC 21 urls.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 07:33:21 -05:00
Ryan Higgins
d82ff15814 Show 856$3 (materials specified) by default in MARC21 .
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 07:33:17 -05:00
Ryan Higgins
5f98f2371e Update MARC21 simple frameworks with biblio.serial and items.enumchron
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 07:33:16 -05:00
21255a2416 Translatable facets in librarian interface
Pushes modified facets display from OPAC to librarian interface.
Corrects also OPAC version which were omitting Titles facet.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 07:26:33 -05:00
1bf93a36db Facets (current) translatable via template
This patch allows to translate facets label with standart
templates / PO files. Facets are still hard coded in Koha.pm.
Template wait those hard coded facets: Topics, Places, Titles,
Autors and Libraries.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 07:26:31 -05:00
Andrew Moore
5838b70b06 removing warnings from C4::Members::GetMember
C4::Members::GetMember emitted a few unnecessary warnings when no $type was passed in. This patch prevents that.

No functional or documentation changes.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:52:17 -05:00
Andrew Moore
e8fdac8d84 Bug 2047: some tests for C4::Biblio::get_biblio_authorised_values
I had these tests laying around for a while. I just forgot to commit them.

No functional or documentation changes needed.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:52:13 -05:00
b853e6bd10 Adding bookfund search to aqbudget.tmpl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:51:30 -05:00
5d980853b0 Adding routing list link to table of information about each subscription (Bug 2059, "Link to Serial Collection routing list missing on menu")
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:51:24 -05:00
dcd12da0e0 Fix for bug 2130, "Patron Image Missing on Permissions Screen"; Correction to allow proper tab highlighting when viewing patron log.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:51:23 -05:00
922e8fc061 Fix for Bug 2120, "
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:42:56 -05:00
eb09aac059 Authorities detail page was missing toolbar, breadcrumbs.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:42:53 -05:00
795d9d5605 Markup error caused layout problems.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:42:52 -05:00
dec7a7115d Structural changes to staff client main page to better handle layout changes with addition/subtraction of news and intranetmainuserblock markup.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:42:47 -05:00
bcca5c9584 Terminology correction: cancelled -> withdrawn. Also adding dateformat variable to new holds queue script to allow correct table sorting with metric dates.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:42:46 -05:00
5675b8d5e4 Adding breadcrumbs to advanced search screen to get us a Home link.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:42:45 -05:00
97becad914 Adding table sorter to holds queue report
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:42:42 -05:00
bcc56e6827 Tweak to OPAC search bar to help prevent wrapping.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-27 06:42:10 -05:00
db2f86c61f Minor change to improve layout at lower resolutions.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-20 14:41:48 -05:00
bfcdfb7f45 Interface improvements to Holds Queue report and changes to the script provided by jmf
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-20 14:41:44 -05:00
ff96846978 Fix for Bug 2147, "Search Results aligned top on staff side."
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-20 14:41:43 -05:00
62391ab1d7 Fix an encoding issue on circulation autocompletion
ysearch.pl returns a list of borrower details for circulation
autocomplete widget. Accented characters wasn't displayed
correctly.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-20 12:55:08 -05:00
Paul POULAIN
b9ecd65610 fix for #1788 : Locations do not sort alphabetically by name in list on "Set" location
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-20 12:55:07 -05:00
Paul POULAIN
86e53a9f40 bugfixing batchupdateISBN.pl
pls, someone from MARC21 confirm.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-20 12:55:06 -05:00
Galen Charlton
171f7ed912 various bugfixes for MARC21 Z39.50 targets
[1] Added MARC-8 as an encoding choice on the target
    administration page.
[2] Fixed TMPL coding errors.
[3] Set the correct encoding (as it happens, 'MARC-8')
    for all of the English sample Z39.50 targets.

Documentation note: due to this patch and the ones from
Frederic, screenshots of the page for editing a Z39.50
target should be redone.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-20 12:55:05 -05:00
Galen Charlton
e3f473187e kohabug 2048 - improve zebraqueue_daemon performance
[1] Increase sleep interval between checks of zebraqueue
    from 0.01 seconds to 0.50.
[2] Batch up commits of changes to the zebraqueue table
[3] If the same record appears multiple times in the queue,
    handle only once.
[4] Properly postpone failures to process record deletes to
    avoid spinning.
[5] Correct how queue entries are marked done - avoid skipping
    an authority record update, e.g., if it has the same
    ID number as a bib that was updated.
[6] Added a FIXME about a possible later enhancement to
    batch up updates so that Zebra isn't told to commit
    after each record.

No documentation changes.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-20 12:55:04 -05:00
709619013d Allowing delete-biblio menu item to trigger javascript warning. Style now mimicsa disabled menu item. Addresses Bug 2135, "Cannot Delete MARC Records."
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-05-20 12:52:04 -05:00
Joshua Ferraro
2ee27fb1cc Final update to holds queue work: adds link to holds queue
from circulation dashboard, creates new sysprefs, assigns
the sysprefs to the proper tab in sysprefs (Circulation),
updatedatabase changes to do the previous, and fixing one
redundent limit in the query for build_holds_queue.pl

Note: still need to address item-level holds
2008-05-20 12:36:40 -05:00
Joshua Ferraro
a9a4965277 Adds a cron script to be run periodically that populates
the tmp_holdsqueue table. This is an alternative holds
targeting workflow that is more suitable for multi-location
libraries than the default holds picklist report.

Note to documentation writers: this summary should be
added to any holds documentation as an overview of
the avaialable methods for holds fulfillment.

This alternative holds workflow assumes an
expectation that the system should target a specific
item for a given hold request, attempt to fulfill the
hold with that item, and if unable to fulfill, select
an available item at another location to fulfill the
hold.

This is quite different than the default Koha behavior
which uses a 'broadcast' method of hold fulfillment.

How it works:

This script weights available locations for holds based
on options specified in two system preferences:

StaticHoldsQueueWeight
	Allows the library to specify a list of library
	location codes -- if used alone, it will rank the
	list statically, selecting the top-ranking available
	location to be added to the picklist.

RandomizeHoldsQueueWeight
	If RandomizeHoldsQueueWeight and StaticHoldsQueueWeight
	are set, the list of library codes in the
	StaticHoldsQueueWeight syspref are randomized rather
	than statically ranked. If RandomizeHoldsQueueWeight
	alone is set, the list of all available library codes
	is used to randomize the weight.

If neither syspref is set, the list is statically
ranked according to how they are pulled out of the system
database.

NOTE: This has not yet been tested with item-level holds
2008-05-20 10:58:24 -05:00
Joshua Ferraro
725e822aed DB Update .086: adding new table tmp_holdsqueue,
used for reporting picklist for holds in multi-location
libraries. This is a temporary workaround to a longer-term
post-3.0 cleanup of the holds process.

Following this will be a cron job for managing the
holds picklist queue as well as a report for viewing
the list of items from circulation
2008-05-20 09:36:26 -05:00