Commit graph

1500 commits

Author SHA1 Message Date
Joe Atzberger
e7ea6196e6 Members.pm - respond to $debug, some formatting and reduction of duplicative code.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-04 17:37:15 -06:00
Joe Atzberger
94c4c7c1f7 Auth_with_ldap : module and test final touches.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-04 17:28:21 -06:00
Joe Atzberger
a462c8939e LDAP - further integration
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-04 17:28:19 -06:00
Joe Atzberger
a5e0283cdd Log.pm: reduce duplicative code in conditional
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-04 17:28:16 -06:00
Joe Atzberger
9b062e128c Auth.pm -- just the start of trying to make Auth intelligible and extensible
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-04 17:27:08 -06:00
Joe Atzberger
009819b1db Dates.pm -- Comment and perldoc cleanup.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-04 17:27:07 -06:00
Joe Atzberger
d88ecc0751 Big LDAP changes, module test for Context.pm, still more yet to come.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-04 17:27:06 -06:00
Joe Atzberger
af14810bac Context.pm: obvious code consolidation, perldoc corrections.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-04 16:03:26 -06:00
Joe Atzberger
a428b49167 Letters.pm: Minor change. Unsure if this is "the right" move, but pretty sure the line does not make sense as is.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-04 15:45:51 -06:00
Chris Cormack
54e6cf71e3 Fix for renewing
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 17:26:28 -06:00
Chris Cormack
4a373f27b0 Fix for bug 1575
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 16:15:57 -06:00
Ryan Higgins
92e89f48f4 disable actions in moremember based on staff_access permission
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 15:17:56 -06:00
Ryan Higgins
1a91801b06 Add Staff member type. Add permissions checks for bug# 1269
and related permissions on memberentry and mods.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 15:17:50 -06:00
Ryan Higgins
06d1995848 Slight mod to getuserflags and haspermission in prep for perms bugfix
Also adding some pod

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 15:17:38 -06:00
Ryan Higgins
85d8c91976 adding Staff Borrower to handle Bug 1269
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 15:17:14 -06:00
Galen Charlton
ad4e02f91d warn on attempts to add duplicate item barcodes during batch import
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 15:06:24 -06:00
Galen Charlton
6bb4eb130d bug 1615: AddItem() now sets issues, renewals, and reserves
When an item was created,  the renewals, issues, and reserves columns
were not set from the MARC data.  This was noticed particularly
in the context of batch loads, where a user might supply
data for those fields.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 15:06:23 -06:00
Henri-Damien LAURENT
8afd53e333 Bug fixing : infinite loop when repeated operator + distinguishing operators
limits would provide with unnecessary repeated "and"
Thus causing wild loop
So removing them.
aud was transformed into author when it qualified audience.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 14:58:43 -06:00
root
3ddff0ce41 Bug Fixing : NZsearch
parenthesis introduce a priority.
yr:XXXX-YYYY is now processed correctly.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 14:57:54 -06:00
Ryan Higgins
105adc6ccd changing haspermission() to require that user has ALL requiredflags, not ANYOF requiredflags
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 14:57:12 -06:00
Paul POULAIN
f5cddc0807 when the result has an author as search term, the link contained the <span style="term"> in it
this fix add a author_nospan, that contains the author in it's native form

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 14:49:01 -06:00
Chris Cormack
432fbaed04 Fix for bug 1613 making sure the zebraqueue is updated when an item is
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 14:12:38 -06:00
Galen Charlton
5d023531a1 bugfix: do not store item tags when saving old copy of bib
If a MARC batch was imported, then reverted, the 952s
from the saved copied of the bib were added back
when the bib was replaced, leading to duplication

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-28 21:44:23 -06:00
6810d3c982 Change from kados to XISBN.pm ("handle no response from ThingISBN"), and change to similar items markup in detail.tmpl
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-28 21:26:43 -06:00
d0379ed325 If LibraryName was not specified, the opac layout was broken. Adding a default ("Koha Online Catalog") to the template in case LibraryName is empty.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-28 21:25:16 -06:00
Joshua Ferraro
f66d9131bf fixing problem with adv search on staff client
Issue was that language limit was being set with a
relation (=) but no operand

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-28 12:47:17 -06:00
Galen Charlton
1854ad60a3 bug 1614: revise GetMarcItem so that info dervies from items table
This should help make the items table more authoritative, and ensures
that the items editor does not blank circulation fields such as
issues.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-27 17:05:56 -06:00
8d5c262682 Moving holdings, description, editions, and related into tabs, enabling AmazonSimilarItems global preference for the staff client (but not working?)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-27 15:57:27 -06:00
Galen Charlton
fe9106af0b bugfix: handle subfield $0 in MARC for an item
Note: C4::Biblio::GetMarcFromKohaField returns (0, 0) if
the kohafield is not defined in the MARC framework, but
in may places the return value is not checked correctly
and does not recognize a subfield $0 (zero).  It
would be better if GetMarcFromKohaField returned (undef, undef)
in that circumstance, but because of the number of places
where that function is used, the changed is deferred for
post 3.0.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-27 15:52:41 -06:00
Galen Charlton
583baef555 MARC21 framework: changed 'items.withdrawn' to 'items.wthdrawn'
The correct field is 'items.wthdrawn', not 'items.withdrawn'.
Spelling may be corrected in post-3.0 version.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-27 15:51:55 -06:00
Galen Charlton
eb52fe26c3 bug 1616: update bib MARC and zebraqueue on item update
Fixed so that when using updateitem.pl to change an
item's lost, damaged, or withdrawn status, the
bib's MARC XML is updated and an entry is added
to zebraqueue.

As part of the fix, C4::Biblio::ModItemInMarconefield
now works correctly.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-27 15:51:47 -06:00
Galen Charlton
a869ed0435 MARC import: part 5 of large file support
Staging job now gets moved to background so that
it does not get killed if it takes longer
than the Apache timeout.

Added AJAX monitoring of job status.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-26 20:05:34 -06:00
Galen Charlton
c938846b3a C4::UploadedFile -- simplified serialization
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-26 20:05:33 -06:00
Galen Charlton
cabb06c56c MARC import: part 4 of large file support
* Added C4::BackgroundJob to monitor tracking of
  background jobs
* start modifying stage-marc-import to use it

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-26 20:05:30 -06:00
bbae57c926 More work on editions in the OPAC; Need both a staff client and OPAC system pref for turning on and off XISBN stuff.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-26 19:59:42 -06:00
96fcc7137c Enabling FRBR system pref for OPAC, to enable/disable display of other editions. Adding editions display to opac-detail, and making some other cosmetic changes. Adding alterating table row colors in opac-user.pl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-26 19:59:32 -06:00
Ryan Higgins
271aa9043d Adding MARC preview to acqui screens
Also cleaning up some missing params and language.
Add another js library: greyox (jquery derivative iiuc).

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-25 22:15:08 -06:00
Joshua Ferraro
a508bc1cd2 s/mt/itemtype/ for FindDuplicate
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-25 21:44:06 -06:00
Joshua Ferraro
db3954aabd allow timeout to be specified in days
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-25 19:41:41 -06:00
Joshua Ferraro
62ce10a838 adding maxItemsToDisplay
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-25 19:32:34 -06:00
Paul POULAIN
304deaadf1 (atz, pls validate) bugfixing dates viewing on moremember
There were 2 bugs :
- one in moremember.pl that supposed the date value to be in preffered order, which is wrong, it's in iso at this time
- the output does not work as expected, as it always return iso.

Pls atz, confirm Dates.pm was bugged.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-25 17:15:34 -06:00
Paul POULAIN
db7407c4a2 Deal with opac template reordering
the modules/ directory is now in opac as well as in intranet.
non english languages were unreachable without this patch.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-25 17:07:00 -06:00
Paul POULAIN
327ae4ff84 include 700 (author) in authority author list
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-25 17:06:42 -06:00
Galen Charlton
e9f36cc227 MARC import: part 3 of large file support
* Introduced C4::UploadedFile to handle management and
  progress tracking of uploaded files.
* Modified stage-marc-import.pl to handle new upload
  mechanism

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-25 16:45:53 -06:00
Galen Charlton
296e4909e0 MARC import: part 2 of large file support
* Added check_cookie_auth to C4::Auth
* Added permissions checks to the file upload scripts
* Added more error handling

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-25 16:45:49 -06:00
Galen Charlton
0c1617010f bugfix: fixed quelling of warning if $db_port not specified
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-25 16:45:36 -06:00
Galen Charlton
1552407c45 quell warning about missing config parameter (DB) 'port'
This context parameter is not necessarily present for
MySQL storage method.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-25 16:43:40 -06:00
Galen Charlton
958b5a097c new C4::Auth::get_session for single place to get CGI::Session object
Refactoring to provide single place to get CGI::Session ojbject;
fixes bug for DB storage method other than 'mysql'.

This refactoring is also part of the patch series for
handling large input files for staging and processing
MARC records.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-25 16:43:26 -06:00
Joshua Ferraro
01f9fd779a fixes to scan
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-25 16:28:08 -06:00
Joshua Ferraro
937bb38e6a fix for bug 1208, exact barcode search
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-25 16:28:04 -06:00