Commit graph

9183 commits

Author SHA1 Message Date
Jesse Weaver
7ee84ba5cb bug 2848 [2/2]: Letters for holds notifications (DB rev 005)
This adds the necessary SQL for holds notifications to work.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-08 08:51:15 -06:00
Jesse Weaver
c9a50403e5 bug 2848 [1/2]: Send notifications to patrons when hold is received
This adds notification code to Reserves.pm to send notifications through email
or SMS to patrons when their hold is filled. It does not send the letter
directly, but instead uses EnqueueLetter. Also, it relies on
EnhancedPatronMessaging being on and the hold notification being turned on for
the specific patron through the 'Messaging' tab.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-08 08:51:12 -06:00
Galen Charlton
6ca9d3eb14 DB rev 003 -> 004 (for Allen's 2754 patch)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-08 08:51:06 -06:00
Allen Reinmeyer
3b1817f685 Bug #2754 Show hold request priority in OPAC
Code changes to display the priority level on holds in OPAC. Turned on/off based on System Preference.  Database changes to systempreferences for both English and French

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-08 08:50:56 -06:00
Galen Charlton
d5b98d3bb0 bug 2613: allow web self-check to accept patron ID
Use 'patronid' instead of 'userid' as the query parameter
for passing the patron userid or barcode around; 'userid'
is claimed by C4::Auth and should be used only for
authentication pages.

Fixes the problem where entering a patron's card
number would cause a redirect to the OPAC login
page.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-08 08:46:36 -06:00
e8d14a6cde Cleaning up Self-Checkout interface, adding some basic formatting based on other standard styles.
Patch also removes a hard-coded English string from the script and some unused functions from sco.js.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-05 16:28:25 -06:00
Andrew Moore
714c9e8404 bug 2825: improving readability of output messages in updatedatabase.pl
Two recent changes to updatedatabase.pl don't include newlines at the
end of their status messages. This patch adds them. This is only useful
if you're running this from the command line.

Note: there is an opportunity here to extract some of the simlar logic
from each of these blocks to a function.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-05 16:25:13 -06:00
Allen Reinmeyer
5f7b2432e4 Bug 2675 users public lists do not show on opac-detail.pl
Code change actually occurs in opac-addbybiblionumber.pl accessed via opac-detail.pl.
Bug fix allows for users to select the 'save to lists' link and add item
to their private, public and all open lists.  Previously, only private
and open lists were retrieved and listed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-05 16:06:38 -06:00
Joe Atzberger
fd45d76e6b Trivial cleanup
2 FIXME's added.
Vestigial "8-character tabs" comment removed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-05 16:05:16 -06:00
Galen Charlton
083e8d9a06 remove superfluous retrieval of $ENV{'REMOTE_USER'}
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-05 16:03:43 -06:00
Joe Atzberger
817cd2680e Minor logical cleanup.
The conditional assignment previously was:
    $norequests = 0 && $norequests if ....

The execution of "0" served no purpose.
Also consolidated RequestOnOpac logic to the one line that cared about it.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-03 09:17:43 -06:00
Joe Atzberger
4a3fcbbe0d Comment out unused variable.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-03 09:17:41 -06:00
Galen Charlton
5f18793461 bug 2758: don't confirm checkout if fine balance is 0
Fixes problem where if the IssuingInProcess preference is ON,
the operator is always required to confirm a checkout if
the patron has had any fine transactions at all, even if
the patron's balance is 0.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-02 16:44:20 -06:00
Nahuel Angelinetti
873d1c6336 bug #2757: change the opac login generation
This patch change the method used to generate a new login for a user when his informations are modified(memberentry.pl).

Before the login are generated with the first letter of lastname and the 9 first letter of the surname, and do not verify the
login already exist).
Now the login will be lastname.surnameX, where X is an incremented digit if the login already exists.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-02 08:35:01 -06:00
41db97255c Corrections and tweaks to recent lists fixes.
Corrected an instance where <!-- TMPL_IF --> was embedded inside an HTML tag (conflicts with translation script). Modified styling of confirm button to match existing interface convention.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-01 11:24:25 -06:00
8350c0ba77 Tweaks to display of "views" tabs (MARC, ISBD, etc).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-01 11:24:22 -06:00
Galen Charlton
933216b1c1 fix POD error introduced in last patch
Run prove xt/author/podcorrectness.t to verify
that POD is syntactically correct.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-01 11:13:35 -06:00
Danny Bouman
cd2bf6e70a bug 2817: Added support to pull Amazon information based on UPC, EAN, and 13-digit ISBN
By adding support for UPC,EAN and 13-digit ISBN we are able to pull much more content from Amazon, especially on most music and dvd content which
does not have an ISBN.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-01 11:05:30 -06:00
Joe Atzberger
f406ce43a9 Pure whitespace edits. Trying to make members more readable.
Use git diff -w to show only one line (a blank one) was edited (removed).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-01 10:51:38 -06:00
Joe Atzberger
9f97e871f1 Bug 2818 - Allow patron editing to coexist with minPasswordLength and '****'.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-01 10:49:26 -06:00
Galen Charlton
324958669a fix permissions error introduced by previous patch
Modules in C4 should not be executable.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-01 10:39:05 -06:00
Nahuel Angelinetti
f6cfcd933d No more used since a while.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-01 10:34:44 -06:00
Nahuel Angelinetti
e0bbb9d7e7 Delete all calls to thesaurus_popup.pl, and no more used plugins.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-01 10:31:46 -06:00
Henri-Damien LAURENT
cb0c787b1b Updating default UNIMARC framework
The previous one was out of date and contained some errors.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-24 10:04:11 -06:00
Galen Charlton
33514a4e35 bug 2801 followup
Quell unitialized value warnings emited when
'use warnings' was added.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-20 18:56:40 -06:00
Joe Atzberger
3cd80072f3 Bug 2801 followup... [SQUASHABLE]
Apparently my git skills are lacking, since I intended this one-liner
to be amended into the patch I resent.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-20 18:30:07 -06:00
Joe Atzberger
5532f6652b Bug 2801 and other cleanup.
In addition to documented bug:
~ SearchString took an unused argument,
~ refactored repeated code into column_picks(),
~ fixed display during delete_confirm, including "name",
~ removed unused C4::Dates dependency.

Resend: typo fixed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-20 18:29:57 -06:00
Henri-Damien LAURENT
f09e5a71d2 Bug Fix : 2686
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-20 18:18:25 -06:00
Galen Charlton
b47e2b1544 bug 2531 followup
* & -> &amp; in URL for XHTML validation
* (unrelated to prior patch) remove broken link to
  button-bg.png for confirm button

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-20 18:13:08 -06:00
Allen Reinmeyer
25eb36f21f Bug #2531 Cannot delete private shelf
Added logic to create a list of private lists to check on deletion.  Multiple pages have the ability to delete lists, both private and public.  Default option of retrieving a user's lists is retrieving the public ones.  Now private lists of the owner are retrieved as well and checked upon deletion request.  This allows any method of deletion to delete the correct list without examining the myriad of options currently used to indicate display of privateshelves and expect all pages to know whether a shelf number comes from a private or public list.  Since deletion occurs based on shelf number and the virtualshelves table has a primary key on shelf number, this will not cause unwanted deletion of shelves.

UPDATE:  added logic for conditional creation of shelves.  Also note change in staff side as deletions worked except for viewing a populated shelf, then deleting.  The confirm message showed, but the display was of public shelves, not private.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-20 08:33:59 -06:00
Ryan Higgins
53a0ed93db bug 2787 : Fix Global Due date
This patch also lightly refactors the conditional structure wrapping the
call to AddItem, renaming a couple variables to remove double-negatives and
abstruse logic.  If SpecifyDueDate is ON, then the input box is used to pass
GlobalDueDate, allowing modification by circ staff, resulting in a default
'sticky' due date of the global due date in that mode.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-20 07:22:18 -06:00
Jesse Weaver
b883e6cd7f fix for bug 2447: yuipath variable not getting passed to help pages
This updates help.pl to pass the yuipath variable correctly. It also adds some script references to help-top.inc to avoid other js errors.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-19 15:45:51 -06:00
5d72025226 Get back boolean button on OPAC Advanced Search page
With this patch, on OPAC Advanced Search page, when More Options is
selected, a boolean combo box appears in front of fields combo box.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-19 15:45:45 -06:00
Henri-Damien LAURENT
9e63271c8a Bug 2790 no UNIMARC search on avail items [1/2]
Changing record.abs file to add the management of acquisition date,
modification date and lost

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-19 15:45:42 -06:00
Ryan Higgins
f3f0e2576f Bug 2365: Serials prediction errors: Roll-overs occur with wrong issue in some cases.
See bugzilla for details.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-19 15:08:57 -06:00
Galen Charlton
cfd2f829d3 bug 2802 followup: remove another reference to "branches"
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-18 16:51:27 -06:00
Henri-Damien LAURENT
8b9af2775e bug fix : 2805
deleting die on lack of user/password in config file.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-18 16:46:32 -06:00
ccad2f8cf0 Language corrections: branch -> library. Changing "Libraries, branches, and groups" to "Libraries and groups." Fixes Bug 2802.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-18 16:46:28 -06:00
Galen Charlton
5880522ea7 bug 2654: require circulate permission to upload offline circ files
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-18 16:46:25 -06:00
Galen Charlton
aa686ee5ab bug 2606: reduce size of offline circ patron database
Reduce the size of the SQLite database produced by
create_koc_db.pl by emiting only the columns
actually used by Kyle Hall's offline circ client.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-18 16:46:21 -06:00
Michael Hafen
db73b67f03 add isbn to cataloging search results
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-18 16:46:16 -06:00
Nahuel Angelinetti
a41acfe435 Do not show the language chooser
This patch change the footer of authority search results popup to use the popup footer, so do not show the language chooser.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 10:29:28 -06:00
Galen Charlton
da13a339bb moved Test_CSV_Various.t to xt/author
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 10:19:43 -06:00
Joe Atzberger
93725f8ae4 Results of CSV module analysis, testing various CSV modules and configs.
The upshot is that despite appearances, whe should NEVER use Text::CSV::Unicode
or any CSV module in non-binary mode.  Text::CSV works in binary mode
by using Text::CSV_XS, so the behavior is the same for both (in binary).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 09:51:24 -06:00
Marc Chantreux
082ed86beb use DESTDIR now
takes carre of changes in Makefile.PL about debian install

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 09:43:22 -06:00
105df865ca Fixes bug #2788 - CoinS support
1 In URL rft.tpages is replaced with rft.page. That's what
  Zotero expects.
2 TMPL_VAR NAME="size" is replaced with "pages" for 1.
3 TMPL_VAR NAME="publisher" is replaced with "publishercode"
  the correct value for rft.pub

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 09:43:14 -06:00
872f852614 Bug #2794: Browse Shelf doesn't work with ISBN containing '-'
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 09:43:09 -06:00
Galen Charlton
a74d196f35 bug 1891 followup - remove dangling /TMPL_IF
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 09:22:06 -06:00
Andrew Moore
5ab1781bab adding "DROP TABLE" commands to several table definitions in kohastructure.sql
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 09:05:04 -06:00
Ryan Higgins
761a589fc0 bug 1891 : bib-level itemtype was required in order to place a hold.
This patch removes some superfluous logic left over from early Koha
when a multi-step holds process allowed you to limit your choices to
specific biblioitems.itemtype values.  Code previously required a value
in biblioitems.itemtype in order to place hold.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 09:05:01 -06:00