Commit graph

2469 commits

Author SHA1 Message Date
Chris Cormack
88fb22f081 Merge remote branch 'kc/new/enh/bug_4820' into kcmaster 2011-01-07 14:27:06 +13:00
10c52de1fa Follow-up on fix for Bug 4820, Alter layout of Circulation and fines rules page
One instance of "default" usage missed in the original update

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-01-07 14:26:20 +13:00
811023934a Follow up on fix for Bug 5570, item types not showing on other editions
Fix for the staff client.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-01-07 14:18:11 +13:00
84205212b4 Fix for Bug 5006 - Invalid XHTML in record matching rules template
- Rework JavaScript clone routines to use jQuery, to take
  label "for" into account, to handle incrementing label,
  and to properly place cloned blocks at the bottom of the group
- Rework JavaScript delete routines to use jQuery, to take
  block label numbers into account, and to show the "add"
  link if you have deleted the last block.
- Correcting markup which nests <div> inside <fieldset>
- Ensuring labels' "for" attribute matches input IDs
- Adding "required" style to required fields

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-01-07 09:57:11 +13:00
Colin Campbell
926ab8c544 Bug 5583 Rename fieldnumber to blocknumber
Variable fieldnumber does not refer to a field
It is the ISBD block number
Rename to blocknumber
Say what we mean adds to maintainability

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-01-07 09:42:05 +13:00
Colin Campbell
782654d178 Bug 5582 Pass tag nums as a string to Doc Popup
Add quotes around tag number when calling doc popup
Otherwise numbers with leading zeroes are interpreted
as octal e.g. 020 returns doc for 016

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-01-07 09:41:01 +13:00
Nicole Engard
f379638c9d bug 5419: make reason checkouts blocked stand out
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-01-05 09:11:32 +13:00
562653bc8d Fix for Bug 3918 - Add to order lists inconsistent
- Added new include to contain add to basket options
- Minor markup corrections

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-01-05 08:46:07 +13:00
Chris Cormack
34c0fb8763 Merge remote branch 'kc/new/bug_5563' into kcmaster 2011-01-03 22:03:28 +13:00
Nicole Engard
c71a36fd27 bug 5562 change 'issues' to read 'checkouts'
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-01-03 22:00:08 +13:00
Nicole Engard
606f978419 bug 5563 change note about cover images on enhanced content
on the enhanced content tab of system
preferences it says that Koha will pick
the first cover image - but in fact it
shows them all - that note needs to be
updated to properly warn of the expected
behavior.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-01-03 21:58:21 +13:00
Robin Sheat
7d0212cf38 bug 4942 - add validation to patron administration
This validation requires an enrollment period or a date to be provided
before the form will save, which will prevent invalid dates getting into
the system.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-01-02 09:26:24 +13:00
d1f74c852b Fix for Bug 3665, adding another submit button as in OPAC
This is the only change proposed in Bug 3665 which hasn't
already been implemented by someone else. It adds a submit
button under the first section of the advanced search page
just like the OPAC advanced search has.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-01-02 09:16:10 +13:00
0185ea6e9a Fix for Bug 4820, Alter layout of Circulation and fines rules page for clarity
I propose some changes to the issuing rules interface to improve usability:

 - Better define and delineate the sub-sections on the page:
   - Default checkout and hold policy
   - Checkout limit by patron category
   - Holds policy by item type

 - Repeat the current library name, when selected, for clarity: "Default
   checkout and hold policy for Athens" rather than "Default checkout and
   hold policy for this library"

 - Use the phrase "all libraries" when no library is selected. "Default
   library" seems ambiguous. "All libraries" better defines how the rule
   will be applied: to all libraries in the absence of a more specific rule.

 - Use the term "all" instead of "default" in cases where a rule will apply
   to all categories or item types.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-01-02 09:13:53 +13:00
d2b9602e53 Fix for Bug 5540, editing slip news changes to librarian interface
The script checks for a language-specific OPAC message and, if none
is found, preselects none of the "display location" options. This
results in the first item in the <select> behing highlighted by
default, "Librarian interface." If we want to select "slip," we
must add an explicit check for it.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-29 20:27:43 +13:00
f5b416b5bb Bug 5530 Follow up
With this patch, I don't see any other place where the old sysprefs editors
(systemprefences.pl) is used anymore.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-22 11:27:55 +13:00
Chris Cormack
801e7ffb72 Bug 5530: Fixing a link to systempreferences.pl instead of preferences.pl 2010-12-21 21:19:23 +13:00
Stéphane Delaune
95c51f1c85 (MT #1654) followup : Adding jquery.tablesorter and jquery.tablesorter.pager support for branch_transfer_limits.pl 2010-12-21 21:18:12 +13:00
Stéphane Delaune
77b3307772 (MT #1654) followup : corrects tablesorting for authorised_values.pl 2010-12-21 21:18:12 +13:00
Stéphane Delaune
fbfe0276a0 (MT #1654) followup : Adding jquery.tablesorter and jquery.tablesorter.pager support for auth_tag_structure.pl 2010-12-21 21:18:12 +13:00
Stéphane Delaune
f1762530d1 (MT #1654) followup : Adding jquery.tablesorter and jquery.tablesorter.pager support for marctagstructure.pl 2010-12-21 21:18:12 +13:00
Stéphane Delaune
6a76d13e44 (MT #1654) followup : Adding jquery.tablesorter and jquery.tablesorter.pager support for cities.pl 2010-12-21 21:18:12 +13:00
Stéphane Delaune
fcd2a2de3d (MT #1654) followup : Adding jquery.tablesorter and jquery.tablesorter.pager support for categorie.pl 2010-12-21 21:18:12 +13:00
Stéphane Delaune
64521709d1 (MT #1654) followup : corrects tablesorting for authorised_values and itemtypes 2010-12-21 21:18:11 +13:00
Stéphane Delaune
6e9727ad36 (MT #1654) followup : Adding jquery.tablesorter and jquery.tablesorter.pager support for itemtypes.pl 2010-12-21 21:18:11 +13:00
Stéphane Delaune
4c70627e9e (MT #1654) followup : Adding jquery.tablesorter and jquery.tablesorter.pager support for branches.pl 2010-12-21 21:18:11 +13:00
Stéphane Delaune
d950e509ff (MT #1654) Adding jquery.tablesorter and jquery.tablesorter.pager support for authorised_values.pl 2010-12-21 21:18:11 +13:00
Stéphane Delaune
1242ec7cc4 (MT #1577) complete langages checkbox for unique id 2010-12-21 21:18:11 +13:00
Paul Poulain
79ad2a0e17 Removing usage of preferences.pl 2010-12-21 21:18:11 +13:00
Matthias Meusburger
c00a51468e MT 2310 : New subfield for fields < 10 is now in a tab
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2010-12-21 21:17:30 +13:00
Matthias Meusburger
710993d0e7 MT 2446 : Cancel authority edition for a field goes back to this field 2010-12-21 21:17:29 +13:00
Chris Cormack
9693db7bff Merge remote branch 'kc/new/enh/bug_2965' into kcmaster 2010-12-21 08:51:31 +13:00
Katrin Fischer
cf4d851907 Bug 2965: Follow up - fixing problem with barcode field
The scanned barcode stayed in the checkout field instead of being
deleted after checkout or confirmation.

This patch reverts the template change, so the barcode is deleted.

Please test!

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-21 08:44:46 +13:00
Chris Cormack
8fe46f3dc1 Merge remote branch 'kc/new/bug_5143' into kcmaster 2010-12-20 13:24:40 +13:00
Liz Rea
c25aaf1ca4 Bug 5143: Help file revisions per Owen Leonard
Nice changes, thanks. :)

LR

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-20 13:23:05 +13:00
Chris Cormack
3c19f22f86 Merge remote branch 'kc/new/enh/bug_5283' into kcmaster 2010-12-20 10:44:03 +13:00
Chris Cormack
206e0709d7 Bug 5283 Follow up, fixing broken template syntax 2010-12-20 10:42:59 +13:00
75762a63e9 Fix for Bug 3262 - OPAC needs syspref to show homebranch on detail page
Revised version of Liz Rea's fix adding homebranch by default. This
revision displays the homebranch name instead of branchcode.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-20 10:12:34 +13:00
Chris Cormack
c9465ed9df Revert "Merge remote branch 'kc/new/bug_5373' into kcmaster"
This reverts commit bf5a328af6, reversing
changes made to a904a9bac7.
2010-12-20 10:08:02 +13:00
Chris Cormack
8902ee5684 Merge remote branch 'kc/new/bug_5446' into kcmaster 2010-12-19 21:26:06 +13:00
9a048e2b12 Bug 5446 Fix a bug introduces by previous patch
When AcqCreateItem was set to 'cataloguing' there was no items fields in the
acq web form to validate in JS...

Alert commented.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-19 21:25:09 +13:00
be70444f68 Fix for Bug 5470 - improvements to results display in the staff client
Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-19 07:44:49 +13:00
396c2143d9 Fix for Bug 3987 - New Sys Prefs Branch - Alphabetize prefs in sections
Adding jquery tablesorter, sorting on sys pref variable by default

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-19 07:20:25 +13:00
324991fefd Fix for Bug 4946 - hold warning needs rewording
This patch improves the phrasing of several messages by
breaking the message variable into distinct parts for more
natural-sounding warnings when:

- Checking out an item on hold for another patron
- Checking out an item which is waiting for another patron
- Checking out an item which is checked out to another patron
- Checking out an item which is checked out to this patron
- Checking out to a patron who has too many checked out

I would appreciate special attention to my changes to the
TooMany function in Circulation.pm to make sure I handled
it correctly.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-17 09:45:03 +13:00
Chris Cormack
9c17e9305a Merge remote branch 'kc/new/enh/bug_5283' into kcmaster 2010-12-17 09:43:17 +13:00
d6e83087a4 Fix for Bug 3859, Attach item clarification
- Modifies hint text
- Adds handling for BiblioDefaultView preference
- Markup and CSS tweaks

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-17 09:41:28 +13:00
koha
05965fb56d Bug 5283 NEWS ITEM FOR RECEIPT SLIP
There is no on-off global parameter for it since if a library does not want to
use it, then the library will not use the "slip" category in news - this is
similar to the OPAC news and Staff news categories in the news feature.

We have been using this for months in Koha 3.0 and the librarians like it and
so does PR as it gives a way to advertise events and news to patrons with every
checkout.

The files modified are:
koha-news.tmpl
moremember-receipt.tmpl
moremember.pl

Darrell Ulm

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-17 09:39:11 +13:00
Srdjan Jankovic
750a8a8dae Bug 5294 - Unescape vendor name when pushing back
Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-17 09:11:19 +13:00
Chris Cormack
bf5a328af6 Merge remote branch 'kc/new/bug_5373' into kcmaster 2010-12-17 09:09:40 +13:00
Garry Collum
cf6867db62 Bug 5373: Adds cardnumber to the field list of the Import Patrons NOTES.
Adds 'cardnumber' as an option to the list of possible fields in the NOTES section of the patron import tool.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-17 09:08:24 +13:00