Commit graph

118 commits

Author SHA1 Message Date
Galen Charlton
438ed23337 staging import - enhance record overlay behavior
Enhanced the ability of catalogers to specify how
bib and item records should be added, replaced, or
ignored during a staging import.

When an import batch of bib records is staged and commit,
the user can now explicitly specify what should occur
when an incoming bib record has, or does not have, a match
with a record already in the database.  The options are:

if match found (overlay_action):
  create_new (just add the incoming record)
  replace (replace the matched record with the incoming one)
  use_template (option not implemented)
  ignore (do nothing with the incoming bib; however, the
          items attached to it may still be processed
           based on the item action)

if no match is found (nomatch_action):
  create_new (just add the incoming record)
  ignore (do nothing with the incoming bib; in this
          case, any items attached to it will be
          ignored since there will be nothing to
          attach them to)

The following options for handling items embedded in the
bib record are now available:

  always_add (add the items to the new or replaced bib)
  add_only_if_match (add the items only if the incoming bib
                     matches an existing bib)
  add_only_if_add (add the items only if the incoming bib
                   does *not* match an existing bib)
  ignore (ignore the items entirely)

With these changes, it is now possible to support the following use cases:

[1] A library joining an existing Koha database wishes to add their
    items to existing bib records if they match, but does not want
    to overlay the bib records themselves.
[2] A library wants to load a file of records, but only handle
    the new ones, not ones that are already in the database.
[3] A library wants to load a file of records, but only
    handle the ones that match existing records (e.g., if
    the records are coming back from an authority control vendor).

Documentation changes:

* See description above; also, screenshots of the 'stage MARC records
for import' and 'manage staged MARC records' should be updated.

Test cases:

* Added test cases to exercise staging and committing import batches.

UI changes:

* The pages for staging and managing import batches now have
  controls for setting the overlay action, action if no match,
  and item action separately.
* in the manage import batch tool, user is notified when they
  change overlay action, no-match action, and item action
* HTML for manage import batch tool now uses fieldsets

Database changes (DB rev 076):

* added import_batches.item_action
* added import_batches.nomatch_action
* added 'ignore' as a valid value for import_batches.overlay_action
* added 'ignored' as a valid value for import_records.status
* added 'status' as a valid value for import_items.status

API changes:

* new accessor routines for C4::ImportBatch

    GetImportBatchNoMatchAction
    SetImportBatchNoMatchAction
    GetImportBatchItemAction
    SetImportBatchItemAction

* new internal functions for C4::ImportBatch to
  determine how a given bib and item are to be
  processed, based on overlay_action, nomatch_action,
  and item_action:

    _get_commit_action
    _get_revert_action

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-30 21:58:46 -05:00
Ryan Higgins
f4f840da2c Small template cleanup: display library name and cat description instead of codes
in circ-menu include.  Also, change 'Default' on main login page to 'My Library'.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-22 17:54:19 -05:00
Paul POULAIN
d853be943f BUGFIX : encoding problem & security problem
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-14 23:46:53 -05:00
Paul POULAIN
4f283bc0fa BUGFIX : encoding problem & security problem
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-11 16:56:24 -05:00
Chris Nighswonger
e15e2f9118 Bugfix: Handling cases where the image is the correct pixel dimensions
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-11 16:54:54 -05:00
Galen Charlton
fc6ccb1a61 granular permissions - updated Tools
Updated all scripts appearing on the tools page
to respect a granular permission defined for
each of them.

The tools menu and home page have been changed so
that only the specific tools that a user has
access are displayed.  This is simple, but depending on
the module and circumstance, it may be better to
display functions that the user has does not have
access to, but disable the links and do some sort
of visual styling to indicate that a function exists
but requires additional privileges to access.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-10 15:53:30 -05:00
Chris Nighswonger
7fbcb6a784 Bugfix: Correcting misspelled variable
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-10 02:59:22 -05:00
Chris Nighswonger
a16d450555 Adding use of C4::Debug for debugging
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-10 02:59:21 -05:00
Chris Nighswonger
9a55637760 NOTE: REQUIRES INSTALLATION OF Image::Magick; Adding image scaling/resizing capability to picture-upload.pl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-08 17:00:05 -05:00
Chris Nighswonger
b626a8bb9a Adding file size limit to picture-upload.pl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-01 06:44:17 -05:00
64f93777a9 Fixing branch select onChange() function, hopefully fixes Bug 1957, Holiday Calendar broken in Internet Explorer
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-21 21:46:28 -05:00
Chris Nighswonger
2ed253639b Modifications to viewlog.pl to keep it in the context from which it was called.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 15:44:45 -05:00
Henri-Damien LAURENT
5904681fac CleanBorrowers fixing.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 11:08:40 -05:00
Ryan Higgins
46826aaee0 Mod C4::Labels::add_batch to accept an array of items.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-17 21:32:31 -05:00
Ryan Higgins
760ce0b18c Partial commit to add Create-Label-Batch-from-Import-Batch
Import batch portion herein. Still need to touch Labels.pm .

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-17 21:32:30 -05:00
Galen Charlton
a9f7993b3e fix errors with using today's date and format_date
This patch should reduce the occurrence of the following
message in the error log:

Illegal Date '2008-3-14' does not match 'iso' format: yyyy-mm-dd

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-15 08:37:21 -05:00
Galen Charlton
9222f7a6ca created old_issues and old_reserves tables
The new tables have the same structure and constraints
as the tables they archive with the following exceptions:

* borrowernumber and biblionumber in old_reserves can be
  NULL
* the FK constraints (e.g., for itemnumber) on old_reserves
  set the child column to NULL if the parent row is deleted
  instead of deleting the child row.
* there is no FK constraint on old_issues.branchcode, allowing
  a branch to be deleted without changing archived requests.

Some miscellaneous cleanup was done as part of this patch:

* GetMemberIssuesAndFines (C4::Members) now uses bind variables
* fixed POD for GetMemberIssuesAndFines

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-15 08:36:31 -05:00
Chris Nighswonger
c767c99051 Correcting code to display patronimage correctly
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-07 07:40:38 -06:00
Chris Nighswonger
55b353f79a Adding Update/Delete functions to patron image management on Details page
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-06 12:14:44 -06:00
Chris Nighswonger
cbc5bbccdd Correction to handle errors processing image file passed in from the patron details screen.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-06 06:25:15 -06:00
Chris Nighswonger
6b89cda969 Completing adding patronimage upload form to patron details screen.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-06 06:25:13 -06:00
Paul POULAIN
c1f801e63a bugfixing language selector
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-29 11:59:37 -06:00
Paul POULAIN
f72902ec5f bugfixing holidays.pl
+ let the superlibrarians choose their branch even if IndepBranches is ON

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-29 11:59:36 -06:00
1351ac2e28 Fixes for Bug 1721 (Modification Log link loses context)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-28 07:59:01 -06:00
bfbae81162 Some changes related to recent commits to patron images: Markup and javascript changes for upload form; Enabling passing of cardnumber and filetype variable to picture upload form; changes to picture display to handle missing image; Adding link to picture upload form from missing image display in circ and moremember; Removal of English text from 'no patron image' file.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-27 09:02:37 -06:00
Chris Nighswonger
9771c038b0 Bugfix: Removing Dumper() call
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-23 11:08:43 -06:00
Chris Nighswonger
de1754d68d Third installment on moving patronimages into the database.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-23 10:55:44 -06:00
Chris Nighswonger
06575bbcb8 Fixing error trap routine in picture-upload.pl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-23 10:55:43 -06:00
Chris Nighswonger
4b232a0c36 Second installment on moving patronimages into the database
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-23 10:55:41 -06:00
Chris Nighswonger
1c1cb10e5e First installment on moving patronimages into the database.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-23 10:55:37 -06:00
Joe Atzberger
3980e9bf8c branchoverdues and letter.pl - cleanup, conditionalized warnings, etc.
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-22 21:49:08 -06:00
2538e369ce Fix for bug 1844, links in the log no longer server erroring
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-22 06:30:55 -06:00
Chris Nighswonger
e4b90465a8 Second fix for bug 1848 correcting bad conditional
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-20 05:41:39 -06:00
5a900838c0 Fixed a bug 1852 that was blocking being able to add news items to the
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-19 20:11:57 -06:00
Chris Nighswonger
5e90496cad Making picture-upload.pl case insensitive when looking for DATALINK.TXT or IDLINK.TXT
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-18 16:44:04 -06:00
Galen Charlton
c90af5d48b more holiday/calendar work
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-15 08:25:46 -06:00
Paul POULAIN
309f4face9 bugfixing inventory
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-11 16:13:33 -06:00
Galen Charlton
b88682f1bb bug 1372: count MARC records correctly
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-08 20:22:43 -06:00
Ryan Higgins
58efea0215 Allow stage_biblios_file to take matcher id as parameter.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-08 06:07:49 -06:00
Chris Nighswonger
f05e50cee2 Modified viewlog.pl to discern where it was called from and display the appropriate menu.
If viewlog.pl is called from the circulation menu, then the circulation menu is displayed.
If viewlog.pl is called otherwise, the tools menu is displayed.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-03 07:24:40 -06:00
Chris Nighswonger
a0b51ee25f Correcting DEBUG var
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-03 07:23:46 -06:00
Chris
80d4bd222f Bugfix for Bug 1618: First Installment
This corrects the major template issues once files are uploaded.
The changes need dressing up a bit still.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-03 07:23:41 -06:00
Chris Cormack
3dda0fa639 Fix for bug 1784,
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-23 21:27:25 -06:00
Joshua Ferraro
c7f22f84ad additional updates to language support
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-05 02:59:47 -06:00
Galen Charlton
8c60e82605 fixed variable masking warnings found by perl -w
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 20:23:59 -06:00
Galen Charlton
8f854c0867 speed boost: tools stage and commit bib records
Turned off autocommit; commit every 50 records.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 16:26:26 -06:00
Galen Charlton
a91b10dd57 inventory: two fixes
* Replaced direct "update items" with ModItem call
* fixed problem in template that prevent barcode file upload
  from working

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 16:24:28 -06:00
Galen Charlton
c6c8e80a73 start of BIB change -- introduce C4::Items
Introduced C4::Items module to separate items API
from biblio API.  Details on changes will be
put in later commit messages.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-03 16:23:12 -06:00
Joe Atzberger
9f1d798bfe import_borrowers.pl - convert dates BEFORE AddMember or ModMember
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-20 20:51:28 -06:00
Joe Atzberger
a8e1618c3f viewlog.pl - fixes bug 1657, passes DHTMLcalendar_dateformat
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-19 18:54:48 -06:00