Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Martin Renvoize	9ec4d86636	Bug 22600: Add 'interface' to accountlines This patch adds the 'interface' field to the accountlines table and updates all Koha::Object routines and calls to use it. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	5 years ago
Josef Moravec	6e3da5397e	Bug 21683: Remove accountlines.accountno Test plan: 1) Play with fines, should work OK 2) Try to print receipts on fines - prinfeercpt.pl, printinvoice.pl 3) git grep getnextacctno -> no occurences 4) git grep accountno should return only: installer/data/mysql/atomicupdate/bug_21683_remove_column_accountno.perl installer/data/mysql/update22to30.pl misc/release_notes/release_notes_3_10_0.txt misc/release_notes/release_notes_3_22_0.txt 5) prove t/db_dependent/Accounts.t t/db_dependent/ILSDI_Services.t t/db_dependent/Stats.t t/db_dependent/Koha/Account.t Rescued-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	5 years ago
Nick Clemens	6533f32c3a	Revert "Bug 22026: Removed 'use Modern::Perl;' from Koha::REST::classes" This causes test failures in D8 and would require packaging our own perlcritic Reverting until future date when consequences do not outweigh benefits This reverts commit `ecc94da6b2`. Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	5 years ago
Jasmine Amohia	ecc94da6b2	Bug 22026: Removed 'use Modern::Perl;' from Koha::REST::classes Test plan: 1) Check all Koha/REST files and confirm that 'use Modern::Perl;' has been removed. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	5 years ago
Tomás Cohen Arazi	814078ab40	Bug 21786: Make balance and credits endpoints handle library_id This patch: - Adds the branchcode <-> library_id mapping in the controller - Adds 'library_id' to the credit and account_line definitions - Makes add_credit handle the library_id param, passing it to the underlying $account->add_credit method. To test: - Run: $ kshell k$ prove t/db_dependent/api/v1/patrons_accounts.t => FAIL: Tests fail, because library_id is not mapped (balance) and because it is not handled when adding a credit. - Apply this patch - Run: k$ prove t/db_dependent/api/v1/patrons_accounts.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago
Tomás Cohen Arazi	2d94834807	Bug 20777: (follow-up) Remove 'dispute' reference in /credits endpoint Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago
Tomás Cohen Arazi	1ab7d74a15	Bug 20944: Fix perlcritic issues Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago
Tomás Cohen Arazi	d19d8ec049	Bug 20944: Add route to add credits to a patron's account This patch adds the /patrons/{patron_id}/account/credits endpoint, that can be used to add credits to a patron's account. It is implemented so the new credits are used to pay existing debts. To test: - Run: $ kshell k$ prove t/db_dependent/api/v1/patrons_accounts.t => SUCCESS: Tests pass! - Make your favourite REST testing tool (RESTer on Firefox?) do: POST /api/v1/patrons/{patron_id}/account/credits { "amount": 100 } - Play with other possible attributes on the credit object. - Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago
Tomás Cohen Arazi	6672b26d16	Bug 20942: (QA follow-up) Use $lines->total_outstanding This patch makes the controller code use $lines->total_outstanding instead of expecting ->outstanding_debits and ->outstanding_credits return the total. Tests should pass as before. No behaviour change is expected. To test: - Run: $ kshell k$ prove t/db_dependent/api/v1/patrons_accounts.t => SUCCESS: Tests still pass, no behaviour change. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago
Tomás Cohen Arazi	bb7c908dc0	Bug 20942: Split debit and credit lines This patch splits the balance to match this object schema: { balance => #, outstanding_credits => { total => #, lines => [ credit_line_1, ..., credit_line_n ] }, outstanding_debits => { total => #, lines => [ debit_line_1, ..., debit_line_m ] } } This change is made to ease usage from the UI. Also because the outstanding credits need to be applied to outstanding debits in order to the balance value to make sense. So we still need to have each total. Tests are added for this change, and the schema files are adjusted as well. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/api/v1/patrons_accounts.t => SUCCESS: Tests pass! - Sign off :-D staff_id is changed into user_id as voted on the dev meeting the RFC got approved. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago
Tomás Cohen Arazi	d079c80b05	Bug 20942: Add route to get patron's account balance This patch implements the /patrons/{patron_id}/account endpoint. It can be used to get the patron's balance information, including outstanding lines. To test: - Apply this patchset - Run: $ kshell k$ prove t/db_dependent/api/v1/patrons_accounts.t => SUCCESS: tests pass! - Make your favourite REST testing tool (RESTer on Firefox?) do: GET /api/v1/patrons/{patron_id}/account to a valid patron_id. Play with Koha's UI to add credits/payments and notice the endpoint returns the right info following the voted RFC. [1] - Sign off :-D [1] https://wiki.koha-community.org/wiki/Patrons_account_lines_endpoint_RFC Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago

11 Commits (9ec4d86636ffd4a11863cafe8d4eddb6e55c13db)