Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Jonathan Druart	fb9268417b	Bug 25172: Remove _recheck_logfile I don't understand how that could be useful. We do not want to test if the logfile is writable every time we log something! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	4 years ago
Jonathan Druart	bfa921665a	Bug 25172: Make Koha::Logger explode if init went wrong We do not want to fail silently for the logger. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	4 years ago
Jonathan Druart	7d8b96803f	Bug 24545: Fix license statements Bug 9978 should have fixed them all, but some were missing. We want all the license statements part of Koha to be identical, and using the GPLv3 statement. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	4 years ago
Jesse Weaver	f089d393dc	Bug 13937: Add a Z39.50 daemon that can inject item status MARC subfields This creates a new daemon, misc/z3950_responder.pl, which can respond to Z39.50 requests. By default, it just proxies searches to Zebra. If desired, however, it can also add a subfield to the item tags on outgoing records with a textual description of the item's status (checked out, lost, etc.). This is useful for certain ILL systems. These strings can be translated using the 'Z3950_STATUS' authorized value. Test plan: 1) Start the Z39.50 server using `perl misc/z3950_responder.pl`. 2) Connect to the server using `yaz-client 127.0.0.1:9999/biblios`. 3) Run a search, such as `find @attr 1=1016 book`. 4) Fetch the results both one at a time with `show 1` and in a batch using `show 1+5`. 5) Turn on MARCXML using `format xml` and `elements marcxml`, and verify that the records are still correctly fetched. 6) Enable the item status subfield by restarting the server with the option `--add-item-status=k`. 7) Search for and fetch records, and verify that a $k subfield is added to the item tags as appropriate. It should show some combination of "Checked Out", "Lost", "Not For Loan", "Damaged", "Withdrawn", "In Transit", or "On Hold" as appropriate, or "Available". 8) Add an authorized value named "Z3950_STATUS" with any of the keys "AVAILABLE", "CHECKED_OUT", "LOST", "NOT_FOR_LOAN", "DAMAGED", "WITHDRAWN", "IN_TRANSIT" or "ON_HOLD", and verify that their descriptions are used instead of the default values above. Signed-off-by: George Williams <george@nekls.org> Signed-off-by: Stefan Berndtsson <stefan.berndtsson@ub.gu.se> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	9 years ago
Nick Clemens	296e0ce224	Revert "Bug 15253: Add Koha::Logger based logging for SIP2" This reverts commit `03c03ed8cd`. Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	5 years ago
Kyle Hall	03c03ed8cd	Bug 15253: Add Koha::Logger based logging for SIP2 Now that we have Koha::Logger, we should use it in our SIP server. This has the potential to make debugging SIP issue much easier. We should add the userid for the sipuser to the namespace so we can allow for separate files per sip user if wanted. Also modifies the log4perl.conf to lazy-open filehandles to log files, so the same config can be used with log-files needing different permissions. Test Plan: 1) Apply this patch set 2) Update the modififed log4perl.conf to your system 3) Restart your sip server 4) Tail your sip2.log, run some queries 5) Note you still get the same output messages as before, with the addition of the ip address and username ( if available ) prefixing the message. Based on original patches by Kyle Hall and additions by Olli-Antti Kivilahti. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago
Marcel de Rooy	44b51ed802	Bug 17088: [Follow-up] Adjust POD in Logger.pm Not important enough to go on its own. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>	8 years ago
Tomas Cohen Arazi	b69beb2499	Bug 14167: (QA followup) use warn instead of just STDERR This patch makes Koha::Logger use 'warn' instead of just printing to STDERR. It introduces tests for this warnings too. Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>	9 years ago
Kyle Hall	e32d731238	Bug 14167: (QA followup) Tidy Koha/Logger.pm Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>	9 years ago
Marcel de Rooy	347d12c41f	Bug 14167: (QA followup) Making Koha::Logger bit more crash resistant Moving the BEGIN block to _init for the most part. We only need to initialize when we actually start using the logger. Removed the third init part. If we do not have a log4perl_conf in the koha config, we are not using it yet. Method get uses hash parameters now. It calls init. If we do not have a config or the logfile is not writable, we will not use log4perl. Using AUTOLOAD as a wrapper around Log4perl in order to add some checks that log4perl does not have. If a logrotate would change file permissions on a default logfile, we should catch that now too (see recheck). Test plan: Run the previous tests again. Will still add a unit test. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>	9 years ago
Kyle Hall	25df3abb22	Bug 14167: (QA followup) Embed default config into Koha::Logger Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>	9 years ago
Marcel de Rooy	02821d52e3	Bug 14167: (QA followup) Adjust category handling in Koha::Logger The first patch makes the category parameter mandatory. This patch makes it optional, falling back to the current package. This is the expected log4perl model. It would not be necessary to pass the class name everywhere (check subclasses..) It also adds a delimiter between the interface and the class name. This allows you to add config lines like: log4perl.logger.opac.C4.Auth = DEBUG, OPAC log4perl.logger.intranet.C4.Circulation = TRACE, INTRANET The first line would make the logger more sensitive to C4::Auth log messages while staying at the WARN level for other messages, etc. The second line makes the trace visible from the renewal example. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>	9 years ago
Kyle Hall	a269e8ec44	Bug 14167: Add Koha::Logger based on Log4perl Koha needs a better logger, and it seems like the best solution would be to take advantage of Log4perl which is already a fully featured logger. We use Log4perl to selectively decide what statements should be logged, and where they should go! Test plan: 0) Install Log::Log4perl via packages or cpan 1) Apply this patch and the example renewal patch 2) Copy etc/log4perl.conf to your koha conf directory, edit the paths to match your current error logs 3) Edit your koha-conf file and add the <log4perl_conf>/path/to/log4perl.conf</log4perl_conf> line 4) Watch your intranet and opac error logs 5) Perform a renewal via the staff interface, note there is nothing new in the log file 7) Update the log4perl.conf, change the log level from WARN to TRACE for both the staff and opac sides 8) Perform a renewal via the staff interface, note the logged lines 9) Perform a renewal via the opac, note the logged lines Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Amended this patch: Moved the renewal stuff to a separate example patch. And upgraded the DEBUG level to WARN in the log4perl config file. Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>	9 years ago

13 Commits (aba8a17713377ecd36a11f3b8961fd6b4e8e0c9d)