Commit graph

9964 commits

Author SHA1 Message Date
Galen Charlton
adaf1d9195 fix minor warning issues in SCO
* test for NO_MORE_RENEWALS now does expect
  that hash key will always exist
* removed unconditional warn

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-03 14:37:29 -05:00
Joe Atzberger
ece3a31fca Cleanup SCO - OPAC self checkout
~ vestigial broken scripts and templates removed
~ meaningless dependencies removed
~ Focus handling issues resolved for cross-browsers
~ Timeout only invoked for non-first screen.  This keeps the refresh from
flooding the logs continuously for no purpose.
~ two halves of "validuser" conditional linked in TMPL
~ elsif's used for $op conditionals

The focus should now appear on the "Return to Account Summary" button during errors.
The user can scan anything (w/ carriage return) and get back to the first screen.
Also, special functionality is added for the magic barcode "__KOHA_NEW_CIRC__".
This effectively ends the patron session and logs them out so the next patron can begin.
The purpose is for patrons to avoid having to use a keyboard at all, if libraries
print and have this special barcode available for patrons at the SCO station.

Enhancement was requested by Plano Independent School District.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-03 14:01:02 -05:00
Garry Collum
e3eeda2fb1 Bug 3268: Adds the ability to edit the description of a holiday.
Adds another radio button to the edit holiday form. This is a partial fix, because you cannot make an edit to a single holiday for multiple branches.

Also fixed a small XHTML error and a wording error from my previous patch on holidays.tmpl (bug 3274).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-03 13:26:40 -05:00
Chris Cormack
4a9050f11f Adding a new developer to the history documentation
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-03 13:26:20 -05:00
Garry Collum
2fb7423fc0 Bug 3274: Patch to fix Holiday Exceptions radio button.
Holiday exceptions only make since for repeatable holidays. Javascript showHoliday function was looking for a 'showTitle' id that no longer existed in the showHolidau form.  Added a hidden input field because of the possibility of re-adding the title text input field at a later time.
Added code to determine whether a holiday as an exception or not, so that the "Delete this program" radio button changes to "Delete this exception" because that is the program's true functionality if the holiday is an exception.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-03 13:26:18 -05:00
Garry Collum
9f5869e8eb Bug 3275: Fixes typo (maxlentgh) in opac-suggestions.tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-03 13:26:04 -05:00
Garry Collum
d24624865a Bug 3276: Minor XHTML error in opac-passwd.tmpl
Fixes a reference to a non-existent id.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-03 13:26:01 -05:00
savitra.sirohi
fda681b2d0 Allow zebra search for Lexile numbers in field 521$a
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-03 13:25:48 -05:00
Garry Collum
535046b5f3 Bug 3283: Fix for a minor XHTML error in opac-tags_subject.tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-03 13:25:46 -05:00
Galen Charlton
84c4c269b6 bug 3170 followup
* tags >= 010, not just > 010, can have subfields
* fixed so that mandatory fields are checked
  regardless of whether a new one is created
  or an existing one modified

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-03 08:09:11 -05:00
Nahuel ANGELINETTI
c885a150c5 (bug #3170) do not check fields < 010
This patch add a if, to disallow the check of fields < 010, because they could have no subfields, and are mandatory.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-29 15:08:30 -05:00
Nahuel ANGELINETTI
927d3e6982 (bug #3170) check if mandatory fields are not empty
This patch make authority and biblio add/edit to check that at least one subfield of mandatory fields are filled-in.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-29 15:06:25 -05:00
Matthias Meusburger
f2dfe5b46e bug 3271 : Added tooltip when adding to a list with no item selected (same as for cart)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-29 08:47:17 -05:00
Galen Charlton
b5ab0da999 bug 3272: preserve formatting when editing help
Tweak the TinyMCE settings so that more of the original
whitespace and HTML is preserved when editing help, making
help patches easier to understand.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-29 08:38:44 -05:00
Zeno Tajoli
b397029280 Fix(2) bug 3266 The 'link' feature in MARC_framework is only for MARCDisplay This second patch for the same bug is only for white spaces and newlines
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-29 08:01:19 -05:00
Garry Collum
b5f419ba93 Bug 3252: Fixes XHTML on catalog statistic form page.
Several form input fields were within a <table> element, but not in a <td>.  This patch pulls the input fields out of the table.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-29 07:53:55 -05:00
Chris Cormack
5feb0a1258 Adding 2 new developers to the history
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-29 07:53:55 -05:00
Galen Charlton
39a9910f2f fix markup error in unimarc_field_128a.tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 20:52:17 -05:00
Galen Charlton
67bcff99b5 fix markup problems in label-edit-layout.tmpl
* couple constructs that caused translation bugs
* now valid XHTML

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 20:46:09 -05:00
Galen Charlton
36c0d0922d fix minor translation bugs in two OPAC templates
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 20:46:01 -05:00
Galen Charlton
aaf3f9fea7 bug 2884: followup patch
[1] Restore behavior of the input field for the library
    code; when adding a new library, it should be a
    a text box; when editing an existing library,
    should be a hidden input.
[2] When user attempts to add a new library with the same
    code as that of an existing library, populate the form
    with what the user entered for the new library, not the
    values from the existing library.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 20:17:44 -05:00
Paul Poulain
950f753f11 fix for #2884: Add error management to branches
While trying to add a new Branch with an existing Branch code, the UI says "Library saved" instead of something such as "Please select a unique branch code".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 19:55:09 -05:00
Galen Charlton
2f3714e2e6 bug 2866: add FilterBeforeOverdueReport syspref (DB rev 037)
Also added index on authorised_values.lib.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 19:20:41 -05:00
Galen Charlton
ab44e2986a bug 2866: Overdues Reports - Upgrading to filter by patron extended attributes
Patch by Rick Welykochy <rick@praxis.com.au> with some squashing
by me.

Bug Report: 2866 Filtering and sorting the overdue report using patron attributes

1. Create a new system preference ?FilterBeforeOverdueReport?
2. Option to filter *before* the overdue report runs, avoiding report slowness
3. Add searchable patron attributes to the list of overdue report filters
4. Add searchable patron attributes to the sort fields on the overdue report
5. add item call number and replacement price
6. the CSV download link now returns the same
   data as the web report, rather than (inconsistently)
   trying to run the overdue_notices.pl batch job
7. always run report if requesting CSV
8. barcodes are now links
9. use item-level item type for overdue itemtype filter

Included is a new callback for searching patron attributes, similar
to circ/ysearch.pl.

The following additional bugs are fixed:

2748: Nothing is output to the .csv file for the "Overdues" circulation report

This is fixed by having circ/overdues.pl produce the CSV output directly instead
of trying to call the overdues cronjob.  The CSV output includes all of the fields
that are displayed on the web table plus the item replacement price and any extended
patron attributes.

2836: overdues.csv may contain HTML
2837: Descending sort doesn't descend on the overdues report plus other probs with report

This enhancement was sponsored by the Plano Independent School District.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 19:20:36 -05:00
Galen Charlton
dfdbb91fcb fix permissions error introduced in prior patch 2009-05-28 18:47:01 -05:00
Paul Poulain
ec6fc4f449 removing comments
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 17:32:39 -05:00
Paul Poulain
4ce1f9c4da Fixing API of ModBiblioMarc
no need to retrieve $biblionumber, as we already know it

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 17:31:57 -05:00
Paul Poulain
1e19efadd6 (not new_acq related) smallfix to avoid a die in case of an invalid record
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 17:31:28 -05:00
Paul Poulain
0fdb397ec6 removing useless line (use Data::Dumper)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 17:31:02 -05:00
Paul Poulain
6924e7d6b4 fix for 2997 : superlibrarian's ability to edit item/patron home branch affected if all other privileges are selected
Before this patch, we used to test for flags == 1, which was wrong when patron had all privileges.
This patch just adds a %2 to check that patron has superlibrarian privilege, and maybe something else we don't care.

I think I fixed it everywhere except in acquisition, that will be addressed by BibLibre new acquisition module.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 17:06:46 -05:00
Michael Hafen
53922726fc bugfix: unbalanced TMPL_IF in opac-tmpl/.../masthead.inc
There used to be two TMPL_IF's here, now there's just one.  Missed removing
the second /TMPL_IF though.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 14:04:52 -05:00
Zeno Tajoli
ce3518b164 Fix bug 3266 The 'link' feature in MARC_framework is only for MARCDisplay
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 08:06:57 -05:00
Garry Collum
6f66396ff9 Bug 2266: Could not uncollapse a tag if you turn on advancedMARCeditor - Revised.
Added javascript and if/else logic to the addbiblio.tmpl and a corresponding anchor tag in CSS.
If advancedMARCeditor is on, the user now clicks on the tag number to expand the marc fields.
If advancedMARCeditor is off, no functionality has changed.  The user clicks on the marc tag's title to expand the marc fields.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 07:03:41 -05:00
Joe Atzberger
82f362673c Allow option to preserve Extended Attributes on patron import update.
Essentially, this patch provides the option to overwrite only matching
Extended Attributes, instead of all of them, treating the ext. fields more
like normal fields.

Several functions added to Members::Attributes with corresponding tests.

[ LL ref. 342 ]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 06:50:39 -05:00
Galen Charlton
38b3eacde0 bug 2641, 3263: minor fixes to labeled MARC view
* fixed to XHTML validation errors
* corrected copyright statement

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 06:42:35 -05:00
Galen Charlton
822e0ffeae bug 2642, 3263: new MARC display system preferences (DB rev 036)
* Added definitions of the new display sysprefs:

  viewISBD - Allow display of ISBD view of bibiographic records
  viewLabeledMARC - Allow display of labeled MARC view of bibiographic records
  viewMARC - viewMARC  Allow display of MARC view of bibiographic records

* Adjusted IntranetBiblioDefaultView
  * made type choice (fixing bug 1933)
  * added better description for English
  * added labeled_marc option

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 06:42:32 -05:00
Galen Charlton
6a86ce7581 bug 3263: fixed ersatz references to AmazonContent
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 06:42:28 -05:00
Rick Welykochy
7504a1bb5a bug 2641, 3263: Staff Search Results Interface Changes
New detail view: labeled MARC

New bib record view in the staff interface that
displays the MARC record in a single page.

Featured sponsored by MassCat.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 06:42:27 -05:00
Galen Charlton
42b58a7e52 bug 1933: started work fixing IntranetBiblioDefaultView syspref
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 06:42:22 -05:00
Galen Charlton
17ab0a7532 bug 3263: Staff Search Results Interface Changes
Coding by Rick Welykochy <rick@praxis.com.au>

[1] Three new system preferences to enable particular
bib record views in the staff interface:

viewMARC
viewLabeledMARC
viewISBD

Implements enhancement 2642.

[2] New button in the regular and cataloging search results
   pages in the staff interface to allow the operator to redo
   the search against Z39.50 targets instead of the Koha database.

[3] Added copyright date and edition to cataloging and Z39.50 search results.
    Implements enhancement 2640.

Feature sponsored by MassCat.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 06:42:20 -05:00
Galen Charlton
dbb7456021 fix DB rev for adding location to subscriptions: 035
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 11:59:58 -05:00
Galen Charlton
ee4de2f652 various improvements to subscription editing
* fix XHTML errors in template
* the patron notification type is now correctly
  displayed when editing a subscription
* turned on warnings (bug 2505)
* added ability to modify the grace period, missed
  in initial patch for bug 3020

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 11:59:57 -05:00
Henri-Damien LAURENT
af32ae0962 Adding and managing location in subscription
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 11:59:55 -05:00
Ryan Higgins
ca5e412c1b bug 3244: Support for multiple PAC interfaces.
Adds three env vars allowing url-specific search limits, and defining
how the limit interacts with 'SearchMyLibraryFirst'.
See http://wiki.koha.org/doku.php?id=en:development:rfcs3.2:rfc32_multiple_opac

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 10:52:23 -05:00
Chris Nighswonger
e72a02e08b Bug 2500 Tweaking DDCN Split for Hyphenated Volumn Numbers
Presently 252.051 T147 v.1-2 is split as

252.051
T147
v.1
-2

This patch corrects the algorithm so that it splits as

252.051
T147
v.1-2

It also updates Labels_split_ddcn.t to include this particular case.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 10:45:36 -05:00
Jesse Weaver
3206d0fe3c Small documentation improvement for C4::Service
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 10:08:36 -05:00
Galen Charlton
53b944b5f5 fix uninitialized value warnings during COinS generation
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 09:02:14 -05:00
Ricardo Dias Marques
87acbc5e9f Updated INSTALL.opensuse file to wiki version
Updated INSTALL.opensuse file to match the one currently (as of 26-May-2009) available in the wiki at:

Installation Guide for Installing Koha 3 on openSUSE 11 - Koha Developer Wiki
http://wiki.koha.org/doku.php?id=opensuse_11.0

This commit is supposed to be applied to the 3.0.x branch.

Changelog:

– Updated last modification date to 02-Dec-2008
– Tried to clarify that one should add the word "rewrite" (without the quotes) to /etc/sysconfig/apache2 in case a2enmod does NOT work
– "make test" does NOT return "Can't connect to data source" errors any longer. Updating "make install" section accordingly
– Updated "make test" output for Koha installation (it doesn't give connect errors any longer)
– Added prompt to accept permanent instlallation of "Test-Manifest-1.22.tar.gz" during "XML::RSS" install
– Installing "XML::RSS" now also installs "Time::y2038"
– Added "force install" of "Barcode::128"
– Added output of "MARC::Charset" installation (that points that it is already up to date)
– Updated "CGI::Session::Serialize::yaml" section that now installs Test::Pod
– Added "MIME::LITE" installation that is new in Koha 3.0 Final
– Removed ImageMagick installation because it's no longer required in Koha 3.0 Final
– Added instructions to install the "GD" Perl module and its package dependencies
– Added "Email::Date" installation that is new in Koha 3.0 Final
– Updated list of prerequisites according to changes done in Koha 3.0 Final
– Added missing step to install yaz. Thanks to Bob Ewart for catching it
– Added explanation of answering Yes to "Install the Zebra configuration files" in a NOZEBRA installation, like this one
– Added explanation of "fr" (French) choice for Koha install
– Promoted run "make install" to Heading 4

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 08:38:21 -05:00
d9c63270d0 Quick fix to catch some instances of XSS vulnerability, there will be more probably, thanks for the heads up Mark
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 08:04:18 -05:00
Joe Atzberger
f58b8916df Cleanup circulation.pl
Removed many unused variables.
Switched to elsif where appropriate.
Cleaned up some whitespace.
Corrected comments.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 07:33:03 -05:00