Commit graph

12024 commits

Author SHA1 Message Date
Ian Walls
aef52b8585 Fixes bug 4201: Holds priority listings assigning large numbers
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-30 06:00:47 -04:00
Nahuel ANGELINETTI
ad01b57bcc (bug #3798) fix changing request branch
a variable was wrong in template.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-30 05:54:04 -04:00
59a6072c77 bug 4333 followup - fix an uninitialized value warning
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-30 05:50:45 -04:00
Colin Campbell
7604bf89f5 Bug 4333 Fix erroneous message re Active Currency
Script was incorrectly asking user to define an active currency
Now test for active currency in the standard way
Use the currency routines in Budgets where applicable
Move the code paths in the if else to subroutines to clarify flow
Enable warnings

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-30 05:42:05 -04:00
Nicole Engard
50375be1f2 BUG 3715 added state to label
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-30 00:15:31 -04:00
Nahuel ANGELINETTI
5d268a83a0 (bug #4295) fix overduerules edition
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 23:57:18 -04:00
Nicole Engard
f316cdc28f bug 3981 follow up change GST to 'Tax Rate' in EN-US
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 23:53:19 -04:00
Nicole Engard
8172699831 bug 4170 updated overdue rules
I added a note that this tool should not be used for
advanced notices. The fact that the Delay is required
is actually true based on the tests we did - which
is another bug.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 23:51:46 -04:00
Jean-André Santoni
a5273d7ebb Added "ordered" column in acqui-home budget display
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 23:47:31 -04:00
668581b720 Improve detail page MARC21 XSL file for 505 and 520 tags
Some tags weren't displayed propertly:

505  If there is no indicator 1, content label is not displayed and
     then repeated 505 tags are also incorrecly displayed. This patch
     add a default label.
502  Wasn't displayed at all. Added in this patch.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 23:36:24 -04:00
Paul Poulain
4ebf32b970 MT2588: minor changes in column order & display
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 23:32:40 -04:00
Nahuel ANGELINETTI
759b485158 (bug #4287) add enrolment period update in 22 to 30 script
this fix the upgrade script, to upgrade the enrolment period, that is no more in years, but in month unity.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 23:30:53 -04:00
Matthias Meusburger
1da207acf6 MT2345 : Changes on contracts
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 23:26:55 -04:00
Jean-André Santoni
06bd4fcae5 Hide basket actions if no basket
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 23:26:52 -04:00
Jean-André Santoni
5546383f70 New contract button
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 23:25:25 -04:00
Ian Walls
2f4f4bdff6 Fixes bug 4326: Items marked as returned yesterday
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 23:16:31 -04:00
J. David Bavousett
e2da272840 Bug 3619 - C4::Letters::_send_message_by_email does not obey AutoEmailPrimaryAddress
This enhancement would cause C4::Letters::_send_message_by_email to obey the
syspref.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 23:10:15 -04:00
04cafc1427 Improve OAI Server MARC21 and UNIMARC XSL
Dublin Core schema name space was repeated for each field
as attribute rather than at <oai_dc:dc> level. This reduces
significantly the size of OAI server responses.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 23:09:04 -04:00
David Birmingham
816dbb2420 Fix to ORDER BY SQL in lists feature
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 23:07:40 -04:00
Sébastien Hinderer
3b39195500 Perl documentation fixup in C4/Items.pm.
The documentation of the DelItem function did not menton the $dbh.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 23:06:22 -04:00
Henri-Damien LAURENT
47805da9ac Fixing members order when string searched
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:59:02 -04:00
Garry Collum
8fd9eed2fc Bug 4285: Intranet bib display links to opac-search.pl, instead of catalogue/search.pl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:46:34 -04:00
Kyle M Hall
db8bda86ea Search Patrons - Make patron search more forgiving.
Patron search has only been searching fields for names
that either match or begin with the given search terms.

This is too strict a search.
For example, take the name "Billie Jo Robinson", "Billie Jo"
being the firstname, and "Robinson" being the last name. If one
were to search for "Billie Jo", this patron would not appear in
the search results.

 To remedy this, the search
type has been changed from 'begins_with' to 'contain'.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:45:29 -04:00
Kyle M Hall
9a989c9e58 Circulation - Disable Barcode Field If Item Needs Confirmation
When issuing items, if a confirmation screen comes up,
another item can still be scanned into the barcode field.

If a librarian does not notice the confirmation dialog,
he or she may continue scanning items without confirming
the issue and thus give a patron an item without it actually
being issued to the patron.

This patch disables the barcode field until the confirmation
question is answered.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:44:49 -04:00
Matthias Meusburger
6532f712b7 MT2621 : Fix simple barcodes display
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:42:10 -04:00
4d50b4f4f0 Fix for Bug 4271, Offer choice of destination for save biblio operation
A follow-up to the fix for Bug 4121, the user should be able to control whether
the action of saving a bibliographic record takes them to the add item screen
or the detail screen, independently of whether they are adding or modifying the
record.

The addition of a "split button" would leave the default action in place if the
user clicked the "main" part of the button. Clicking on the menu would give the
user specific choices.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:39:10 -04:00
J. David Bavousett
55492a640f Bug 4257: Make advance notices actually go out by avoiding null selects
The wrong variable was used to select the number of days-until-due; this fixes it to use
the borrower's preference setting.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:36:38 -04:00
Henri-Damien LAURENT
09d0a978a7 Fixing Tests on SQLHelper
one test was failing for want of correct parameters
An other one was not correctly described

test on search with a simple string fails because was done with branchcode and start_with includes NULL branches
Removing branchcode from filtercolumns

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:35:28 -04:00
Jared CAMINS-ESAKOV
a326217179 Bug 4371: Display MARC21 field 773 w/XSLT
Display MARC21 field 773 in the OPAC detail view when XSLT is enabled.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:32:24 -04:00
Jared CAMINS-ESAKOV
4f11c2e728 Bug 4370: Fix ind1 semantics for MARC21 780/785
When using XSLT stylesheets for display, show MARC21 fields 780 and 785 on the OPAC details page only when ind1=0, as specified by the standard.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:32:23 -04:00
Matthias Meusburger
99a84a6ee0 MT 2553 : Adds a Cancel button
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:30:07 -04:00
Katrin Fischer
ac037be307 Bug 4404: Untranslated strings in staff search result page
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:23:49 -04:00
Colin Campbell
e7bdbd0583 Bug 4248 Rework Cities dropdown for members entry
Garry Collum's patch correctly identified the core flaw in operation
looking closer revealed some other flaws (2 "blank" options, some vars
and documentation belonging to a superceded version, etc.
Changed GetCities to return a structure rather than the messy two returns
Let the template do the concatenation and removed the CGI::Popup

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:20:36 -04:00
066850a13a Revert "Bug 4248: Fixes zip code in cities town pull down list."
This reverts commit 2eac2e7242.
2010-04-29 22:20:12 -04:00
Garry Collum
2eac2e7242 Bug 4248: Fixes zip code in cities town pull down list.
Adds zip code to the GetCities function.  This function is only used in memberentry.pl.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:19:16 -04:00
Nicole Engard
977db7c45e update circ/fine rules help file
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:16:19 -04:00
Jane Wagner
cdc46d0a2a Bug 4210 Acq suggestions don't have LibraryName value passed
Updated to current head.  The various acquisitions suggestion templates have a LibraryName field, but no value is passed for that field.  Added a parameter for that data.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:14:10 -04:00
Jane Wagner
c575628b74 Bug 3782 Update installer info for z39.50 targets
New York Public Library and New York University Library have changed their z39.50 connection information; this patch updates the installer files to the current setups.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:12:30 -04:00
Jane Wagner
7bebc1e111 Bug 3750 Modify XSLT to display subfield n of 111/711 and remove period after 110/710
If a 111/711 uses a subfield n (Number of part/section/meeting), XSLT wasn't displaying it which made for an incomplete display.

	e.g., International Conference on Concurrency Theory 1999 : Eindhoven, Netherlands)
	instead of 10th International Conference on Concurrency Theory 1999 : Eindhoven, Netherlands)

I've added it to show before subfield a if present.  I've also removed the period that XSLT puts in the results and display after the last occurrence of a 110/710.  It's fairly standard practice for these entries to have a period in the MARC record, so the XSLT display was showing a double period.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:11:31 -04:00
Jane Wagner
6ecb2ddbb5 Bug 3788 XSLT does not obey viewISBD syspref
Modified XSLT.pm and MARC21slim2OPACDetail.xsl to obey the viewISBD syspref
setting in the OPAC.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:09:59 -04:00
Chris Cormack
8478586cf1 Bug 4372 - Fix for bookcount.pl not counting started transfers as seeing an item
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:03:42 -04:00
Jane Wagner
88d522aec1 Bug 4377 Create default HOLD_PRINT notice file
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:02:15 -04:00
Henri-Damien LAURENT
e40728f4d5 MT2464 : branch_transfer_limit.pl usability change
Adds branchnames along with branchcodes for display

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:01:27 -04:00
Paul Poulain
c2f0fb370f removing AutoCommit=0, the last item is not commited
For an unknown reason, the last item batch updated is NOT updated.
After investigating a LOT (more than 3 hours), it appears the problem comes from the AutoCommit=0
I tried to solve it, but failed. So I remove the AutoCommit=0 option.

this result in a loss of perfs, but it's not a big problem I think. OTH, now everything is updated !

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 21:59:15 -04:00
Paul Poulain
d0bca1bdd3 Bug Fixing batchmod.pl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 21:57:38 -04:00
Matthias Meusburger
c8bf22893e MT 2553 : Adds background job for items batch modification
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 21:57:04 -04:00
Matthias Meusburger
7f3df2735d MT 2269, Follow-up : Granular permissions for items batch modification and deletion
Change of permissions names
Change of branch title in guided reports
Add a "Select All / Clean All" on items selection
Add a link to item when a given item cannot be deleted

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 21:55:39 -04:00
Matthias Meusburger
4b027bc4c9 MT2527 : Adds default empty value for branches when batch modifying items
(so they are not modified by mistake)

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 21:52:17 -04:00
Matthias Meusburger
4dd2086deb MT 2269 : Do not display all the items if there is a large amount of items
Also fix the barcode not found problem (due to empty lines)

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 21:52:15 -04:00
Nahuel ANGELINETTI
67f9ea0264 (MT #3007) update hold transfer slip datas
This patch add information to hold transfer slip:
 * itemcallnumber
 * location
 * waiting date

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 21:42:43 -04:00