Commit graph

9951 commits

Author SHA1 Message Date
Galen Charlton
b5ab0da999 bug 3272: preserve formatting when editing help
Tweak the TinyMCE settings so that more of the original
whitespace and HTML is preserved when editing help, making
help patches easier to understand.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-29 08:38:44 -05:00
Zeno Tajoli
b397029280 Fix(2) bug 3266 The 'link' feature in MARC_framework is only for MARCDisplay This second patch for the same bug is only for white spaces and newlines
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-29 08:01:19 -05:00
Garry Collum
b5f419ba93 Bug 3252: Fixes XHTML on catalog statistic form page.
Several form input fields were within a <table> element, but not in a <td>.  This patch pulls the input fields out of the table.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-29 07:53:55 -05:00
Chris Cormack
5feb0a1258 Adding 2 new developers to the history
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-29 07:53:55 -05:00
Galen Charlton
39a9910f2f fix markup error in unimarc_field_128a.tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 20:52:17 -05:00
Galen Charlton
67bcff99b5 fix markup problems in label-edit-layout.tmpl
* couple constructs that caused translation bugs
* now valid XHTML

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 20:46:09 -05:00
Galen Charlton
36c0d0922d fix minor translation bugs in two OPAC templates
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 20:46:01 -05:00
Galen Charlton
aaf3f9fea7 bug 2884: followup patch
[1] Restore behavior of the input field for the library
    code; when adding a new library, it should be a
    a text box; when editing an existing library,
    should be a hidden input.
[2] When user attempts to add a new library with the same
    code as that of an existing library, populate the form
    with what the user entered for the new library, not the
    values from the existing library.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 20:17:44 -05:00
Paul Poulain
950f753f11 fix for #2884: Add error management to branches
While trying to add a new Branch with an existing Branch code, the UI says "Library saved" instead of something such as "Please select a unique branch code".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 19:55:09 -05:00
Galen Charlton
2f3714e2e6 bug 2866: add FilterBeforeOverdueReport syspref (DB rev 037)
Also added index on authorised_values.lib.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 19:20:41 -05:00
Galen Charlton
ab44e2986a bug 2866: Overdues Reports - Upgrading to filter by patron extended attributes
Patch by Rick Welykochy <rick@praxis.com.au> with some squashing
by me.

Bug Report: 2866 Filtering and sorting the overdue report using patron attributes

1. Create a new system preference ?FilterBeforeOverdueReport?
2. Option to filter *before* the overdue report runs, avoiding report slowness
3. Add searchable patron attributes to the list of overdue report filters
4. Add searchable patron attributes to the sort fields on the overdue report
5. add item call number and replacement price
6. the CSV download link now returns the same
   data as the web report, rather than (inconsistently)
   trying to run the overdue_notices.pl batch job
7. always run report if requesting CSV
8. barcodes are now links
9. use item-level item type for overdue itemtype filter

Included is a new callback for searching patron attributes, similar
to circ/ysearch.pl.

The following additional bugs are fixed:

2748: Nothing is output to the .csv file for the "Overdues" circulation report

This is fixed by having circ/overdues.pl produce the CSV output directly instead
of trying to call the overdues cronjob.  The CSV output includes all of the fields
that are displayed on the web table plus the item replacement price and any extended
patron attributes.

2836: overdues.csv may contain HTML
2837: Descending sort doesn't descend on the overdues report plus other probs with report

This enhancement was sponsored by the Plano Independent School District.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 19:20:36 -05:00
Galen Charlton
dfdbb91fcb fix permissions error introduced in prior patch 2009-05-28 18:47:01 -05:00
Paul Poulain
ec6fc4f449 removing comments
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 17:32:39 -05:00
Paul Poulain
4ce1f9c4da Fixing API of ModBiblioMarc
no need to retrieve $biblionumber, as we already know it

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 17:31:57 -05:00
Paul Poulain
1e19efadd6 (not new_acq related) smallfix to avoid a die in case of an invalid record
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 17:31:28 -05:00
Paul Poulain
0fdb397ec6 removing useless line (use Data::Dumper)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 17:31:02 -05:00
Paul Poulain
6924e7d6b4 fix for 2997 : superlibrarian's ability to edit item/patron home branch affected if all other privileges are selected
Before this patch, we used to test for flags == 1, which was wrong when patron had all privileges.
This patch just adds a %2 to check that patron has superlibrarian privilege, and maybe something else we don't care.

I think I fixed it everywhere except in acquisition, that will be addressed by BibLibre new acquisition module.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 17:06:46 -05:00
Michael Hafen
53922726fc bugfix: unbalanced TMPL_IF in opac-tmpl/.../masthead.inc
There used to be two TMPL_IF's here, now there's just one.  Missed removing
the second /TMPL_IF though.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 14:04:52 -05:00
Zeno Tajoli
ce3518b164 Fix bug 3266 The 'link' feature in MARC_framework is only for MARCDisplay
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 08:06:57 -05:00
Garry Collum
6f66396ff9 Bug 2266: Could not uncollapse a tag if you turn on advancedMARCeditor - Revised.
Added javascript and if/else logic to the addbiblio.tmpl and a corresponding anchor tag in CSS.
If advancedMARCeditor is on, the user now clicks on the tag number to expand the marc fields.
If advancedMARCeditor is off, no functionality has changed.  The user clicks on the marc tag's title to expand the marc fields.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 07:03:41 -05:00
Joe Atzberger
82f362673c Allow option to preserve Extended Attributes on patron import update.
Essentially, this patch provides the option to overwrite only matching
Extended Attributes, instead of all of them, treating the ext. fields more
like normal fields.

Several functions added to Members::Attributes with corresponding tests.

[ LL ref. 342 ]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 06:50:39 -05:00
Galen Charlton
38b3eacde0 bug 2641, 3263: minor fixes to labeled MARC view
* fixed to XHTML validation errors
* corrected copyright statement

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 06:42:35 -05:00
Galen Charlton
822e0ffeae bug 2642, 3263: new MARC display system preferences (DB rev 036)
* Added definitions of the new display sysprefs:

  viewISBD - Allow display of ISBD view of bibiographic records
  viewLabeledMARC - Allow display of labeled MARC view of bibiographic records
  viewMARC - viewMARC  Allow display of MARC view of bibiographic records

* Adjusted IntranetBiblioDefaultView
  * made type choice (fixing bug 1933)
  * added better description for English
  * added labeled_marc option

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 06:42:32 -05:00
Galen Charlton
6a86ce7581 bug 3263: fixed ersatz references to AmazonContent
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 06:42:28 -05:00
Rick Welykochy
7504a1bb5a bug 2641, 3263: Staff Search Results Interface Changes
New detail view: labeled MARC

New bib record view in the staff interface that
displays the MARC record in a single page.

Featured sponsored by MassCat.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 06:42:27 -05:00
Galen Charlton
42b58a7e52 bug 1933: started work fixing IntranetBiblioDefaultView syspref
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 06:42:22 -05:00
Galen Charlton
17ab0a7532 bug 3263: Staff Search Results Interface Changes
Coding by Rick Welykochy <rick@praxis.com.au>

[1] Three new system preferences to enable particular
bib record views in the staff interface:

viewMARC
viewLabeledMARC
viewISBD

Implements enhancement 2642.

[2] New button in the regular and cataloging search results
   pages in the staff interface to allow the operator to redo
   the search against Z39.50 targets instead of the Koha database.

[3] Added copyright date and edition to cataloging and Z39.50 search results.
    Implements enhancement 2640.

Feature sponsored by MassCat.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-28 06:42:20 -05:00
Galen Charlton
dbb7456021 fix DB rev for adding location to subscriptions: 035
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 11:59:58 -05:00
Galen Charlton
ee4de2f652 various improvements to subscription editing
* fix XHTML errors in template
* the patron notification type is now correctly
  displayed when editing a subscription
* turned on warnings (bug 2505)
* added ability to modify the grace period, missed
  in initial patch for bug 3020

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 11:59:57 -05:00
Henri-Damien LAURENT
af32ae0962 Adding and managing location in subscription
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 11:59:55 -05:00
Ryan Higgins
ca5e412c1b bug 3244: Support for multiple PAC interfaces.
Adds three env vars allowing url-specific search limits, and defining
how the limit interacts with 'SearchMyLibraryFirst'.
See http://wiki.koha.org/doku.php?id=en:development:rfcs3.2:rfc32_multiple_opac

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 10:52:23 -05:00
Chris Nighswonger
e72a02e08b Bug 2500 Tweaking DDCN Split for Hyphenated Volumn Numbers
Presently 252.051 T147 v.1-2 is split as

252.051
T147
v.1
-2

This patch corrects the algorithm so that it splits as

252.051
T147
v.1-2

It also updates Labels_split_ddcn.t to include this particular case.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 10:45:36 -05:00
Jesse Weaver
3206d0fe3c Small documentation improvement for C4::Service
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 10:08:36 -05:00
Galen Charlton
53b944b5f5 fix uninitialized value warnings during COinS generation
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 09:02:14 -05:00
Ricardo Dias Marques
87acbc5e9f Updated INSTALL.opensuse file to wiki version
Updated INSTALL.opensuse file to match the one currently (as of 26-May-2009) available in the wiki at:

Installation Guide for Installing Koha 3 on openSUSE 11 - Koha Developer Wiki
http://wiki.koha.org/doku.php?id=opensuse_11.0

This commit is supposed to be applied to the 3.0.x branch.

Changelog:

– Updated last modification date to 02-Dec-2008
– Tried to clarify that one should add the word "rewrite" (without the quotes) to /etc/sysconfig/apache2 in case a2enmod does NOT work
– "make test" does NOT return "Can't connect to data source" errors any longer. Updating "make install" section accordingly
– Updated "make test" output for Koha installation (it doesn't give connect errors any longer)
– Added prompt to accept permanent instlallation of "Test-Manifest-1.22.tar.gz" during "XML::RSS" install
– Installing "XML::RSS" now also installs "Time::y2038"
– Added "force install" of "Barcode::128"
– Added output of "MARC::Charset" installation (that points that it is already up to date)
– Updated "CGI::Session::Serialize::yaml" section that now installs Test::Pod
– Added "MIME::LITE" installation that is new in Koha 3.0 Final
– Removed ImageMagick installation because it's no longer required in Koha 3.0 Final
– Added instructions to install the "GD" Perl module and its package dependencies
– Added "Email::Date" installation that is new in Koha 3.0 Final
– Updated list of prerequisites according to changes done in Koha 3.0 Final
– Added missing step to install yaz. Thanks to Bob Ewart for catching it
– Added explanation of answering Yes to "Install the Zebra configuration files" in a NOZEBRA installation, like this one
– Added explanation of "fr" (French) choice for Koha install
– Promoted run "make install" to Heading 4

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 08:38:21 -05:00
d9c63270d0 Quick fix to catch some instances of XSS vulnerability, there will be more probably, thanks for the heads up Mark
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 08:04:18 -05:00
Joe Atzberger
f58b8916df Cleanup circulation.pl
Removed many unused variables.
Switched to elsif where appropriate.
Cleaned up some whitespace.
Corrected comments.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 07:33:03 -05:00
Joe Atzberger
8c0ac886bf Cleanup waitingreserves.pl and .tmpl
Use warnings and provide fallback values to avoid them.
Move waitingdate check up to top of loop.
Move $today creation outside loop (should be same for all).
Remove unused and unnecessary variables.
Add subtitle escaping to .tmpl and slightly standardize formatting.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 07:25:14 -05:00
400f2bad9e Bug 3169 - Google jacket display, remove preview image on result page
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 07:06:29 -05:00
Garry Collum
34f08ca117 Bug 1687: Can't assign holidays to all branches at once.
This patch adds a select box to the new holiday form that allows the user to copy the holiday to all branches. If a holiday for a particular location already exists for a location, that holiday and location is not changed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 07:06:26 -05:00
Garry Collum
22b55a4a1d Bug 3022: Cataloging statistic wizard not pulling the itemtype data correctly.
Added code to detect if the syspref for item-level_itypes is being used.  The report now correctly returns data based on the syspref.  There are some pre-existing XML errors with the FORM view of catalogue_stats.pl.  I'll send a subsequent patch to deal with these.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 07:06:24 -05:00
Galen Charlton
3cfa84362f bug 3219: handle variation in Amazon responses
An Amazon ItemLookup response can sometimes have
more than one Item element, where the ones after
the first appear to be cross references to items
that have the same ISBN.  Changed parsing so that
those responses are no longer treated like pseudohashes.

This fixes the following crash:

[error] detail.pl: Pseudo-hashes are deprecated at /catalogue/detail.pl line
213., referer: /cgi-bin/koha/catalogue/detail.pl

Which may lead to a nasty:
[error] Out of memory!, referer: /cgi-bin/koha/catalogue/detail.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 07:06:20 -05:00
Garry Collum
7457bc6d10 Bug 3261: Fix for invalid XHTML on Personal Details page.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 07:02:36 -05:00
Joe Atzberger
85b09f8d0e Cleanup view_holdsqueue.pl and .tmpl (minor)
Convert to GetBranchesLoop.
Insert template message to display for ALL libraries search, so that the
message is n0t truncated like "X items found for".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 06:55:49 -05:00
Galen Charlton
1e6ae8e650 minor fix - don't declare variables in a conditional
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 06:53:55 -05:00
Joe Atzberger
b83ee6b483 Cleanup branchtransfers
Remove unused sub and variables.
Convert to using GetBranchesLoop instead of local code.
Use elsif where appropriate.
Added fallback values and enabled warnings.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 06:46:52 -05:00
Joe Atzberger
3c9ed58cba Cleanup transferstoreceive.pl and .tmpl
Removed unused variables.  Replaced EXPR.
Inserted hidden span to correct tablesorter behavior on title field.  Without this patch
because of the link href in the cell, the sort would end up being effectively on
biblionumber, not title.

Mostly whitespace edits in template.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-27 06:43:17 -05:00
Garry Collum
6d75e726d5 Bug 3241: Place hold button appears on results page if opacuserlogin is off
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-26 10:20:12 -05:00
Nicole Engard
0d6e559c56 Fixed capitalization and standardized statements.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-26 08:51:51 -05:00
Garry Collum
7eff11f229 Bug 3253: Fixes XHTML for the Patron Statistics form page.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-05-26 08:51:31 -05:00