Commit graph

9507 commits

Author SHA1 Message Date
b70cd9f3eb Adding patron address to select patron form.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-04-01 10:49:27 -05:00
Nahuel ANGELINETTI
1bb9f76e66 (bug #3057) mandatory subfield edition
modify the "name" of mandatory input field.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 19:17:37 -05:00
Joe Atzberger
92051e44dd Convert opac-reserve to use GetBranchesLoop.
Removed irrelevant and unused variables dealing with branches.
Also pulled default branch from userenv when not specified as a param.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 19:06:54 -05:00
Joe Atzberger
9fa7abc255 Improve performance and fault tolerance for sync_items...
Pulled the GetMarcFromKohaField outside the loop, since we only need to
check it once.  Same for $item_sth.  Added safety checks for success of
delete_field and GetMarcItem, with warnings on failure.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 19:06:52 -05:00
Joe Atzberger
aef62d880c cleanup some of value_builder MARC21 plugins
Tons of unnecessary dependencies removed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 19:06:50 -05:00
Joe Atzberger
1c5637032a perltidy some ugly value_builder plugins
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 19:06:46 -05:00
Joe Atzberger
c16d624f8f whitespace cleanup and remove editor comments
No functionality affected.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 19:06:43 -05:00
Nahuel ANGELINETTI
f62ee9385f (bug #3063) fix unimarc 4xx plugin with cloned field
this patch fix the unimarc plugin 4xx to work with cloned fields, the id of the div wasn't replaced when the field was cloned.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 19:06:41 -05:00
24ecde6e08 Instructions and packages required for Debian Lenny Installation
INSTALL.debian-lenny
    Instructions for installing Koha on Debian Lenny.
    Based on INSTALL.debian. Almost all Perl modules are now available
    via Debian packages. MySQL installation is simplified.

debian-lenny.packages
    List of all Lenny packages required by Koha.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 18:37:10 -05:00
deba21330c Bug #3036 Avoid command-line installer blocking on opensolaris plateform
Koha installation/upgrade on OpenSolaris 'seems' to work.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 18:37:08 -05:00
Mason James
a0f4cfd85c fixes error below...
bookcount.pl: Illegal Date 'Item has no branch transfers record' does not match 'iso' format: yyyy-mm-dd at /home/mason/git/kap-k3-2/circ/bookcount.pl line 88

tested on 3.0.x

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 18:37:05 -05:00
Mason James
01f91622da fixes many 'Use of uninitialized value in string eq at ...' warnings.. at admin/branches.pl line 242.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 18:37:03 -05:00
7f3cac43d3 Changing "Waiting to be pulled" to "Pending" as per Bug 3033 'Holds "Waiting to be pulled" falsely implies that items are available'
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 18:37:00 -05:00
Henri-Damien LAURENT
32a84d56c5 Minor bug fix Documentation update : 3039
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 18:36:57 -05:00
3d2e952983 Hiding labels for add to list options when user isn't logged in or options don't exist. Fixes Bug 3043.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 18:36:55 -05:00
Mason James
dacb4e0e60 quietens a noisy debug pop-up, when debugging
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 18:36:49 -05:00
Joe Atzberger
13665732e8 Bug 2958 - notforloan (8008) is a numeric field.
Update index to allow searching for "On Order" items, -1 value.
Example:
http://atz.dev.kohalibrary.com/cgi-bin/koha/opac-search.pl?q=ccl=notforloan:-1

Without this patch, search for "-1" is normalized to "1".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 18:33:35 -05:00
Joe Atzberger
ec8ca853a6 Invalid field 'expiry' referenced.
This caused a warning from C4::Dates on every execution, since the value
passed to format_date was undefined.  Now we reference the correct field
and check for a populated value before trying to reformat it.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 18:33:33 -05:00
Henri-Damien LAURENT
66c3b26579 Bug Fix : weight field was broken in UNIMARC
Title-cover was not defined in record.abs
So the relevance ranking was broken.
This patch corrects that
For UNIMARC people, please reindex

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 18:33:31 -05:00
3c3e20526e Fix for Bug 3062, "place hold on lists different font"
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 18:33:26 -05:00
Galen Charlton
30dae108e6 convert '&' to '&amp;' in Syndetics URLs
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 18:17:46 -05:00
Galen Charlton
b465e24a6b DB rev 014 -> 015
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:24:43 -05:00
Daniel Sweeney
0e76b374eb Changed syndetics base URI from syndetics.com to www.syndetics.com
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:52 -05:00
Daniel Sweeney
afde76f1c1 Added upc to content_identifier_exists criteria.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:51 -05:00
Daniel Sweeney
1dd8e5996c Added content_identifier_exists test to opac-detail.tmpl to prevent broken images in Syndetics content for some titles.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:51 -05:00
Joshua Ferraro
bd5272f074 Fix for LL Bug 405: Syndetics Enhanced Content: some cover imags are being generated as IMGs but show as broken images
Adds new template variable to test for enhanced content identifiers

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:51 -05:00
Joshua Ferraro
0547da0093 Fix for LL Bug 404: Syndetics Enhanced Content: Excerpts show with embedded HTML tags and entity references
XMLout needed the NoEscape option set

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:51 -05:00
Joshua Ferraro
edcc606257 Syndetics Enhancement: adds upc/oclc to the functions to retrive non-image data
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:51 -05:00
Joshua Ferraro
3d65e44d5c Syndetics and Amazon bugfix enhancements
This patch resolves a number of problems related to Enhanced Content:

1. Previously, there was no syspref for controlling whether or not to display
Amazon.com cover images apart from other content. This had the side effect
of preventing use of amazon.com content alongside use of another provider's
images. This patch introduces AmazonCoverImages and OPACAmazonCoverImages,
and changes the name of AmazonContent to AmazonEnabled.

So, for instance, you can now enable OPACAmazonSimilarItems yet utilize
SyndeticsCoverImages for displaying those similar items.

NOTE TO DOCUMENTATION TEAM: please update references to AmazonContent
and OPACAmazonContent to comply with the above.

2. Fixes some semantically incorrect uses of AmazonContent (now OPACAmazonEnabled)
on the OPAC side.

3. Resolves once and for all, the normalization of ISBN,UPC,EAN and OCLC numbers
for all enhanced content elements; These elements can be normalized using the
new functions in C4::Koha; I've replaced use of the various previously used
variables $xisbn,$norm_isbn,$clean_isbn, etc with $isbn, and the template
variable normalized_isbn.

We finally have a single, consistant place to retrieve normalize values for
these fields given a particular record.

4. Adds Syndetics attribution statements to display of all Syndetics content
'enhanced content provide by Syndetics' or 'Enhanced Description from Syndetics'

5. Adds an option to view the large cover image on the detail page on the OPAC
when using SyndeticsCoverImages; this option is controlled by a new system
preference: SyndeticsCoverImageSize which has two values: MC (medium) LC (large)

6. Adds UPC and OCLC numbers for Syndetics enhanced content queries especially
helpful for finding enhanced content for DVD and Music materials

7. Adds capability to display Syndetics images to opac-user for checkouts and overdues

8. Updates to systempreferences.sql, and updatedatabase.pl database revision 015

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:51 -05:00
Joshua Ferraro
2eb8d90fc4 Second patch to address LL Bug 367 Titles without ISBNs display "no cover image available" while titles with ISBNS that don't match a Syndetics cover display nothing
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:50 -05:00
Joshua Ferraro
9abcd844f5 Add Syndetics AuthorNotes, Awards, Series
This patch also includes a new function to retrieve the index
page from Syndetics and parse it for available content prior to
retrieving content; this is done to speed up syndetics content
by not retrieving content that doesn't exist for an item. However,
Syndetics continues to be a very slow service compared to Amazon.com
and other enhanced content services

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:50 -05:00
Joshua Ferraro
91a998a2ec Fix for LL bug 367 Titles without ISBNs display "no cover image available"
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:50 -05:00
Joshua Ferraro
11bd4a7660 Adds Syndetics Reviews
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:50 -05:00
Joshua Ferraro
9806abf865 Adds support for Syndetics Excerpts and Editions
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:50 -05:00
Joshua Ferraro
de6227bd0a Add Syndetics Summaries and TOC
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:50 -05:00
Joshua Ferraro
2cc793f7aa Adding Syndetics Cover Images to OPAC Detail Page, including shelf browser
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:50 -05:00
Joshua Ferraro
e99fd37c69 Adds Syndetics Cover Images to Results Page on OPAC
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:49 -05:00
Joshua Ferraro
3d46ed59ee Add System Prefs for Syndetics to Auth
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:49 -05:00
Joshua Ferraro
69c74c06ae Move Amazon.pm to External/ directory
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:49 -05:00
Joshua Ferraro
49769420d3 Database Revisions for Syndetics Solutions Enhanced Content
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-27 17:23:49 -05:00
b9352f18b6 Fix for Bug 3031, Standardize OPAC login form labels.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-12 08:52:38 -05:00
Galen Charlton
3c04a7915a fix error introduced in a previous commit
Change to GetReservesFromBiblionumber() had effect
of causing all requests of constrainttype other
than 'o' to not be included in result.

while ($foo) {
    $bar or next;
    # do stuff
    # do other stuff
}

is not equivalent to

while ($foo) {
    if ($bar) {
        # do stuff
    }
    # do other stuff

}

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-11 10:39:33 -05:00
Galen Charlton
0d590c1e30 bug 3028: remove reservefix.pl cronjob
Removed cronjob, which was written to work around
a bug in 2.2 that no longer applies and is specific
to a single library in any event.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-11 09:12:16 -05:00
Joe Atzberger
a3ae0a5628 Test for LCCN splitting.
This test establishes what LCCN splitting is required to do
to be considered successful.  See Bug 2691.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-11 08:37:27 -05:00
c0b0a2741e Correcting delete patron button to use TMPL_VAR instead of DOM query. Fixes Bug 3014, Can't delete restricted patron from circulation screen.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-11 08:37:25 -05:00
ebc9a26686 Fix for Bug 3015: Check-in screen displays branch name inconsistently
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-11 08:37:23 -05:00
0a2be5e29b Changes to tabindex values to improve keyboard access.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-11 08:37:21 -05:00
Joe Atzberger
964e18e472 Sort collection codes by description for dropdown.
Collection code descriptions were otherwise displaying in an
unsorted order.  The result was not readable for any sufficiently
large number of ccodes.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-11 08:37:16 -05:00
90e995704c Fix for Bug 3027, Hide RSS option in patron messaging. Also includes some markup cleanup.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-11 08:37:15 -05:00
Joe Atzberger
6b3e5ce0dc Correct perldoc
Indentations misformatted for code blocks.  Also updated reference to
GetBranchesLoop.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-03-11 08:37:13 -05:00