Commit graph

10297 commits

Author SHA1 Message Date
Nahuel ANGELINETTI
b93b407f64 (bug #2829) fix some mistakes extracting editor segment
This patch fix how to extract the editor segment, and improve ISBN10/13 support.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 08:17:28 -04:00
Nicole Engard
0f3e4ae601 BUG 3371: ISBN no longer shows twice when more options on
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-22 16:41:26 -04:00
Nicole Engard
bfaebdf13e BUG #3533: Fix documentation link in news for new installs
This patch only fixes the link for new installs, not for
updates.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-22 16:40:45 -04:00
Nicole Engard
20949844c3 Cleaned up display on reports page
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-22 16:40:25 -04:00
Liz Rea
ca591d092b Adds helpful note to Home Phone and Home Email fields to remind staff which fields are shown on transit slips.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-22 16:33:44 -04:00
Darrell Ulm
8a4195658d Bug 2652 - This patch is an extension of the slip printing feature
and will print a SHORT SLIP of today's checkouts only.
 I also enhanced the normal slip to print the overdues separately as well as today's
 checkouts. There is another button on the print CIRC menu. Easily another quick key
 can be added, one for the regular slip and one for the short slip, i.e. today's
 only.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-20 21:08:05 -04:00
Colin Campbell
3199d032e5 Avoid numeric comparisons with leading zeroes
Numbers in perl with leading zeros are interpreted in octal
Ensure that comparisons are done using string operators
or where appropriate use the MARC::Field method

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-20 21:01:52 -04:00
b94e7acbbc Adding Katrin to the tranlsation tab on the about page
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-20 21:01:22 -04:00
Garry Collum
c89ed2ca1d Bug 3420: Revised follow-up patch for 'patrons with no checkouts'
Comments out all warnings that were used for debugging.

Enables warnigns and fixes the resulting warnings.

This patch replaces the previous follow-up patch for bug 3420.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-20 21:01:16 -04:00
Garry Collum
2c7d5b369d Bug 2889: Adds table highlighting to the Authority search results.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-20 21:01:13 -04:00
Chris Cormack
ae88b06b57 Edits to the about page : Adding a couple of missing developers, and adding ohloh links, still more links to go
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-20 21:01:11 -04:00
Garry Collum
10816a8b33 Bug 2505: Enables warnings in reserveratios.pl
Also fixes resulting warnings.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-20 21:01:08 -04:00
27e07d23d5 Remove utility script replaced by a test case
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-19 22:04:02 -04:00
Jane Wagner
bf38b1f7bb Bug 3532 show lost, damaged statuses on patron record
The patron record Details tab list of checkouts does not show lost, long overdue, claims returned, or damaged status, only that an item is overdue.  Added a check for lost and damaged statuses and a display of any matching statuses to the patron Details tab.

(revised version to drop unneeded lines from moremember.tmpl file)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-19 21:56:48 -04:00
5fc23f3fde Test case identifying incoherences between 'en' sysprefs and translated ones
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-19 21:56:43 -04:00
dfe0ffaa57 Follow up patch for the about patch, changing management team to release team
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-17 08:27:54 -04:00
811735595a Updating about page, some are bound to be missed, please send additional patches
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-17 08:27:51 -04:00
Garry Collum
315a541682 Bug 3420: Fixes 'Patrons with no checkouts' report.
Fixed typo in SQL statement.  Commented out some unused SQL statements.

Removed limit for itemtype (column not available in results) and added limit for branchcode.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-15 09:56:03 -04:00
201fab5c09 fixed glitch in display of current time filter in OPAC top issues
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-15 09:47:07 -04:00
Henri-Damien LAURENT
97a68f046e Translating unimarc_leader plugin in english
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-15 09:39:07 -04:00
Michael Hafen
2ace8cb33d bugfix invalid comparison to ceilingDueDate in CalcDateDue()
The comparison to check the ceilingDueDate is done in the syspref format,
which isn't a good comparison.  This changes to code so the comparison is done
using iso format.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-15 09:39:04 -04:00
Garry Collum
e60b571d6d Bug 2505: Enabled warnings in opac-topissues.pl
Fixed resulting warnings and fixed a small bug with the timeLimit drop-down box.  It would not retain its value on subsequent pages if 'no Limit' was selected as an option.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-15 09:39:02 -04:00
Garry Collum
5d23aafbee Bug 2553: Alphabetizes library and itemtype dropdown lists in Lost Items report.
Form - Fixes alphabetization of dropdowns.

Results - Fixes format of "Date last seen" to be the system date preference.  Adds highlighting to the table.

Enables warnings. Pages generated no warnings.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-15 09:38:59 -04:00
Nicole Engard
be8d899c98 Updated Help Files - Part 4
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-15 09:31:43 -04:00
Nicole Engard
cebfb00073 Updated help files - Part 3
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-15 09:31:36 -04:00
Nicole Engard
a5fba3c59d More Updated Help Files
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-15 09:31:25 -04:00
Nicole Engard
b13ff60615 Updates and adds new help files
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-15 09:31:21 -04:00
7340075163 Merge branch 'translation' of git://git.workbuffer.org/git/koha into test
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-15 09:24:47 -04:00
bd5925cd99 Starting work on translations for 3.2 2009-08-15 18:36:22 +12:00
8f103c4684 added new module dep Digest::SHA to about.pl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-13 09:29:57 -04:00
678262db3d bug 3204: tweaks to AWS request signing
* Add AWSPrivateKey system preference to the
  Enhanced Content tab in the syspref editor
* Now warns to log if attempting to use
  the Amazon API without setting AWSPrivateKey

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-13 09:29:57 -04:00
fcf2bfb638 bug 3204: add AWSPrivateKey syspref (DBrev 040->041)
The AWSPrivateKey syspref is describe more fully
in a previous commit, but to summarize, it should
contain the Amazon Web Services Secret Access Key
required by Amazon to sign requests to their
Product Advertising API.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-13 09:29:57 -04:00
b8a87ca256 bug 3204: followup to fix AWS request signing
[1] There were some ersataz spaces in the string
    being signed.
[2] AWS expects a trailing '=' in the Base64 signature

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-13 09:29:56 -04:00
Henri-Damien LAURENT
54f7ca4d3b bug 3204: implement request signing for Amazon Web Services
After 2009-08-15, Amazon Web Services will expect that
all requests to the Product Advertising API, which is what
Koha uses for retrieving reviews and other enhanced content
from Amazon, include signatures.  This patch and
subsequenct patches implement this functionality.

What this means in practice (assuming the user has elected
to use any enhanced content from Amazon) is that

[1] The user must get a Amazon Secret Access Key.  This can
    be done by logging in to the user's AWS account
    at (e.g.) http://aws.amazon.com/, going to the 'Access Identifiers'
    page, and from there retrieving and/or creating a new Secret
    Access Key.

[2] The contents of the Secret Access Key should then be
    entered into the new AWSPrivateKey system preference.

Once that is done, grabbing reviews and table of contents from Amazon
should work as normal.  If the user doesn't do this before 2009-08-15,
reviews and TOCs will no longer be supplied from Amazon, although there
should be no crashes - the content will simply not show up.

Note that the requirement to sign requests does *NOT* appear to apply
to simply displaying book covers from Amazon.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-13 09:29:56 -04:00
Nicole Engard
baa0b08149 ENH: 3525 - Link to OPAC View from Staff Bib
This patch adds a link to the OPAC view for a bib
record from the staff client so catalogers can
preview changes as the patrons see them.

This patch only shows the link is the OPACBaseURL
system preference has a value.

[RM note re bug 2152: this is probably enough to keep
 OPACBaseURL after all - the staff interface has
 no other way of reliably knowing where the OPAC
 is.]

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-12 21:50:16 -04:00
James Winter
898c269150 (Bug 3527) Removed unnecessary WHERE from UPDATE statement
The WHERE in this statement selected a bunch of different accounttypes, mostly legacy items.
But for sub writeoff to be called in the first place, it must have been an account with a
positive amountoustanding already, and we have the borrowernumber and accountnumber, so this
WHERE was un-needed, and prevented writeoff of locally-defined manual invoice types.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-12 21:31:50 -04:00
James Winter
13bef6756e Modified write in fines.pl to silence message unless verbose is set.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-12 21:31:45 -04:00
Garry Collum
11a1c687fd Bug 2505: Enabled warnings in opac-export.pl and opac-sendbasket.pl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-12 21:28:27 -04:00
Garry Collum
2bd29c4af4 Bug 2505: Enable warnings in opac-passwd.pl an opac-renew.pl.
Fixed resulting warnings in opac-renew.pl.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-12 21:28:24 -04:00
878d562a52 Terminology correction: we now use the term "hold" instead of "reserve"
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-12 21:14:31 -04:00
cef89fe6c2 Terminology correction: we now use the term "hold" instead of "reserve"
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-12 21:14:28 -04:00
f6519d10e3 Hide z39.50 search button for users without cataloging privileges.
This also simplifies the display of the z39.50 search button on the search results page. It's overkill to use a YUI button when there are already simpler standard buttons in use in the same area.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-12 21:14:24 -04:00
5c8d1a82c6 Adding some style to the OPAC search results page's "highlight" link
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-12 21:14:12 -04:00
2402601988 Fix for Bug 3256, "Long email address cut off in patron windows"
This fix tweaks the overflow settings for the email address and adds an image of an elipsis as the background, giving the appearance that the text is being truncated.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-12 21:13:59 -04:00
Garry Collum
90d1248a1b Bug 2505: Enabled warnings in opac-userupdate.pl
Enabled warnings.  Corrected all resulting warnings by initializing variables.

Some fixes and enhancements possibly related to Bug: 1153 - Existing B_address now shows in the resulting email. Birthdate now appears in the email using the System's default format. If the patron changes data in the form data took place the FIELD name now appears as uppercase in the resulting email.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-11 20:45:57 -04:00
Henri-Damien LAURENT
731b82f764 3519 : mergeauthority and authority edition were not synched
mergeauthority and ModAuthority were working on two separate directories.
So that no authority would ever be merged via cronjob or commandline script
when MergeAuthoritiesOnUpdate is disable

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-11 19:30:14 -04:00
d5da1cace0 future hold request followup 4 - date controls
Fixed the calendar control for selecting the request
date in staff and OPAC so that user can explicitly
select current date and all days in the future.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-11 19:23:40 -04:00
7242939cf4 future hold request followup 3 - build_holdsqueue
Fixed the holds queue job so that it correctly
ignores hold requests that are not yet scheduled
to be filled.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-11 19:23:40 -04:00
4ecaa1f9bd future hold request followup 2 - fix queries
Clarify when it is necessary to add a
'reservedate <= CURRENT_DATE()' clause.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-11 19:23:40 -04:00
e96c821ad7 future hold request followup 1 - updatedatabase
Fix so that syspref description is populated after
a database updated.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-11 19:23:39 -04:00