Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Julian Maurice	96cc447045	Bug 25898: Prohibit indirect object notation Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Jonathan Druart	638786e719	Bug 24663: Remove authnotrequired if set to 0 It defaults to 0 in get_template_and_user Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
David Roberts	9789a43025	Bug 24940: Serials statistics wizard: order vendor list alphabetically This patch changes the dropdown from being sorted by aqbookseller.id to aqbookseller.name To test: 1) Add at least 2 vendors: - First: ZZZZ - Second: AAAA 2) Add subscriptions for each of the vendors 3) Check the pull down in the serials statistics wizard and verify it lists them as ZZZZ, AAAA 4) Apply the patch 5) Re-check the pull down in the wizard and check that the vendors are now listed AAAA,ZZZZ Signed-off-by: Devinim <kohadevinim@devinim.com.tr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	4 years ago
Charlotte Cordwell	5d9348ffa2	Bug 20012: use Modern::Perl in Reports perl scripts Test Case: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; borrowers_out.pl cat_issues_top.pl catalogue_out.pl catalogue_stats.pl dictionary.pl issues_avg_stats.pl issues_stats.pl itemslost.pl manager.pl reports-home.pl serials_stats.pl stats.print.pl Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	6 years ago
Jonathan Druart	9b9803b69c	Bug 15758: Koha::Libraries - Remove GetBranchesLoop Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
Marc Véron	17af2c9a1e	Bug 14961: Remove C4::Dates from files reports/*_stats.pl Remove C4::Dates from following files: - reports/acquisitions_stats.pl - reports/borrowers_stats.pl - reports/reserves_stats.pl - reports/serials_stats.pl - reports/issues_avg_stats.pl - reports/issues_stats.pl To test: - Go to Home > Reports - Verify that following reports work as before: - Other > Average loan time - Statistic wizards - Acquisitions - Patrons - Circulation - Serials - Holds Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>	9 years ago
Jonathan Druart	a6c9bd0eb5	Bug 9978: Replace license header with the correct license (GPLv3+) Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> http://bugs.koha-community.org/show_bug.cgi?id=9987 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	9 years ago
Jonathan Druart	e20270fec4	Bug 11944: use CGI( -utf8 ) everywhere Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Bernardo Gonzalez Kriegel	5a9786eea8	Bug 12706: Remove CGI::scrolling_list from serial_stats.pl This patch depends on Bug 12696 Removed one instance in this file. Pulldown with one value, 'CSV' To test: 1. Apply the patch for Bug 12696 2. Apply this patch 3. Go to Reports > Statistics wizard > Serial 4. Check 'Into an application' pulldown, with value 'CSV' 5. Search for regressions Followed test plan. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and QA script, works as described. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Tomás Cohen Arazi	afd2418d73	Bug 11349: Change .tmpl -> .tt in scripts using templates Since we switched to Template Toolkit we don't need to stick with the sufix we used for HTML::Template::Pro. This patch changes the occurences of '.tmpl' in favour of '.tt'. To test: - Apply the patch - Install koha, and verify that every page can be accesed Regards To+ P.S. a followup will remove the glue code. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	10 years ago
Owen Leonard	d6c40ebe5a	Bug 11718 - Use new DataTables include in reports templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to all circ-related pages which use DataTables. Apply the patch and test the following pages to confirm that table sorting works correctly: - Reports -> Guided reports -> Use saved (reports/guided_reports.pl?phase=Use saved): "Creation date" sorting has been reconfigured to use the title-string method for sorting on an unformatted date. C4:Reports::Guided.pm has been modified to pass an unformatted date to the template. Sorting should work correctly for all settings of the dateformat system pref. - Reports -> Catalog by item type (reports/manager.pl?report_name=itemtypes) - Reports -> Serials statistics wizard (reports/serials_stats.pl): The subscription begin and subscription end columns have been modified to use the title-string filter for sorting. An unformatted date is now passed from reports/serials_stats.pl to the template, where the KohaDates filter is used for formatting. Sorting is based on the unformatted date. Sorting should work correctly for all settings of the dateformat system pref. - Sorting of titles should now exclude article from sorting. - Minor template improvements: - Vendor name now links to vendor details. - Subscription title now links to subscription details. - Library name is now shown instead of branchcode. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Checked all pages, no regressions or Javascript errors detected. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Jonathan Druart	c39380ed4e	Bug 8782: Close a subscription If a subscription is no longer enough published (or we are not waiting for a new periodical) we are allowed to close it. If a subscription is closed, we are not able to receive or generate a new serial. On the serial module, we can now - close a subscriptionn - reopen a closed subscription On serial search 2 tabs is displayed (opened and closed subscriptions). This patch adds: - a new field subscription.closed in DB - a new status for serials (8 = stopped) Test plan: - search subscriptions - close a subscription and check that you cannot receive or generate a new serial - launch another search and check that the closed serial is into the "closed" tab. - You are allowed to reopen a subscription on the subscription detail page and on the subscription result page. A javascript alert ask you if are certain to do this operation. - Check the serial status "stopped" everywhere the status is displayed (catalogue/detail.pl, serials/claims.pl, serials/serial-issues-full.pl, serials/serials-collection.pl, serials/serials-edit.pl, serials/serials-recieve.pl, serials/subscription-detail.pl and opac-full-serial-issues.pl) - The report statistics does not include the closed subscriptions if you don't check the "Include expired subscriptions" checkbox. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 8782: Followup: add some minor modifications - Show 'closed' information in biblio detail page - Add a column in serials report table - Search subscriptions on title words instead of string - Prevent serials editing when subscription is closed - Don't change status of "disabled" serials Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 8782 - Close a subscription - Followup - Fix updatedatabase.pl Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Owen Leonard	491c02f2e1	Bug 2553 [Serials report] alphabetize dropdown menus Rebase of a patch originally submitted by gcollum@gmail.com Original commit message: Improvement on the previous patch through the use of GetBranchesLoop. Added code so that the logged in location will be the location that is selected by default. Fixed a couple of minor xhtml errors. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	12 years ago
Dobrica Pavlinusic	95bf6fb012	Bug 7829 - reports/ remove all exit(1) for plack In Bug 7772 Ian correctly noted that reports have exit(1) all over the place. This is left over from old code, and this patch changes them to exit(0). I decided to use plain exit as opposed to explicit exit(0) since it produces cleaner code, but I'm welcoming suggestion on this. Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	12 years ago
Colin Campbell	263dded818	Bug 6752: Be stricter with utf-8 encoding of output use encoding(UTF-8) rather than utf-8 for stricter encoding Marking output as ':utf8' only flags the data as utf8 using :encoding(UTF-8) also checks it as valid utf-8 see binmode in perlfunc for more details In accordance with the robustness principle input filehandles have not been changed as code may make the undocumented assumption that invalid utf-8 is present in the imput Fixes errors reported by t/00-testcritic.t Where feasable some filehandles have been made lexical rather than reusing global filehandle vars Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	13 years ago
Galen Charlton	b49a0a30a1	bug 4176: remove references to unimplemented system preference MIME The intended functionality of this system preference was never implemented. To avoid template changes prior to 3.2.0, put in hard-coded string 'CSV' to (accurately) identify the type of the output files in the affected reports. Signed-off-by: Galen Charlton <gmcharlt@gmail.com>	14 years ago
Lars Wirzenius	6e7a4d3a3d	Fix FSF address in directory reports/ Signed-off-by: Galen Charlton <gmcharlt@gmail.com>	14 years ago
Matthias Meusburger	9a43a47755	MT 2051 : granular permissions for guided reports	15 years ago
Garry Collum	36e0248231	Bug 2553: Fixes location drop-down alphabetization in Serials Statistics wizard form. Signed-off-by: Galen Charlton <galen.charlton@liblime.com>	15 years ago
Nahuel ANGELINETTI	6c5bf09326	(bug #2939 ) delete a warning just add a default value to $sep Signed-off-by: Galen Charlton <galen.charlton@liblime.com>	16 years ago
Nahuel ANGELINETTI	720cddeca6	(bug #2938 ) add a serials subscriptions report this patch add a report for serials. It's have to limit branch/bookseller, and excluding expired serials. It's possible to export in CSV format. This patch will have another, to add this report in menus. Signed-off-by: Galen Charlton <galen.charlton@liblime.com>	16 years ago

21 Commits (bbb4c847b42c30ab785f21aa3195bf8831b452c6)