Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
8997 commits 35 branches 612 tags 1.8 GiB
Commit graph

50 commits

Author SHA1 Message Date
Joe Atzberger (siptest
bd0ef37c24 Bugs 2541 and 2587 - AddIssue must return date object as intended. 
SIP actually relied on the AddIssue return that was not reliable.
AddRenew also updated to return C4::Dates object for datedue.

Please note, any running SIPServer will have to be restarted
*immediately* after applying this patch, because although Koha
C4 behaves as normal, the SIP server runs as a Net::Server with
components cached.  Changes will not be applied until SIPServer
restarts, and so checkout actions may fail until then.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
 2008-09-11 08:06:04 -05:00
Joe Atzberger (siptest
288bbecf2f Correct application of noissues flag in SIP. 
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
 2008-09-09 10:52:44 -05:00
Joe Atzberger
a01f4056f1 Minor SIP cleanup, conditionalize warnings. 
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
 2008-08-27 09:55:00 -05:00
Galen Charlton
a670f1817e bug 2509: fix file permissions 
Following suggestion by Vincent Danjean for Debian
packaging, 0755 -> 0644 for non-executable
files.

Also removed shebang from a few modules in C4.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
 2008-08-21 18:55:02 -05:00
Vincent Danjean
c52357edc6 Still fixing permission and first line of scripts 
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
 2008-08-20 20:23:54 -05:00
Joe Atzberger
49bf046701 Prevent compilation errors from complex C4 import/export. 
SIP code uses UNIVERSAL modules that do not tolerate the circular deps in
C4, specifically, in Auth.pm.  Changing the order so that UNIVERSAL follows
the other imports is important to avoiding failures like:
  perl -w -e 'use UNIVERSAL qw(can); use C4::Auth;'
    "MarkIssueReturned" is not exported by the C4::Circulation module

This patch should resolve the problem earlier seen with Shelves too.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
 2008-08-18 07:15:39 -05:00
Andrew Moore
dde4051f1b Bug 2400 [18/18]: fixing pod syntax in C4/SIP/Sip/MsgType.pm 
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
 2008-08-12 19:43:24 -05:00
Andrew Moore
ab13ef3535 Bug 2400 [17/18]: fixing pod syntax in C4/SIP/ILS/Item.pm 
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
 2008-08-12 19:43:06 -05:00
Andrew Moore
0b49401746 Bug 2400 [16/18]: fixing pod syntax in C4/SIP/ILS/Patron.pm 
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
 2008-08-12 19:42:59 -05:00
Joe Atzberger (siptest
99efcf83f0 Interactive tests for SIP abstraction representation and Members. 
The test for members is useful to compare against the SIP (ILS)
representation.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-06-25 11:45:30 -05:00
Joe Atzberger (siptest
3e7013d174 Bugfix Circulation, Expand ILS::Patron mapping. 
ILS::Patron is where most of the intelligence for SIP's representation
is lodged.  Currently there is difficulty with C4::Members functions.
GetMemberDetails is required for the needed flags, but it returns
empty structure on bad barcodes, where it should be undef.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-06-25 11:45:29 -05:00
Joe Atzberger (siptest
5aecb46ad0 SIP - Lots of regexp hacking of input streams and verbose debugging feedback. 
The basic problem is that the SIP logic doesn't know where the
input is coming from.  It might be a RAW socket, and it might
be telnet.  If it is telnet, although the specs declare a
character set (from MS, unfortunately), they do not specify a telnet
implementation.  So you might get telnet handshaking or
renegotiations in the middle of an otherwise peaceful session and
these should not be taken as SIP commands.  Patches include a move
towards using $CRLF from Socket to avoid problems w/ foreign platform
mapping \n and \r to \015 or \012.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-06-20 06:12:42 -05:00
Joe Atzberger (siptest
1a46bc1218 Interactive debugging aides for SIP abstraction layer. 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-06-05 22:43:44 -05:00
Joe Atzberger (siptest
5f9a539104 Major SIP components reworked. 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-06-05 22:43:43 -05:00
Joe Atzberger (siptest
56cf70e52d Expanded SIP config file. 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-06-05 22:43:41 -05:00
Joe Atzberger (siptest
5671608e13 Object oriented module is not an Exporter. 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-06-05 22:43:40 -05:00
Joe Atzberger (siptest
910e13c4ad Add debugging around readline. 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-06-05 22:43:39 -05:00
Joe Atzberger (siptest
dd06b59fdc SIP tests for renew and renew_all. 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-06-05 22:43:38 -05:00
Joe Atzberger (siptest
84ba43c32e Debugging util. script for SIP config XML. 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-06-05 22:43:38 -05:00
Joe Atzberger (siptest
53576bbb19 Tweak verify_cksum. 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-06-05 22:43:37 -05:00
Joe Atzberger (siptest
4c42971c6e SIP abstraction layer implementation for ILS, Items and Patrons. 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-06-05 22:43:36 -05:00
Joe Atzberger (siptest
6750a1b250 Abstraction layer implementation for Transactions. 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-06-05 22:43:35 -05:00
Joe Atzberger (siptest
3ca5e017bc Add check to resensitize sub. 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-06-05 22:43:34 -05:00
Joe Atzberger (siptest
2cc75039d8 Object oriented module is not an Exporter. 2 subs added, also. 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-06-05 22:43:31 -05:00
Joe Atzberger (siptest
ba673bcc43 Correct package name. 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-06-05 22:43:30 -05:00
Joe Atzberger (siptest
926e6135e5 Object Oriented module is not an Exporter. 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-06-05 22:43:28 -05:00
Joe Atzberger (siptest
9ddb0afc66 Add do_renew_all function, necessary for implementation. 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-06-05 22:43:27 -05:00
Joe Atzberger (siptest
1d821fe51a Whitespace cleanup and one commented-out function added. 
Verify with: git diff -w  C4/SIP/Sip/Configuration.pm

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-06-05 22:43:26 -05:00
Joe Atzberger (siptest
07e51faa9b Trivial POD revision. 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-06-05 22:43:25 -05:00
Joe Atzberger (siptest
3f8e8e06f3 SIP/t - test files adapted, supplemented, expanded. Note: requires matching data to be loaded. 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-06-05 22:43:24 -05:00
Joe Atzberger (siptest
b9b4c5f963 SIP/koha_test - remove duplicative tests 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-06-05 22:43:23 -05:00
Chris Cormack
ef6b767117 Changing CanBookBeRenewed to pass back the reason a renewal cannot proceed 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-01-08 16:13:20 -06:00
Joe Atzberger
199daed4ed Sip.pm - BEGIN block VERSION and vars related to export. 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-01-07 20:02:43 -06:00
Joe Atzberger
68cdeccfe7 SIPServer.pm - BEGIN block VERSION and vars related to export. 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-01-07 20:02:42 -06:00
Galen Charlton
9d4d8897b2 item rework: various changes 
* Move CheckItemPreSave to C4::Items (from C4::Biblio)
* Modified C4::Biblio::AddBiblioAndItems to use appropriate
   internal routines from C4::Items
* Moved GetItemnumberFromBarcode to C4::Items
* Removed duplicate C4::Biblio::_koha_new_items
* Removed disused C4::Biblio::MARCitemchange

Currently AddBiblioAndItems is a special routine that
uses private subs from both C4::Biblio and C4::Items.
This needs to be refactored.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2008-01-03 16:25:42 -06:00
Joe Atzberger
377db43117 C4 and misc: permissions fixes 
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-12-13 19:00:34 -06:00
Ryan Higgins
cb1ec158c0 Adding calendar widget to circulation/stickyduedate 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-20 16:27:25 -06:00
Chris Cormack
51172422fe Tweaking test 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-06 06:33:23 -06:00
Chris Cormack
ca1d6576c5 SIP returns (checkin) working now 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-06 06:33:17 -06:00
Chris Cormack
117f261571 You can return items now BUT we need to get the branch to do this properly 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-06 06:33:11 -06:00
Chris Cormack
141cdbb3a3 Can check an item out now 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-06 06:33:08 -06:00
Chris Cormack
cc67a70f10 Work in progress on the SIP code 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-06 06:33:04 -06:00
Ryan Higgins
a10cb962ff updating test data for Koha system 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-06 06:33:03 -06:00
Ryan Higgins
3b246d26af more koha and data specific tests. 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-06 06:33:02 -06:00
Ryan Higgins
96c66ecf5e tiny cleanup 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-06 06:33:00 -06:00
Ryan Higgins
5c67b4e51a rm swp 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-06 06:32:59 -06:00
Ryan Higgins
e22429c53e continue getmember 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-06 06:32:58 -06:00
Ryan Higgins
b47c02a154 adding koha-specific / data specific test cases 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-06 06:32:57 -06:00
Ryan Higgins
cca508bbed updating ILS::Patron for Koha. 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-06 06:32:55 -06:00
Ryan Higgins
7b9b36bd2e adding openncip / opensip SIP2 service 
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
 2007-11-06 06:32:53 -06:00