Commit graph

2903 commits

Author SHA1 Message Date
Jean-André Santoni
c6027e73c5 Fixed a major bug in ModReceiveOrder
Orders were not splited correctly.
2010-01-28 15:11:53 +01:00
Jean-André Santoni
022978d4f4 [MT2593] Added "ordered" column in acqui-home budget display 2010-01-28 15:11:52 +01:00
Nahuel ANGELINETTI
800494a5ef (bug #4004) disallow access for non-logged in users in opac
This doesn't define borrowernumber = 0 if a borrower is NOT logged.
We know borrowernumber 0 is mysqluser... So in virtualshelves, a non logged user have all permissions.
2010-01-28 15:11:52 +01:00
Nahuel ANGELINETTI
da2ba2759c [followup](bug #3667) don't delete if member is guarantor
this fix cleanborrowers to don't delete guanrantors.
2010-01-28 15:11:52 +01:00
Nahuel ANGELINETTI
7855f1d8bd [followup](bug #3667) fix dateexpiry filtering
this fix the dateexpiry used to filter users, now we use date specified.
2010-01-28 15:11:52 +01:00
Nahuel ANGELINETTI
c2e245e2da [followup](bug #3667) cleaning borrowers fix
This fix GetBorrowersWhoHaveNotBorrowedSince to select only borrowers that have no issues and have no old_issues more recent than a specified date.
2010-01-28 15:11:52 +01:00
Paul Poulain
9d1e7f43e1 (bug #4020) XSLT unimarc display
When using XSLT Display, and UNIMARC,
since marcFlavour is not used in encoding data, when data is true utf8, as_xml
fails on some subfields.

Moreover, because transformMARCXMLForXSLT edits some values in the marc record
and the PERL UTF8 is not handled by MARC::File::USMARC, it endsup in double
encoding the data.
Sending a patch to fix both issues.

This patch adds
    - two functions in  C4/Charset.pm
        NormalizeString (uses Unicode::Normalize)
        SetUTF8Flag (This function in my opinion belongs to MARC::Record, or at least MARC::File::USMARC)
    - edits C4::XSLT in order to cope with the correct marcflavour
    - edits C4::Search searchResults to use setUTF8Flag
2010-01-28 15:11:51 +01:00
Henri-Damien LAURENT
a97d12faa7 C4::SQLHelper Changing $$ notation to $ -> 2010-01-28 15:11:51 +01:00
Henri-Damien LAURENT
3b43a79c43 Suggestions.pm :Changing $$ notation to $ -> 2010-01-28 15:11:51 +01:00
Henri-Damien LAURENT
6a3579b2f3 MT 2285 : enhancement for patronSearch 2010-01-28 15:11:51 +01:00
Paul Poulain
01ba63a84f #4003 default value in PrepareItemrecordDisplay
The default value you can define in cataloguing framework was not used for item created from acq or serial recieve
2010-01-28 15:11:50 +01:00
Henri-Damien LAURENT
f64de645da Bug :authid empty in Authorities Default summary 2010-01-28 15:11:50 +01:00
Nahuel ANGELINETTI
e75d26e794 (bug #3667) fix borrowers cleanup
This add a check of borrower expiry date, and don't delete the borrower if he's still active.
2010-01-28 15:11:49 +01:00
Matthias Meusburger
5f61beed72 MT2408 : UI Changes / CSV Export 2010-01-28 15:11:48 +01:00
Henri-Damien LAURENT
23a1397419 Dates : improvements string recognition
Dates can now have one digit for month and day
2010-01-28 15:11:47 +01:00
Matthias Meusburger
6281ed6b91 MT 1801 : Opac shelves and basket are displayed the same way
This patch also fixes broken location display in both shelves and basket.
2010-01-28 15:11:47 +01:00
Henri-Damien LAURENT
f0aee34d3f followup : auto_truncation 3287252c0
truncated words bore a double * which would create an error

Conflicts solved :
	C4/Search.pm
2010-01-28 15:11:46 +01:00
Henri-Damien LAURENT
f6f80e1b8b Bug Fix : 3689
Disabling Query_AutoTruncate for NoZebra searches

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2010-01-28 15:11:46 +01:00
Henri-Damien LAURENT
640595651f (bug #3584) detect ccl queries
This patch C4::Search::buildQuery to detect ccl queries, and let zebra to parse them.
And set a default index "kw" if not specified.
This improve the detection of ccl queries, and do not duplicate the "ccl=" value.
Adding = as an index sign
Followup to 3037ff9e81

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2010-01-28 15:11:46 +01:00
Henri-Damien LAURENT
10c727edf3 Revert "C4/Search.pm followup auto_truncation 3.0.x cherry-pick"
This reverts commit 58406a5e4bb50e18c9620e91b90295d8219842b8.

Conflicts:

	C4/Search.pm
2010-01-28 15:11:46 +01:00
Paul Poulain
7d8b369ba4 Improved guided reports (#3929)
added runtime parameters for guided reports. Online help:

Can I have run-time defined parameters?

Yes, you can: there is a specific syntax that Koha will understand as 'ask for values when running the report'. The syntax is &lt;&lt;Question to ask|authorised_value&gt;&gt;.

The &lt;&lt; and &gt;&gt; are just delimiters. You must put &lt;&lt; at the beginning and &gt;&gt; at the end of your parameter
The Question to ask will be displayed on the left of the string to enter.
The authorised_value can be omitted if not applicable. If it contains an authorised value category, or <strong>branches</strong> or <strong>itemtype</strong> or <strong>categorycode</strong>, a list with the Koha authorised values will be displayed instead of a free field

Note that you can have more than one parameter in a given SQL
Note that entering nothing at run time won't probably work as you expect. It will be considered as "value empty" not as "ignore this parameter". For example entering nothing for : "title=&lt;&lt;Enter title&gt;&gt;" will display results with title='' (no title). If you want to have to have something not mandatory, use "title like &lt;&lt;Enter title&gt;&gt;" and enter a % at run time instead of nothing
Sample :
SELECT surname,firstname FROM borrowers WHERE branchcode=&lt;&lt;Enter patrons library|branches&gt;&gt; AND surname like &lt;&lt;Enter filter for patron surname (% if none)&gt;&gt;
2010-01-28 15:11:46 +01:00
Matthias Meusburger
94cca6a22b MT 2495 : Fix multiple occurences of itemtype in guided reports criteria
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2010-01-28 15:11:45 +01:00
Henri-Damien LAURENT
697e8e7014 SearchInTable : problem with primary key searches
SearchInTable was filtering primary Key thus returning the whole table when asked a search on a primary key
2010-01-28 15:11:45 +01:00
Jean-André Santoni
0ed6bcdabb [MT1234] Huge rewritte to use the API instead of hardcoded SQL in the script
Also fixes a bug in the template.
2010-01-28 15:11:44 +01:00
Henri-Damien LAURENT
c8ff9618cd followup : auto_truncation 3287252c0
truncated words bore a double * which would create an error
2010-01-28 15:11:43 +01:00
Henri-Damien LAURENT
e5c8244009 C4/Search.pm followup auto_truncation 3.0.x cherry-pick
Auto_truncation is used even though exact search selected.
This patch removes this side effect

Conflicts solved:
	C4/Search.pm
Cherry-picked from 3.0.x :
	3287252c0
2010-01-28 15:11:42 +01:00
8ad2c7d7ac Merge commit 'pianohacker-koha/prefs-submit' into master
Merge in Jesse Weaver's system preference editor changes.

Conflicts:
	C4/Bookfund.pm
	koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
	koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc
	koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tmpl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-01-26 20:26:17 -05:00
Jane Wagner
885c68e269 Bug 3294 Use cn_sort field to sort inventory list output
The inventory tool was using itemcallnumber, title to sort; modified
Items.pm to use cn_sort, itemcallnumber, title so that call numbers
sorted on the padded sort field instead.
2010-01-23 15:33:23 +01:00
Henri-Damien LAURENT
d339abf0bf Merge branch 'patroncards-wip' of git://git.foundations.edu/koha into community
Conflicts solved:
	Makefile.PL
	installer/data/mysql/en/mandatory/sysprefs.sql
	installer/data/mysql/fr-FR/1-Obligatoire/unimarc_standard_systemprefs.sql
	installer/data/mysql/updatedatabase.pl
	kohaversion.pl
2010-01-20 23:16:34 +01:00
Kyle M Hall
2d1d4cd6e7 OpacAddMastheadLibraryPulldown
In the current OPAC, there is no easy way to search a particular library.
By default, a user searches all libraries, or with SearcMyLibraryFirst turn on,
the user's home library. In dev_week, a library pulldown menu existed in the search masthead.

This commit adds the option to bring that pulldown menu back
by turning on the system preference OpacAddMastheadLibraryPulldown
2010-01-20 22:38:23 +01:00
f650aad34b Rotating Collections
This feature is designed to manage collections of items that move
from library to library periodically. Koha can already track who *has*
and item, and who *owns* and item, but not who *should have* an item.
That is the issue this feature addresses.

It allows a persion to create a collection, and add any number of items
to that collection. The collection can then be transferred from library
to library. If an item shows up at a library that does not currently
'hold' that collection, Koha will ask you to transfer it to the library
that does currently 'hold it. In that way, one can even transfer
collections where some of the items are currently checked out. As soon
as they make it back to a library, they will get transferred to the
current library holding that collection.

The feature consists of 4 main pages.
'Home' Page: The landing page, lists collections and provides access to
the rest of the tools.
  Access is via the Tools page.
Edit Collections: Add/Delete new rotating collections
Add/Remove Items: Add/Remove items from a given collection
Transfer Collection: Set the current 'holder' of a given collection.

Librarian access is controlled by 'CAN_user_tools_rotating_collections'
2010-01-20 22:35:15 +01:00
a078297d1f Fix for Bugs 3998, 3968. Includes other markup corrections and reformats
Bug 3998: Confusing warning on budget add page
Bug 3968: Empty Blue Box Pop Up

- Removed warning, made budget amount a required field.
- Added conditional logic to prevent display of tooltip when there is no content
- Moved filter form into sidebar
- Changed Budgets.pm to pass an ID to a form field
- Improvements to breadcrumbs and title tags
- Restructured budgets admin toolbar to match existing toolbar patterns:
  "new," "edit," etc.
2010-01-20 22:31:58 +01:00
Henri-Damien LAURENT
f3868bf6fe Adding Extended Attributes management to Auth_with_LDAP 2010-01-20 22:29:10 +01:00
Chris Nighswonger
ff13d25bb3 Bugfix: Various Label Creator bugs
This fixes:

* A bug which caused the label template editor to throw
an error when saving when no previous profile was applied.

* A typo which caused a 'fetch without execute' error in Labels.pm

It also comments out several useless warns
2010-01-19 22:27:09 -05:00
49ae985518 Fixes for Bug 3376, Serials Display in OPAC
- Formatting links to different subscription views as tabs like the links to MARC view, ISBD, etc.
- Styling display of brief subscription view for better clarity
- Moving filter form on full subscription view to sidebar
- jQuery-fying some full subscription view scripts
- Adding branch name to output of full subscription information
- Styling year links for visibility and clarity (I'm not styling them as standard tabs because
  they wouldn't wrap well with many many years' worth of subscriptions)
2010-01-19 22:11:35 +01:00
9cdf370f67 Fix for Bug 3589, OpacHighlightedWords sys pref does nothing 2010-01-15 10:12:28 +01:00
Chris Nighswonger
47fa09e85c Enhancement: Make web installer log errors to error log
The web installer should log errors to the error log instead of only
dumping them to the browser. This will allow a record of the errors
which may be useful for later debugging.
2010-01-15 10:00:36 +01:00
074efa8dce Overdue Notices: Add a Bcc to messages
If a global syspref OverdueNoticeBcc is present, send overdue notices to
this address. This allow a library to track and gather all outgoing
overdue notices.
2010-01-15 09:59:32 +01:00
Chris Nighswonger
7682f493c6 Enhancement: Make web installer log errors to error log
The web installer should log errors to the error log instead of only
dumping them to the browser. This will allow a record of the errors
which may be useful for later debugging.
2010-01-13 13:30:31 -05:00
Chris Nighswonger
ed7009df42 [30/30] Removing depricated files 2010-01-11 18:21:43 -05:00
Chris Nighswonger
8a0db421bd [15/30] Patron Card Creator profile editor interface and code 2010-01-11 18:21:13 -05:00
Chris Nighswonger
7edf6810e6 [12/30] Patron Card Creator layout editor interface and code 2010-01-11 18:21:12 -05:00
Chris Nighswonger
666c70d9cf [11/30] Patron Card Creator batch editor interface and code 2010-01-11 18:21:11 -05:00
Chris Nighswonger
fdd149d406 [8/30] Patron Card Creator template editor interface and code 2010-01-11 18:17:05 -05:00
Chris Nighswonger
ff9b43e386 [6/30] C4::Creators module
Here we consolidate all code common to both Label and Patron Card Creators.
2010-01-11 18:17:04 -05:00
Chris Nighswonger
4a675bcaad [5/30] A rework of Label Creator code
This rework removes code held in common with the Patron Card Creator
and move is to the new C4::Creators module.
2010-01-11 18:16:52 -05:00
Chris Nighswonger
e0dfa63306 [2/30] C4::Patroncards::Lib 2010-01-11 18:16:16 -05:00
Chris Nighswonger
347848ede3 [1/30] C4::Patroncards::Patroncard Module
A module for creating patron card objects and manipulating them.
2010-01-11 17:23:06 -05:00
Colin Campbell
f5de454caa Bug 3945 NULL is not a valid Supplier id
Get SuppliersWithLateIssues should return a list of suppliers
If you have subscriptions with no supplier it also returned a
invalid supplier with a null id and null name.
This patch ignores the non-supplier supplier
2010-01-06 17:01:49 +01:00
115dd8752f Interface corrections and improvements to OPAC lists
- improving behavior for users with no javascript
- style improvements to list "toolbar"
- adding new toolbar icons
- adding display of subtitle to lists
2010-01-05 13:54:09 +01:00
7cc44be17d Moving some list functions into the standard toolbar.
- Adding download functions to menu button
- Some markup corrections
2010-01-05 13:54:08 +01:00
Chris Cormack
27ba6ff050 Bug 3930 link to biblio was missing in manage staged marc import 2009-12-20 14:31:43 +01:00
Chris Cormack
7a4f725c8b Fixing bug with CanBookBeReserved ... rules for default borrower codes were being ignored 2009-12-20 14:31:37 +01:00
d8b299bcda Removing global database handler, breaking tests and dangerous if we ever use mod_perl - All tests now passing 2009-12-20 14:31:37 +01:00
d51332698b Bug 1807, can now search with : in the box if you want to use ccl do ccl: title=fish 2009-12-20 14:31:35 +01:00
111bdfddfa Bug 1807 - Commenting out flawed nested queries implementation, now users can search using () 2009-12-20 14:31:35 +01:00
Jean-André Santoni
e3c78da1eb [MT2435] Fixed the SQL syntax error in GetLateOrders 2009-12-20 14:31:23 +01:00
Garry Collum
898b78535b Bug 3955: Fixes leading space error in search.
Leading spaces in a search term were causing an error to be thrown in a join operator when auto-truncations is turned on. This patch removes the leading spaces.
2009-12-20 14:28:48 +01:00
ec48133f71 Bug 3863 - Amazon Content Not Working
Sysprefs were not sent to templates.
2009-12-20 14:27:03 +01:00
Michael Hafen
929d281e93 bugfix Move Item From Biblio - biblioitemnumber isn't the same as biblionumber
In the database and code biblioitemnumber is not guaranteed to be the same as
biblionumber.
2009-12-20 14:27:02 +01:00
David Birmingham
77141dab35 Translated & to &amp; in xmlrecord
If the homebranch tag had an & in its name, then the XML wouldn't parse
correctly.  As a result, if XSLT was turned on, "No copies available" would
always be displayed.
2009-12-20 14:26:35 +01:00
Henri-Damien LAURENT
5b9ed679c5 haspermission signature had changed 2009-11-23 17:05:55 +01:00
Matthias Meusburger
54b6b9bd1d Remove ticket parameter from auto added hidden fields.
(Normal login directly after a failed CAS login didn't work previously to this removal)
2009-11-23 16:37:54 +01:00
Matthias Meusburger
c92bc8d73b Added debug mode for CAS warn messages 2009-11-23 16:34:31 +01:00
Matthias Meusburger
26d85c3cd6 Add missing return when CAS user is invalid 2009-11-23 16:32:40 +01:00
Henri-Damien LAURENT
36a01ea347 Second CAS version : CAS and non-CAS login can coexist
Conflicts solved :

	C4/Auth.pm
	opac/opac-main.pl
2009-11-23 16:26:35 +01:00
Matthias Meusburger
77ab8970f1 Add a syspref for CAS logout 2009-11-23 16:23:27 +01:00
Matthias Meusburger
acdd090246 Moved CAS configuration from config file to sysprefs 2009-11-23 16:23:20 +01:00
Henri-Damien LAURENT
7126496210 First CAS version : when CAS is enabled, login through CAS is mandatory
Conflicts solved C4/Auth.pm
2009-11-23 16:21:37 +01:00
Henri-Damien LAURENT
b323737267 MT1883 : Serials enddate was not cleanly used
GetExpirationDate should now be used only to get the NEXT expirationdate based on startdate
Perltidying C4/Serials.pm
2009-11-19 23:09:47 +01:00
Paul Poulain
66ade62eb4 oups, sorry, fixing mistake in previous patch
(reverting a not related and probably bogus change)
2009-11-19 23:09:47 +01:00
Paul Poulain
50c980b028 revamping a little opac-detail for subscription (adding more history information) 2009-11-19 23:09:47 +01:00
Matthias Meusburger
b529f00aa3 MT 2050 : Fast cataloging 2009-11-19 23:09:46 +01:00
Henri-Damien LAURENT
677111b342 Bug Fixing : C4/Acquisition.pm
Updating ModStatus to ModSuggestion
2009-11-19 22:54:41 +01:00
Nahuel ANGELINETTI
2bf19bc97a (bug #3674) allow users creation with disabled password 2009-11-19 10:40:28 +01:00
Henri-Damien LAURENT
c4f19cbac9 MT 2298 : Fix hidelostitems
This patch fixes the opac search, and C4::Search to take care about hidelostitems for items, and not records.

Conflicts solved C4/Search.pm
2009-11-19 09:33:20 +01:00
Henri-Damien LAURENT
3daa3143ff 2298 2299 : Search.pm and opac-search.pl
Removing filter available and hidelostitems at Biblio level
2009-11-19 09:27:17 +01:00
Nahuel ANGELINETTI
2345dc7c27 (bug #3778) GetBranchesLoop and searchMyLibraryFirst
This fix GetBranchesLoop, if searchmylibraryfirst is disabled, getbranchesloop mustn't select any branch.
2009-11-18 19:12:45 +01:00
Nahuel ANGELINETTI
8f292e4e50 (bug #3783) fix marcurls
this permit to have multiples urls in one field
2009-11-18 19:04:52 +01:00
Henri-Damien LAURENT
d83ca6fedf Adding a test in C4::Charset in UNIMARC_Encoding 2009-11-17 16:27:13 +01:00
Henri-Damien LAURENT
9d52c46dda Better conformance for UNIMARC Authorities Encoding
encoding is on 8th character and not 9th
2009-11-17 16:27:12 +01:00
Paul Poulain
b89765e682 removing hardcoded (english) string 2009-11-17 16:27:12 +01:00
Paul Poulain
feaaffd0b1 missing ) result in SQL error 2009-11-16 17:21:58 +01:00
Henri-Damien LAURENT
19ac7c1569 Bug Fix : 3343 MT1313 Authorities MARC summary
When more than one heading, fields are mixed and not well ordered
2009-11-11 20:59:32 +01:00
Henri-Damien LAURENT
72d91ac361 Adding a warning On subscription deletion for item
If we really wanted to delete all items linked to a subscription when we delete a subscription
we should change the database structure as such :
ALTER TABLE serialitems ADD FOREIGN KEY ( itemnumber ) REFERENCES items (itemnumber) ON DELETE CASCADE ;
ALTER TABLE serial CHANGE subscriptionid subscriptionid INT( 11 ) NOT NULL
ALTER TABLE serial ADD INDEX subscription ( subscriptionid )
ALTER TABLE serial ADD FOREIGN KEY ( subscriptionid ) REFERENCES subscription (subscriptionid) ON DELETE CASCADE ;
2009-11-11 15:19:24 +01:00
Henri-Damien LAURENT
fc1a5ed318 MT1883 : Serials enddate was not cleanly used
GetExpirationDate should now be used only to get the NEXT expirationdate based on startdate
Perltidying C4/Serials.pm
2009-11-11 14:00:11 +01:00
Paul Poulain
761211ca0c reindenting & removing comments 2009-11-11 11:17:47 +01:00
Paul Poulain
74fed183f9 oups, sorry, fixing mistake in previous patch
(reverting a not related and probably bogus change)
2009-11-10 22:23:50 +01:00
Paul Poulain
6c086454ff revamping a little opac-detail for subscription (adding more history information) 2009-11-10 22:23:50 +01:00
Jane Wagner
0157b46e13 Bug 3702 add branch description as primary sort for items in staff mode
The default sort order for items attached to a title in staff mode is
items.dateaccessioned desc.  This means that a particular library's holdings
will be scattered through the list -- a special problem when it comes to serial
issues.  I've done a change to Items.pm that makes the sort order branch
description followed by dateaccessioned.  Thus, a library's holdings will be
grouped together in the display.
2009-11-10 22:23:50 +01:00
Paul Poulain
ed047fead8 adding XSLT for intranet (UNIMARC only, MARC21 will be done by kf)
- the XSLTParse4Display sub now has a new parameter : the interface (intranet or opac)
- the XSLTdisplay sysprefs is common to staff & opac (Auth.pm)
- added UNIMARC xslt in intranet templates (modified to deal with staff/opac differences)
2009-11-10 22:23:50 +01:00
Paul Poulain
35fc57ae39 subs declared twice 2009-11-10 22:23:49 +01:00
Paul Poulain
638dfd30e5 fixing overdue checking (today is not late)
NOW() returns minuts and seconds. date_due is just YYYY-MM-DD
Thus date_due < now() is wrong if date_due is today, and the patron is considered as late.
With curdate(), the patron is late only the day after the overdue limit
2009-11-10 22:23:48 +01:00
Henri-Damien LAURENT
a4ac58cec8 enhancement C4::Members.pm Improving POD
Adding a function to output field as xml
2009-11-06 12:33:15 +01:00
Henri-Damien LAURENT
486c0b075e SQLHelper Enhancement Adding contain as searchtype 2009-11-06 12:33:15 +01:00
Henri-Damien LAURENT
50e8e5a33f enh Serials-collection Checking claimed late and expected issues
Could be better handled with jquery
2009-11-06 12:33:15 +01:00
Jean-André Santoni
eff46d395e Adds billing address support in the basketgroup.
Also fixes a bug in ModBasketgroup, and renames the PDF uploaded to the client.
2009-11-04 13:17:09 +01:00
Jean-André Santoni
d61161a3d5 [3.2.x](bug #3624) Per-basketgroup delivery place
Librarian are now able to select a different delivery place for each basketgroup. They can choose one from the branch list or manualy using a textarea.
Database schema and PDF generation have been modified to reflect these changes.
2009-11-02 17:02:02 +01:00
Henri-Damien LAURENT
ee7d0af37b POD improvement 2009-11-02 16:51:20 +01:00
Paul Poulain
4de7b92904 some reindenting & XHTML compliance 2009-10-30 13:49:39 +01:00