Commit graph

237 commits

Author SHA1 Message Date
Chris Cormack
c1181b780b Merge remote branch 'kc/new/pending_qa/enh/bug_3644' into kcmaster 2011-04-09 19:16:45 +12:00
4747f5adb2 Bug 4189 : Searching z39.50 without selecting any servers results in error message
This patch makes z3950_search.pl handle the situation properly, and z3950_search.tmpl
show a proper message instead of a program error. All this, in case the javascript
checks that alert the user (that at least one target has to be chosen)  are by-passed.

Regards
To+

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Fixed small translation problem in javascript alert message.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-04-08 13:19:20 +12:00
33c7b21cde Bug 6084: Missing translation markers in javascript alert messages
I ommited commented lines and "if $debug" lines too.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-04-07 21:46:45 +12:00
Jared Camins-Esakov
f0b17df29a Fix two small typos in MARC21 field 006 value builder
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-04-04 08:56:14 +12:00
Magnus Enger
edf8ad5d5d Bug 3644 Add support for NORMARC
- XSLT for the OPAC
- Value_builders for lesder, 007 and 008
- Default NORMARC framework
- Reverse MARC logic of some subs, so MARC21 is default (and works for NORMARC)
- Add NORMARC as an option to the syspref marcflavour
- Add record.abs for NORMARC
- Add NORMARC and nb as options to Makefile.PL
- Add etc/zebradb/lang_defs/nb/sort-string-utf.chr
- Copy MARC21slim2OAIDC.xsl to NORMARCslim2OAIDC.xsl

Some things are still missing, e.g.:

- XSLT for Intranet
- More MARC21slim2*.xsl transformations
2011-03-30 10:13:37 +02:00
Chris Cormack
554c77569d Merge remote branch 'kc/new/bug_3013' into kcmaster 2011-03-13 14:02:06 +13:00
Janusz Kaczmarek
728b3725df Bug 5569: Corrections to addbiblio.tmpl to be able to delete repetable mandatory subfields
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-03-12 20:48:54 +13:00
Chris Cormack
b06a289173 Merge remote branch 'kc/master' into new/bug_3013 2011-03-08 08:28:42 +13:00
Salvador Zaragoza Rubio
519cb622db Bug 3013 - Value builder for 006 and 008 need choices for all format types
Modification of the intranet cataloguing plugin for 006/008 fields to allow
select a type of material and change the positions available to enter the data.
Data are hard stored in xml files to allow easy translation and processing through
Javascript and JQuery-AJAX.

Bug 3013 - Fix selection of combo and trailing whitespace

Bug 3013 - Fix selection of combo

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-03-08 08:28:32 +13:00
Chris Cormack
3f35705ddc Merge remote branch 'kc/new/enh/bug_2170' into kcmaster 2011-02-15 15:55:54 +13:00
173d3cbb2d Follow-up fix for Bug 2170 - Adding 'edititems' user-permission
Save button and duplicate confirmation redirects must respect
the edititems permission: Users without permission to edit items
should not be redirected to the edit items screen.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-02-15 10:31:22 +13:00
af1009da3d Bug 5735: Expanding/collapsing cloned fields in editor takes original field
Adds corrected onclick response for expanding marc tags.
Removes some lines that did not work as promised.

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-02-14 09:50:32 +13:00
Paul Poulain
3a29f37dff Bug 5726 : MT1059 Follow-up : Fix merge reference selection presentation
A change in global-staff.css messed the merge reference selection presentation

    Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-02-09 13:47:00 +13:00
Chris Cormack
a4cc394508 Bug 5691 - Delete all items respects independentbranches system preferences
Squashed commit of the following:

commit 66cdb8804136803a3f626d183c8f192f61f3c7b1
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Fri Feb 4 12:55:10 2011 +1300

    Bug 5691: Updating copyright statement

commit 79ef6c269afc9c644c51709a7657542a0fc6d7d6
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Fri Feb 4 12:52:13 2011 +1300

    Bug 5691 - Fixing a syntax error and tidying up some formatting

commit a66485dba113c05ed51a3b4ff19f788e335aa1f6
Author: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Date:   Tue Oct 5 17:23:55 2010 +0200

    (MT #1365) Delete all items

    Using DelItemCheck in cataloguing/additem.pl
    when deleting all items

commit fe845fd48ab22ff82ad6d8971c468c327b49f3c4
Author: Christophe Croullebois <christophe.croullebois@biblibre.com>
Date:   Wed Sep 22 11:39:28 2010 +0200

    (MT #1365) Delete all items

    Now if IndependantBranches is on and a user try to delete all items, only the items of his branch will be deleted.
    A message explain this fact.

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>

Followup: (MT #1365) Fixing up the English idiom
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-02-05 07:41:29 +13:00
Christopher Hall
8fd29f3d62 Bug 5462: both intranet and opac seem to be 'clean', still need to make relevant changes in scripts
Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
2011-02-03 09:57:00 +00:00
86df2d1efa Bug 5480 Some usual UNIMARC cataloguing plugins doesn't work anymore
[3.2] To be applied

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-01-10 04:47:20 +13:00
Colin Campbell
926ab8c544 Bug 5583 Rename fieldnumber to blocknumber
Variable fieldnumber does not refer to a field
It is the ISBD block number
Rename to blocknumber
Say what we mean adds to maintainability

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-01-07 09:42:05 +13:00
Colin Campbell
782654d178 Bug 5582 Pass tag nums as a string to Doc Popup
Add quotes around tag number when calling doc popup
Otherwise numbers with leading zeroes are interpreted
as octal e.g. 020 returns doc for 016

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-01-07 09:41:01 +13:00
d6e83087a4 Fix for Bug 3859, Attach item clarification
- Modifies hint text
- Adds handling for BiblioDefaultView preference
- Markup and CSS tweaks

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-17 09:41:28 +13:00
bd7cca935b Updated fix for Bug 2170, Adding 'edititems' user-permission
This patch follows up on the addition of the 'edititems'
permission by adding a check of the new permission to places
in the interface which link to the edit item screen.

The catalogue toolbar had to be extensively re-worked in
order to ensure that the "New" and "Edit" menus would appear
(or not) whether or not edit_catalogue, edit_items, or
create_subscription permissions are on.

Revised for current HEAD

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-14 13:10:57 +13:00
565b780bec Bug 5041 Allow to delete non-repeatable field
Minus links wasn't displayed as it should in order to allow cataloger to
delete (empty all subfields) a non repeatable subfield.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-12-13 20:13:52 +13:00
b050029c65 Fix for Bug 3013, Value builder for 006 and 008 need choices for all format types
This partial fix adds a complete list of values for 006/00, "Form of material,"
following the list found here: http://www.loc.gov/marc/bibliographic/bd006.html

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-11-17 21:01:52 +13:00
Chris Cormack
414b2ace4f Merge remote branch 'kc/new/signoffs' into kcmaster
Conflicts:
	installer/data/mysql/updatedatabase.pl

Updated updatedatabase.pl to handle new version number
2010-11-04 20:14:28 +13:00
Chris Cormack
78a1f58275 Merge remote branch 'kc/new/bug2567' into kcmaster
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-11-03 21:21:36 +13:00
Nicole Engard
c3aa3d9681 bug 5168 change link text from holdings to items
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-11-02 14:55:28 +13:00
141ec0b9bc bug 5190: improve linking to MARC field documentation
* zero-pad tag numbers as needed
* handle special case for linking to UNIMARC 0XX vs. 1-8XX
* add a wrapper function
* add comment about the poor linkability of IFLA's UNIMARC documentation

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-11-02 14:55:20 +13:00
29432ee42c bug 5190: link to MARC21/UNIMARC online doc in the bib editor
Patch from  Tomás Cohen Arazi <tomascohen@gmail.com>

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-11-02 14:55:18 +13:00
Chris Cormack
f0fc240e91 Merge remote branch 'kc/new/for-3.4/spelling' into kcmaster 2010-11-02 11:33:49 +13:00
3c91225a49 bug 2567: let 008/15-17 and 008/24-27 be set
Fixes bug where the MARC21 008 plugin was falsely
claiming that it set the illustration and nature of
contents positions by deriving it from other fields
in the bib records.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2010-10-31 15:41:22 +13:00
f987d35a22 Fix for Bug 5254 - no need to scroll left to right on acq z search
- Adding inline preview/import menu to match cataloging z39.50 search
- Improving behavior of inline menu on both pages
- Adding white space to ISBN/ISSN output on both pages to allow
  line breaks, improving table width and horizontal scrolling.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-26 08:48:15 -04:00
391ce2b469 bug 3211: fix some errors that crept into the cleanup
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-25 11:05:26 -04:00
dc6f654623 Further fixes for Bug 3211, cataloging value plugin forms should be valid XHTML
- Adding page heading
- Adding "Cancel" link to close popup
- Correctly marking up <label> <input> pairs
- Correctly escaping JavaScript blocks
- General markup corrections

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-25 09:55:02 -04:00
c0fedbab3c remove last vestiges of NOTMARC mode
MARC, the metadata exchange format for the 20th century!

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-21 21:06:52 -04:00
Bernardo Gonzalez Kriegel
914a73cac4 Bug 5124 - Duplicate and Misspelled words: periodicy outputing
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-17 13:51:33 -04:00
Bernardo Gonzalez Kriegel
3b2f23c7da Bug 5121 - Misspelled words: stripts biographyl Begininning
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-17 13:51:32 -04:00
Chris Nighswonger
d8f16da180 Bug 4867 - cannot clone subfields in marc editor, other clone/unclone weirdness
When the clone/unclone plus/minus were replaced with images the <span> tags were inadvertantly deleted
causing the js to loose its ability to identify the clone/unclone links and properly udpate the indexes.
The resulting incorrect indexes caused various weirdnesses to result when one attempted to clone/unclone
subfields.

This patch simply adds classes to the two links and updates the js to identify the links based on class.

Thanks to owen for his help in chasing this down.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-10-06 06:11:36 -04:00
9efbc2d935 Bug 3217 Impossible to change biblio record FW to Default
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-24 20:34:56 -04:00
5944bd56fa Fix for Bug 4859, Formatting cleanup for merge biblio record interface
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-23 22:42:39 -04:00
4e6a664fb0 Fix for Bug 4868 - Improve controls for cloning and deleting MARC subfields
Changes "+" and "-" controls to actively linked images giving
better feedback about their clickability and an increased click
target area.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-19 08:23:26 -04:00
77f04bd426 Bug 2789 Fix UNIMAC leader plugin
The plugin was returning a 25 characters length leader rather than 24
characters. So leader was recreated automatically, removing user update,
before writing biblio record.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-06-09 10:14:11 -04:00
Nahuel ANGELINETTI
3fac59ba6b (bug #4522) fix plugin unimarc 210$c
This patch change the way to retrieve the value to insert in the record.
The way it was done, was verry ugly.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-24 09:14:34 -04:00
8e23cbc28f bug 4464: properly check if a subfield is populated if it is in a textarea
Subfields whose contents are longer than 100 characters are represented on the
bib form using a <textarea> instead of a text <input>.  The check on whether
at least one subfield for a mandatory field is populated wasn't not
checking for <textarea> subfields.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-24 07:55:07 -04:00
7f700bd461 Bug 4516 (Character shift in MARC21 Field 008)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-17 10:36:19 -04:00
Katrin Fischer
d7e519bd64 BUG 4499: Javascript error messages not translatable
- Cataloging > New Record (addbiblio.tmpl)
- Administration > Currencies > New Currency (currency.tmpl)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-05-13 14:20:05 -04:00
4d50b4f4f0 Fix for Bug 4271, Offer choice of destination for save biblio operation
A follow-up to the fix for Bug 4121, the user should be able to control whether
the action of saving a bibliographic record takes them to the add item screen
or the detail screen, independently of whether they are adding or modifying the
record.

The addition of a "split button" would leave the default action in place if the
user clicked the "main" part of the button. Clicking on the menu would give the
user specific choices.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-29 22:39:10 -04:00
3ecc2772f7 Fix for Bug 4302, shouldn't have to scroll left to right on z search results
Adds inline pop-up menu for each row of Z39.50 search results, similar to the
one recently added to the additem screen. This allows the user to click
anywhere in the row to display the menu and access the preview/import links.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-23 07:10:35 -04:00
Matthias Meusburger
1741062446 MT3160 : Fix plugin callback when subfields are cloned
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-16 00:44:20 -04:00
Paul Poulain
dd3d172b81 MT2502 : Reports Editor's 200$b to biblio's 210$c within unimarc_field_210c plugin
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-07 13:12:28 -04:00
Nicole Engard
d4705a2f3e bug 4317 fix typo in cataloging plugin
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-04-07 08:43:27 -04:00
2ce51846a0 More fixes for Bug 2600, HTML tags in titles not escaped in many places
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2010-02-03 16:52:31 -05:00