Commit graph

9166 commits

Author SHA1 Message Date
Danny Bouman
cd2bf6e70a bug 2817: Added support to pull Amazon information based on UPC, EAN, and 13-digit ISBN
By adding support for UPC,EAN and 13-digit ISBN we are able to pull much more content from Amazon, especially on most music and dvd content which
does not have an ISBN.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-01 11:05:30 -06:00
Joe Atzberger
f406ce43a9 Pure whitespace edits. Trying to make members more readable.
Use git diff -w to show only one line (a blank one) was edited (removed).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-01 10:51:38 -06:00
Joe Atzberger
9f97e871f1 Bug 2818 - Allow patron editing to coexist with minPasswordLength and '****'.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-01 10:49:26 -06:00
Galen Charlton
324958669a fix permissions error introduced by previous patch
Modules in C4 should not be executable.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-01 10:39:05 -06:00
Nahuel Angelinetti
f6cfcd933d No more used since a while.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-01 10:34:44 -06:00
Nahuel Angelinetti
e0bbb9d7e7 Delete all calls to thesaurus_popup.pl, and no more used plugins.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-12-01 10:31:46 -06:00
Henri-Damien LAURENT
cb0c787b1b Updating default UNIMARC framework
The previous one was out of date and contained some errors.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-24 10:04:11 -06:00
Galen Charlton
33514a4e35 bug 2801 followup
Quell unitialized value warnings emited when
'use warnings' was added.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-20 18:56:40 -06:00
Joe Atzberger
3cd80072f3 Bug 2801 followup... [SQUASHABLE]
Apparently my git skills are lacking, since I intended this one-liner
to be amended into the patch I resent.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-20 18:30:07 -06:00
Joe Atzberger
5532f6652b Bug 2801 and other cleanup.
In addition to documented bug:
~ SearchString took an unused argument,
~ refactored repeated code into column_picks(),
~ fixed display during delete_confirm, including "name",
~ removed unused C4::Dates dependency.

Resend: typo fixed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-20 18:29:57 -06:00
Henri-Damien LAURENT
f09e5a71d2 Bug Fix : 2686
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-20 18:18:25 -06:00
Galen Charlton
b47e2b1544 bug 2531 followup
* & -> &amp; in URL for XHTML validation
* (unrelated to prior patch) remove broken link to
  button-bg.png for confirm button

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-20 18:13:08 -06:00
Allen Reinmeyer
25eb36f21f Bug #2531 Cannot delete private shelf
Added logic to create a list of private lists to check on deletion.  Multiple pages have the ability to delete lists, both private and public.  Default option of retrieving a user's lists is retrieving the public ones.  Now private lists of the owner are retrieved as well and checked upon deletion request.  This allows any method of deletion to delete the correct list without examining the myriad of options currently used to indicate display of privateshelves and expect all pages to know whether a shelf number comes from a private or public list.  Since deletion occurs based on shelf number and the virtualshelves table has a primary key on shelf number, this will not cause unwanted deletion of shelves.

UPDATE:  added logic for conditional creation of shelves.  Also note change in staff side as deletions worked except for viewing a populated shelf, then deleting.  The confirm message showed, but the display was of public shelves, not private.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-20 08:33:59 -06:00
Ryan Higgins
53a0ed93db bug 2787 : Fix Global Due date
This patch also lightly refactors the conditional structure wrapping the
call to AddItem, renaming a couple variables to remove double-negatives and
abstruse logic.  If SpecifyDueDate is ON, then the input box is used to pass
GlobalDueDate, allowing modification by circ staff, resulting in a default
'sticky' due date of the global due date in that mode.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-20 07:22:18 -06:00
Jesse Weaver
b883e6cd7f fix for bug 2447: yuipath variable not getting passed to help pages
This updates help.pl to pass the yuipath variable correctly. It also adds some script references to help-top.inc to avoid other js errors.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-19 15:45:51 -06:00
5d72025226 Get back boolean button on OPAC Advanced Search page
With this patch, on OPAC Advanced Search page, when More Options is
selected, a boolean combo box appears in front of fields combo box.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-19 15:45:45 -06:00
Henri-Damien LAURENT
9e63271c8a Bug 2790 no UNIMARC search on avail items [1/2]
Changing record.abs file to add the management of acquisition date,
modification date and lost

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-19 15:45:42 -06:00
Ryan Higgins
f3f0e2576f Bug 2365: Serials prediction errors: Roll-overs occur with wrong issue in some cases.
See bugzilla for details.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-19 15:08:57 -06:00
Galen Charlton
cfd2f829d3 bug 2802 followup: remove another reference to "branches"
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-18 16:51:27 -06:00
Henri-Damien LAURENT
8b9af2775e bug fix : 2805
deleting die on lack of user/password in config file.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-18 16:46:32 -06:00
ccad2f8cf0 Language corrections: branch -> library. Changing "Libraries, branches, and groups" to "Libraries and groups." Fixes Bug 2802.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-18 16:46:28 -06:00
Galen Charlton
5880522ea7 bug 2654: require circulate permission to upload offline circ files
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-18 16:46:25 -06:00
Galen Charlton
aa686ee5ab bug 2606: reduce size of offline circ patron database
Reduce the size of the SQLite database produced by
create_koc_db.pl by emiting only the columns
actually used by Kyle Hall's offline circ client.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-18 16:46:21 -06:00
Michael Hafen
db73b67f03 add isbn to cataloging search results
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-18 16:46:16 -06:00
Nahuel Angelinetti
a41acfe435 Do not show the language chooser
This patch change the footer of authority search results popup to use the popup footer, so do not show the language chooser.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 10:29:28 -06:00
Galen Charlton
da13a339bb moved Test_CSV_Various.t to xt/author
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 10:19:43 -06:00
Joe Atzberger
93725f8ae4 Results of CSV module analysis, testing various CSV modules and configs.
The upshot is that despite appearances, whe should NEVER use Text::CSV::Unicode
or any CSV module in non-binary mode.  Text::CSV works in binary mode
by using Text::CSV_XS, so the behavior is the same for both (in binary).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 09:51:24 -06:00
Marc Chantreux
082ed86beb use DESTDIR now
takes carre of changes in Makefile.PL about debian install

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 09:43:22 -06:00
105df865ca Fixes bug #2788 - CoinS support
1 In URL rft.tpages is replaced with rft.page. That's what
  Zotero expects.
2 TMPL_VAR NAME="size" is replaced with "pages" for 1.
3 TMPL_VAR NAME="publisher" is replaced with "publishercode"
  the correct value for rft.pub

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 09:43:14 -06:00
872f852614 Bug #2794: Browse Shelf doesn't work with ISBN containing '-'
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 09:43:09 -06:00
Galen Charlton
a74d196f35 bug 1891 followup - remove dangling /TMPL_IF
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 09:22:06 -06:00
Andrew Moore
5ab1781bab adding "DROP TABLE" commands to several table definitions in kohastructure.sql
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 09:05:04 -06:00
Ryan Higgins
761a589fc0 bug 1891 : bib-level itemtype was required in order to place a hold.
This patch removes some superfluous logic left over from early Koha
when a multi-step holds process allowed you to limit your choices to
specific biblioitems.itemtype values.  Code previously required a value
in biblioitems.itemtype in order to place hold.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 09:05:01 -06:00
Galen Charlton
1e248dbc58 bug 2779: fix template syntax error in OPAC home page
Fixes cause of following message in Apache log:

[Wed Nov 12 14:33:36 2008] [error] [client xxxxx] HTML::Template::Pro:in
TMPL_IF at pos 2860:end tag:found e instead of > at pos 2886

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 09:04:58 -06:00
Galen Charlton
34ba89fd5d fix POD error
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-11 16:03:09 -06:00
Andrew Moore
549ec91a13 Bug 2775: adding method to clean syspref cache in C4::Context
C4::Installer provides a way to update the kohaversion syspref. Now that
C4::Context caches syspref values, any updated value through C4::Installer
is not being seen.

This patch adds a method to C4::Context to allow you to clean that
cache. Then, it calls that method when the kohaversion syspref is changed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-11 15:59:00 -06:00
47c9185ec2 Updated Italian translation files
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-11 08:58:18 -06:00
9cb231a63e Removing some unused stuff from print stylesheet, hiding Koha logo from print view.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 16:31:12 -06:00
Nahuel Angelinetti
090a88345a Fix overdue list if you do not specify a branchcode.
Before, if you do not provide a "branchcode" you have an empty csv export.
Now, if you have an empty branchcode you have all overdues listed in csv.
(I made a typo error in code)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 16:28:28 -06:00
Nahuel Angelinetti
be5cddb39d Do not allow an user to have an empty date
If the user set an empty date as the expiration date during a patron modification, we recalculate the expiration date with sysprefs and the registration date.
Before, when you set an empty date, 0000-00-00 is put in the database (too bad).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 16:17:11 -06:00
0551f48150 Improve C4::Charset::MarcToUTF8Record performance
A script like bulkmarkimport.pl spends most of the time
in C4::Charset::MarcToUTF8Record function, and
specifically in C4::Charset::char_decode5426
just initializing a hash. This patch moves this
hash outside function to avoid its initializing
each time the functon is called.

A test on a specific conversion script shows me
that performances were improved from 23s to 8s.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 15:53:29 -06:00
Nahuel Angelinetti
ff27962633 A typo error was in the tmpl does not allow the user to sort by acquisition date.
The patch fix this, after changing a bad "if".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 15:53:27 -06:00
Clay Fouts
0ff177431b Database connectivity cleanups
This patch employs process-local caching of systempreferences and
eliminates the "select 1" execution every time dbh() is called.
DBI::ping() is used instead.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 15:53:25 -06:00
John Beppu
9f782076db bug 2563: could not input into marc 008, fields 7-10 and 11-14
You actually *could* input data into those fields, but it wasn't
immediately obvious, because the field size was "4" and the
value was "    ".  You couldn't type anything in until you
backspaced over the spaces that were there by default.

UPDATE 2008-11-05:  Make absolutely sure that those values
are 4 chars long (via JavaScript)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 15:53:24 -06:00
c9a00b8b47 Correcting behavior of SpecifyDueDate and sticky due date options. Fixes Bug 2748.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 15:37:46 -06:00
Nahuel Angelinetti
c76687b090 Add a dependance to CGI::Session::serialize::yaml 4.20
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 15:37:41 -06:00
Allen Reinmeyer
338e0a0dd5 Bug #2760 wrong permissions for guided reports
Guided reports and dictionary access was dependant on the editcatalogue permission instead of the report permission.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 15:37:38 -06:00
Allen Reinmeyer
af9945088c UPDATE:Bug #2756 opacbookbag preference turns off add items to list
There was a bug in the javascript that prevented the 'select all','clear all' and the 'add-to' list.  Javascript wasn't including basket.js on virtualshelves option.  Also, 'Save to Lists' was calling addtoshelf instead of addtolist. Functionality is now the same for virtualshelves regardless of opacbookbag status.

UPDATED:  Removed EXPR in TMPL_IF conditions

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 15:12:29 -06:00
Nahuel Angelinetti
36fe3b8c6f Some tab cleaning
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 15:04:26 -06:00
Nahuel Angelinetti
a79a977ee2 fix the private shelf deletion in opac
this patch add an "hidden" field in the template, that permit in C4::VirtualShelves::Pages to get the right(privates) shelves with
GetShelves in$
of always public shelves.
So when a private shelf is wanted to be deleted, the script watch only in public shelves if the shelf exists, and doesn't work.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-06 14:48:14 -06:00