Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Author	SHA1	Message	Date
Julian Maurice	96cc447045	Bug 25898: Prohibit indirect object notation Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Jonathan Druart	638786e719	Bug 24663: Remove authnotrequired if set to 0 It defaults to 0 in get_template_and_user Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	4 years ago
Jonathan Druart	42ebef689f	Bug 23075: Do not 'Send' if the url is not correct Just in case. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	5 years ago
Martin Renvoize	a1161ced1d	Bug 23075: Report if mana-kb server is not found This patch adds a status check into the mana configuration page and prompts the user to ask an adminstrator to check the configured mana service url. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	5 years ago
Martin Renvoize	4dc64b4b12	Bug 23034: (RM follow-up) Consistent coding style We had a mix of q\|\|, q{} and '' in this one script. This followup just makes them all conform to our standard style of q{}. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	5 years ago
Joonas Kylmälä	0df3fc3dae	Bug 23034: Remove uninitialized value warning in Mana KB settings This gets rid of the warning "Use of uninitialized value $auto_share in string ne at [...]" by initializing the variable with empty string. Test plan: 1) Go to page cgi-bin/koha/admin/share_content.pl and unselect "Auto subscription sharing". Click "Save". 2) Check plack-error.log and notice the warning "Use of uninitialized value $auto_share [...]" 3) Apply the patch and repeat the previous steps but now this time the warning is gone in plack-error.log. 4) Make sure the AutoShareWithMana syspref with and without the patch is in unselected state after clicking "Save". Sponsored-by: The National Library of Finland Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	5 years ago
Alex Arnaud	a7513c0dc6	Bug 22210: Mana config - Replace firstname and lastname with name I've applied a patch on Mana test server. If you want to test with your own Mana instance, do the folowing: - checkout bug/22210 branch from http://git.biblibre.com/biblibre/koha-mana.git - run these sql queries on Mana database (we need an update DB method i think): - ALTER TABLE librarian ADD COLUMN name VARCHAR(50) AFTER email - UPDATE librarian SET name = (SELECT CONCAT(firstname, ' ', lastname)) - ALTER TABLE librarian DROP COLUMN firstname - ALTER TABLE librarian DROP COLUMN lastname Test plan - set mana_config to "https://mana-test.koha-community.org", - go to admin > Share content with Mana KB, - set "Use Mana KB for sharing content" to yes, - save, - in the 2nd fieldset, enter a name and email, - click on send to Mana KB, - check that you got a token, - you should receive an email (Mana KB registration) - check the name is correct Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>	5 years ago
Owen Leonard	e142e85d65	Bug 22198: Add granular permission setting for Mana KB This patch adds a separate permission for managing Mana KB. To test, apply the patch and update the database. - Open the permissions page for a patron with staff client privileges - Confirm that there is a "Manage Mana KB content sharing (manage_mana)" permission. - Leaving this new permission unchecked, log into the staff client with as that patron and go to the Administration home page. - The "Using Mana-KB" link should not appear. - Navigate directly to /cgi-bin/koha/admin/share_content.pl. You should get a "permission denied" message. - Modify the patron's permissions to grant them access to Mana KB. - Confirm that the link now appears on the Administration home page and that the user can access the page. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	5 years ago
Alex Arnaud	fe26d42ada	Bug 17047: add a dedicated page for Mana setup Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>	6 years ago