Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Author	SHA1	Message	Date
Jonathan Druart	41a8005d10	Bug 28606: Remove $DEBUG and $ENV{DEBUG} We should remove the debug statements or use Koha::Logger when we want to keep it. Test plan: Confirm that occurrences of remaining occurrences of DEBUG need to be kept (historical scripts for instance) Confirm that the occurrences removed by this patch can be removed Confirm that the occurrences replaced by Koha::Logger are correct Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Looks good to me, noting a few minor points on BZ. JD amended patch: replace "warn #Finished" with "#warn Finished", and put the statement on a single line Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	3 years ago
Julian Maurice	b168f4a2e9	Bug 21395: Make perlcritic happy This patch adds a .perlcriticrc (copied from qa-test-tools) and fixes almost all perlcrictic violations according to this .perlcriticrc The remaining violations are silenced out by appending a '## no critic' to the offending lines. They can still be seen by using the --force option of perlcritic This patch also modify t/00-testcritic.t to check all Perl files using the new .perlcriticrc. I'm not sure if this test script is still useful as it is now equivalent to `perlcritic --quiet .` and it looks like it is much slower (approximatively 5 times slower on my machine) Test plan: 1. Run `perlcritic --quiet .` from the root directory. It should output nothing 2. Run `perlcritic --quiet --force .`. It should output 7 errors (6 StringyEval, 1 BarewordFileHandles) 3. Run `TEST_QA=1 prove t/00-testcritic.t` 4. Read the patch. Check that all changes make sense and do not introduce undesired behaviour Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>	6 years ago
Jonathan Druart	ba0f84b46c	Bug 9978: (followup) Replace license header with the correct license (GPLv3+) There was another form of the v2. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>	9 years ago
Galen Charlton	abf5820ba6	installer: improvements to fix-path-perl.PL on Win32 Signed-off-by: Chris Cormack <crc@liblime.com> Signed-off-by: Joshua Ferraro <jmf@liblime.com>	17 years ago
Galen Charlton	5b98031b60	installer: deal with permissions in fix-perl-path.PL Files in blib generally are a-w on Unix platforms. Modified fix-perl-path.PL to temporarily set them o+w while file is being checked.	17 years ago
Galen Charlton	06fb84f566	installer: made $DEBUG in fix-perl-path.pl contigent on DEBUG env var	17 years ago
Chris Nighswonger	ffea1e0832	Win32 support: Added differentiation between -w perl switch in shebang line. Signed-off-by: Galen Charlton <galen.charlton@liblime.com>	17 years ago
Chris Nighswonger	42c9423408	Win32 support: Switch DEBUG off and corrected warning bug. Signed-off-by: Galen Charlton <galen.charlton@liblime.com>	17 years ago
Chris Nighswonger	7fcfc09669	Win32 support: Stripped ^M line endings and various other housekeeping. Signed-off-by: Galen Charlton <galen.charlton@liblime.com>	17 years ago
Chris Nighswonger	b310be2bab	Win32 support: Adding a script to modify shebang lines per installation platfom. Signed-off-by: Galen Charlton <galen.charlton@liblime.com>	17 years ago