Commit graph

16479 commits

Author SHA1 Message Date
Paul Poulain
e73058e469 Bug 7304 followup DBRev number 2012-06-27 16:56:08 +02:00
Julian Maurice
203757e353 Bug 7304: More permissions for budgets
- Possibility to add users to a budget
- Restrictions changed to:
  - None
  - Owner
  - Owner and users
  - Owner, users and library
- Restricted users cannot spent on these budgets (they cannot modify them
  either)

Modified pages:
 - admin/aqbudgets.pl
 - admin/aqplan.pl
 - suggestion/suggestion.pl
 - acqui/acqui-home.pl
 - acqui/addorderiso2709.pl
 - acqui/basket.pl
 - acqui/neworderempty.pl

Unit tests in t/Budgets/CanUserUseBudget.t and t/Budgets/CanUserModifyBudget.t

Bug 7304 tmp

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-06-27 16:25:44 +02:00
Katrin Fischer
51cdcd91f7 Bug 7905: Follow up - Multi-line subscription notes
This patch adds the TT filter to other places where we are displaying the
subscription notes:

- OPAC detail page, subscription tab
- OPAC subscription brief history page
- Staff detail page, subscription tab

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-06-27 15:29:56 +02:00
Adrien Saurat
8b3a2d9dd0 Bug 7905: display serial notes on several lines
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patch works and makes use of TT filters!

I agree the display could be improved to work a bit nicer
for long lines or multi-line comments, but this is still a nice
improvement.
2012-06-27 15:29:33 +02:00
Jonathan Druart
b3cec7bec3 Bug 5345: DataTables integration in acquisition module [5]
basketgroup.tt

http://bugs.koha-community.org/show_bug.cgi?id=8105
Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-06-26 18:00:06 +02:00
2b74492d7d Bug 8181 [REVISED] Replace DynArch calendar widget with jQueryUI version
All instances of the old DynArch calendar have been replaced with
jQueryUI versions and the old library files have been removed.

calendar.inc has been modified to include jQueryUI localization
strings and global configuration options. Just add a "datepicker"
class to an input field to trigger a datepicker prompt.

If you would like two fields in one from to limit each other (one
is date from, one is date to), add these classes to each:
"datepickerfrom" and "datepickerto." This will prevent an invalid
entry, e.g. a date in the latter which falls before the former.

jQueryUI is now upgraded to the latest verision, 1.8.21.

Edit: Now with proper translatability, date formatting, first day
of the week handling, and RTL support.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Ian Walls <koha.sekjal@gmail.com>
QA Comment:  rebased on current master; minor merge conflicts with other patches pushed

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-06-25 18:26:26 +02:00
Sophie Meynieux
45a0e7a9db Bug 8191 : Adding a new value to 8 position of coded data field 100
From july 2012, unimarc norm evolves and the value k "monograph with both publication date and print date" must be added for this position.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Checked the new value shows up and is correctly copied into the field.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-06-25 18:23:24 +02:00
Jared Camins-Esakov
4afe8b00a1 Bug 8255: allow local cover images to be cached
At the moment, local cover images cannot be cached by the web browser
or any intermediate reverse proxies. This results in an unnecessary
load on the server, and is entirely unnecessary.

Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-06-25 18:12:29 +02:00
Paul Poulain
068e5be639 Merge remote-tracking branch 'origin/new/bug_7143' 2012-06-25 18:01:28 +02:00
4eaaefecab 7143 Followup for timeline
Fixes few tabs within date; adds a regex to fix mistakes with spaces.

Signed-off-by: Marc Veron <veron@veron.ch>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-06-25 18:00:59 +02:00
Marc Veron
c8080f9196 Bug 7368 - General staff client typo omnibus
Corrects 2 typos, see comment #9

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-06-25 17:59:29 +02:00
Julian Maurice
1e6644f597 Bug 6090: Do not enqueue empty messages
This patch avoid enqueuing messages that have an empty body. It can
happen when letter is empty or becomes empty after being processed by
parseletter

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-06-25 17:56:05 +02:00
a78298d2f0 Bug 8194 - Layout problem on subscription add when showing manual history
Markup errors were causing display problems when the "manual history"
section is shown.

To test, apply the patch, load the subscription add page, and check
the "manual history" checkbox. The "Serials planning" section
should appear directly below the "manual history" section.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-06-25 17:54:38 +02:00
Adrien Saurat
b9f6122ec6 Bug 7379: display of copy number description (AV)
The biblio/items detail pages (staff and OPAC) display
the copynumber description if an authorized value
is configured accordingly.

Signed-off-by: Gaetan Boisson <gaetan.boisson@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-06-25 16:34:44 +02:00
Alex Arnaud
0023e2a1ce Bug 8224 - Make authorized values appear in planning list
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
I can confirm the bugs on current master and this patch fixes both problems.

- Pull down list for "Planning" on the budget page was not showing
  categories of authorized values
- Planning page showed the categories, but budget_period_id was
  missing from the URL

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-06-25 16:24:13 +02:00
Katrin Fischer
30dc74b7fb Bug 8241: Remove text fragment from Z39.50-Server search
Removes an accidently added "curr" from below the search options
for administration > Z39.50 client targets.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-06-25 16:22:48 +02:00
6cc03670e4 Bug 8241 - Remove stray references to YUI autocomplete
- Removing unused references to YUI assets in authorities/auth_finder.tt
- Removing unneeded call to autocomplete JS in help-top.inc and
  adding new jQuery dependencies.
- Minor HTML markup corrections to auth-finder-search.inc discovered
  in debugging the patch.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested:
- help files on various pages
- auth finder plugin in cataloguing
- authority search in authorities module
2012-06-25 16:22:46 +02:00
Matthias Meusburger
23033cd937 Bug 8282: Bug in modules list in about.pl
Last modules were not displayed if the number of modules did not match the number of rows of the table (when $number_of_modules % 4 != 0)

Signed-off-by: Marc Veron <veron@veron.ch>

Added some code to about.tt to have empty the last remaining cells, not sure if an other signoff is needed.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-06-25 16:20:32 +02:00
Paul Poulain
866fc7653c Bug 8289 Upgrading from 2.2 does not work anymore
The updatedatabase22to30.pl script update the engine from MyISAM to InnoDB for most tables.

However, the TYPE=InnoDB was deprecated, and is not removed.
The correct syntax is now ENGINE=InnoDB

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
2012-06-25 16:15:42 +02:00
19d30206df Bug 8272 - OPAC : date expiration format
Adding TT date filter to output of expiration date
on OPAC user page.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-06-20 23:29:59 +02:00
3768602ae7 Bug 8043 - today's checkouts are in Previous checkouts in circulation.pl
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-06-20 23:25:31 +02:00
c6f1f64cb7 Bug 8251 - Patrons get incorrectly debarred
Patrons get incorrectly debarred because of the use of Datetime->delta_days
wich happens to always return a positive number.

Also changed the use of Datetime->truncate function so it follows the docs,
using 'day' instead of 'days' (which is used in DateTime::Duration).

This patch has been tested against master.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-06-20 23:24:24 +02:00
Jonathan Druart
3069f1e6d9 Bug 8154: The export today's checked in barcodes generated file is always empty
Comparation of date and datetime is always false

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>

Exported file contains the list of checked in items.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-06-20 23:19:34 +02:00
ac5e09a0f0 Bug 8267 - Overdue notices not working
The variable $i was being re-used and overwriting the necessary value that was being passed to a subroutine. Renaming $i to $j fixed it. I also added an extra safety check within parse_letter that would also have prevented this bug.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-06-20 23:14:56 +02:00
Paul Poulain
deb0e8dc45 Bug 3708 follow-up DBRev number 2012-06-20 23:11:20 +02:00
Paul Poulain
a163be4113 Bug 3708 - Add another customizable region to the OPAC: right sidebar nav
This patch creates a new system preference, OpacNavRight, in
which the librarian can add HTML which will appear on the OPAC
main page under the login form. If the user is logged in the content
will appear in place of the login form.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-06-20 23:11:06 +02:00
Meenakshi.R
8bd8aba577 Bug 4255 - Add item type to facet list
This is for MARC 21 only.

Made following changed:

- In getFacets in C4/Koha.pm added item type facet for 952y and 942c
- In getRecords in C4:Search.pm added code to get description of itemtype codes
- facets.inc in both staff and opac to show item types related label in the facets block

To test:

Add records such that a certain itype (say BK) is present in both 942c and 952y in two DIFFERENT records.

Run a search where both test records are present. Test to see if itype types are presented in the facets block (both OPAC and staff).

Click on the itype (say BK), both the test records should appear in the refined results. This shows that the feature works for both 942c and 952y.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Ian Walls <koha.sekjal@gmail.com>

QA Comment: fixed capitalization in template includes according to HTML4 coding
guideline ("Item types" instead of "ItemTypes")

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-06-20 22:27:21 +02:00
Jared Camins-Esakov
7bc4a6025b Bug 5910: [SIGNED-OFF] only add "All authority types" for UNIMARC
UNIMARC is the only marcflavour that does not already have an option
for searching all authority types, so check that the marcflavour is
UNIMARC before displaying the additional "All authority types" option.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-06-20 22:22:25 +02:00
Paul Poulain
434b4559eb Bug 5910: allow users to search on all auth types
Add search on "all authorities types" option in the authorities type select

rewritten for T::T

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2012-06-20 22:22:22 +02:00
Paul Poulain
b93e6df3a1 Merge remote-tracking branch 'origin/new/bug_6634' 2012-06-20 22:19:06 +02:00
Maxime Pelletier
8036be591f bug 6634 : 3 more cases of manager_id not populated
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-06-20 22:18:19 +02:00
Paul Poulain
40323adcc2 Bug 6774 follow-up DBRev number 2012-06-20 22:04:51 +02:00
Amit Gupta
5836738957 Bug 6774 Display barcode on OPAC detail page(Correcting Typo).
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Rebased to current master, works in my tests, but needs another set of eyes.
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
2012-06-20 22:04:32 +02:00
Paul Poulain
d094e24af9 Bug 7447 allow to specify a date in overdue_notice.pl
This patch add a new parameter to overdue_notices.pl, that is a date.
If you add --date=YYYY-MM-DD when running overdue_notices, it will generate overdues as if you were on date provided

that's usefull if you want to relaunch an overdue calculation that has failed, of after changing your circ rules

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-06-20 21:50:21 +02:00
Paul Poulain
2102895ab5 Adding Claire Hernandez as contributor + adding missing contributors in about.tt 2012-06-20 21:49:40 +02:00
Robin Sheat
aceee32f5c Bug 7642 - remove the cloud weight from the tags
Signed-off-by: Stacey Walker <stacey@catalyst-eu.net>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-06-20 21:43:07 +02:00
Dobrica Pavlinusic
2c8829f731 Bug 7857 - [SIGNED-OFF] database upgrade fails with plack
This patch fixes PERL5LIB path injection to include installer dir
which is required

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-06-20 21:33:34 +02:00
Dobrica Pavlinusic
b1322bb6cb Bug 7857 - database upgrade fails with plack
Updating database structure

Update errors :

    Can't locate C4/Context.pm in @INC (@INC contains: /etc/perl /usr/local/lib/perl/5.10.1 /usr/local/share/perl/5.10.1 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.10 /usr/share/perl/5.10 /usr/local/lib/site_perl /usr/local/lib/perl/5.10.0 /usr/local/share/perl/5.10.0 .) at /srv/koha/installer/data/mysql/updatedatabase.pl line 37.
    BEGIN failed--compilation aborted at /srv/koha/installer/data/mysql/updatedatabase.pl line 37.

It seems that plack cleans enviroment, so we have to re-instart PERL5LIB
so script invocation won't fail.

It also fixes exit 1 which fail with plack.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-06-20 21:33:26 +02:00
Dobrica Pavlinusic
a29a5df175 Bug 7857 - invalidate cached preferences after SetVersion
This allows plack to correctly move to login page after database upgrade
2012-06-20 21:32:33 +02:00
Paul Poulain
8c309c1a67 Bug 7955 follow-up spelling fixes
* removing useless upper cases
* s/precedent/previous/ and s/Actual/Current/ to be consistent with other Koha pages
2012-06-20 21:31:43 +02:00
Paul Poulain
db6a65eab3 Bug 7955 follow-up DBRev number 2012-06-20 21:30:54 +02:00
Jonathan Druart
5e2001a6f8 Bug 7955: Statistics tab for Patron checkouts
This patch adds a new 'statistics' tab in the Patron module.
For a borrower, this tab contains a table with:
- number of checkout for today
- number of checkin for today
- "precedent state", the number of checkouts the patron had yesterday on
  its library card
- "actual state", the number of checkouts on the borrower card at the current date

A new syspref (StatisticsFields) contains a list of fields (separated by
pipe (|) on which the table results is based. The default value is
location|itype|ccode

Signed-off-by: Mathilde Formery <mathilde.formery@ville-nimes.fr>
2012-06-20 21:16:50 +02:00
Claire Hernandez
1a2e242704 Bug 7994: Fix pref yaml errors
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-06-20 21:09:29 +02:00
Claire Hernandez
6ee7ad02aa Bug 7994: scripts to check yaml files
$ prove yaml_valid.t
checks a closed list of files
$ perl yaml_valid.pl -f myfile.yaml
try to load a yaml file with YAML::LoadFile and show errors

(both files pertidied)

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2012-06-20 21:07:46 +02:00
c3bcfc4f82 Bug 8006 - Loading offline circulation does not anonymize
Simple, one line fix. Added the privacy parameter to the list
of parameters passed to C4::Circulation::MarkIssueReturned.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-06-20 19:40:41 +02:00
Jonathan Druart
c3f16aa97d Bug : DataTables integration in acquisition module [1]
parcel.tt

http://bugs.koha-community.org/show_bug.cgi?id=8098
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Fixed bug number.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-06-20 19:32:06 +02:00
Jonathan Druart
364b9a2da9 Bug 8099: DataTables integration in acquisition module [2]
acqui-home.tt

http://bugs.koha-community.org/show_bug.cgi?id=8099
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-06-20 19:30:39 +02:00
Jonathan Druart
8a2139e495 Bug 8100: DataTables integration in acquisition module [8]
neworderbiblio.tt

http://bugs.koha-community.org/show_bug.cgi?id=8100

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Fixed bug number.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-06-20 19:26:52 +02:00
Jonathan Druart
e31768aab1 Bug 8102: DataTables integration in acquisition module [14]
supplier.tt

http://bugs.koha-community.org/show_bug.cgi?id=8102
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Corrected bug number.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-06-20 19:06:02 +02:00
Jonathan Druart
e76afafb94 Bug 5345: DataTables integration in acquisition module [12]
parcels.tt

http://bugs.koha-community.org/show_bug.cgi?id=8103
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-06-20 18:57:35 +02:00