Commit graph

9322 commits

Author SHA1 Message Date
John Beppu
e7702b3334 POD for C4::Members::Messaging
- fixed typos and formatting.
- added notes on how to add new kinds of messages.
- added notes on the tables being used.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-04 13:55:14 -06:00
John Beppu
a8accfb4c5 Messaging Preferences for Intranet
- Added ability to modify per-user messaging preferences.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-04 13:55:09 -06:00
John Beppu
65b0ca3923 Messaging Preferences for OPAC
- Added ability to request a messaging config change.
  (Apparently, users aren't allowed to directly change these settings.)

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-04 13:54:45 -06:00
John Beppu
2302621702 Schema Changes for Email Checkout Slips
- new table, item_circulation_alert_preferences
- new data:
  - letter -- 2 new templates
  - message_transport_types -- feed
  - message_attributes -- Item Check-in and Item Checkout
  - message_transports -- for each attribute and for each transport_type...

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-04 13:54:13 -06:00
526a39b62d Showing totals for charges and replacement costs on patron detail screen and print view.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-04 13:41:18 -06:00
74400dd694 Move opaclanguagesdisplay to I18N/L10N tab where opaclanguages pref is.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-04 13:41:17 -06:00
Nahuel ANGELINETTI
ba34bea474 (bug #2938)[follow previous] Add new report in menus
Just adding the new report in miscellaneous menus

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-02 08:42:00 -06:00
Nahuel ANGELINETTI
720cddeca6 (bug #2938) add a serials subscriptions report
this patch add a report for serials.
It's have to limit branch/bookseller, and excluding expired serials.
It's possible to export in CSV format.
This patch will have another, to add this report in menus.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-02 08:41:48 -06:00
Mason James
35a8b9bf55 fixes SQL typo and return value in GetImportBatchStatus()
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-02 08:20:57 -06:00
Joe Atzberger
8b402f82df Prevent js failure if syspref "gist" is undefined.
The javascript is malformed and therefore fails the onsubmit check if
gist does not receive a value.  This patch allows failover to default 0.
Also removed an unused dbh.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-02 08:20:54 -06:00
Joe Atzberger
01230ccd5e Minor rework of template js.
Lines explicitly ended with semicolons.  Allow some better behavior if TMPL_VAR's
are undefined or zero.

Note FIXME added.  I believe this is part of the fragmentary integration of
Katipo code for GST.  Would be obliged if someone with access there can confirm.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-02-02 08:20:50 -06:00
Mason James
eaa62ab2cd bug 2870, fixes non-populating of guarantor fields
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-28 17:42:00 -06:00
Nahuel ANGELINETTI
c338353a4b Delete a "=" added lastly and make this script not working
It seems no one use this script, because it cannot work.
This patch delete a "=".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-28 17:41:59 -06:00
Joe Atzberger
11b90be284 Cleanup and perltidy.
Add "use warnings", remove unused variables and unnecessary finish/disconnect
at the end.  This script could be improved to run only on tables that need to
be altered instead of touching all of them.  It should also probably contain
warnings to the effect that it does not rescue your DATA that was forced into
whatever encoding the table used previously.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-28 17:29:43 -06:00
Joe Atzberger
d2c4ae65ab Obsolete harness for tests, replaced by make and other test structures.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-28 17:15:39 -06:00
Galen Charlton
010dc2f0a9 holds policy followup - fix column definition
Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-16 08:24:26 -06:00
Galen Charlton
a263230a06 followup to holds policies - fix itype
Overriding items.itype from biblioitems.itemtype
is needed only with item-level_itypes is OFF.

[LL bug 321]

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-16 08:22:52 -06:00
Daniel Sweeney
d764a7cf89 Corrected several typos that caused the installer to fail when creating the Koha schema.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-16 08:22:40 -06:00
Galen Charlton
ff9533369c bump DB rev 011 -> 012
Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-16 08:22:26 -06:00
Galen Charlton
cb04440f44 language fix: "branch" => "library"
Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-16 08:22:18 -06:00
Jesse Weaver
ee36f27745 Database updates for hold policies
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-16 08:21:58 -06:00
Jesse Weaver
d594e26461 Database changes and new sysprefs for holds policies
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-16 08:21:47 -06:00
Jesse Weaver
1301705150 Add holds policies
This adds holds policy creation support to smart rules and read support to
C4/Circulation.pm, and the two reservation pages. It also adds a system
preference, AllowHoldPolicyOverride, to control whether the staff can override
these policies.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-16 08:21:07 -06:00
Nahuel ANGELINETTI
0209a96db7 Unescape some double quotes, that make a validation error.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-12 16:29:34 -06:00
011fa47b9d Related to earlier patch: adding body id to add flexibility to CSS customizations.
This patch adds a different id to opac-shelves, opac-suggestions, and opac-tags based on whether or not the user is logged in, allowing for changes to style based on logged-in status.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-12 16:21:20 -06:00
Galen Charlton
b99e65ca76 bug 2908 followup - use "list", not "shelf"
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-12 16:18:03 -06:00
Nahuel ANGELINETTI
c49b3eb464 (bug #2909) fix the attachment base64 encoding
this patch change the attachment encoding, else if the file is too large, koha throws an error.
This solution was found on koha list in a Joshua's e-mail

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-12 15:52:08 -06:00
Nahuel ANGELINETTI
bfebda4ad9 (bug #2908) adding send shelf by e-mail feature
This patch add the form for sending shelf by e-mail, and add a button in shelves that allow the user to send a shelf.
It's an approximate copy of the send basket feature.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-12 15:51:59 -06:00
Galen Charlton
f35a9d5a27 bump DB rev 010 -> 011 2009-01-12 15:16:58 -06:00
Andrew Moore
38d0b4078e Bug 2578: remove unwanted intranetuserjs syspref - Database revision 3.01.00.011
The default syspref setting for intranetuserjs should be empty. At one
time, an unwanted value accidently got put in there. This removes the
syspref only if it equals the unwanted value.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-12 15:15:47 -06:00
Danny Bouman
277049ada5 bug 2687 followup: Increase maxlength attribute to support 64 characters
Modified the borrower attribute and borrower password fields to support a maxlength of 64 characters.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-12 15:05:25 -06:00
Danny Bouman
f198b3f5cf bug 2687: Increased length of borrower attribute fields
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-12 15:02:12 -06:00
Nahuel ANGELINETTI
796f626b5b (bug #2904) support of 856$u and 856$z in UNIMARC
This patch change the linktext as the label of the link(in 856$z), and set the url from the 856$u.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-09 13:22:01 -06:00
Allen Reinmeyer
7ca82ab5d2 Bug 2902 Public shelves do not display when user not logged in.
An ending </div> was not placed correctly and encompassed both
privateshelves and publicshelves

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-09 12:28:45 -06:00
Joe Atzberger
54f5ee3332 Prevent multiple warnings per notice filling cron logs.
If a value being substituted in was NULL, then warnings like this
would be emailed to the crontab owner (or MAILTO):

Use of uninitialized value in substitution (s///) at /home/user/kohaclone/C4/Letters.pm line 508.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-09 12:22:30 -06:00
Galen Charlton
e7aff14ba2 bug 2505: more warnings fixes in C4/Context.pm
* more portable way to determine uname for
  crash messages
* C4::Context->userenv now returns undef instead
  of 0 if no userenv has been set yet; returning
  undef when necessary is almost always better
  than returning a scalar when a hashref is
  normally expected.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-09 12:17:49 -06:00
stan
5ce47ac580 Enable use warnings;, clean up complainy functions, fix a few tab/space formatting issues.
Refactoring KOHAVERSION to be less crufty, enabling use warnings, change formatting slightly in places.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-09 10:42:57 -06:00
Marc Chantreux
38360d470a WEBSERVER_HOST and WEBSERVER_HOST added
comments added too

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-08 14:57:40 -06:00
Galen Charlton
3a7ae97440 followup to patch for bug 2900
Previous patch broke date comparison that sets
overdue flag - now that ISO-formatted date
strings are being compared, must use "it"
instead of "<".

"2009-01-02" lt "2009-01-08" is true
"2009-01-02" <  "2009-01-08" is *false*

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-08 14:19:09 -06:00
Joe Atzberger
c70cd87d54 Bug 2900: fix GetPendingIssues.
GetPendingIssues did several bad things:
~ select * on a 4 table join,
~ including multiple namespace collisions,
~ including large fields marc and marcxml from biblioitems,
~ return ($count, \@array_being_counted).

Not everything is fixed here (see FIXMEs), but the situation is
improved considerably, with bug 2900 resolved.  The "timestamp"
namespace collision in query should be resolved by separate patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-08 11:08:27 -06:00
Galen Charlton
d97ba8cecc bug 2747: avoid warning if items.itype is NULL
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-07 15:33:21 -06:00
Joe Atzberger
cdb4b60d93 Bug 2747 for staff interface itemtype display.
Prefer accuracy over graphical icon.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-07 15:13:43 -06:00
Joe Atzberger
458b0ed510 GetAuthValCode calls were positioned inside the loop,
despite the same values being supplied each time.  Then
the conditional assignments would repeat the same calls again!
That means execution was liable to query the DB at least once
and as many as four times per item.  With a large number of items
this is an unnecessary burden.  By moving the calls outside
the loop, we can guarantee that we never have to call the DB for
that info more than twice (once for lost, once for damaged).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-07 15:11:17 -06:00
Galen Charlton
2dcca73ae0 fix permission error introduced in a previous patch
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-06 21:04:42 -06:00
Joe Atzberger
5f1d461df9 Bug 2752 - comment out problematic DELETE op.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-06 20:47:42 -06:00
Michael Hafen
0506218f8b javascript redirect when selecting a patron on circulation.pl Patron Selection Screen
This adds a little javascript to the Patron Selection form input after searching for a patron to check out to.
On click it redirects to checking out to the clicked patron.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-06 20:42:47 -06:00
Michael Hafen
1c6fb50648 Put patron Privilege 'updatecharges' to use on fines pages
This changes the flags required for the fines pages to include the
updatecharges flag.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-06 20:40:45 -06:00
ac196cddcc Hiding SMS messaging preferences if there is no SMSSendDriver defined in system preferences.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-06 20:29:53 -06:00
3686361d3e Hiding SMS settings in OPAC if SMSSendDriver is not defined. Fixes Bug 2455, remove SMS column from patron messaging preferences if SMSSendDriver is not defined
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-06 20:29:43 -06:00
Joe Atzberger
a581f7203c Bug 2842: ->regexp('syspref') failed for users of iso dateformat.
Sticky due date and patron import were the two areas affected.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-01-06 20:24:46 -06:00