Koha-community/Koha - Koha - Koha: The world's first free and open source library system

Commit Graph

Author	SHA1	Message	Date
Owen Leonard	63d7386ed0	Bug 11829: fix JavaScript error on staff client biblio details pages if template variables are undefined The JavaScript included in cat-toolbar.inc expects several variables to be passed to the template for use in calculations. Several scripts do not pass the required variables to the template, leading to a JS error. This patch re-adds (See Bug 9823) hold count calculation to the required scripts and copies the acquisitions-related count calculation from detail.pl into related bibliographic detail scripts so that the commonly-included cat-toolbar.inc can receive correct values. To test, locate a bibliographic record which has no holds and is not used in a current or deleted order, but which has a local cover image attached. Check the following views to confirm there is no JavaScript error: - Normal - MARC - Labeled MARC - ISBD - Items - Images (from the Images tab on the "Normal" detail page) Next, locate a bibliographic record with no items attached which is used in an Acquisitions order. On each of the pages listed above, choose "Delete record" from the Edit menu. This should trigger a warning that the record is used in an order. Cancel the deletion. Finally, delete the order which references the bibliographic record. On each of the pages listed above, choose "Delete record" again. This should trigger a warning that the record is used in a deleted order. Cancel the deletion. I went through the test plan, everything works OK. It resolves Bug 11831 as well. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> - Printing from MARC and ISBD view works again - No more Javascript errors found - Deleting a record with attached order gives the correct warning, both for ordered and cancelled. Passes all tests and QA script. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	10 years ago
Marcel de Rooy	e536fd087d	Bug 9823: QA follow-up for GetReservesFromBiblionumber calls The template params holds and holdcount are not used in the ISBD template. Removed the associated code from catalogue/ISBDdetail.pl. Same applies for catalogue/MARCdetail.pl and labeledMARCdetail.pl. Same applies also for catalogue/imageviewer.pl. Same applies also for catalogue/moredetail.pl. In catalogue detail.tt only the number of holds is used. Removed the code that passed the holds array to the template. For consistency opac-detail should also incorporate future holds into its holds count; added the all_dates parameter for that reason. The Reserves module is no longer needed in moredetail. Removed it. Checked the other scripts also. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Jonathan Druart	8b685c1e80	Bug 9823: Refactor return from GetReservesFromBiblionumber The return from GetReservesFromBiblionumber contains an unnecessary extra variable. In scalar context an array returns its element count. Maintaining a separate count can lead to unforeseen bugs and imposes ugly constructions on the subroutine's users. Remove the useless count variable from the return This patch also changes the parameters: now the routine takes a hashref. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Placed biblio holds, future holds and item holds. Works as expected. Tested Holds.t and Reserves.t. Pass. Tested /cgi-bin/koha/ilsdi.pl?service=GetRecords&id=999 with two holds on one item. Fine. C4/SIP/ILS/Item.pm: Looked for "whatever" and "arrayref" and could not find them anymore. Looks good. Handled a few unneeded calls in QA follow-up. Left only one point to-do for serials/routing-preview.pl. See Bugzilla. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Jonathan Druart	9237ee80c4	Bug 11397: Remove the itemnumber list on the Acquisition detail tab The list of links to items from the acquisitions tab can be unwieldy if an order was used to purchase a lot of them, and the availability of AcqItemSetSubfieldsWhenReceived and filters on the holdings table provide alternative ways to do things like turn off on-order statuses. Test plan: - verify this patch does not introduce regression on the enhancement introduced by bug 8230. - verify the itemnumber list does not appears anymore. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> The acquisitions details tab on the holdings table in the staff client no longer shows the links to the items. Tests pass. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. In my tests the itemnumbers didn't show up on the acquisition detail tab before the patch. So the patch visually only changed the column header for me. All other acquisition related information showed up ok. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Marcel de Rooy	d92dc91f77	Bug 11329: Check for MARC record existence in catalogue/showmarc Intranet counterpart patch. Same check as in opac/opac-showmarc. Test plan: [1] Run showmarc.pl with valid biblionumber in id parameter. [2] Remove id parameter from URL. You should get a 404 now. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes koha-qa.pl, works as advertised. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Jonathan Druart	38edd714c5	Bug 9788: QA followup 1/ CURRENT_DATE() is a MySQLism and should be replaced with CAST(now() AS DATE). 2/ The date formatting should be done in the template (using the TT plugin). Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Marcel de Rooy	92be11bbcf	Bug 9788: (follow-up) removing the alldates parameter from GetReservesFromItemnumber Before bug 9788 the alldates parameter of GetReservesFromItemnumber was actually not used in the codebase. The first patch of bug 9788 did change that and passed true by default. But a closer look revealed that we do not really need it. The parameter is removed by this patch; the SQL statement is slightly adjusted: if reservedate<=now or a waitingdate is filled for the requested itemnumber, GetReservesFromItemnumber will return the reserve. This includes so-called future waits: a future hold that has been confirmed ahead of time with pref ConfirmFutureHolds > 0 days. Note that future item-level holds are not really interesting to return; this just corresponds to original behavior. Future next-available holds are not in view at all; they do not contain an item number. Test plan: Actually, the test plan of the first patch is valid. But for completeness I repeat it here: [1] Enable future holds and set ConfirmFutureHolds to 2 days. [2] Place a future next-available hold for 2 days ahead. [3] Check item status on catalogue detail. Available? That is fine. [4] Confirm the future hold by checking it in. ('future wait') [5] Look at item status again on catalogue detail. Must be Waiting now. [6] Switch to OPAC and login as another opac user. Goto Place a hold. [7] Check item status with item level hold info. Is it waiting? [8] Try to place hold in staff, check item level status again. Waiting? [9] Make a transfer for the item. Switch branch. Check hold status on Transfers to receive. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Marcel de Rooy	1a9737be76	Bug 9788: Improvements when calling GetReservesFromItemnumber This patch makes GetReservesFromItemnumber also returns the waiting date and removes some repeated code. Improves item status display on catalogue detail, when placing a hold at opac-reserve and in staff, and on transfers to receive form. This patch builds on work from reports 9367 and 9761. Test plan: Place a future next-av. hold (enable future holds prefs), say 2 days ahead. Check item status on catalogue detail. Nothing to see. Enable ConfirmFutureHolds by inserting a number of days, say 2. Confirm earlier hold by checking it in. Look at item status again on detail. Switch to other opac user. Try to place a hold again. Check item status with item level hold info. Try to place hold in staff, check item level status. Make a transfer for that item. Switch branch. Look at transfers to receive. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Galen Charlton	bb75025364	Bug 7002: fix some invalid superlibrarian permission checks This patch fixes a problem where if a staff user has superlibrarian permissions, but also has module-specific permissions, they are prevent from editing item records that they should be allowed to. To test: [1] Turn on IndependentBranches. [2] Register a superlibrarian staff user at branch A. [3] Give that new account at least one other module-level permission. This cannot be done through the user interface, however, but can be done via SQL: UPDATE borrowers SET flags = 3 WHERE userid = 'XXX'; [4] Log in as that new superlibrarian. [5] Bring up the item details (catalogue/moredetail.pl) page for an item at branch B. Note that there is no 'Edit Item' link. [6] Similarly, try editing that item (cataloging/additem.pl). Note that the edit form forbids you from touching the item. [7] Finally, try editing that item using the Tools \| Batch item modification utility. Note that it doesn't allow you to do so. [8] Apply the patch. [9] Repeat steps 5 through 7. This time, the item actions should be allowed. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes QA script and test suite. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Jonathan Druart	7180eb1153	Bug 8230: Display acquisition details on the catalogue detail page This patch adds a new tab "Acquitition details" on the catalogue detail page. It provides a list of order made for this biblio. New system preference: AcquisitionDetails: Hide/Show the new tab. The default for new and upgraded installations is to display the new tab. Test plan: 1/ Apply the patch. 2/ Select the "placing an order" value for the AcqCreateItem pref. 3/ Create a new order with X items. 4/ Go on the catalogue detail page for the selected biblio. 5/ Click on the "Acquisition details" tab and check that your order is displayed. Itemnumbers are present in the last column. Check that links are not broken. 6/ Close your basket. 7/ Status become "Ordered" 8/ Receive X-1 items. 9/ Come back on the catalogue detail page. There are 2 orders: 1 complete and 1 partial. The complete one has a receive date. 10/ Receive the last item. 11/ Now you have 2 orders with a complete status. 12/ Cancel the last receipt. 13/ You have 1 ordered and 1 complete (2 items). 14/ Cancel the first receipt. 15/ You have 1 ordered (3 items). 16/ Delete your order 17/ You have 1 deleted order. 18/ Switch the AcqCreateItem pref to "receiving an order" 19/ Do again steps 3 to 17. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Mathieu Saby	b693ea0cd8	Bug 9780: restrict the ability to delete a bib record associated with an order Currently, anyone can delete a record used in an order. With this patch, only librarians with managing order permission can delete it if it is used in an active or a deleted order. This patch also add a specific warning informing that deleting a record used in an active order is dangerous. To test : A. test what can do and see a librarian with order managing rights 0) Connect to Koha with a borrower with order managing rights 1) in a basket, create 2 orders A & B from new records 2) delete order B 3) in the catalogue, try to delete - record used for order A : you should see a specific warning informing you the record is used in 1 order, and that deleting it is dangerous - record used for order B : you should see a specific warning informing you the record is used in 1 deleted order - a record not used in any order : you should see no specific warning B. test what can do and see a librarian without order managing rights 4) Connect to Koha with a borrower without order managing rights 5) in a basket, create 2 orders A & B from new records 6) delete order B 7) in the catalogue, try to delete - record used for order A : you should see a specific warning informing you that you need specific rights to delete the record - record used for order B : idem - a record not used in any order : you should see no specific warning Signed-off-by: Pierre Angot <tredok.pierre@gmail.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Julian Maurice	8848863b7b	Bug 9044: Provide item selection in record detail page (staff client) This patch add a column in the items table of catalogue/detail.pl that contains checkboxes for item selection and a drop-down list of actions that can be executed for the selection of items. Currently available actions are: - Delete selected items: redirect to batch items deletion - Modify selected items: redirect to batch items modification Item selection is only enabled if the new syspref StaffDetailItemSelection is ON. Actions are not displayed if user doesn't have the right permissions. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Further testing notes on last patch. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	12 years ago
Galen Charlton	f791dd4770	Bug 5645: improve converting simple search to Z39.50 search This patch builds on the patch for bug 10742 by ensuring that when a search initiated from the staff interface simple search returns results, if you click on the Z39.50 search button, the search form is populated with the search string without "kw,wrdl". To test: [1] Perform a search in the staff interface that will return results. [2] Click the Z39.50 search button. [3] Observe that the search string appears in the title field in the Z39.50 search form, but with a prefix of "kw,wrdl". [4] Apply the patch. [5] Repeat steps 1-2. This time, the search string appears without the index prefix. This will make the Z39.50 search much more likely to work. [6] Repeat steps 1-2, but with a search that does not return any hits in the Koha database. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Owen Leonard	4885435c6a	Bug 10868 - Use new DataTables include in catalog templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to all catalog-related pages which use DataTables. The checkout history script has been altered to send unformatted dates to the template, and the template now uses the "title-string" sorting filter to enable sorting on unformatted dates. To test, view the following pages and confirm that table sorting is still working correctly: Catalog -> Biblio detail page Catalog -> Biblio detail page -> Checkout history Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Sorting works. No koha-qa errors. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Note: On the issue history page: 1/ If the checkin on is empty (the item is currently checked out), the line is sorted in last. 2/ The Renewed column is not sorted by date. Before this patch, the sort was worse. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Meenakshi.R	0005f6bad3	Bug 7639: add option to forgive overdue fines when declaring items lost This patch adds functionality to forgive overdue fine when an item is set to lost status. Fines are forgiven only when the syspref WhenLostForgiveFine is set to yes. Item can be set to lost status from: - catalogue/moredetail.pl - cataloguing/additem.pl - tools/batchMod.pl - misc/cronjobs/longoverdue.pl Changed subroutine C4::Circulation::LostItem to forgive fines on the item depending on the value of syspref WhenLostForgiveFine. This routine is currently used to return an item and charge a replacement cost. Also added a new syspref in C4::Circulation::LostItem - WhenLostChargeReplacementFee. The replacement fee will now be charged only if this syspref is set to yes. The default value of the WhenLostChargeReplacementFee is yes, meaning that current behavior will not change during upgrade. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Alex Hatley <alexh@cctexas.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Testing notes on last patch in series. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	12 years ago
Kyle Hall	dbaefb626c	Bug 10550: Fix database typo wthdrawn This patch updates the wthdrawn field in items and deleteditems to be withdrawn instead. No functional changes are made. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Save for translation files (that will be fixed on next release), only occurrence of wthdrawn is on updatedatabase.pl No koha-qa errors. This touch many files, and I did not test everything, but all seems normal. I think that any problem could be fixed later. Perhaps both entries in updatedatabase.pl could be joined into one, but thats for QA. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Fridolyn SOMERS	0ab71d3264	Bug 10742: improve converting simple search to Z39.50 search In intranet, when search does not return results, there is a button to perform the same search on Z39.50 servers. This works well when coming from advanced search. But when using simple search from header, in the Z39.50 search box "kw,wrdl" is added to the operand in title. This patch simply adds kw as default value when the cgi does not have idx parameter. Test plan : - In intranet, perform a search from header that does not return any result. For example "afalseword" - Click on "Z39.50 Search" => you get a popup with the searched word in title. For example: Title: afalseword - Go to advanced search page - Enter the same word into first input and submit - Click on "Z39.50 Search" => you get a popup with the searched word in title. Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Small change, fixes an annoying problem. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Jared Camins-Esakov	762c3304ea	Bug 10404: add previous/next browsing to staff client Although previous/next browsing was added for searches in the OPAC in 2011, the staff client has been without any sort of search browsing. Until now. This patch is an all-singing, all-dancing, all-compatible implementation of search browsing that will work across multiple browser tabs and on any browser since IE7 (though the staff client layout is broken on IE7). To test: 1) Perform a search that will bring up multiple results. 2) View one of the results. 3) Use the Previous and Next links to browse along the search results. 4) Use the "Return to results" button to check that you end up at the correct page of results, even if you page through more than 20 records. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Janusz Kaczmarek	0b05d1acb9	Bug 10578: fix results sorting in staff interface To test (in librarian's interface): 1. Have some biblio records to get a list when searching. 2. Make an advanced search with 'as phrase' modifier (title -- ti,phr: or author -- au,phr: , etc.) 3. Having the result list try to change the sort order. 4. You should get no results with a message like: "No results match your search for 'au%2Cphr: " etc. 5. Apply the patch 6. Repeat steps 2. & 3. 7. You should get the list sorted according to your choice. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, passes all tests and QA script. Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Jonathan Druart	ec3735433a	Bug 10515: make behavior of library category fetchers consistent with other fetchers The prototype is not consistent, GetBranchCategory should return only 1 result and GetBranchCategories should not have a categorycode argument. This patch fixes that. Test plan: 1/ Try to add/remove/modify a library. 2/ Add some groups 3/ Add these groups to a library Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Chris Cormack	0e0403372e	Bug 9665: QA follow up fixing tabs Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Owen Leonard	4b9a6d803f	Bug 9665: add RIS and BIBTEXT bibliographic record export to staff interface The OPAC offers RIS and BIBTEX as choices for bibliographic downloads, but the staff client was missing these options. This patch adds them. To test, view a record in the staff client (detail.pl, MARCdetail.pl, etc.) and click the "Save..." toolbar button. BIBTEX and RIS should be available and functional. Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Galen Charlton	066b55ef4d	Bug 10080: (followup) change two last instances of the old syspref name Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Kyle Hall	b00ec06968	Bug 10080 - Change system pref IndependantBranches to IndependentBranches Test Plan: 1) Enable IndependantBranches 2) Apply this patch 3) Run updatedatabase.pl 4) Verify that the system preference still functions correctly Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com>	11 years ago
Galen Charlton	97addc2fb4	bug 8215: (followup) rename GetItemReservesInfo Renamed that routine to GetItemCourseReservesInfo in order to avoid any potential confusion with reserves qua hold requests. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	11 years ago
Galen Charlton	65b874bb47	bug 8215: (followup) make sure C4::CourseReserves doesn't export anything New modules should not export any symbols by default without a very good reason. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	11 years ago
Kyle Hall	be869ab279	Bug 8215 - Course Reserves Adds a course reserves system for academic libraries. The course reserves system allows libraries to create courses and put items on reserves for those courses. Each item with at least one reserve can have some of its attributes modified while it is on reserve for at least one active course. These attributes include item type, collection code, shelving location, and holding library. If there are no active courses with this item on reserve, it's attributes will revert to the original attributes it had before going on reserve. Test Plan: 1) Create new authorised value categories DEPARTMENT and TERM 2) Create a new course, add instructors to that course. 3) Reserve items for that course, verify item attributes have changed. 4) Disable course, verify item attributes have reverted. 5) Enable course again, verify item attributes again. 6) Delete course, verify item attributes again. 7) Create two new courses, add the same item(s) to both courses. 8) Disable one course, verify item attributes have not reverted. 9) Disable both courses, verify item attributes have reverted. 10) Enable one course, verify item attributes are again set to the new values. 11) Edit reserve item attributes, verify. 12) Disable all courses, edit reserve item attributes, verify the item itself still has its original attributes, verify the reserve item attributes have been updated. 13) Verify the ability to remove instructors from a course. 14) Verify new permissions, top level coursereserves, with subpermissions add_reserves and delete_reserves. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Corinne Bulac <corinne.hayet@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> http://bugs.koha-community.org/show_bug.cgi?id=8125	12 years ago
Jared Camins-Esakov	cd281e4880	Bug 10281: searching for a search domain fails For reasons I cannot fathom, the split() in handling multi-branch limits was not coming up with a valid search group code. Replacing the split() with a substr() and creating the CGI parameter as a string rather than as an arrayref fixes the problem. This problem may not affect all installations, since I tested this exact feature just under two months ago and it worked fine, and none of the relevant code has been changed since then that I can see. To test: 1) Create search group, and add at least one library to it, in /cgi-bin/koha/admin/branches.pl 2) Apply patch 3) Try doing a search limited to your search group, making sure that the search will match items that belong to a library in the search group 4) Sign off Signed-off-by: Magnus Enger <magnus@enger.priv.no> I have failed to recreate the problem on three different dev installs, both on Ubuntu and Debian, but the current patch does not break anything as far as I can tell, so I'm signing off. I tested with two libraries in the same search domain, with each library owning a different book by the same author. Searching for the author in - all libraries, - individual libraries and - the search domain that contains both libraries all return the expected results. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and QA script pass. I couldn't reproduce the problem, but didn't find any regressions. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	11 years ago
Galen Charlton	a7eb34f2c8	Revert "Bug 6554 - make Koha internally utf-8 clean" This reverts commit `d542740ab8`. Rolling back bug 6554 work until we have more comprehensive tests. Conflicts: opac/opac-search.pl	11 years ago
Colin Campbell	5b6f89714d	Bug 9684 : Correct path to compact.xsl When try to display card view of retrieved record error occurred as compact.xsl could not be found script was constructing path as though it was opac Also added fallback to en version if no xsl file found under current lang as done in opac-showmarc.pl Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Test plan: * Set sys pref to use CCSR * Do a Z39.50 Search * Click 'card' on one of the results * confirm that there is no error. All test pass Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> I am astonished that opacthemes affects Z39.50 search in staff so this might be fixing a bigger problem. Checked that clicking on Card works for both themes now correctly after I confirmed the bug. Also all views in OPAC were checked for both themes. All tests and QA script pass. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	11 years ago
Dobrica Pavlinusic	d542740ab8	Bug 6554 - make Koha internally utf-8 clean In current implementation (mostly commented out in this patch) uses heuristic to guess which strings need decoding from utf-8 to binary representation and doesn't support utf-8 characters in templates and has problems with utf-8 data from database. With this changes, Koha perl code always uses utf-8 encoding correctly. All incomming data from database is allready correctly marked as utf-8, and decoding of utf8 is required only from Zebra and XSLT transfers which don't set utf-8 flag correctly. For output, standard perl :encoding(utf8) handler is used so it also removes various "wide character" warnings as side-effect. Test scenario: 1. make sure that you have utf-8 characters in your biblio records, patrons, categories etc. 2. try to search records on intranet and opac which contain utf-8 characters 3. install language which has utf-8 characters, e.g. uk-UA dpavlin@koha-dev:/srv/koha/misc/translator(bug_6554) $ PERL5LIB=/srv/koha/ perl translate install uk-UA 4. switch language to uk-UA and verify that templates display correctly 5. test search and Z39.50 search and verify that caracters are correct Signed-off-by: Owen Leonard <oleonard@myacpl.org> I followed the test plan, adding utf-8 characters to library names, patron categories, titles, and authorized values. I tried the uk-UA translation and everything looked good. When performing Z39.50 searches for titles containing utf-8 characters I got results which were still occasionally contaminated with dummy characters [?] but I assume this is Z39.50's fault not the patch's. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Already signed, add mine. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Julian Maurice	90c323f713	Bug 9875: Hide empty items tab The two holdings tabs displayed whether or not there is anything to go in them. Signed-off-by: Corinne Bulac <corinne.hayet@bulac.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> If one item list is empty, no empty tab is shown. All tests and QA script pass. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Tomás Cohen Arazi	4dcee58a4d	Bug 7440 - Remove NoZebra vestiges Removed NoZebra vestiges. This comprises several code blocks that depend on the NoZebra syspref and NZ related functions/methods. C4::Biblio-> GetNoZebraIndexes _DelBiblioNoZebra _AddBiblioNoZebra C4::Search-> NZgetRecords NZanalyse NZoperatorAND NZoperatorOR NZoperatorNOT NZorder C4::Installer-> set_indexing_engine Sponsored-by: Universidad Nacional de CÃ³rdoba Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	11 years ago
Owen Leonard	f3d99e6a13	Bug 9663 - Individual bibliographic record "Save" option requires export permission This patch corrects permission on the export option available on catalogue pages in the staff client (detail.pl, MARCdetail.pl, etc) so that users no longer require "export_catalogue" permission. "export_catalogue" permission is required only for tools/export.pl. This patch also corrects some crazy nearby indentation. Sorry, couldn't resist. To test, visit a page like detail.pl with and without "export_catalogue" permission. It should be possible to save the record as MODS, MARCXML, MARC, etc. without error. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Vitor FERNANDES	6dcd8f235f	Bug 9395: Problem with callnumber and standard number searches This problem happens because there isn't a operator "phr" in the values of callnumber and standard number search. So many results aren't the corrects ones. Test plan: - Apply the patch - In the dropbox search menu of OPAC main page header, the callnum should have only callnum - In OPAC advanced search the callnumber and standard number options shouldn't have "phr" - In staff client advanced search the callnumber and standard number options shouldn't have "phr" - Change OPACNumbersPreferPhrase and IntranetNumbersPreferPhrase to "use" - The options listed before should use now the operator "phr" - This will resolve the problems with the searches of callnumbers and standard numbers in OPAC and staff client (spaces problems, no results, inconsistent results, etc...) Sponsored-by: KEEP SOLUTIONS Signed-off-by: Owen Leonard <oleonard@myacpl.org> I don't know how to reproduce the searching problems described in the bug, but I can confirm that the patch works correctly to enable/disable the use of 'phr' in the searches described in the test plan. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> System preferences work as described, switching indexes in OPAC and staff. All tests and QA script pass. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Kyle Hall	bc4fd0710f	Bug 5790 - Prevent deletion of records with holds - QA Followup Signed-off-by: Liz Rea <liz@catalyst.net.nz> fixes qa concerns, feature still works Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Kyle Hall	700f9980bb	Bug 5790 - Prevent deletion of records with holds Test Plan: 1) Apply patch 2) Create a record 3) Create an item for the record 3) Place a hold on the bib 4) Attempt to 'Delete all items', you should recieve an error message stating to delete all holds before deleting all items. Also, it is possible to get into a situation where a record has holds but no items. In this situation, it is not possible to view/delete the holds without adding an item back to the record. In this case, attempting to delete the bib causes a warning, but does not prevent deletion. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Passes tests - do note that it was a design decision to leave the delete links clickable even though they are grey. The reasoning is that librarians will want to be able to know why they cannot delete a given item or bib - I like this. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Kyle Hall	a1e9e3d8d9	Bug 9292 - Remove dead code related to 'publictype' This patch removes the superflous code related to 'publictype' which is a key set for item hashes in some perl files. This key is never used or stored. Test Plan: 1) Apply patch 2) Test catalogue/detail.pl, opac/opac-detail.pl and opac/opac-user.pl 3) You should not see any changes in behavior Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Jonathan Druart	4dbcd077f6	Bug 8377: Followup move style in a css file and do not pass template to a pm 1/ It's better to set style of the video marked in a css file. 2/ Replace some for my $i in (0..#$array) with for my $element in (@array) 3/ the routine in a pm returns a hash not the $template variable Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Mirko Tietgen	33aa6ec2fd	Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff client This enhancement uses information from MARC field 856 to generate the appropriate HTML5 code to embed am media player for the file(s) in a tab in the OPAC and staff client detail view. This patch supports the HTML5 <audio> and <video> element. Additionally it gives basic support for the <track> element. This element is not supported very well by recent browsers. Please consider the patch working when you get working video or audio. Rebased to Master 22.11.2012 Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Kyle Hall	63ec7a4fce	Bug 7674 - Followup - Add missing right-hand curly bracket Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and perlcritic pass. Tests: Database update - OK, system preferences were added correctly - Version number of updatedatabase was only XXX, changed to 3.11.00.XX OPAC 1) Detail page - OK, no visible change when OpacSeparateHoldings is turned off - OK, switching OpacSeparateHoldingsBranch works correctly - OK, shelf browser opens in correct tab - OK, only one tab shows when logged out INTRANET 2) Detail page - OK, no visible change when SeparateHoldings is turned off - Number of items is missing on top of the tabs Notes: - database update doesn't include bug number - other holdings tab does show when there are 0 items at other branches, it could be hidden in those cases - if there are over 50 items in the holdings or Other holdings tab, the warning and link 'This record has many physical items. Click here to view them all.' is only shown for the first tab. - closing the shelf browser on the second tab goes back to first tab - number ofitems is missing on top of the tabs - there are lots of indentation changes in the second patch, this makes it very hard to see the changes, please provide separate patches in the future Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Julian Maurice	b39c762dde	Bug 7674: Add 2 sysprefs to indicate the branch we want to separate on The 2 sysprefs are SeparateHoldingsBranch and OpacSeparateHoldingsBranch and permit to chose between home branch and holding branch. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Paul Poulain	5a14940f80	Bug 7674: Separate items in two tabs on biblio detail page (staff+opac) Two tabs: "<branch> holdings" / "Other holdings" "<branch> holdings" tab contains items whose homebranch is the current branch. "Other holdings" tab contains all other items. If current branch is not set (connected with mysql user or not logged in (opac)), the display is unchanged (1 tab "Holdings") Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Owen Leonard	df7e36e8fb	Bug 8893 - show more information on printout My proposed solution eliminates the special print view page altogether and has the Print button trigger the browser's print function. I've tweaked the print stylesheet to improve the output. Normally I don't think print buttons in the interface are necessary, since a user could be expected to be able to print the page using browser controls. But I think it's best not to remove the button when people are used to seeing it. The behavior people will find now is different when clicking the button from different catalogue pages. A user on the MARC detail page, instead of getting the generic print view will get a print of the page they're on. Overall I think this is more in line with what a user would expect. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Jonathan Druart	c39380ed4e	Bug 8782: Close a subscription If a subscription is no longer enough published (or we are not waiting for a new periodical) we are allowed to close it. If a subscription is closed, we are not able to receive or generate a new serial. On the serial module, we can now - close a subscriptionn - reopen a closed subscription On serial search 2 tabs is displayed (opened and closed subscriptions). This patch adds: - a new field subscription.closed in DB - a new status for serials (8 = stopped) Test plan: - search subscriptions - close a subscription and check that you cannot receive or generate a new serial - launch another search and check that the closed serial is into the "closed" tab. - You are allowed to reopen a subscription on the subscription detail page and on the subscription result page. A javascript alert ask you if are certain to do this operation. - Check the serial status "stopped" everywhere the status is displayed (catalogue/detail.pl, serials/claims.pl, serials/serial-issues-full.pl, serials/serials-collection.pl, serials/serials-edit.pl, serials/serials-recieve.pl, serials/subscription-detail.pl and opac-full-serial-issues.pl) - The report statistics does not include the closed subscriptions if you don't check the "Include expired subscriptions" checkbox. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 8782: Followup: add some minor modifications - Show 'closed' information in biblio detail page - Add a column in serials report table - Search subscriptions on title words instead of string - Prevent serials editing when subscription is closed - Don't change status of "disabled" serials Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 8782 - Close a subscription - Followup - Fix updatedatabase.pl Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Mathieu Saby	8718629c5c	Bug 8954: Make languages list in advanced search translatable (revision 1) In opac-search.pl and search.pl, this patch moves the $lang variable from the end to the begining of the script, and use it as a parameter for getAllLanguages. In Languages.pm, getAllLanguages function is modified : - if no parameter is passed to the function, it returns english languages names - if a $lang parameter conforming to RFC4646 syntax is passed : -- the function returns languages names translated in $lang if possible -- if a language name is not translated in $lang in database, the function returns english language name To test, set your opac and staff interface in english and in other languages and check search.pl and opac-search.pl : - If language names in your languages_description table are translated in the same language you use for your GUI, the language names in dropdown list will be translated in this language (+native name). - If your GUI is in english, or in a language into whitch languages names are not translated in languages_description, the dropdown list will stay in english (+native name). Signed-off-by: Marc Veron <veron@veron.ch> Patch behaves as expected. With Opac language set to French I got all languages with French language name. With German (de-DE), I got only a few with German language names (and all other with English ones), this was due to missing entries for de-DE in table language_descriptions. This behaviour is consistent with the description above. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested language list in OPAC and staff advanced search is translated properly after applying the patch. Checked that language switcher still works like it should. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Fixed typo in POD.	12 years ago
Marcel de Rooy	ff38060039	Bug 8872: Changes for intranet showmarc Simplifies template (eliminating intranet-bottom include). Makes encoding for card view more consistent with approach in Templates module. Rearranges a few lines in script for consistency and performance. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Passed-QA-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>	12 years ago
Mark Tompsett	b8f4b1fa14	Bug 8175 - check logs error or displays incorrectly in details.pl Changed "$item->{'materials'} ne ''" to "defined($item->{'materials'}) && $item->{'materials'} =~ /\S/" in if condition to prevent error when it is NULL, and to properly capture the intent of printing if there is something visible. Cases tested include NULL, '0', '', ' ', and 'blah' by using UPDATE items SET materials=NULL where biblionumber=19158; where the biblionumber was chosen randomly, because only NULL was in the items.materials field. The NULL case triggers an error, but it does display correctly. The ' ' case displays an apparently empty column, which does not seem to be the intent of the flag that is being set. This is why a simple $var check is not sufficient. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	12 years ago
David Cook	63145eb3d2	Bug 8718 - Normal catalogue detail view in staff client doesn't show missing serials or subscription history note Adds librariannote (staff subscription history note) and missing list to the normal catalogue detail view in staff client. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	12 years ago
Fridolyn SOMERS	f941dc341a	Bug 8481: Items table is showing in opac-MARCdetail.pl but not in MARCdetail.pl Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>	12 years ago

... 2 3 4 5 6 ...

534 Commits (e7d4c773be5cf1df275827270465f7f55b95ce02)