Commit graph

10320 commits

Author SHA1 Message Date
Sébastien Hinderer
ed62c08288 Database structure modification.
Adds the country and B_country columns to the borrowers table.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 18:17:11 -04:00
63b9b7655b bug 3539: tweaked English description of HidePatronName syspref
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 13:58:25 -04:00
Chris Cormack
634df1c76c Bug 3539, Adding a systempreference to hide borrowers name on the catalogue detail page, and holds page
Squashed commit of the following:

commit e9dd6e1dee03fe3503f7995b57510f9edfe6b333
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Wed Aug 19 08:14:53 2009 +0000

    Version number

commit df3ee5473e79b760a91c62b96d7ce19229e0fd27
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Wed Aug 19 08:08:11 2009 +0000

    French systempref

commit c4b036e4e43947d7d1fb9f2e18e460788cb4e1ec
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Wed Aug 19 00:25:33 2009 +0000

    Code to update the database, and updating the sysprefs.sql

commit f74b942c24d5e9c33a4ec0e5ac706a0e347eb1a7
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Tue Aug 18 02:07:22 2009 +0000

    Now hides the name on the detail screen too

commit 53c80dbef88e360a4bbb78ecff3a6ca6ec401398
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Tue Aug 18 01:35:19 2009 +0000

    Allowing the librarians to choose to hide the borrowers name on holds

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 13:52:26 -04:00
7d2562a70a bug 3485: fixed updatedatbase (also DBRev 043->044)
* Fixed case of copy-and-pastitis in DBrev descrieption
* Inserted description for new syspref

NOTE: Please do not leave the system preference description blank
in the updatedatabase entry - even for non-English users, an English
description is more useful than a blank one.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 13:25:48 -04:00
PTFS Contractor
36ec435cd9 bug 3485: Clear Borrower record after checkout.
Button added to clear the last Borrower record after transaction is complete
To enable, turn on the syspref DisplayClearScreenButton.

This work was sponsored by Middletown Township Public Library, Middletown, NJ USA

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 13:21:21 -04:00
5ea0d6bb9b bug 3481: imporve cart_to_shelf.pl
Use revised CartToShelf() to insure that indexer
knows to reindex affected bib records.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 13:07:33 -04:00
d2943ebc6c bug 3481 followup - ensure permanent location is stored when updating item
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 13:07:33 -04:00
dafb3e20da bug 3481 followup - improve CartToShelf
* added POD
* removed optional $barcode argument - in all cases,
  itemnumber is known, and we should stick with
  itemnumber when retrieving an existing item
* use ModItem to do the update so that indexer
  will know to reindex bib - otherwise, can't
  do an accurate search of items that are on
  the shelving cart.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 13:07:33 -04:00
4b71494f19 bug 3481 followup - set temporary processing location
Ensure that the temporary processing location is always
set regardless of whether one item is added or multiple
copies are added at once.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 13:07:33 -04:00
8219d79f5a cosmetic fix - use $itemnumber as argument to GetItems when available
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 13:07:32 -04:00
40ad4d2129 bug 3481 followup - add new sysprefs to circulation section 2009-08-23 13:07:32 -04:00
6f5797a315 bug 3481 followup - fix database update
Set items.permanent_location to the current value
of items.location - otherwise, the item shelving location
could get blanked as existing items are checked in.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 13:07:32 -04:00
Colin Campbell
e40e11ab0c bug 3481: Allow Item Temporary Locations for Processing and Shelving.
Allows temporary locations corresponding to 'in processing' and 'shelving'
so that newly-created items, and newly-returned items do not show
immediately as a available. Three new system preferences govern the usage
of these features.

NewItemsDefaultLocation. If system pref NewItemsDefaultLocation is set to a location code,
 all newly catalogued items will be set to the location set in this preference.
 Location code must be a valid LOC authorized value type.

InProcessingToShelvingCart. if the system pref InProcessingToShelvingCart is turned on,
any items run through returns.pl with a location code for 'PROC', will be modified to
have a new location code of 'CART'.

ReturnToShelvingCart.  If the syspref ReturnToShelvingCart is turned on,
all items returned other than confirmed holds will have a new location code of 'CART'.
Any item issued is automatically taken of the shelving cart.

Adds a cron script shelf_to_cart.pl which should be run hourly.
Updates all items with a location of CART to the item's permanent location.

The original location code is stored in the new items column 'permanent_location'.

Original Author: PTFS Contractor <dbavousett@ptfs.com>

This work co-sponsored by
  Middletown Township Public Library, Middletown, NJ USA  and
  East Brunswick Public Library, East Brunswick, NJ USA

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 11:54:46 -04:00
b159ba8e5a fix how patron_flagged gets set for opac-user.tmpl
Remove unneeded variable and get value from $borr->{'flagged'}
directly, avoiding glitch where $borr->{'flagged'} could be
set after old $patron_flagged variable was set.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 11:35:26 -04:00
8e40c2d017 bug 3493: DBrev 041->042 (added OPACFineNoRenewals)
Also changed default value of OPACFineNoRenewals to 99999
when upgrading existing databases so that there's no (likely)
sudden change in OPAC behavior.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 11:35:26 -04:00
Jesse Weaver
f8a43317b1 Prevent OPAC renewals if fines are over limit
This introduces a new system preference, OPACFineNoRenewals, that sets a
limit on the total fines a patron can have before they can no longer
renew their own books. opac-user.pl has been updated to obey this limit.

This work sponsered by East Brunswick Public Library, East Brunswick, NJ USA

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 10:13:26 -04:00
5593a28164 implement bailing out of AddReturn if IndependantBranches is on
If IndependantBranches is ON and user attempts to return an
item at a library other than the item's home library, bail out.
This action, which was previously just a suggestion in the code,
is now required to ensure that the item doesn't get its
holdingbranch set to the library at which the attempt to return
the item was made.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 10:05:09 -04:00
15fbaea348 bug 3409 followup - fix use of $hbr
$hbr in this context is a branch code, not an
item field.

Also added use of C4::Debug;

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 10:05:09 -04:00
b59e016612 AddReturn now always updates holdingbranch
Prior to this patch, this was done only when returning
an item after it had been out on loan.  Even if the
item had not been on loan, the fact that it was checked
in means that it is now in fact at the new holding library.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 10:05:09 -04:00
223d1fa6e8 bug 3409 follow: fix crash if holdingbranch is undef
Make _GetCircControlBranch() default to the item's home library
in the case where it otherwise would have returned the item's
holding library but that field is null.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 10:05:09 -04:00
80820af3f6 bug 3409 followup: renamed _GetCirculationBranch
New name is  _GetCircControlBranch so as not to confuse
the library that a circulation transaction is taking
place at with the library that is supposed to control
circulation policy lookup.

Also fixed formatting errors in _GetCircControlBranch.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 10:05:09 -04:00
9dec888d78 bug 3409 followup: always set holdinglibrary to library last seen at
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 10:05:09 -04:00
Henri-Damien LAURENT
b00efc7295 Bug fix 3409 : Adding an internal function to C4::Circulation
This patch add the use of CircControl and HomeOrHoldingBranch for return and transfert rules.
* ItemHomeLibrary goes to item{HomeOrHoldingBranch}
* PatronLibrary goes to the borrower library
* PickupLibrary depends where the items was checked out, and the actual library.

This add a little improvment that does not re-request each time the circcontrol syspref.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 08:24:52 -04:00
Nahuel ANGELINETTI
b93b407f64 (bug #2829) fix some mistakes extracting editor segment
This patch fix how to extract the editor segment, and improve ISBN10/13 support.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-23 08:17:28 -04:00
Nicole Engard
0f3e4ae601 BUG 3371: ISBN no longer shows twice when more options on
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-22 16:41:26 -04:00
Nicole Engard
bfaebdf13e BUG #3533: Fix documentation link in news for new installs
This patch only fixes the link for new installs, not for
updates.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-22 16:40:45 -04:00
Nicole Engard
20949844c3 Cleaned up display on reports page
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-22 16:40:25 -04:00
Liz Rea
ca591d092b Adds helpful note to Home Phone and Home Email fields to remind staff which fields are shown on transit slips.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-22 16:33:44 -04:00
Darrell Ulm
8a4195658d Bug 2652 - This patch is an extension of the slip printing feature
and will print a SHORT SLIP of today's checkouts only.
 I also enhanced the normal slip to print the overdues separately as well as today's
 checkouts. There is another button on the print CIRC menu. Easily another quick key
 can be added, one for the regular slip and one for the short slip, i.e. today's
 only.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-20 21:08:05 -04:00
Colin Campbell
3199d032e5 Avoid numeric comparisons with leading zeroes
Numbers in perl with leading zeros are interpreted in octal
Ensure that comparisons are done using string operators
or where appropriate use the MARC::Field method

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-20 21:01:52 -04:00
b94e7acbbc Adding Katrin to the tranlsation tab on the about page
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-20 21:01:22 -04:00
Garry Collum
c89ed2ca1d Bug 3420: Revised follow-up patch for 'patrons with no checkouts'
Comments out all warnings that were used for debugging.

Enables warnigns and fixes the resulting warnings.

This patch replaces the previous follow-up patch for bug 3420.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-20 21:01:16 -04:00
Garry Collum
2c7d5b369d Bug 2889: Adds table highlighting to the Authority search results.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-20 21:01:13 -04:00
Chris Cormack
ae88b06b57 Edits to the about page : Adding a couple of missing developers, and adding ohloh links, still more links to go
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-20 21:01:11 -04:00
Garry Collum
10816a8b33 Bug 2505: Enables warnings in reserveratios.pl
Also fixes resulting warnings.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-20 21:01:08 -04:00
27e07d23d5 Remove utility script replaced by a test case
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-19 22:04:02 -04:00
Jane Wagner
bf38b1f7bb Bug 3532 show lost, damaged statuses on patron record
The patron record Details tab list of checkouts does not show lost, long overdue, claims returned, or damaged status, only that an item is overdue.  Added a check for lost and damaged statuses and a display of any matching statuses to the patron Details tab.

(revised version to drop unneeded lines from moremember.tmpl file)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-19 21:56:48 -04:00
5fc23f3fde Test case identifying incoherences between 'en' sysprefs and translated ones
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-19 21:56:43 -04:00
dfe0ffaa57 Follow up patch for the about patch, changing management team to release team
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-17 08:27:54 -04:00
811735595a Updating about page, some are bound to be missed, please send additional patches
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-17 08:27:51 -04:00
Garry Collum
315a541682 Bug 3420: Fixes 'Patrons with no checkouts' report.
Fixed typo in SQL statement.  Commented out some unused SQL statements.

Removed limit for itemtype (column not available in results) and added limit for branchcode.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-15 09:56:03 -04:00
201fab5c09 fixed glitch in display of current time filter in OPAC top issues
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-15 09:47:07 -04:00
Henri-Damien LAURENT
97a68f046e Translating unimarc_leader plugin in english
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-15 09:39:07 -04:00
Michael Hafen
2ace8cb33d bugfix invalid comparison to ceilingDueDate in CalcDateDue()
The comparison to check the ceilingDueDate is done in the syspref format,
which isn't a good comparison.  This changes to code so the comparison is done
using iso format.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-15 09:39:04 -04:00
Garry Collum
e60b571d6d Bug 2505: Enabled warnings in opac-topissues.pl
Fixed resulting warnings and fixed a small bug with the timeLimit drop-down box.  It would not retain its value on subsequent pages if 'no Limit' was selected as an option.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-15 09:39:02 -04:00
Garry Collum
5d23aafbee Bug 2553: Alphabetizes library and itemtype dropdown lists in Lost Items report.
Form - Fixes alphabetization of dropdowns.

Results - Fixes format of "Date last seen" to be the system date preference.  Adds highlighting to the table.

Enables warnings. Pages generated no warnings.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-15 09:38:59 -04:00
Nicole Engard
be8d899c98 Updated Help Files - Part 4
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-15 09:31:43 -04:00
Nicole Engard
cebfb00073 Updated help files - Part 3
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-15 09:31:36 -04:00
Nicole Engard
a5fba3c59d More Updated Help Files
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-15 09:31:25 -04:00
Nicole Engard
b13ff60615 Updates and adds new help files
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-15 09:31:21 -04:00