When an unauthorized call to svc is made, we use the ErrorDocument middleware to respond with an HTML
page. The API doens't do this, it simply returns its status. We should mount the svc as its own app to avoid
the redirect to HTML for unauthorized responses
To test:
1 - Create a report
2 - Add to IntranetUserJs:
$(document).ready(function() {
// Your report ID
var reportId = '492';
// Fetch the report
$.get('/cgi-bin/koha/svc/report?id=' + reportId, function(data) {
console.log('Kaboom');
});
});
3 - Log out
4 - Attempt to login
5 - KO
6 - Apply patch
7 - Reset all (or copy the necessary changes to your plack/apache files)
8 - Generate report and update user js again
8 - Logout, login
9 - Success!
Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This patch adds relator codes from the May 14, 2024 technical notice
(https://loc.gov/marc/relators/tn240514rel.html) to the list of MARC21 relator
terms in Koha.
To test:
1. Apply patch and reset_all
2. Go to Administration > Authorized values > RELTERMS
3. Search for the added relator codes
- wfs - Writer of film story
- wft - Writer of intertitles
- wts - Writer of television story
Note: this is added in the installer files. It will not affect existing
installations. For existing installations, add the new relator codes in
Administration > Authorized values > RELTERMS.
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This patch updates the default MARC21 bibliographic framework to add missing
subfields to field 647.
To test:
1. Apply patch and reset_all
2. Go to Administration > MARC bibliographic framework
3. Click Actions next to the default framework and choose MARC structure
4. Search for field 647
5. Click Actions > View subfields (or Edit subfields)
6. Check that subfields match the documentation
https://www.loc.gov/marc/bibliographic/bd647.html
(note that subfields $4 and $e are added in bug 37114)
Added subfields are:
- a - Named event (NR)
- c - Location of named event (R)
- d - Date of named event (NR)
- g - Miscellaneous information (R)
7. Optional: run the framework test in Administration > MARC bibliographic
framework test
--> All should be OK
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This patch updates the MARC21 default bibliographic framework
to reflect the changes brought by Update 38 (June 2024).
To test:
1. Apply patch and reset_all
2. Go to Administration > MARC bibliographic framework
3. Click Actions next to the default framework and choose MARC structure
4. Check for the changes detailed in the update
https://www.loc.gov/marc/bibliographic/bdapndxg.html
- No changes in the framework for 055, changes only affect indicator values and
field documentation
- There should be two new subfields in 082
- 0 - Authority record control number or standard number (R)
- 1 - Real World Object URI (R)
- There should be two new subfields in 083
- 0 - Authority record control number or standard number (R)
- 1 - Real World Object URI (R)
- No changes in the framework for 341, changes only affect field documentation
- Field 383 should now be titled NUMERIC DESIGNATION OF MUSICAL WORK OR
EXPRESSION
- There should be a new subfield in 580
- 5 - Institution to which field applies (NR)
- There should be two new subfields in 647
- 4 - Relationship (R)
- e - Relator term (R)
- There should be two new subfields in 648
- 4 - Relationship (R)
- e - Relator term (R)
- There should be a bew subfield in 773
- 5 - Institution to which field applies (NR)
- There should be a bew subfield in 774
- 5 - Institution to which field applies (NR)
- There should be a bew subfield in 787
- 5 - Institution to which field applies (NR)
5. Optional: run the framework test in Administration > MARC
bibliographic framework test
--> All should be OK
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
The patch updates the MARC21 authority frameworks to Update 38
To test:
1. Apply patch and reset_all
2. Go to Administration > Authority types
3. Click Actions next to the Default framework and choose MARC structure
4. Check for the changes detailed in the update
https://www.loc.gov/marc/authority/adapndxf.html
- There should be two new subfields in 082
- 0 - Authority record control number or standard number (R)
- 1 - Real World Object URI (R)
- There should be two new subfields in 083
- 0 - Authority record control number or standard number (R)
- 1 - Real World Object URI (R)
- Field 383 should be named NUMERIC DESIGNATION OF MUSICAL WORK OR EXPRESSION
5. Optional: Check other authority frameworks, they should all be changed
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
The patch updates the MARC21 authority frameworks to Update 37
To test:
1. Apply patch and reset_all
2. Go to Administration > Authority types
3. Click Actions next to the Default framework and choose MARC structure
4. Check for the changes detailed in the update
https://www.loc.gov/marc/up37authority/adapndxf.html
- Two subfields in 022 should be marked as obsolete
- l - ISSN-L [OBSOLETE]
- m - Canceled ISSN-L [OBSOLETE]
- There should be a new field 023 named CLUSTER ISSN with the following
subfields https://www.loc.gov/marc/authority/ad023.html
- 0 - Authority record control number or standard number (NR)
- 1 - Real World Object URI (R)
- 2 - Source (NR)
- 6 - Linkage (NR)
- 8 - Field link and sequence number (R)
- a - Cluster ISSN (NR)
- y - Incorrect Cluster ISSN (R)
- z - Canceled Cluster ISSN (R)
- No changes in field 371, changes only affect field documentation
- No changes in field 372, changes only affect field documentation
- No changes in field 374, changes only affect field documentation
- No changes in subfield 376$2, changes only affect subfield documentation
- There should be a new subfield in 376
- d - Other designation
5. Optional: Check other authority frameworks, they should all be changed
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
The patch updates the MARC21 authority frameworks to Update 36
To test:
1. Apply patch and reset_all
2. Go to Administration > Authority types
3. Click Actions next to the Default framework and choose MARC structure
4. Check for the changes detailed in the update
https://www.loc.gov/marc/up36authority/adapndxf.html
- There should be a new field 361 named STRUCTURED OWNERSHIP AND CUSTODIAL
HISTORY with the following subfields
https://www.loc.gov/marc/authority/ad361.html
- 0 - Authority record control number or standard number (R)
- 1 - Real World Object URI (R)
- 3 - Materials specified (NR)
- 5 - Institution to which field applies (NR)
- 6 - Linkage (NR)
- 7 - Data provenance (R)
- 8 - Field link and sequence number (R)
- a - Name (NR)
- f - Ownership and custodial history evidence term (R)
- k - Formatted date (NR)
- l - Date (NR)
- o - Type of ownership and custodial history information (R)
- s - Shelf mark of copy described (NR)
- u - Uniform Resource Identifier (R)
- x - Nonpublic note (R)
- y - Identifier of the copy described (NR)
- z - Public note (R)
- No changes to subfield 368$d, changes only affect subfield documentation
- There should be a new field 857 named ELECTRONIC ARCHIVE LOCATION AND ACCESS
with the following subfields
https://www.loc.gov/marc/authority/ad857.html
- 2 - Access method (NR)
- 3 - Materials specified (NR)
- 5 - Institution to which field applies (NR)
- 6 - Linkage (NR)
- 7 - Access status (NR)
- 8 - Field link and sequence number (R)
- b - Name of archiving agency (NR)
- c - Name of Web archive or digital archive repository (NR)
- d - Date range of archived material (NR)
- e - Data provenance (R)
- f - Archive completeness (NR)
- g - Persistent identifier (R)
- h - Non-functioning Uniform Resource Identifier (R)
- l - Standardized information governing access (R)
- m - Contact for access assistance (R)
- n - Terms governing access (R)
- q - Electronic format type (R)
- r - Standardized information governing use and reproduction (R)
- s - File size (R)
- t - Terms governing use and reproduction (R)
- u - Uniform Resource Identifier (R)
- x - Nonpublic note (R)
- y - Link text (R)
- z - Public note (R)
5. Optional: Check other authority frameworks, they should all be changed
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
prove t/db_dependent/Koha/BackgroundJob/ImportKBARTFile.t
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This patch removes the logged warning if a file parse is successful.
Test plan:
1) prove t/db_dependent/Koha/BackgroundJob/ImportKBARTFile.t
2) The output will have a logged message - 'EOF - End of data in parsing input stream'
3) Apply patch
4) Repeat step 1
5) The warning will be gone
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
To test:
1. Have a patron with some checkouts, holds, and charges that can login into the SCO module.
2. Notice the dataTable controls for searching the table, copying the table, exporting as CSV, or printing.
3. APPLY PATCH
4. Try step 2 again, this time the only dataTable control should be the search filter.
Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
To test:
1. Put some items on hold, make some bib level holds and some item
level holds. Make sure that some of the holds have different shelving
locations.
2. Build the holds queue. In KTD: perl
/kohadevbox/koha/misc/cronjobs/holds/build_holds_queue.pl
3. Notice that the shelving location is in the same column as
itemcallnumber
4. Apply patch and restart_all
5. Reload the holds queue and notice that shelving location now has it's
own column.
6. Make sure you can sort by shelving location correctly.
7. Re-run the holds queue and apply the filter for shelving location.
Make sure all your holds of that shelving location are shown.
8. While in the holds queue try usiong the 'Shelving location' filter on
the left side of the page, make sure it works right.
9. Go to Admin > Table settings. Try hiding the shelving location column
and reload the holds queue to make sure it is properly hidden.
10. Try hiding some other columns via Table settings to make sure all
columns are still properly being hid.
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This patch changes the placement of the catalog concern banner in the
OPAC. Changing the way it is added to the DOM will prevent it from
obscuring content.
To test, apply the patch and clear your browser cache if necessary.
- In the staff interface, make sure the "OpacCatalogConcerns" system
preference is enabled.
- Locate a bibliographic record and view the detail page.
- Click the "Report a concern" link in the sidebar.
- Submit your concern.
- When the concern is successfully submitted and the modal closes, the
success banner ("Your concern was successfully submitted.") should
appear below the breadcrumbs menu and above the biblio view tabs
("Normal view, "MARC view", etc.).
Sponsored-By: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This patch adds logging of unhandled exceptions that could occur. This
is happening on busy production sites right now. This is also useful for
plugin jobs that might not be 100% following the guidelines and would
benefit from this.
But as the [DO NOT PUSH] patch highlights, this is something we really
want to have on our current codebase, as a database connection drop
might make us reach that `catch` block we are adding logging to on this
patch.
To test:
1. Apply the [DO NOT PUSH] patch
2. Run:
$ ktd --shell
k$ restart_all ; tail -f /var/log/koha/kohadev/worker*.log
3. Pick a valid barcode on the staff UI
4. Use the 'Batch delete items' tool in the cataloguing section
5. Start the job for deleting the item
=> FAIL: The item got deleted, but the job marked as failed and no logs
about the reasons
6. Apply this patch and repeat 2-5
=> SUCCESS: Same scenario but there's a log with the error message
7. Sign off :-D
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Prerequisites:
- Have at least 2 budgets with funds
1. Add several budgets ("Acquisitions" > "Budget") with funds ("Actions" > "Add fund")
2. Keep one budget active (check the "Make Budget active" box in
the budget edit page)
- Have at least one file of records imported into Koha ("Cataloging" >
"Stage records for import" > "Upload a file")
To test:
1. Go to Acquisitions page.
2. Create a vendor and new basket if not already available.
3. In your vendor, "Add to the basket" > "From a staged MARC file".
4. Click "Add orders" of one of the MARC file.
5. Check the checkbox in the "Select for import" tab.
6. In the dropdown menu of the "Fund" field, verify the budget
names.
--> Ensure Koha displays all inactive budgets even if the "Show
inactive funds" checkbox is not checked.
7. Apply patch, and refresh the page (crtl + F5)
8. Verify the budgets in the "Fund" dropdown menu and test it with
the "Show inactive funds" checked and uncheked"
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Bug 12478 commented this code out, however, we do return the 'used' parameter in ES authority searches. While
we should implement the feature for both ES and Zebra as an index, we can restore this behaviour here.
To test:
1 - Search authorities on OPAC with SearchEngine syspref set to both Elasticsearch and Zebra
I just searched for 'a'
2 - Confirm results with no usage are included
3 - Test with both values of OPACShowUnusedAuthorities
4 - Apply patch
5 - Repeat searches with both engines and syspref settings
6 - Confirm unused authorities not shown in either engine when syspref is "Don't show"
7 - Conifrm unused authorities shown in both engines when syspref is "Show"
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This patch blocks the patron set as the anonymous patron from logging into the staff interface and OPAC.
To test:
1) In Administration->sys. pref, make sure AnonymousPatron is pointed to an account.
2) Visit that patron's page and set their permissions to superlibrarian ("Access to all librarian functions")
3) Ensure that you know the username and password for this patron and can log in.
4) Visit the OPAC, attempt to log-in with your anon patron.
5) Note that you can log in and nothing happens.
6) Visit the staff interface, attempt to log-in with anon patron.
7) Once again, note that you are able to log-in with no issue.
8) Apply patch and restart_all
9) Attempt to log into the OPAC and staff interface with the patron again.
10) This time, you should get an error message on both pages saying, "Error: You can't log in as the anonymous patron!"
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
prove t/db-dependent/Auth.t
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This removes the unblessing of the patron object and uses fields form the patron
To test:
Confirm tests still pass:
prove -v t/db_dependent/Holds.t t/db_dependent/Circulation.t t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t t/db_dependent/Reserves.t t/db_dependent/api/v1/holds.t
Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This routine currently takes the agerestriction value from biblioitems and an unblessed borrower object
and uses the date of birth to calculate whether the ptrons DOB is before or after the minimum value required
against the age restriction
We have a routine in the patron object to get the patron's age - we cna use this against the parsed agerestriction
value in a simple comparison and remove the need to unbless and pass the patron.
FIXME: We should move this to a biblioitems or biblio object method
To test:
0 - In Admin -> Koha to MARC mapping, set biblioitems.agerestriction to 521,a
1 - Set syspref AgeRestrictionMarker to 'Age'
2 - Edit a record and set 521$a to 'Age 14'
3 - Add an item or copy the barcode of the item on that record
4 - Attempt to checkout item to Lisa Charles in sample data, or a 15 year old patron
5 - It should checkout fine
6 - Check in item
7 - Edit patron Joyce Gaines to set age to 13 DOB:06/20/2011, or create a 13 year old patron
8 - Attempt to checkout item
9 - Item is blocked
10 - Apply patch
11 - Repeat tests, confirm no change
Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Some markup errors in the OPAC recalls history template are causing the
table to not be responsive even though the DataTable is configured to be
responsive. This patch corrects it.
Also changed:
- Removed obsolete <span class="tdlabel">, a remnant of the
way we did responsive tables before the DataTable option
- Removed very obsolete "type" attribute from the <script> tag and very
obsolete "<![CDATA" marker from the script block.
- Removed <span>s which were used in the obsolete "title-string" method
of sorting a DataTable.
To test you must have recalls enabled and have at least one circulation
rule which allows for recalls.
- Log in to the OPAC as a user who can place recalls.
- Locate an item which is elligible for recall and place the recall.
- Go to your user summary page, and click the "Recalls history" link in
the sidebar.
- Confirm that the table of recalls on that page behaves
correctly. It should adjust well to varying browser widths.
Sponsored-by: Athens County Public Libraries
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
When you do an advanced search for call number, your search uses the index
callnum, but the code that maps your search to a possible Z39.50 search
still uses the index lcn,phr which was last used 15 years ago, so it's
treated as an unknown index and mapped to the Title field in the Z39.50
search form.
Test plan:
1. Click Search in the top menu to load Advanced Search
2. Change the dropdown menu for the first input from Keyword to Call
Number, and paste TT174.3 in the input and search
3. Find the Z39.50/SRU search button in your results and click it
4. Note that your search was filled in the Title field
5. Apply patch, reset_all
6. Repeat steps 1-3, note that your search was filled in the Dewey field
7. Choose the server Library of Congress SRU and search
8. Note that even though we labelled it Dewey and you searched for an
LC call number, your results are things with that call number in 050,
the LC call number field.
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Run the agreements cypress test spec:
cypress run --spec t/cypress/integration/ERM/Agreements_spec.ts
Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Test plan:
1. Enable ERM module
2. Confirm that you can open the ERM module in the staff interface.
3. Go to the authorized values, select 'ERM_AGREEMENT_CLOSURE_REASON' and edit the 'Cancelled' authorized value by removing the description. Making this change with any of the ERM authorized values will result in an error.
4. Go back to the ERM module and notice that there is an error. 'Something went wrong: Error: Expected string - got null.'
5. Apply patch. Run yarn js:build. Repeat test plan
6. Create a new agreement. Pick status 'Closed'.
7. Open 'Closure reason'. Confirm there is an entry for 'Expired' and an empty entry below that.
Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
prove koha/t/db_dependent/api/v1/authorised_values.t
Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Test plan:
Part A: New installation
1. Start a fresh test instance
2. Set EmailFieldPrimary to "selected addresses", and do not touch
EmailFieldSelection
3. Edit a patron to ensure the following fields are set:
- Primary email
- Secondary email
- Alternate email
- Enable email notices for item checkout
4. Attempt to check an item out to that patron
--> Koha explodes!
5. Apply patch
6. reset_all
7. Repeat steps 2-4
--> Checkout succeeds!
8. Ensure test plan for bug 12802 still passes
Part B: Upgraded installation
1. Start a fresh test instance at version 23.11
2. Switch to main
3. Install database update
4. Set EmailFieldPrimary to "selected addresses", and do not touch
EmailFieldSelection
5. Edit a patron to ensure the following fields are set:
- Primary email
- Secondary email
- Alternate email
- Enable email notices for item checkout
6. Attempt to check an item out to that patron
--> Koha explodes!
7. Go back to 23.11 and reset_all
8. Switch to main and apply patch
9. Repeat steps 4-6
--> Checkout succeeds!
10. Ensure test plan for bug 12802 still passes
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This patch restores the "Remove from list" control to the batch
operations toolbar when one is looking at the contents of a list. It was
unintentionally left out of the previous patch.
The patch also corrects some button markup to ensure consisten style of
controls in the batch operations toolbar.
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This patch tries to address errors in the way features are displayed in
result lists so that controls for holds, tags, lists, etc. are shown or
hidden according to system preferences.
The patch converts the Cart/Lists dropdown to separate buttons, making
the display logic simpler and making the interface more consistent with
updates to the staff interface search results.
To test, apply the patch and rebuild the OPAC CSS.
- In the OPAC, test these pages:
- Catalog search results
- List contents
- Test with various combinations of these system preferences:
- opacbookbag
- DisplayMultiPlaceHold
- virtualshelves
- OPACHoldRequests
- TagsEnabled
- TagsInputOnList
- UseRecalls
- ArticleRequests
With each different combination of settings the right controls should
appear in the toolbar at the top (if present), and with each search
result.
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This patch makes the generic method pass any parameters it got passed to
the underlying `delete()` method.
To test:
1. Apply the unit tests patch
2. Run:
$ ktd --shell
k$ prove t/db_dependent/Koha/Objects.t
=> FAIL: Tests fail, parameters are not passed
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This patch adds a new key 'notconsidered' to the authority cache when
linking to avoid doubling when creating new authorities and wishing
to ignore thesaurus
To test:
0 - Set LinkerConsiderThesaurus to "don't"
1 - Set AutCreateAuthorities to generate
2 - Set AutLinkBiblios to Do
3 - Set CataloguingModuleRelink to Do
4 - Save a new record in Koha with the same randomized heading repeated
but from 3 different authority sources
ensure source is defined by indicators only and by field $2 once
ensure the heading is random so that no matches will be found
5 - Confirm each authority is linked to a new unique authority
6 - Apply patch, restart all
7 - Repeat 4 with a new subject heading
8 - Confirm all headings are linked to the same authority
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
In the OPAC display of titles on a list, the "Remove from list" control
needs to trigger a POST operation instead of GET. This patch
appends a form for handling single entry deletions, populating
the hidden input upon confirmation.
To test, apply the patch and create a list if necessary, adding multiple
titles to it.
- View the contents of your list.
- Each title on your list should have a "Remove from this list" link.
- Click one of these. You should see a modal confirmation, "Are you
sure you want to remove this item from the list?"
- Confirming should delete the title form the list.
- Check multiple checkboxes in the list of titles and click "Remove
from list" at the top of the list.
- You should see a modal confirmation, "Are you sure you want to
remove these items from the list?"
- Confirming should result in all checked titles being removed
from the list.
- Check one or more checkboxes and then click a single "Remove from
list" link. After confirming, you should find that only the one
title was removed from the list.
Sponsored-by: Athens County Public Libraries
Signed-off-by: Eric Garcia <cubingguy714@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Test plan:
Add some serials:
1) Add a new serial, visit:
/cgi-bin/koha/serials/subscription-add.pl
2) Put a biblionumber in the 'record' field, e.g. '112'.
Press 'next' and click 'ok' on the alert box.
3) Fill all the required fields and click 'test prediction'.
4) Fill the Subscription end date (= Expiration Date).
5) Click 'save subscription'.
6) Repeat steps 1-5 to create a second serial.
Batch edit serials:
1) Visit serials and hit the 'Search' button:
/cgi-bin/koha/serials/serials-home.pl
2) Click the 2 checkboxes for the 2 serials we created
previously and click the new link that pops up
'Edit selected serials'.
3) Click 'Save' without changing anything.
4) Go back to either of the serials, notice the value
for Expiration date is changed to TODAY
(the date of the batch edit).
Apply the patch and retest the batch editing (before
retesting, change the expiration dates of the two
serials back to the original expiration date).
Note that the expiration date now only changes if you
enter a date in the 'Expiration date' field.
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Test Plan:
1) Create 3 clubs, 1 limited to library A, 1 limited to library B and one not limited
2) Use a patron with home library A.
3) Go to the opac-user page, "Clubs" tab show 0/2 (the one from library B is not listed)
4) Browse to /cgi-bin/koha/svc/club/enroll?id=1
5) Reload that page a couple times
6) Note the patron is now enrolled in the same club multiple times
7) Delete those enrollments
8) Apply this patch
9) Restart all the things!
10) Repeat steps 2-7, note the lack of duplicate enrollments!
11) Repeat steps 2-10 for the staff interface
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
The patch updates the MARC21 authority frameworks to Update 35
To test:
1. Apply patch and reset_all
2. Go to Administration > Authority types
3. Click Actions next to the Default framework and choose MARC structure
4. Check for the changes detailed in the update
https://www.loc.gov/marc/up35authority/adapndxf.html
- There should be a new subfield in 856
- g - Persistent identifier (R)
- Subfield 856$h should be renamed Non-functioning Uniform Resource Identifier and should now be repeatable
- Subfield 856$q should now be repeatable
5. Optional: Check other authority frameworks, they should all be changed
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
The patch updates the MARC21 authority frameworks to Update 34
To test:
1. Apply patch and reset_all
2. Go to Administration > Authority types
3. Click Actions next to the Default framework and choose MARC structure
4. Check for the changes detailed in the update
https://www.loc.gov/marc/up34authority/adapndxf.html
- There should be a new subfield in 024
- 7 - Data provenance (R)
- There should be a new subfield in 034
- 7 - Data provenance (R)
- There should be a new subfield in 043
- 7 - Data provenance (R)
- There should be a new subfield in 065
- 7 - Data provenance (R)
- There should be a new subfield in 100
- 7 - Data provenance (R)
- There should be a new subfield in 110
- 7 - Data provenance (R)
- There should be a new subfield in 111
- 7 - Data provenance (R)
- There should be a new subfield in 130
- 7 - Data provenance (R)
- There should be a new subfield in 147
- 7 - Data provenance (R)
- There should be a new subfield in 148
- 7 - Data provenance (R)
- There should be a new subfield in 150
- 7 - Data provenance (R)
- There should be a new subfield in 151
- 7 - Data provenance (R)
- There should be a new subfield in 155
- 7 - Data provenance (R)
- There should be a new subfield in 162
- 7 - Data provenance (R)
- There should be a new subfield in 180
- 7 - Data provenance (R)
- There should be a new subfield in 181
- 7 - Data provenance (R)
- There should be a new subfield in 182
- 7 - Data provenance (R)
- There should be a new subfield in 185
- 7 - Data provenance (R)
- There should be a new subfield in 260
- 7 - Data provenance (R)
- There should be a new subfield in 335
- 7 - Data provenance (R)
- There should be a new subfield in 336
- 7 - Data provenance (R)
- There should be a new subfield in 348
- 7 - Data provenance (R)
- There should be a new subfield in 360
- 7 - Data provenance (R)
- There should be a new subfield in 368
- 7 - Data provenance (R)
- There should be a new subfield in 370
- 7 - Data provenance (R)
- There should be a new subfield in 371
- 7 - Data provenance (R)
- There should be a new subfield in 372
- 7 - Data provenance (R)
- There should be three new subfield in 373
- 4 - Relationship (R)
- 7 - Data provenance (R)
- i - Relationship Information (R)
- There should be a new subfield in 374
- 7 - Data provenance (R)
- There should be a new subfield in 375
- 7 - Data provenance (R)
- There should be a new subfield in 376
- 7 - Data provenance (R)
- There should be a new subfield in 377
- 7 - Data provenance (R)
- There should be a new subfield in 378
- 7 - Data provenance (R)
- There should be a new subfield in 380
- 7 - Data provenance (R)
- There should be a new subfield in 381
- 7 - Data provenance (R)
- There should be a new subfield in 382
- 7 - Data provenance (R)
- There should be a new subfield in 383
- 7 - Data provenance (R)
- There should be a new subfield in 384
- 7 - Data provenance (R)
- There should be a new subfield in 385
- 7 - Data provenance (R)
- There should be a new subfield in 386
- 7 - Data provenance (R)
- There should be a new field 387 called REPRESENTATIVE EXPRESSION CHARACTERISTICS, with the following subfields
- 0 - Authority record control number or standard number (R)
- 1 - Real World Object URI (R)
- 2 - Source of term (NR)
- 3 - Materials specified (NR)
- 6 - Linkage (NR)
- 7 - Data provenance (R)
- 8 - Field link and sequence number (R)
- a - Aspect ratio of representative expression (R)
- b - Color content of representative expression (R)
- c - Content type of representative expression (R)
- d - Date of capture of representative expression (R)
- e - Date of representative expression (R)
- f - Duration of representative expression (R)
- g - Intended audience of representative expression (R)
- h - Language of representative expression (R)
- i - Place of capture of representative expression (R)
- j - Projection of cartographic content of representative expression (R)
- k - Scale of representative expression (R)
- l - Script of representative expression (R)
- m - Sound content of representative expression (R)
- There should be a new subfield in 388
- 7 - Data provenance (R)
- There should be a new subfield in 400
- 7 - Data provenance (R)
- There should be a new subfield in 410
- 7 - Data provenance (R)
- There should be a new subfield in 411
- 7 - Data provenance (R)
- There should be a new subfield in 430
- 7 - Data provenance (R)
- There should be a new subfield in 447
- 7 - Data provenance (R)
- There should be a new subfield in 448
- 7 - Data provenance (R)
- There should be a new subfield in 450
- 7 - Data provenance (R)
- There should be a new subfield in 451
- 7 - Data provenance (R)
- There should be a new subfield in 455
- 7 - Data provenance (R)
- There should be a new subfield in 462
- 7 - Data provenance (R)
- There should be a new subfield in 480
- 7 - Data provenance (R)
- There should be a new subfield in 481
- 7 - Data provenance (R)
- There should be a new subfield in 482
- 7 - Data provenance (R)
- There should be a new subfield in 485
- 7 - Data provenance (R)
- There should be a new subfield in 500
- 7 - Data provenance (R)
- There should be a new subfield in 510
- 7 - Data provenance (R)
- There should be a new subfield in 511
- 7 - Data provenance (R)
- There should be a new subfield in 530
- 7 - Data provenance (R)
- There should be a new subfield in 547
- 7 - Data provenance (R)
- There should be a new subfield in 548
- 7 - Data provenance (R)
- There should be a new subfield in 550
- 7 - Data provenance (R)
- There should be a new subfield in 551
- 7 - Data provenance (R)
- There should be a new subfield in 555
- 7 - Data provenance (R)
- There should be a new subfield in 562
- 7 - Data provenance (R)
- There should be a new subfield in 580
- 7 - Data provenance (R)
- There should be a new subfield in 581
- 7 - Data provenance (R)
- There should be a new subfield in 582
- 7 - Data provenance (R)
- There should be a new subfield in 585
- 7 - Data provenance (R)
- There should be a new subfield in 670
- 7 - Data provenance (R)
- There should be a new subfield in 672
- 7 - Data provenance (R)
- There should be a new subfield in 675
- 7 - Data provenance (R)
- There should be a new subfield in 677
- 7 - Data provenance (R)
- There should be a new subfield in 678
- 7 - Data provenance (R)
- There should be a new subfield in 680
- 7 - Data provenance (R)
- There should be a new subfield in 700
- 7 - Data provenance (R)
- There should be a new subfield in 710
- 7 - Data provenance (R)
- There should be a new subfield in 711
- 7 - Data provenance (R)
- There should be a new subfield in 730
- 7 - Data provenance (R)
- There should be a new subfield in 747
- 7 - Data provenance (R)
- There should be a new subfield in 748
- 7 - Data provenance (R)
- There should be a new subfield in 750
- 7 - Data provenance (R)
- There should be a new subfield in 751
- 7 - Data provenance (R)
- There should be a new subfield in 755
- 7 - Data provenance (R)
- There should be a new subfield in 762
- 7 - Data provenance (R)
- There should be a new subfield in 780
- 7 - Data provenance (R)
- There should be a new subfield in 781
- 7 - Data provenance (R)
- There should be a new subfield in 782
- 7 - Data provenance (R)
- There should be a new subfield in 785
- 7 - Data provenance (R)
- There should be a new subfield in 788
- 7 - Data provenance (R)
- There should be a new subfield in 856
- e - Data provenance (R)
- These 856 subfields should be renamed
- l - Standardized information governing access (R)
- n - Terms governing access (R)
- r - Standardized information governing use and reproduction (R)
- t - Terms governing use and reproduction (R)
5. Optional: Check other authority frameworks, they should all be changed
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
The patch updates the MARC21 authority frameworks to Update 33
To test:
1. Apply patch and reset_all
2. Go to Administration > Authority types
3. Click Actions next to the Default framework and choose MARC structure
4. Check for the changes detailed in the update
https://www.loc.gov/marc/up33authority/adapndxf.html
- No changes in the frameworks for field 034, changes only affect field
documentation
- There should be two new subfields in 672
- i - Relationship information (R)
- 4 - Relationship (R)
5. Optional: Check other authority frameworks, they should all be changed
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
The patch updates the MARC21 authority frameworks to Update 32
To test:
1. Apply patch and reset_all
2. Go to Administration > Authority types
3. Click Actions next to the Default framework and choose MARC structure
4. Check for the changes detailed in the update
https://www.loc.gov/marc/up32authority/adapndxf.html
- There should be two new subfields in 022
- 0 - Authority record control number or standard number (NR)
- 1 - Real World Object URI (R)
- There should be three new subfields in 046
- 3 - Materials specified (NR)
- x - Nonpublic note (R)
- z - Public note (R)
- Subfield 082$2 should now be named Edition information
- Subfield 083$2 should now be named Edition information
5. Optional: Check other authority frameworks, they should all be changed
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
The patch updates the MARC21 authority frameworks to Update 31
To test:
1. Apply patch and reset_all
2. Go to Administration > Authority types
3. Click Actions next to the Default framework and choose MARC structure
4. Check for the changes detailed in the update
https://www.loc.gov/marc/up31authority/adapndxf.html
- There should be a new field 335 EXTENSION PLAN with the following subfields https://www.loc.gov/marc/authority/ad335.html
- 0 - Authority record control number or standard number (R)
- 1 - Real World Object URI (R)
- 2 - Source (NR)
- 3 - Materials specified (NR)
- 6 - Linkage (NR)
- 7 - Data provenance (R)
- 8 - Field link and sequence number (R)
- a - Extension plan term (NR)
- b - Extension plan code (NR)
- The following 856 subfields should be marked as obsolete
- b - Access number [OBSOLETE]
- h - Processor of Request [OBSOLETE]
- i - Instruction [OBSOLETE]
- j - Bits per second [OBSOLETE]
- k - Password [OBSOLETE]
- l - Logon [OBSOLETE]
- n - Name of location of host [OBSOLETE]
- r - Settings [OBSOLETE]
- t - Terminal emulation [OBSOLETE]
- Field 043 should now be repeatable
- There should be two new subfields in 375
- 0 - Authority record control number or standard number (R)
- 1 - Real World Object URI (R)
- There should be two new subfields in 384
- 0 - Authority record control number or standard number (R)
- 1 - Real World Object URI (R)
5. Optional: Check other authority frameworks, they should all be changed
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
The patch updates the MARC21 authority frameworks to Update 30
To test:
1. Apply patch and reset_all
2. Go to Administration > Authority types
3. Click Actions next to the Default framework and choose MARC structure
4. Check for the changes detailed in the update
https://www.loc.gov/marc/up30authority/adapndxf.html
- Field 883 should be named METADATA PROVENANCE
- Subfield 883$a should be named Creation process
- Subfield 883$d should be named Creation date
- Subfield 883$q should be named Assigning or generating agency
5. Optional: Check other authority frameworks, they should all be changed
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This patch adds a new 'ip_limit' option to Koha::Template:Plugin::Branches
To test:
1 - Set some branches in the system to have random IPs
2 - Set one branch to have your IP
To find the IP in KTD I:
Enabled ILS-DI
Set ILS-DI:AuthorizedIPs to 1.1.1.1
Visit:
http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=248&id_type=biblio
And note the unauthorized IP listed
3 - Log out, confirm all branches are listed
4 - Log in, enable StaffLoginRestrictLibraryByIP
5 - Log out, confirm branches with IPs are removed
6 - Confirm branch matching your IP is listed
7 - Choose any of the branches and login
8 - Confirm login works
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This patch adds the CRUD endpoints for stock rotation rota's.
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
