Commit graph

306 commits

Author SHA1 Message Date
Henri-Damien LAURENT
5009969845 using Warn and not print for debugging purpose
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-11 06:10:01 -06:00
Joe Atzberger (siptest
1527f93f3a Members.pm - make sure we don't return empty refs (is firstname fallback really needed?)
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-08 06:08:04 -06:00
Chris Nighswonger
c6d6f60013 More fixes for patron images
Added GetPatronImage function to Members.pm
Added code to circulation.pl, boraccount.pl, readingrec.pl, and moremember.pl to grab patron image and pass it off to the template
Corrected code in circ-menu.inc to properly display patron image.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-02-03 07:24:28 -06:00
Joe Atzberger
e660a339a8 Members.pm - BEGIN block VERSION and vars related to export.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-07 20:02:34 -06:00
Chris Cormack
f077aa6c1f Fix for bug 1730 fixing display for pay.pl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-07 01:57:50 -06:00
Joshua Ferraro
8d072519b6 synching deletedborrowers table with borrowers table
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-01-04 21:30:30 -06:00
Chris Cormack
48b4d54408 Fix for bug 1515
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-30 20:51:22 -06:00
Chris Cormack
28fe361296 Fix for bug 1666
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-27 17:21:35 -06:00
Chris Cormack
dfc5c181bc Big bugfix for bug 1631
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-26 18:40:28 -06:00
Chris Cormack
ac21232fd5 Fix for bug 1691
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-26 14:33:08 -06:00
Chris Cormack
5d0a5eb01e Fixing a problem that was causing double conversion of dates
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-20 20:51:41 -06:00
Joe Atzberger
c102b3c6f5 Members overhaul for Dates.pm - Stop double converts and disappearing expiration mods.
Allow errors displayed by memberentrygen.  Please confirm with add'l tests, feedback.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-20 19:19:00 -06:00
Joe Atzberger
0c3fb7051e Members.pm - checkuniquemember minor refactor and perldoc correction.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-20 19:11:52 -06:00
Joe Atzberger
44c792801e Members.pm - dbh->{'mysql_insertid'} still needed, despite shortcomings.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-14 10:05:04 -06:00
Joe Atzberger
afdcdab964 Members.pm - Handle bad categorycode, Dates.pm - other problems persist.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-14 10:02:45 -06:00
Paul POULAIN
e5ffa4db79 add registration fees on registration renewal if needed
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-14 09:07:27 -06:00
Paul POULAIN
6fac0001a1 Member enrolment fee fixed :
if there is an enrolment fee, create a debt on patron subscription

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-14 09:07:12 -06:00
Paul POULAIN
0f1c857d3f Changing some patron management rules (#1631)
- the guarantor is no more readonly: it can be typed manually
- useless fields in case of an institution are removed (like DoB, Firstname, gender)
- reintroducing the relashionship select, that was missing in the template (but was handled by the pl)
- moving B_phone to a more logical place (with alternate coordinate)
- reintrocing contactnote in "alt contact"
- changing the select_city behaviour : when a city is choosen, the zipcode & city are automatically filled.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-14 09:03:25 -06:00
Ryan Higgins
e4788e8a97 Add 'Staff' category_type to new dropdown, add category_type to GetMemberDetails retval
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-12 08:03:02 -06:00
Joe Atzberger
e7ea6196e6 Members.pm - respond to $debug, some formatting and reduction of duplicative code.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-04 17:37:15 -06:00
Joe Atzberger
d88ecc0751 Big LDAP changes, module test for Context.pm, still more yet to come.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-04 17:27:06 -06:00
Chris Cormack
4a373f27b0 Fix for bug 1575
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 16:15:57 -06:00
Ryan Higgins
1a91801b06 Add Staff member type. Add permissions checks for bug# 1269
and related permissions on memberentry and mods.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 15:17:50 -06:00
Ryan Higgins
85d8c91976 adding Staff Borrower to handle Bug 1269
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-12-02 15:17:14 -06:00
Joe Atzberger
6a8899390c Members.pm: 1 stupid change (whitespace) and 1 real one (comma -- changes the number of args).
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-11-17 11:00:24 -06:00
Chris Cormack
e911586f23 Changing searchmember to do an exact search on cardnumber first.
To speed up circulations

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-20 17:06:13 -05:00
Chris Cormack
b9c20fa9cf Patch from Galen Charlton, removing $Id$ $Log$ and $Revision$ from files
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 20:22:01 -05:00
Paul POULAIN
917c1ab46c fines management (bugfixes & minor improvement)
- pay.pl fixed, the librarian can see patron fines & mark them paid
- fines2.pl fixed, the script now calculate the fines correctly from the finerules :
  * itemtype / patron category if it exist
  * itemtype / default if needed
- renamed misc/fines.pl as fines-sanop.pl
- added 2 systempreferences:
  * MaxFine: the max amount a patron can be charged for an item
  * NoReturnSetLost: how many days of late before a non returned item is marked lost & the patron charged for the full cost of replacement
(those values where hardcoded in fines2.pl
- C4/Circulation/Fines.pm has been removed (unused duplicate of C4/Overdues)

Note that SANOP feature about notify levels have NOT been ported here. I think they are too specific now, and the code is poorly written
I've renammed fines.pl to fines-sanop.pl to point that it is specific.
Thus, all notify_id related features are not used by anything (and always 0)
Can be interesting to reintroduce them, but that will probably be a large work...

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-18 16:25:00 -05:00
Henri-Damien LAURENT
e6e4395553 patches for members and resultlists.
--
Henri Damien LAURENT et Paul POULAIN
Consultants indépendants
en logiciels libres et bibliothéconomie (http://www.koha-fr.org)

>From 616f0a385848b9a1fee7c76ff7b1f3be090ccb66 Mon Sep 17 00:00:00 2001
From: Henri-Damien LAURENT <henridamien@koha-fr.org>
Date: Tue, 16 Oct 2007 15:20:45 +0200
Subject: [PATCH] Bug Fixing : userid was blanked out in partial edit.
Adding some checks on branch presence for independant branches

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-17 07:05:39 -05:00
Henri-Damien LAURENT
8f67beb26d Bug Fixing : Memberentry was broken.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-15 23:54:20 -05:00
Henri-Damien LAURENT
7e35eaab09 Parenthesis mistakenly removed.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-09 19:00:32 -05:00
Henri-Damien LAURENT
8fba9e3265 Modifying ModMember so that if there were a flag parameter on page it would not write borrower flags
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-09 18:45:42 -05:00
Paul POULAIN
493e2b85c6 Adding IndependantBranches Filter + adding some ordering on member list display.
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-05 14:24:27 -05:00
Paul POULAIN
440d04e8e3 Revert "Adding IndependantBranches Filter + adding some ordering on member list display."
This reverts commit 0dee069f30f05f0d63d3b5e5047cdd3986aa373c.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-05 14:24:22 -05:00
Joshua Ferraro
a7cadab7b3 Revert "fix for bug 1468, but not sure if this is the best"
This reverts commit ae206e86ad.
2007-10-05 14:02:44 -05:00
Joshua Ferraro
ae206e86ad fix for bug 1468, but not sure if this is the best
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2007-10-05 13:30:25 -05:00
Paul POULAIN
ebb9890ccb Adding IndependantBranches Filter + adding some ordering on member list display.
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-10-03 14:58:51 -05:00
Paul POULAIN
ba569c3cfa Revert "Adding IndependantBranches Filter + adding some ordering on member list display."
This reverts commit 0dee069f30f05f0d63d3b5e5047cdd3986aa373c.

Signed-off-by: Chris Cormack <crc@liblime.com>
2007-10-03 14:58:48 -05:00
Paul POULAIN
d24f28a413 Adding IndependantBranches Filter + adding some ordering on member list display.
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-10-03 14:58:44 -05:00
Henri-Damien LAURENT
04a108482d BUG FIXING : Using LEFT JOIN in replacement of implicit inner joins. WARN NOT FULLY TESTED
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-10-03 14:58:35 -05:00
Chris Cormack
3e93b33975 Fix for bug 1454
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-10-01 22:03:27 -05:00
Chris Cormack
2154ed5cc1 Fix for 1431, checking userid is unique
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-10-01 20:40:26 -05:00
Chris Cormack
ee56e731ab Fix for bug 1436, changing to use issuedate, not timestamp for sorting issues
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-30 20:45:46 -05:00
Paul POULAIN
a400e4be59 Bug Fixing :
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-30 15:58:00 -05:00
Henri-Damien LAURENT
3f940dba8e Bug Fixing, again password was not crypted.
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-28 16:45:22 -05:00
Henri-Damien LAURENT
0b1bff5f3d Bug Fixing : crypting password before storing them to database.
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-28 16:45:16 -05:00
401dce8971 Various random noodlings: - Visual changes to circ, detail, request, and member pages. Fixed checkouts/reserves tabs on circulation.tmpl. Moved new form-layout CSS into staff-global.css and generalized it for wider use. Refined patron details sidebar for use on circulation.tmpl
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-27 16:32:52 -05:00
Henri-Damien LAURENT
0a6809af92 Bug Fixing : password were modified when patron page was edited even though unchanged
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-26 05:29:34 -05:00
Paul POULAIN
0b78706879 FIX for 1391, search on 1 digit cardnumber
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-24 15:29:09 -05:00
Paul POULAIN
7902f78491 Som reorganization and recommiting memberentrygen.tmpl
Signed-off-by: Chris Cormack <crc@liblime.com>
2007-09-12 20:54:44 -05:00
toins
a3135df486 really minor change : POD fixing, indentation & some compilation warn removing. 2007-07-26 15:18:46 +00:00
toins
6ec59c52b9 using 'our' instead of 'use vars' which is deprecated.
removing some compilation warns.
2007-07-12 15:22:09 +00:00
rangi
73e6be1340 Fix for bug 1295 adding a borrower with the same cardnumber 2007-07-08 23:07:31 +00:00
rangi
c75b84fac7 Fix for bug 1365 2007-07-02 00:38:17 +00:00
toins
38f7d2148a removing warn compilation. 2007-06-13 13:03:34 +00:00
tipaul
35fae6a9e4 bugfixes for acquisition module 2007-05-04 13:59:53 +00:00
hdl
a171035f1d GetBorrowerIssues is deleted from C4::Circulation
Use GetPendingIssues from C4::Members instead.
2007-04-25 14:07:34 +00:00
hdl
fb1e47e435 Deleting GetMembersFromSurname
Using SearchMember instead.
2007-04-25 13:38:00 +00:00
tipaul
fb143b71ba BIG COMMIT : cleaning of Reserves.pm. See detail on koha-devel 2007-04-24 16:10:36 +00:00
hdl
b642e687d2 Still Code Cleaning.
Abiding by Name Convention.
Using Members wherever it should be used.
Borrower is only used for borrower Categories.
+ GetBorrowersWhoHaveNeverBorrowed
and lists like that.
2007-04-24 15:41:27 +00:00
hdl
7d8e8b0bf6 BugFixing :
GetBorrowerAcctRecord now takes a date.
2007-04-24 14:17:24 +00:00
hdl
d4430fd6d6 Continuing Code Cleaning. 2007-04-24 13:57:13 +00:00
tipaul
9f42b8ad49 renaming currenttransfers to transferstoreceive 2007-04-23 15:21:17 +00:00
tipaul
3ddec89262 moving Reserves2.pm to Reserves.pm 2007-04-23 14:08:47 +00:00
hdl
0b66bd800d Code Cleaning Members.
- checkaccount and getborraccountno => GetBorrowerAcctRecord

Many changes in names,
some changes in function signature.
Will be detailed in a mail to kohadevel.
2007-04-23 13:10:07 +00:00
tipaul
7bd99ef365 removing all useless %env / $env 2007-04-18 17:00:14 +00:00
tipaul
c596d55374 HUGE COMMIT : code cleaning circulation.
some stuff to do, i'll write a mail on koha-devel NOW !
2007-04-04 16:46:22 +00:00
tipaul
2ffd5b7228 rel_3_0 moved to HEAD 2007-03-09 14:28:54 +00:00
tgarip1957
ab45e7aaab Bug fixing and complete removal of Date::Manip 2006-11-06 21:01:43 +00:00
tgarip1957
c5627d23ec A new Date.pm to use for all date calculations. Mysql date calculations removed from Circ2.pm, all modules free of DateManip, a new get_today function to call in allscripts, and some bug cleaning in authorities.pm 2006-10-20 01:20:56 +00:00
tgarip1957
57d5b19dca Fixes bug with MARChtml2xml in Biblio.pm
synching with dev_week
2006-09-11 17:09:59 +00:00
tgarip1957
7e52a5665c Clean up before final commits 2006-09-06 16:21:03 +00:00
tgarip1957
0b5c3f94e7 New XML API
Event & Net::Z3950 dependency removed
HTML::Template::Pro dependency added
2006-09-01 22:16:00 +00:00
tgarip1957
0451359813 New set of routines for HEAD.
Uses a complete new ZEBRA Indexing.
ZEBRA is now XML and comprises of a KOHA meta record. Explanatory notes will be on koha-devel
Fixes UTF8 problems
Fixes bug with authorities
SQL database major changes.
Separate biblioograaphic and holdings records. Biblioitems table depreceated
etc. etc.
Wait for explanatory document on koha-devel
2006-08-25 21:07:08 +00:00
toins
8a5c2d3b36 Deleted a duplicated function. 2006-07-27 13:48:02 +00:00
toins
1c68ea8229 new function & subs renamed. 2006-07-21 10:15:57 +00:00
toins
c7edb82220 2 functions added : GetBorrowersFromSurname & GetBranchCodeFromBorrowers 2006-07-12 07:49:06 +00:00
toins
cc9524a875 Head & rel_2_2 merged 2006-07-04 14:36:51 +00:00
btoumi
9a2677f401 Members.pm ,memberentry(A)(P)(C).tmpl,memberentry.pl:bug fix with wrong field name
memberentry.pl:translate  title in english ;=) (i hope is ok)
buf fix with bad condition
2006-06-22 10:07:49 +00:00
btoumi
963c7de328 Members.pm:add a field in sql request (sub getborrowercategory) to return category_type
memberentry.pl:modify call to getborrowercategory
moremember.tmpl:modify condition to display "add child" option (only for adult)
moremember.pl:add condition,call to getborrowercategory , change variable name
2006-06-15 14:05:23 +00:00
btoumi
8a469ed85d members.pm: add field fax in getguarantordata function
memberentry.pl : move getgarantordata use before step1
and add default_city value from guarantor  data (if exist)
2006-06-12 15:12:11 +00:00
btoumi
5bdce695b9 Members.pm: modify getborrowercategory function to return dateofbirthrequired and upperagelimit
memberentryC and P  : add error message ERROR_age_limitations
memberentry.pl : replace sql request  by function getborrowercategory for return upperagelimit and dateofbirthrequired
moremember.pl: modify call to function getborrowercategory
2006-06-12 13:00:40 +00:00
btoumi
d7526b7044 members.js :translate javascript message
moremember.tmpl:change wrong url
Members.pm: change wrong field name in sql request(sub newmember)
memberentryA.tmpl : change wrong field name
memberentry.pl:change test condition (checkuniquemember)
2006-06-07 14:55:36 +00:00
bob_lyon
58249a9807 merging Katipo changes...
site specific chage for issues data being stored in two tables
2006-06-06 23:36:37 +00:00
btoumi
a98d60ada1 bug fix :syntax error in variable name 2006-06-06 15:54:36 +00:00
btoumi
88d93b4563 modifiy sql syntax for modmember and newmember
add right field in sql syntax
move get_age function from memberentry.pl
2006-06-02 15:48:10 +00:00
btoumi
e67590c3aa move function get_age :
memberentry.pl => Members.pm
add forgotten field in sql request
2006-06-02 14:51:43 +00:00
rangi
25ee635911 Modifying members is now working, well mostly anyway. 2006-06-01 23:18:57 +00:00
rangi
55cb9efaa4 Fixing a lot of formatting
Now working on fixing modmember so it works with the new members system
2006-06-01 22:49:08 +00:00
rangi
31c21007cc add_member_orgs, to add borrowers to organisations (other borrowers) 2006-05-23 03:18:39 +00:00
rangi
30412ec5cf Code to display list of organisations/institutions if memberofinstitution is set to yes 2006-05-23 00:46:32 +00:00
rangi
36d317eeb7 Adding version string, checked merge from dev_week, not needed 2006-05-22 23:25:37 +00:00
tipaul
97182dceb2 improvements from SAN Ouest Provence :
* introducing a category_type into categories. It can be A (adult), C (children), P (Professionnal), I (institution/organisation).
* each category_type has it's own forms to create members.
* the borrowers table has been heavily modified (many fields changed), to get something more logic & readable
* reintroducing guarantor/guanrantee system that is now independant from hardcoded C/A for categories
* updating templates to fit template rules

(see mail feb, 17 on koha-devel "new features for borrowers" for more details)
2006-04-14 09:31:24 +00:00
kados
36b3d24bcd sync with head. 2006-04-03 23:45:00 +00:00
tipaul
b38997925f big commit, still breaking things...
* synch with rel_2_2. Probably the last non manual synch, as rel_2_2 should not be modified deeply.
* code cleaning (cleaning warnings from perl -w) continued
2005-10-26 09:11:02 +00:00
tipaul
e82eca42c9 see mail on koha-devel : code cleaning on Search.pm + normalizing API + use of biblionumber everywhere (instead of bn, biblio, ...) 2005-09-22 10:01:45 +00:00
tipaul
830ba65a20 moving NewBorrowerNumber sub to Members package 2005-09-05 19:27:21 +00:00
tipaul
b897d55f23 moving findguarantor sub to Members package 2005-09-05 19:26:08 +00:00
tipaul
6b0ee5525b synch'ing 2.2 and head 2005-06-20 14:10:00 +00:00
tipaul
369527637b synch'ing 2.2 and head 2005-05-04 15:39:07 +00:00
tipaul
2cc3037397 adding getmember sub to the package (the Search.pm/borrdata should be removed, it has nothing to do here) 2004-10-04 20:19:08 +00:00
tipaul
1edf59efe5 road to a better member management code.
Useful for LDAP integration
2004-09-02 16:27:09 +00:00
tipaul
56825e415f modularizing (with Members.pm) members management
(beginning of...)
2004-08-30 13:48:58 +00:00
tipaul
3635a596cf synch'ing 2.0.0 branch and head 2004-02-11 08:35:31 +00:00
slef
928d76058a DBI call fix for bug 662 2003-12-15 16:18:45 +00:00
acli
7d7deb7b36 Moved the cardnumber generation logic out of memberentry.pl; new module
C4::Members created to hold this logic

Fixed syntax error in newimember.pl
Make newimember.pl use the cardnumber generation logic (bug 206)
Updated newimember.pl to use get_template_and_user
Other minor mods to newimember.pl; new tab size noted
2003-02-10 07:14:16 +00:00