Tree:
efd9ed271c
16.05.x
16.11.x
17.05.x
17.11.x
18.05.x
18.11.x
19.05.x
19.11.x
20.05.x
20.11.x
21.05.x
21.11.x
22.05.x
22.11.x
23.05.x
23.11.x
3.0.x
3.10.x
3.12.x
3.14.x
3.16.x
3.18.x
3.2.x
3.20.x
3.22.x
3.4.x
3.6.x
3.6.x-maint/testing
3.6.x-rmaint/testing
3.8.x
MM-OPAC/theme_dep
main
new/bootstrap-opac
new_12478_elasticsearch
3.0.5_rc1
3.02.02
R_1-1-1RC1
R_1-2-1
R_1-2-1RC6
R_1-2-2
R_1-2-2RC4
R_1-2-3
R_1-2-3RC11
R_1-2-3RC12
R_1-2-3RC13
R_1-2-3RC14
R_1-2-3RC15
R_1-2-3RC16
R_1-2-3RC17
R_1-2-3RC18
R_1-2-3RC20
R_1-2-3RC21
R_1-2-3RC22
R_1-2-3RC23
R_1-2-3RC25
R_1-2-3RC26
R_1-2-3RC5
R_1-3-0
R_1-3-1
R_1-3-2
R_1-3-3
R_1-9-0
R_1-9-1
R_1-9-2
R_1-9-3
R_2-0-0
R_2-0-0RC1
R_2-0-0RC2
R_2-0-0RC3
R_2-0-0RC4
R_2-0-0pre1
R_2-0-0pre2
R_2-0-0pre3
R_2-0-0pre4
R_2-0-0pre5
R_2-1
R_2-2-6
R_2-2-6RC2
R_2-2-6RC3
R_2-2-6RC4
R_2-2-7
R_2-2-9
R_2-3-0
R_2-4
R_2_2_4
R_2_2_5
R_2_2_6_RC
dev_week
html_template_pro
rel_3_0_5
v16.05.00
v16.05.00-beta
v16.05.01
v16.05.02
v16.05.02-01
v16.05.03
v16.05.04
v16.05.05
v16.05.05-01
v16.05.06
v16.05.06-01
v16.05.07
v16.05.08
v16.05.09
v16.05.10
v16.05.11
v16.05.12
v16.05.13
v16.05.14
v16.05.15
v16.05.16
v16.05.17
v16.05.18
v16.05.19
v16.11.00
v16.11.01
v16.11.02
v16.11.03
v16.11.04
v16.11.05
v16.11.06
v16.11.07
v16.11.08
v16.11.09
v16.11.10
v16.11.11
v16.11.11-1
v16.11.12
v16.11.13
v16.11.14
v16.11.15
v16.11.16
v17.05.00
v17.05.01
v17.05.02
v17.05.03
v17.05.04
v17.05.05
v17.05.06
v17.05.07
v17.05.08
v17.05.09
v17.05.10
v17.05.11
v17.05.12
v17.05.13
v17.05.14
v17.11.00
v17.11.01
v17.11.02
v17.11.03
v17.11.04
v17.11.05
v17.11.06
v17.11.07
v17.11.08
v17.11.09
v17.11.10
v17.11.11
v17.11.12
v17.11.13
v17.11.14
v17.11.15
v17.11.16
v17.11.17
v17.11.18
v18.05.00
v18.05.00-rc1
v18.05.00-rc2
v18.05.01
v18.05.02
v18.05.03
v18.05.04
v18.05.05
v18.05.06
v18.05.07
v18.05.08
v18.05.09
v18.05.10
v18.05.11
v18.05.12
v18.05.13
v18.05.14
v18.11.00
v18.11.01
v18.11.02
v18.11.03
v18.11.04
v18.11.05
v18.11.06
v18.11.07
v18.11.08
v18.11.09
v18.11.10
v18.11.11
v18.11.12
v18.11.13
v18.11.14
v18.11.15
v18.11.16
v19.05.00
v19.05.01
v19.05.02
v19.05.03
v19.05.04
v19.05.05
v19.05.05-1
v19.05.06
v19.05.07
v19.05.08
v19.05.09
v19.05.10
v19.05.11
v19.05.12
v19.05.13
v19.05.14
v19.05.15
v19.05.16
v19.05.17
v19.11.00
v19.11.01
v19.11.02
v19.11.03
v19.11.04
v19.11.05
v19.11.06
v19.11.07
v19.11.08
v19.11.09
v19.11.10
v19.11.11
v19.11.12
v19.11.13
v19.11.14
v19.11.15
v19.11.16
v19.11.17
v19.11.18
v19.11.18-2
v19.11.19
v19.11.20
v19.11.21
v19.11.22
v19.11.23
v19.11.24
v19.11.25
v19.11.26
v19.11.27
v19.11.28
v19.11.29
v20.05.00
v20.05.01
v20.05.02
v20.05.03
v20.05.04
v20.05.05
v20.05.06
v20.05.07
v20.05.08
v20.05.09
v20.05.10
v20.05.11
v20.05.12
v20.05.13
v20.05.14
v20.05.15
v20.05.16
v20.05.17
v20.05.18
v20.11.00
v20.11.01
v20.11.02
v20.11.03
v20.11.04
v20.11.05
v20.11.06
v20.11.07
v20.11.08
v20.11.09
v20.11.10
v20.11.11
v20.11.12
v20.11.13
v20.11.15
v20.11.16
v20.11.17
v20.11.18
v20.11.19
v21.05.00
v21.05.01
v21.05.02
v21.05.03
v21.05.04
v21.05.05
v21.05.06
v21.05.07
v21.05.08
v21.05.09
v21.05.10
v21.05.11
v21.05.12
v21.05.13
v21.05.14
v21.05.15
v21.05.16
v21.05.17
v21.05.18
v21.05.19
v21.05.20
v21.05.21
v21.05.22
v21.05.22-1
v21.05.22-2
v21.11.00
v21.11.01
v21.11.02
v21.11.03
v21.11.04
v21.11.04-1
v21.11.05
v21.11.06
v21.11.07
v21.11.08
v21.11.09
v21.11.10
v21.11.11
v21.11.12
v21.11.13
v21.11.14
v21.11.15
v21.11.16
v21.11.17
v21.11.18
v21.11.19
v21.11.20
v21.11.21
v21.11.21-1
v21.11.22
v21.11.23
v21.11.24
v21.11.25
v21.11.26
v22.05.00
v22.05.01
v22.05.02
v22.05.03
v22.05.03-1
v22.05.04
v22.05.05
v22.05.05-01
v22.05.06
v22.05.07
v22.05.08
v22.05.09
v22.05.10
v22.05.11
v22.05.12
v22.05.13
v22.05.14
v22.05.15
v22.05.16
v22.05.17
v22.05.18
v22.05.19
v22.05.20
v22.05.20-2
v22.11.00
v22.11.01
v22.11.02
v22.11.03
v22.11.04
v22.11.05
v22.11.05-1
v22.11.06
v22.11.07
v22.11.08
v22.11.09
v22.11.10
v22.11.11
v22.11.12
v22.11.13
v22.11.14
v22.11.15
v22.11.15-1
v22.11.16
v22.11.16-1
v23.05.00
v23.05.01
v23.05.02
v23.05.03
v23.05.04
v23.05.05
v23.05.06
v23.05.07
v23.05.08
v23.05.09
v23.05.09-01
v23.05.10
v23.05.10-02
v23.11.00
v23.11.01
v23.11.02
v23.11.03
v23.11.04
v23.11.04-4
v3.0.6
v3.00.00
v3.00.00-alpha
v3.00.00-beta
v3.00.00-beta2
v3.00.00-stableRC1
v3.00.01-stable
v3.00.01-stable_update
v3.00.01.005
v3.00.02-final
v3.00.02-stable
v3.00.03
v3.00.04
v3.00.04_final
v3.00.04_fixed
v3.00.05
v3.00.06
v3.02.00
v3.02.00-alpha
v3.02.00-alpha2
v3.02.00-beta
v3.02.00-rc
v3.02.01
v3.02.03
v3.02.04
v3.02.05
v3.02.06
v3.02.07
v3.02.08
v3.02.09
v3.02.10
v3.02.11
v3.04.00
v3.04.01
v3.04.02
v3.04.03
v3.04.04
v3.04.05
v3.04.06
v3.04.07
v3.04.08
v3.06.00
v3.06.01
v3.06.02
v3.06.03
v3.06.04
v3.06.05
v3.06.06
v3.06.07
v3.06.08
v3.06.09
v3.06.10
v3.06.10.000
v3.06.11
v3.06.12.000
v3.08.00
v3.08.01
v3.08.02
v3.08.03
v3.08.04
v3.08.05
v3.08.06
v3.08.07
v3.08.08
v3.08.09
v3.08.10
v3.08.11
v3.08.12
v3.08.13
v3.08.14
v3.08.15
v3.08.16
v3.08.17
v3.08.18
v3.08.19
v3.08.20
v3.08.21
v3.08.22
v3.08.23
v3.08.24
v3.10.00
v3.10.01
v3.10.02
v3.10.03
v3.10.04
v3.10.05
v3.10.06
v3.10.07
v3.10.08
v3.10.09
v3.10.10
v3.10.11
v3.10.12
v3.10.13
v3.12.00
v3.12.00-alpha
v3.12.00-alpha2
v3.12.00-beta1
v3.12.00-beta3
v3.12.00-rc1
v3.12.00-rc2
v3.12.00-rc3
v3.12.01
v3.12.02
v3.12.03
v3.12.04
v3.12.05
v3.12.06
v3.12.07
v3.12.08
v3.12.09
v3.12.10
v3.12.11
v3.12.12
v3.12.13
v3.12.14
v3.12.15
v3.14.00
v3.14.00-alpha1
v3.14.00-alpha2
v3.14.00-beta
v3.14.01
v3.14.02
v3.14.03
v3.14.04
v3.14.05
v3.14.06
v3.14.07
v3.14.08
v3.14.09
v3.14.10
v3.14.11
v3.14.12
v3.14.13
v3.14.14
v3.14.15
v3.14.16
v3.14.17
v3.16.00
v3.16.00-beta
v3.16.00-pkg
v3.16.00-rc
v3.16.01
v3.16.02
v3.16.03
v3.16.04
v3.16.05
v3.16.05.1
v3.16.06
v3.16.07
v3.16.08
v3.16.09
v3.16.10
v3.16.11
v3.16.12
v3.16.13
v3.16.14
v3.16.15
v3.18.00
v3.18.00-beta
v3.18.01
v3.18.02
v3.18.03
v3.18.04
v3.18.05
v3.18.05.1
v3.18.06
v3.18.06-3
v3.18.07
v3.18.08
v3.18.09
v3.18.10
v3.18.11
v3.18.12
v3.18.13
v3.20.00
v3.20.00-beta
v3.20.01
v3.20.02
v3.20.03
v3.20.04
v3.20.05
v3.20.06
v3.20.07
v3.20.07.1
v3.20.08
v3.20.09
v3.20.10
v3.20.11
v3.20.12
v3.20.13
v3.20.14
v3.20.15
v3.22.00
v3.22.00-beta
v3.22.01
v3.22.02
v3.22.03
v3.22.04
v3.22.05
v3.22.06
v3.22.07
v3.22.08
v3.22.09
v3.22.10
v3.22.11
v3.22.12
v3.22.13
v3.22.14
v3.22.15
v3.22.16
v3.22.17
v3.22.18
v3.22.19
v3.22.20
v3.22.21
v3.8.16
version-1-2-0
version-1-2-1
${ noResults }
279 Commits (efd9ed271c703ef104b9ff8da1a06a98b9f4d0bb)
Author | SHA1 | Message | Date |
---|---|---|---|
Martin Renvoize |
efd9ed271c
|
Bug 31095: Remove GetDebarments from members/moremember.pl
This patch removes the use of GetDebarments from members/moremember.pl and replaces template references with patrons.restrictions and the new includes introduced in the prior patch Test plan 1. Confirm that the 'Restrictions (x)' tab still appears on the patron details page. 2. Confirm that the 'Restrictions (x)' tab count is correct 3. Confirm that the 'Restrictions (x)' tab table functions 4. Confirm that the 'Restrictions (x)' tab 'Add manual restriction' form works as expected Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> |
2 years ago |
Owen Leonard |
d4aceae4af
|
Bug 32086: Consistent classes for primary buttons: Patrons
This patch makes changes the button markup in patron module templates so that all submit buttons and any buttons that should should be styled as primary buttons have the Bootstrap class "btn btn-primary." To test, apply the patch and view patron module pages to confirm that everything looks correct. In most cases there are no visible changes. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> |
2 years ago |
Owen Leonard |
dd75682f77
|
Bug 30487: Convert checkout and patron details page tabs to Bootstrap
This patch updates the checkout and patron details pages, updating jQueryUI tabs to Bootstrap tabs. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Go to Circulation -> Check out and load a patron record for checkout. Ideally the patron record should have a variet of data associated with it: - Checkouts - Relative's checkouts (if patron is a guarantor or guarantee to another patron with checkouts) - Holds - Article requests - Claims - Restrictions - Clubs On the patron's checkout page, test the various tabs corresponding to the features listed above. Having data to display in those tabs helps confirm that any table functionality triggered by the tab activation is working correctly. The checkouts tab should work correctly whether you have "Always show checkouts immediately" checked or not. Test that you can pre-select any tab by appending its anchor to the URL, e.g.: /cgi-bin/koha/circ/circulation.pl?borrowernumber=123#reserves Perform the same checks on the patron details page. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> |
2 years ago |
Julian Maurice |
0e0604132e
|
Bug 30952: Remove messages box on patron detail page when empty
Issue #28 Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> |
2 years ago |
Julian Maurice |
874e4d4708
|
Bug 30952: Add card layout to patron messages in moremember.pl
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> |
2 years ago |
Julian Maurice |
cd21757826
|
Bug 30952: Undo change to Home breadcrumb for remaining templates
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> |
2 years ago |
Solène Desvaux |
f43558f539
|
Bug 30952: Staff interface redesign (header)
What this patch does: - change the navigation bar style - change the breadcrumbs style - change the "last borrower" link style - move the search bar inside the navigation bar - move the help link to the same row as the breadcrumbs Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> |
2 years ago |
Lucas Gass |
7386962012
|
Bug 10950: (follow-up) Change display of pronoun fields
Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> |
2 years ago |
Lucas Gass |
3d57e7d584
|
Bug 10950: Display pronouns field
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> |
2 years ago |
Lucas Gass |
a93d6fa853
|
Bug 31486: Redirect to proper page after message deletion
To test: 1. Go to a patron account and create some messages 2. Try deleting some from both the patron details page and the patron checkout page. 3. Notice that is you are on the patron checkout page and delete a message you are then redirected to the patron details page. 4. Apply patch 5. Try deleting messages from both pages and confirm you are redirected back to that same page and the message is properly deleted. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> |
2 years ago |
Shi Yao Wang |
db42939885
|
Bug 30922: Make the "Relative's checkouts" table configurable by the table settings
Adds "relatives-issues-table" in table settings. Test plan: 1- Apply the patch 2- Check out an item to a patron with a guarantor 3- Go to the guarantor's "details" and "check out" page > relatives' checkouts and look at the different columns (you should see collection and location) 4- Go to admin > table settings > patron > moremember > relatives-issues-table or admin > table settings > circulation > circulation > relatives-issues-table to hide some columns (e.g. collection and location) and click save 5- Do step 3 again and notice some columns (e.g. collection and location) are hidden 6- Also notice the "Columns" and "Export" buttons that should work as intended Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> |
2 years ago |
jeremy breuillard |
e56c0dead6
|
Bug 29983: Display the pretend claim column in overdue.tt
This patch displays the column "Return claims" from the page "moremember.pl" to the page "overdues.pl". Rebase on master. Test plan: 1) Use a patron with at least 1 item who should be checked out soon 2) Home > Patron > Patron details for [name] 3) Click on the 'Checkout' button down the page to show the full table and notice the "Return Claims" column 4) Now go to Home > Circulation > Overdues 5) Find the patron who has to check out and have a look at the table 6) Apply patch and repeat 4) and 5) -> the "Return Claim" column is now displayed on the table Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> |
2 years ago |
Jonathan Druart |
9309dedb53
|
Bug 30578: Remove circ/ysearch.pl in favor of the /patrons REST API route
This patch removes the circ/ysearch.pl script used by the jQuery autocomplete widget. We can now use the /api/v1/patrons endpoint to retrieve the patrons and generate the patron result list. Prior to this patch the different occurrences were defining the style and the list of patron's attributes to display for each option (name, date of birth, age, address, etc.). Now they are all displaying the same information. To acchieve this we had to: * Make js-date-format.inc and js-patron-get-age.inc available from js_includes.inc and so available from everywhere, which is certainly a good move. We could discuss why this code is in include file instead of JS files however. * Remove the .ajaxSetup call in tags-review.js to reduce its scope: an underscore parameter was added to the REST API query (?) A better solution would have been to extend the existing widget (https://learn.jquery.com/jquery-ui/widget-factory/extending-widgets/) but I didn't manage to do it, and I feel like there is a bug in jQuery autocomplete. The "source" was not taken into account. We could think about replacing the jQuery autocomplete with something else, but that's outside the scope of this bug. Test plan: Search for patrons and confirm the autocomplete works and that the "select" action works as before (either a redirect or select the patrons) on the different views: * Place a hold * Search for tags (form on the left) * In the header, "Check out" and "Search patrons" * Add instructors to course reserves * View logs (the "librarian" input) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> |
2 years ago |
Martin Renvoize |
66b35f505b
|
Bug 28854: Enable claims return view when BundleLostValue is set
This patch adds the alternation of BundleLostValue to enable the return claims functionality when Bundles are enbled. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> |
2 years ago |
Martin Renvoize |
d5608b8ff0
|
Bug 21978: Add support for middle name
This patch adds the new 'Middle name' field to the patron record. To test: 1) Apply patches 2) Update database, restart all and clear the browser cache 3) Load a patron in the staff module 4) Confirm you can see and edit the new 'Middle name' field 5) Confirm the new middle name data displays on patron details 6) Confirm the new middle name data displays on patron search results 7) Confirm the new middle name data displays everywhere patron names are displayed. 8) Confirm the new middle name data displays on the OPAC 9) Confirm the 'Middle name' field appears in the OPAC borrower modification screens 10) Edit sysprefs `BorrowerMandatoryFields`, `BorrowerUnwantedFields`, `SelfModificationBorrowerUnwantedField`, `PatronSelfModificationMandatoryField`, `PatronSelfRegistrationBorrowerMandatoryField` and `PatronSelfRegistrationBorrowerUnwantedField` to confirm you can make the new field required or hidden. 11) Verify that DefaultPatronSearchFields contains the new field if you already had 'firstname' in the field list 12) Enable PatronAutoComplete system preference 13) Type patrons surname into checkout or patron search but don't hit return 14) Confirm the patrons middle name is displayed in the preview 15) Go to tools > patron lists and attempt to add a patron to a list 16) Patrons middle name should appear in the autocomplete here too Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> |
2 years ago |
Victor Grousset |
7758a0248e
|
Bug 30733: Simplify translatable strings
And a few minor fixes when they where causing issues for translatability. And rephrased a string about password reset to have it identical to other strings with the same meaning. Simplified via wrapping strings with <span> to split to huge concatenated strings with a lot of %s everywhere. == Test plan == This patch needs mainly proof reading. Still it's possible to do some basic testing to demonstrate that adding a <span> in an IF doesn't break anything. Pick in one of the 110 modified templates a string that you know how to display. Otherwise: 1. acquisitions => vendor => basket => add to basket => search "from existing record" => add order 2. Cancel the order 3. You see without issue "Bibliographic record will not be deleted" 4. administration => Patron categories 5. Try to delete a used and unused category 6. You see as expected Category XXXX is in use. Deletion not possible! and Confirm deletion of category XXXX Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> |
2 years ago |
Katrin Fischer |
3f784ea613
|
Bug 30891: (QA follow-up) Add check to patron details page
Adds a similar check to the patron details shown when selecting the details tab in the patron account in the staff interface. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> |
2 years ago |
Martin Renvoize | 4a2d659b7d |
Bug 30695: (QA follow-up) Catch moremember.tt too
This patch does the same treatment for moremember.tt where the same summary block is includes. We also correct the tab order to be a little more consistent too. We should really move this to an include and refer to it from both templates instead of this copy/paste code.. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> |
2 years ago |
Jonathan Druart | 1473575317 |
Bug 30603: Fix other occurrences
Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> |
2 years ago |
Nick Clemens | 6ae0b3c76c |
Bug 29926: Add ability for superlibrarian to view/edit password expiration
To test: 1 - Sign in as a superlibrarian 2 - Find a patron account with no password expiration set 3 - View member detials 4 - note expiration says 'Never' 5 - Edit patron 6 - Set patron expiration 7- Save 8 - View details, confirm password expiration shows correctly 9 - Sign in as non-superlibrarian 10 - Confirm you don't see expirationdate on details page 11 - Edit patron and confirm password expiration does not show 12 - Edit HTML and confirm you epxiration date not saved <input type="text" name="password_expiration_date" value="2052-05-02"> Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> |
2 years ago |
Jonathan Druart | 6f222544c4 |
Bug 29648: Fix occurrences of GetColumns
We could add the configuration to these tables as well, but let go first but the others (read: feeling lazy right now). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> |
2 years ago |
Owen Leonard | 24cb4f71f4 |
Bug 29155: (follow-up) Work around change to jQueryUI tab API
For some reason, with the combination of jQuery 3.6.0 and jQueryUI 1.13.1, the way to access the current active tab's link has changed. Previously the tab activate event would provide information about the link as "ui.newTab.context." It appears that "context" is no longer available. This patch updates the two instances in Koha where this process is broken. To test, apply the patch and check out to a patron with holds on their account. - When the checkout page loads, confirm that each tab loads its contents correctly when clicked. - Check that the correct tab is activated when you append the tab link to the page url, e.g. /cgi-bin/koha/circ/circulation.pl?borrowernumber=XXX#reldebarments ...which should select the "Restrictions" tab for you. You may need to try this in a new tab or shift-reload to get the browser to look for the hash. - Perform the same tests on the patron details page. Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> |
2 years ago |
Owen Leonard | 9a8653f29b |
Bug 27631: (follow-up) Various corrections
This patch addresses issues found during QA: - Double headings (patron details page) - Inconsistent heading position (check out, patron accounting) - Missing headings when there is no data (Library EANs, Item search fields, MARC modification templates). - Typo: Z19.50 => Z39.50 - Reword "Classification sources" heading: "Classification configuration" Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> |
2 years ago |
Wainui Witika-Park | 26e38d4990 |
Bug 27631: labels and members folders
Changed each of the pages in the labels and members folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. The hierarchy of heading tags may be broken in many pages, but this will be dealt with in an additional bug. To test: 1) Go to the Staff Client 2) Apply patch 3) Go to each of the pages in the labels and members folders and check that they have an obvious and descriptive heading 4) Ensure that the heading in the page is <h1> Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> |
3 years ago |
Jonathan Druart | e08629b68b |
Bug 29602: Surround strings with span tag
To be nicer with translators. Update the PO files for whichever languages will show how this is useful. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> |
2 years ago |
Owen Leonard | de2d8ba3e4 |
Bug 30011: Update links to jQueryUI assets, remove datepicker references, etc.
This patch updates templates to include the new version of jQueryUI. It removes some references to the now unused datepicker widget as well as the jQuery timepicker addon. Some minor JavaScript and style updates to fix issues resulting from the upgrade. To test, apply the patch and update the CSS in the staff interface AND in the OPAC (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). IN THE OPAC: - The OPAC only uses the tabs jQueryUI widget. - View pages where tabs are used: Bibliographic details, user summary, advanced search. IN THE STAFF INTERFACE: - The staff interface uses four jQueryUI widgets: accordion, autocomplete, sortable, and tabs - Test the accordion widget on two pages: Administration -> Table settings and Patrons -> Patrons requesting modifications. - Test autocomplete (requires PatronAutoComplete to be enabled) on various pages. For example: - From the "Check out" tab in the header search box. - From the "Search patrons" tab in the header search box, e.g. from the main Patrons page. - Place hold -> Search patrons. - Tools -> Patron lists -> Add patrons to list -> Patron search. - Test sortable: - Administration -> System preferences -> Language. - With more than one language installed you should be able to drag to re-order the enabled languages. Confirm that your change is saved successfully. - Administration -> MARC bibliographic framework -> MARC structure -> Edit subfields on a tag with multiple subfields. You should be able to drag to re-order the tabs at the top of the subfield constraints edit page. Confirm that your changes are saved successfully. - Cataloging -> New record. Test that you can re-order subfields under a tag with multiple subfields and that your changes are saved. - Tabs: View various pages with tabs: Check out, bibliographic details, basic MARC editor. They're everywhere. Also confirm that the removal of the leftover datepicker doesn't affect pages which use the calendar include: Test various pages which use Flatpickr, e.g. check out, renew, reports, etc. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> |
2 years ago |
Jonathan Druart | ce1ab5a386 |
Bug 30093: Rename patron-search.inc to patron-search-header.inc
We will use 'patron-search.inc' in the next patch Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> |
2 years ago |
Mark Tompsett | 370a10c512 |
Bug 6815: Capture member photo via webcam
This patch builds on a patch by Mark Tompsett, adding the option to take a patron's picture using the computer's webcam. The photo can then be saved to the patron's account. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Administration -> System preferences and enable the 'patronimages' preference. - View a patron record. In the sidebar, hover your mouse over the blank patron image. Click the "Edit" button which appears. - A modal window should appear with two sections, "Upload patron photo" and "Take patron photo." - If your computer has a webcam, your browser should ask permission to access it. Grant access. - You should see the view of your webcam shown under the "Take photo" button. - Click the "Take photo" button. The captured photo should be shown in place of the live video from the webcam. - You should now see three buttons: "Retake photo," "Download photo," and "Upload photo." - Clicking "Retake photo" should hide those buttons and return you to a live video view. - Clicking "Download" should make your browser download the image. - Clicking "Upload" should cause the page to redirect back to the patron detail page where you should see the new patron image displayed in the sidebar. - Trigger the modal again and click the "cancel" button. The modal should disappear and camera access should stop. - If your computer has no webcam the modal should appear correctly but there should be a banner at the bottom indicating that a camera is not available. - Try the test again but this time deny your browser access to the webcam. You may need to reset the camera permissions in your browser's settings. When the modal appears you should see a message saying access to the camera is denied. - The patron image edit modal should be available on all pages which show the patron image in the sidebar: Check out, Batch check out, Details, Accounting, Routing lists, Circulation history, Holds history, Modification log, Notices, Statistics, Files, Purchase suggestions, Discharges, Housebound, and ILL requests history. - Test adding an image to a patron record using the "Upload photo" option. It should still work correctly. - If the patron has an image attached, the "Upload photo" section should have a "Delete" button. Test that it works correctly. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> |
4 years ago |
Aleisha Amohia | db095c3a7b |
Bug 19532: Recalls on intranet
See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls == TEST PLAN FOR RECALLS == ADMINISTRATION 1. Apply all patches 2. Run database updates, update schema files and confirm everything applies cleanly 3. Run tests and confirm everything passes: t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Recalls.t t/db_dependent/Stats.t t/db_dependent/Circulation/CalcFine.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Patron.t t/db_dependent/XSLT.t t/db_dependent/Search.t t/db_dependent/Holds.t t/db_dependent/Circulation/transferbook.t t/db_dependent/Circulation.t 4. Go to Administration -> system preferences. Find the UseRecalls system preference. It should be DISABLED. Confirm RecallsMaxPickUpDelay is set to 7 by default. 5. Go to Administration -> circulation rules. Confirm there are no recalls circulation rules showing. 6. Test a few circulation flows: checking out, placing a reserve, checking in, fulfilling a reserve, etc. Confirm everything works as normal. 7. Go to Administration -> system preferences. Enable the UseRecalls system preference. 8. Go to Administration -> circulation rules. Set the following rules: Recalls allowed (count) = 0 Recalls per record (count) = 0 On shelf recalls allowed ( If any unavailable / If all unavailable ) = If any unavailable Recall due date interval (days) = 3 Recall overdue fine amount = (something different to your normal fine amount) Recall pickup period (days) = 1 Throughout your testing, try with different combinations of these rules and itemtype / branchcode / categorycode. Also try with null values. Keep the circulation rules open in another tab so you can refer to and update these easily. You should also have at least one other tab open for the staff client, and a third tab open for the OPAC, for ease of testing. 9. Go to your account -> More -> Set permissions. Confirm the recalls permission is checked. 10. Set up a test user with OPAC login details (Borrower A). This could also be your own user, as long as you have OPAC login access. 11. Set up a test record (Biblio A) with at least two items (Item A and Item B) of the same item type (or an item type with the same recall circ rules). PLACING A RECALL 12. Log in to the OPAC as Borrower A. Do a catalogue search with a term that will return multiple results, including Biblio A. 13. Click on Biblio A. 14. Notice there is a 'Place recall' button on the sidebar menu. Click this button. There will be a message saying that there are no items to recall - this is because all items are available. 15. Check out Item A to another borrower (Borrower B). 16. Refresh the 'Place recall' page. You will still NOT be able to place a recall - this is because Recalls allowed = 0 and Recalls per record = 0. 17. Edit the circulation rules to have the following values: Recalls allowed (count) = 1 Recalls per record (count) = 1 18. Refresh the 'Place recall' page. You will now see the form to place a recall. BIBLIO-LEVEL RECALL, NO TRANSFER 19. Place a biblio-level recall. Pickup location: Branch A, the set branch when you are logged into the staff client Recall not needed after (expiration date): whatever you want Select 'recall next available item' Click confirm 20. Confirm the recall is placed successfully. Confirm that the new due date displayed is correctly calculated to be today's date, plus 3 days (taken from the 'recall due date interval' circ rule) 21. In the staff client, look at Borrower B's account, and go to their Notices tab. Confirm they have received a 'Notification to return recalled item' notice. 22. Look at Borrower B's checkouts table. Notice the due date for their checkout has been adjusted, and there is now a note to say that the item was recalled and the due date adjusted. 23. Log in to the OPAC as Borrower B and go to your summary tab. Notice there is a note under their checkout to say the item had been recalled. 24. Log out of the OPAC and log back in as Borrower A. 25. Go to your summary tab. Confirm there is a Recalls tab with a count of 1. 26. Cancel the recall using the button. Confirm it cancels and the Recalls tab disappears. 27. Do a catalogue search with a term that will return multiple results, including Biblio A. 28. When the results load, notice there is a 'Place recall' button next to the 'Place hold' button. Click this 'Place recall' button. 29. Notice you are redirected straight to the form to place a recall. 30. Place a biblio-level recall again, following the steps in Step 19. 31. Go to your recalls history tab. Notice your first cancelled recall shows here. 32. Cancel the recall you just created, using the button. Confirm it cancels and you are redirected to your summary tab. 33. In the staff client, enable the UseCourseReserves system preference. 34. Go to the main menu, click Course Reserves. 35. Add a new course. (You may also have to define an authorised value for DEPARTMENT.) 36. Add Item A as a reserve to this course. 37. View Course Reserves in the OPAC. Click the course you just created. 38. Notice the reserve has a Recall button underneath it's 'Checked out' status. Click this button. 39. Place a biblio-level recall again, following the steps in Step 19. 40. Click the 'Place recall' link in the breadcrumbs. 41. Notice there is a message saying that you have reached the max number of recalls on this record. This is because Recalls allowed = 1 and Recalls per record = 1. 42. Edit the circulation rules to have the following values: Recalls allowed (count) = 10 Recalls per record (count) = 5 43. Refresh the 'Place recall' page. You will now see the form to place a recall. 44. Create another test record (Biblio B) with at least one item (Item C). 45. Find this record on the OPAC and place a biblio-level recall again, following the steps in Step 19. 46. In the staff client, go to Circulation -> Old recalls. You should be able to see your two cancelled recalls. 47. Go to Circulation -> Recalls queue. Your current recalls should show here. 48. Use the 'Select all' checkbox to select all recalls. 49. Cancel the recalls using the 'Cancel selected recalls' button. 50. Go to the OPAC and place a biblio-level recall on Biblio A again, following the steps in Step 19. 51. In the staff client, check in Item A, which should still be checked out to Borrower B. 52. A box should pop-up asking you to confirm Borrower A's recall. Click ignore. 53. Click the link to go view Biblio A's details in the catalogue. 54. Click the recalls tab. Notice Borrower A's recall is displayed, and shows it is still Requested (has not been confirmed waiting). 55. Check in Item A again. This time, confirm the recall as waiting using the "Confirm recall" button. 56. Go to Borrower A's Notices tab. Confirm there is a notice "Recalled item awaiting pickup". 57. Go to Borrower A's checkouts. Notice there is a recalls tab. Confirm the recall is showing as "Ready for pickup". 58. Click the 'Actions' dropdown. Click the "Revert waiting" button. The page should show a message that the waiting status has been reverted, without reloading. 59. This time, check in Item B. The recall confirmation box should show again, because this a biblio-level recall that any recallable item under Biblio A can fill. Click the "Print slip and confirm" button. 60. Check the slip that is generated. Confirm it contains Borrower A's correct details, and the details of the recall are correct. 61. Go to Circulation -> Recalls awaiting pickup. Confirm the recall is now waiting and shows in this list. (You could also try this with Item B having a different item type to Item A, and circ rules not allowing Item B's item type to have recalls. When checking in Item A, it should not trigger the recall box). 62. Go to Borrower A's checkouts. Check out Item B. 63. Confirm the checkout is successful and the recall is removed from the Recalls tab. 64. Go to Circulation -> Old recalls. The fulfilled recall should show. 65. Check in Item B. BIBLIO-LEVEL RECALL, TRANSFER REQUIRED 66. Check out Item A to Borrower B. 67. Log in to the OPAC as Borrower A. 68. Find Biblio A and place a biblio-level recall. Pickup location: Branch B, a different branch from your logged in branch. This recall will require a transfer. Recall not needed after (expiration date): whatever you want Select 'recall next available item' Click confirm 69. In the staff client, check in Item A at Branch A. Notice the box that pops up shows that a transfer is required. 70. Click "confirm recall and transfer" and confirm the transfer. 71. Go to your account and click the Recalls tab. 72. Confirm the recall status now shows the item is in transit to Branch B. 73. In the drop-down top-right of your window, select 'Set library'. 74. Set your library to Branch B. 75. Go to Circulation -> Transfers to receive. Notice that the recall is showing here. 76. Click 'Cancel transfer'. 77. Go to Circulation -> Recalls queue 78. Confirm the recall status has been reverted to Requested. 79. Set your library back to Branch A. 80. Check in Item A and trigger the transfer. 81. Set your library back to Branch B. 82. Check in Item A at Branch B. 83. When the 'Recall found' box pops up, click Ignore. 84. Go to Circulation -> Recalls to pull. The recall should show here, with a button to "Cancel recall and return to: Branch A" 85. Click the button to cancel the recall. 86. Repeat Steps 66-70. 87. Check in Item A at Branch B. Confirm the recall as waiting. 88. Check out Item A to Borrower A to fulfill the recall. 89. Set your library back to Branch A and check in Item A. ITEM-LEVEL RECALL, NO TRANSFER 90. Go to Administration -> circulation rules. Set the following rules: On shelf recalls allowed ( If any unavailable / If all unavailable ) = If all unavailable 91. Check out Item A to Borrower B. 92. Log in to the OPAC as Borrower A and go to Biblio A. 93. Click the 'Place recall' button. Confirm there is a message that there are no items to recall. This is because On shelf recalls allowed = If all unavailable, and there is still one item (Item B) available. 94. In the staff client, edit Item B to have a withdrawn, item lost or not for loan status. 95. Refresh the 'Place recall' page. Confirm you can now see the form to place a recall. 96. Place an item-level recall. Pickup location: Branch A. Recall not needed after (expiration date): whatever you want Select 'recall a specific item' Item B will not be selectable, and Item A should be selected by default. Click confirm 97. In the staff client, edit Item B and remove the lost or missing status. 98. Check in Item B. Confirm the recall box does not pop up, because it cannot fill the item-level recall. 99. Check in Item A. Confirm the recall as waiting. 100. Go to Circulation -> Recalls awaiting pickup 101. Expire the recall. Confirm it expires as expected. ITEM-LEVEL RECALL, TRANSFER REQUIRED 102. Repeat steps 91 to 95. 103. Place an item-level recall. Pickup location: Branch B, we will require a transfer. Recall not needed after (expiration date): whatever you want Select 'recall a specific item' Item B will not be selectable, and Item A should be selected by default. Click confirm 104. In the staff client, check in Item A. Confirm the recall and trigger the transfer. 105. Set your library to Branch B and check in Item A. 106. Confirm the recall as waiting. 107. Check out Item A to Borrower A and fulfill the recall. 108. Set your library back to Branch A and check in Item A. CRONJOBS: EXPIRING RECALL 109. Check out Item A to Borrower B. 110. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 111. In your terminal, enter mysql and edit the expiration date of your recall to be before today UPDATE recalls SET expirationdate = NOW()-2 WHERE recall_id = X; 112. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 113. Go to Borrower A's account and go to the Recalls history tab 114. Confirm the recall has been expired because the current date surpassed the specified expiration date 115. Check out Item A to Borrower B. 116. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 117. In the staff client, check in Item A and confirm the recall as waiting. 118. In your terminal, enter mysql and edit the waiting date of your recall to be before today UPDATE recalls SET waitingdate = NOW() - interval 5 day WHERE recall_id = X; 119. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 120. Go to Borrower A's account and go to the Recalls history tab 121. Confirm the recall has been expired because the recall had been waiting for more days than the Recall pickup period 122. Go to Administration -> circulation rules. Set the following rules: Recall pickup period (days) = 0 123. Set the RecallsMaxPickUpDelay system preference = 1. 124. Check out Item A to Borrower B. 125. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 126. In the staff client, check in Item A and confirm the recall as waiting. 127. In your terminal, enter mysql and edit the waiting date of your recall to be before today UPDATE recalls SET waitingdate = NOW()-2 WHERE recall_id = X; 128. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 129. Go to Borrower A's account and go to the Recalls history tab 130. Confirm the recall has been expired because the recall had been waiting for more days than the RecallsMaxPickUpDelay syspref CRONJOBS: OVERDUE RECALL 131. Check out Item A to Borrower B 132. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 133. In your terminal, enter mysql and edit the due date of the checkout to Borrower B to be before today UPDATE issues SET date_due = NOW()-2 WHERE issue_id = X; 134. Run the overdue cronjob from within your shell perl misc/cronjobs/recall/overdue_recalls.pl 135. Go to Circulation -> Overdue recalls 136. Confirm your recall is showing here now as the recall has been marked Overdue CIRCULATION 137. Check in Item A. 138. When the recall box pops up, click Ignore. 139. Check out Item A to Borrower B. You should see a yellow confirmation box, saying that another borrower has recalled the item you are trying to check out. 140. Click "No don't check out" and confirm the item isn't checked out and the recall remains. 141. Repeat Step 139. 142. Click "Yes check out" and confirm the item is checked out and the recall remains. 143. When Borrower B's checkout table loads, confirm that you cannot renew or check in the item from the Checkouts table because there is a 'Recalled' link which takes you to the recalls tab for that biblio. 144. Repeat Steps 137-139. 145. Select "Cancel recall" and click "Yes check out" and confirm the item is checked out and the recall has been cancelled. 146. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 147. Check in Item A. Confirm the recall as waiting. 148. Check out Item A to Borrower B. You should see a yellow confirmation box, saying that that another borrower has recalled the item that you are trying to check out. 149. Select "Revert waiting status" and click "Yes check out" and confirm the item is checked out and the recall status has reverted to requested. OTHER 150. In your terminal, enter mysql and edit the due date of the checkout to Borrower B to be before today UPDATE issues SET date_due = NOW()-2 WHERE issue_id = X; 151. Go to Borrower A's recalls and click the Actions dropdown. 152. Click "Mark as overdue" and confirm the recall is marked as overdue manually. 153. Go to Tools -> Log Viewer. Check only the Recalls module, and leave all other parameters, and click Submit. 154. Confirm all of the recalls actions that have been made are correctly logged. Note: recalls messaging preferences are introduced in Bug 23781. The recall feature is fully documented at: https://wiki.koha-community.org/wiki/Catalyst_IT_Recalls Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> |
4 years ago |
Lari Taskula | a925cb8ba4 |
Bug 30081: Add item type column to holds table
Add new column item type to holds table in patron's details and check out views. Some libraries will find this information useful for distinguishing inter library holds from normal holds. To test: 1. Apply patch 2. Place a hold and confirm it 3. Go to cgi-bin/koha/circ/circulation.pl?borrowernumber=1 with borrowernumber being the id of your patron 4. Click "1 Hold(s)" tab 5. Observe new column "Item type" 6. Confirm the item type is correct 7. Go to moremember.pl?borrowernumber=1 with borrowernumber being the id of your patron 8. Repeat steps 4-6 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> |
2 years ago |
Martin Renvoize | 1f746a585e |
Bug 29519: Allow resolution of claims return at checkin
Add a 'Resolve' button in the alert dialogue that is displayed when a lost item with a return claim is checked in. The button will trigger the usual resolution modal allowing the user to pick their resolution. This patch splits the resolution modal out of checkouts.js and checkouts-table.inc so it can be used outside of the checkouts table. We then reload it, optionally based upon the presence of the claims preference, where needed. This has the added benefit that it saves a little bit of page load data in cases where the feature is not enabled. Test plan 1. As we alter the file locations of the resolution handling code we need to test that normal claims functionality continue to work as expected. 2. Test the new functoinality by checking in an item that has been claimed as returned (but not yet resolved). The dialogue box should now contain a 'resolve' button next to each claimant and clicking upon it should trigger the resolution modal where the librarian can subsequently pick the resolution and submit it. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> |
2 years ago |
The Minh Luong | 327be4a704 |
Bug 28576: Update the maximum size of an image.
This patch modifies the maximum size of a patron's image, from 500KB to 2MB. Also, in Home/Patrons/anyPatron, when you try to add an image to a patron, you can now see the supported file types AND the maximum size. The following places are affected by this patch: - Home/Patrons/anyPatron - Home/Tools/Upload patron images - Home/Tools/Patron card creator/Images To test: 1)Search for any patron and go to his page. 2)Hover over the image area on the left and click on the "Add" button. 3)Notice that the message above the choose file button only specifies file types without the maximum size. 4)Add an image bigger than 500KB. 5)Nothing happens. (This is because the maximum size is 5KB) 6)Apply the patch. 7)Repeat steps from 1 to 3. 8)Notice that the message now includes the maximum size. 9)Add an image bigger than 500KB, but smaller than 2MB. 10)The image is succesfully uploaded. 11)Add an image bigger than 2MB. 12)Nothing happens. (The maximum size is now 2MB) 13)Repeat the steps 9 to 12 in "Home/Tools/Upload patron images" and "Home/Tools/Patron card creator/Images". 14)Notice that the maximum size is updated. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> |
2 years ago |
Salman Ali | 55c8bf114e |
Bug 28576: Add patron image in patron detail section does not specify image size limit
When you try to add an image to a patron in Home/Patrons/anyPatron, it only states the file types that are supported but not the maximum size. If you try to add an image that is bigger than 500 kb, nothing happens and the reason is not presented. This is not the case with the 2 other places where we can add patron images in which they give warnings: Home/Tools/Upload patron images Home/Tools/Patron card creator/Images For now, i simply added the size limit to the file supported message. To test: 1)Search for any patron and go to his page 2)Hover over the image area on the left and click on add 3)Notice the message above the choose file button only specifies file types not size. 4)Add an image bigger than 500 kb 5)Nothing happens 6)Apply patch 7)Repeat steps from 1 to 3 8)Notice the message now includes the maximum size Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> |
3 years ago |
Tomás Cohen Arazi | db0ebb3ab5 |
Bug 29844: Simplify Koha::Clubs->get_enrollable
This patch removes the wantarray use in Koha::Clubs->get_enrollable and adjusts the callers. Also, reference to some unused params in Koha::Patron clubs-related methods are removed as well. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> |
2 years ago |
Jonathan Druart | 093cffe7c1 |
Bug 29735: Remove flatpickr init from categories.js and holds.js
Same as bug 29394, we want the flatpickr instanciations be done at the same place, from calendar.inc. That way they will all behave identically. Test plan: Edit a patron category and confirm that the "until date" calendar has the "yesterday" and "today" dates disabled Place a hold on an item, go to the patron detail page, click the "holds" tab, suspend. That should trigger a modal that will display a calendar with "yesterday" and "today" dates disabled Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> |
2 years ago |
Owen Leonard | c9263fe32e |
Bug 29289: 'Show fines to guarantor' should have its own id on patron detail page
This patch adds an id attribute to the list item containing the "Show fines to guarantor" information on the patron detail page in the staff interface. This makes it consistent with the markup for the similar "Show checkouts to guarantor" list item. To test, apply the patch and view a patron's details in the staff client. Inspect the source to confirm that the "Show fines to guarantor" line has an id, "patron-privacy_guarantor_fines". Alternatively, add this to the IntranetUserCSS system preference: #patron-privacy_guarantor_fines { background-color: pink; } The line on the patron details page should be highlighted in pink. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> |
3 years ago |
Tomás Cohen Arazi | fab3f92cd0 |
Bug 28377: Use the API to suspend/resume holds
This patch makes the patron page (detail and circulation) use the API to suspend/resume holds on the holds tab. It previously used the old svc/ scripts we plan to replace. To test 1. Have a patron with some holds 2. Play with suspending/resuming holds. Include the indefinite suspension. => SUCCESS: Everything works as usual 3. Apply this patch 4. Repeat 2 => SUCCESS: Nothing changed, a soft breeze surprises you 5. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> |
3 years ago |
Jonathan Druart | bcfd3849a9 |
Bug 29394: Remove flatpickr instantiations from most of the tt files
We must reduce the instantiations as much as possible to take advantages of the default values and specific behaviours we have defined in calendar.inc This patch is suggesting to have a .flatpickr class and using the data attributes: - flatpickr-futuredate - flatpickr-pastdate - flatpickr-enable-time - flatpickr-on-close-focus Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
3 years ago |
Nick Clemens | e1622fdf6f |
Bug 29227: Patron messaging preferences digest show as editable but are not
On moremember.pl we load the messaging preferences for display only, we do not need to load the JS for editing the preferences To test: 0 - Enable EnhancedMessagingPreferences 1 - Load the detais tab for a member 2 - Note the digest column in messaging preferences is clickable 3 - Apply patch 4 - Reload, it is not clickable 5 - Confirm editing the patron (or their messaging prefs) works as expected Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
3 years ago |
Tomás Cohen Arazi | 02db36b95c |
Bug 29083: Update article requests-related Koha::Patron methods to use relationships
This patch makes Koha::Patron->article_requests use the underlying DBIC relationship and _new_from_dbic instead of a plain search. It also refactors 'article_requests_current' and 'article_requests_finished' to use ->article_requests, as well as the new methods introduced by bug 29082 for filtering. No behavior change should take place. To test: 1. Apply the unit tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Patron.t \ t/db_dependent/ArticleRequests.t => SUCCESS: Tests pass! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Bug 29083: Unit tests This patch adds missing tests for Koha::Patron->article_requests and moves (and extends) tests for 'article_requests_current' and 'article_requests_finished' that were originally in ArticleRequests.t into Koha/Patron.t as we now do. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/ArticleRequests.t \ t/db_dependent/Koha/Patron.t => SUCCESS: Tests pass! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Bug 29083: (QA follow-up) Remove unused param Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Bug 29083: Fix OPAC listing of article requests This patch makes the OPAC template reuse a precalculated value for the active article requests for the patron (and its count). The original code relied on the methods returning a list, which is not the case for _new_from_dbic until bug 28883 is pushed. This patch fixes that. Note: there was an odd behavior when ArticleRequests was enabled but no active article requests were present: the tab wasn't rendered but the 'empty table' with the 'You have no article requests currently.' message was displayed below the Checkouts tab. I'm not sure that was caused by this patches, or other. Fixed on this patch. To test: 1. In the OPAC, go to 'your summary' => FAIL: Things don't show for article requests 2. Add some article requests and repeat 1 => FAIL: Something's wrong there 3. Apply this patch and repeat 1 => Yes! Things show correctly! 4. Cancel all your article requests => SUCCESS: Things render as they should 5. Re-enter the 'your summary' page (to force re-rendering) => SUCCESS: Things render correctly for empty article requests 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Bug 29083: Remove article_requests_finished and article_requests_current This patch removes those methods that are not really needed. Templates are adjusted to use the expected combination of ->article_requests->filter_by_current. To test: 1. Apply this patch 2. Visit a patron with article requests => SUCCESS: All works 3. Run: $ kshell k$ prove t/db_dependent/Koha/Patron.t => SUCCESS: Tests pass, less tests. 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
3 years ago |
Owen Leonard | e5f1ada249 |
Bug 28937: Use Flatpickr on circulation and patron pages
This patch replaces the use of jQueryUI's datepicker on circulation and patron-related pages. The patch modifies Flatpickr's default configuration (in calendar.inc) so that it has the following features: - A Flatpickr input with a "futuredate" class will require that the selected date be after today. - The Flatpickr input field will be wrapped in a container to facilitate better CSS styling. - Generic handling of paired date fields is enabled using ".flatpickrfrom" and ".flatpickrto" field classes. This mimics the same feature we have for jQueryUI datepickers using ".datepickerfrom" and ".datepickerto". This patch also removes an unused function which was repeated in three templates: validate1. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Circulation and check out to a patron. - Open the Restrictions tab and click "Add manual restriction." - In the "Expiration" field, test that the Flatpickr widget works correctly and limits to dates after today. - Enable the SpecifyDueDate preference if necessary. - Test the behavior of the SpecifyDueDate controls: Setting a date, clearing a date, session persistence. - Enable the SuspendHoldsIntranet system preference if necessary. - Check out to a patron with existing holds. - Open the Holds tab and click the "Suspend" button for one of the holds. - In the modal window which appears, check that the Flatpickr widget works correctly and limits to dates after today. - At the bottom of the table of holds, test that the "Suspend all holds" Flatpickr works correctly and limits to dates after today. - Perform this same test from the patron details page. - Enable the BatchCheckouts system preference if necessary. - Open a patron record and click "Batch check out" in the left-hand sidebar menu. - Test that the "Hard due date" Flatpickr works correctly as a date and time picker. - Go to Circulation -> Overdues. - Test that the date due filters in the sidebar work correctly and are linked, e.g. the "to" field cannot be before the "from" field. - Perform the same test here: Circulation -> Holds to pull; and here: Circulation -> Hold ratios. - Enable the HouseboundModule system preference if necessary. - Check out to or view details of a patron. - Click "Housebound" in the sidebar menu. - Save delivery day and frequency settings for that patron. - Click "Add a new delivery." - Test that the "Date" Flatpickr widget works correctly. - Go to Patrons -> A patron record -> Edit. - Test that Flatpickr widgets work on the following fields: - Date of birth - Registration date & Expiration date (linked). - Patron restrictions -> Add manual restriction -> Expiration. - View a bibliographic record and start the process of placing a hold. - After selecting a patron, test the "Hold starts on" and "Hold expires on" date fields. The fields should be linked and each should limit to future dates. - Confirm that the dates are saved correctly when you submit the hold. - Locate a bibliographic record with multiple holds and view the holds. - In the table of holds, test each date field: Date, expiration, and suspend-until. - Test that Flatpickr's static "formatDate" method is working correctly: - Locate a bibliographic record's item so that there is text in both the "Public note" and "Non-public note" field. - Check that item out to a patron. - After the page reloads the public and non-public notes should be shown under the checkout title highlighted in red. - Check for references to a "validate1" function. There should be none. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
3 years ago |
Owen Leonard | 13ad7c7ea0 |
Bug 28438: Capitalization: Various corrections
This patch makes capitalization corrections to many templates in the OPAC and staff interface. A exhaustive test plan would be huge, so I recommend examining the patch to confirm that it contains correct case changes. If you want to make it easier to examine changes you can try: https://github.com/so-fancy/diff-so-fancy Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
3 years ago |
Tomás Cohen Arazi | 9ec1bd1a10 |
Bug 28261: Add visual feedback on overridden pickup locations on patron's page
This patch makes the patron pages in the staff interface use the API and Select2 to render the pickup locations list. This has the effect of adding visual feedback on those pickup locations that need an override, based on the current configuration options. All the checks are done in the GET /holds/:hold_id/pickup_locations route, so this is a fairly trivial change. To test: 1. Have a couple holds for a patron, some overrriden, some not 2. Visit the patrons' detail page, holds tab. => SUCCESS: You see the holds, pickup location has a dropdown 3. Repeat in the circulation tab for the patron => SUCCESS: You see the holds, pickup location has a dropdown 4. Apply this patch 5. Repeat 2 and 3 => SUCCESS: Same behavior as before, but the dropdown is rendered with Select2 and has a search feature. Overridden pickup locations have an icon telling so 6. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
3 years ago |
Owen Leonard | dffb3fede8 |
Bug 27873: Improve message consistency: checkout and patron detail pages
This patch creates a new include for showing circulation and patron-related messages on both the checkout page and the patron detail page. This allows the two pages to be consistent with each other. The patch also makes some minor CSS adjustments, including the addition of an SVG to replace an old GIF, arrow-bullet.gif. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - View both the checkout and patron details page for patrons in the staff interface, confirming that the information is displayed in the same way, including: - Pending modifications - Pending expiration - Expired - Address in doubt - Card lost - Restricted (indefinite and with expiration) - Outstanding overdues - Outstanding return claims - Patron age incorrect for their category - Outstanding charges - Account credit - Waiting holds (at logged-in library or other library) - Circulation note (from borrowers.borrowernotes) - Messages (added at logged-in library or other library) EDIT: Fixed merge error. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
3 years ago |
Maryse Simard | b23ecb5882 |
Bug 11879: (follow up) Some fixes and code cleanup
- Display the value in the patron detail page - Adds support for BorrowerUnwantedField (staff) - Removes unecessary code in opac/opac-memberentry.pl Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Bin Wen | 975c48fb4a |
Bug 11879: Add a new field to patron record: main contact method
This patch adds the "Main Contact Method" field in the borrower modification form. This field is useful for reporting purposes, or to know which contact method to use first when trying to contact a borrower. Test plan: 0) Apply patch 1) updatedatabase.pl 2) In the staff client, edit a patron's contact info. There should be a new dropdown select to choose the main contact method 3) In the opac page, edit the personal details.There should be a new dropdown select to choose the main contact method. 4) Save the form. It should work. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Owen Leonard | 20450829eb |
Bug 26838: Improve styling of checkin message
This patch makes some changes to the style and use of the "problem" class in the staff interface: - Remove the background color - Remove the extra line height Some changes to the template: - Remove the problem class from the checkin message. The checkin message configuration determines whether the dialog is an alert or a message-style dialog. - Add Font Awesome icons to the "problem" messages in patron details and serials collection. This is to help emphasize the message for users who might have difficulty seeing the color difference. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Administration -> Item types and configure a checkin message for an item type: Add a message and select "Message" as the checkin message type. - Check in an item with that item type and confirm that you see the checkin message. It should be displayed in a message-style dialog without any additional styling. - Change the item type configuration to use "Alert" as the checkin message type. Confirm that the correct style is shown in this case as well. - Locate a patron with a NULL value in borrowers.password. View the detail page for that patron. - Under the "Library use" heading, the "Password" line should contain a link with the text "Undefined," preceded by a red-colored Font Awesome icon. - In Serials, locate a subscription which is expired. - View the details for the subscription, and then open "serial collection" from the sidebar menu. - On the serial collection page there should be a cell in the subscription summary table showing the message "Subscription expired" preceded by a red-colored Font Awesome icon. Signed-off-by: Salman Ali <salman.ali@inLibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
4 years ago |
Joonas Kylmälä | 1c0bf00f9d |
Bug 28490: Revert "Bug 26995: Remove one remaining occurrence in moremember"
This reverts commit
|
3 years ago |
Jonathan Druart | c3b50e9e97 |
Bug 26995: Remove one remaining occurrence in moremember
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
3 years ago |
Wainui Witika-Park | 1701149e90 |
Bug 26703: members folder
Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the members folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
3 years ago |