Commit graph

464 commits

Author SHA1 Message Date
tipaul
27edbcc574 fixing typo in Biblio.pm POD 2003-05-20 16:22:44 +00:00
tipaul
d8551b19c2 * PARTIAL fix for #322 => gives strange results imho
* removing unused subs
* indenting with tabs
* adding monthly report (stats.pl?time=month)
2003-05-19 16:20:51 +00:00
tipaul
fffb89aef4 fixing strange bug when cardnumber not set and borrower does not exists : sometimes finded value anyway ! 2003-05-19 14:55:32 +00:00
wolfpac444
9f32a8adf0 Bug fixes. 2003-05-19 13:59:12 +00:00
tipaul
7a95c1d809 support for subtitles, additional authors, subject.
This supports is only for MARC <-> OLD-DB link. It worked previously, but values entered as MARC were not reported to OLD-DB, neither values entered as OLD-DB were reported to MARC.
Note that some OLD-DB subs are strange (dummy ?) see OLDmodsubject, OLDmodsubtitle, OLDmodaddiauthor in C4/Biblio.pm
For example it seems impossible to have more that 1 addi author and 1 subtitle. In MARC it's not the case. So, if you enter more than one, I'm afraid only the LAST will be stored.
2003-05-19 13:45:18 +00:00
wolfpac444
5169e23b54 Fixed theme/language templating in intranet. 2003-05-13 05:10:07 +00:00
wolfpac444
0499df0045 Fixed bug #405 2003-05-08 14:12:29 +00:00
wolfpac444
8b4a044bb5 Changed the scripts to use format_date 2003-05-08 13:19:39 +00:00
wolfpac444
00fef22485 Added "noissuescharge" parameter 2003-05-08 12:48:23 +00:00
tipaul
368d9107a2 moving loggedinuser => loggedinusername in includes and Auth.pm :
The $loggedinuser in Koha is the CODE of the logged user (result of get_user_and_template subroutine).
BTW, in get_user_and_template subroutine, the TMPL_VAR loggedinuser is replaced by the NAME of the user.
This is troubleshooting.
so, I replace the name by the "loggedinusername" template variable.
If you want to add the username somewhere, just add <TMPL_VAR name="loggedinusername"> in the template.

Fixes bug #401
2003-05-05 15:00:53 +00:00
tipaul
1a218daf74 fix : when a book is taken and marked "not returned yet", it's now marked returned and issue done. 2003-05-05 14:14:28 +00:00
wolfpac444
b65bd46a6b *** empty log message *** 2003-05-05 11:51:20 +00:00
tipaul
fa5d7968a2 missing " 2003-05-05 10:11:34 +00:00
tipaul
3c4012d4de fix for 191, code reindenting & some query improvment 2003-05-05 09:41:03 +00:00
tipaul
7608bee7cf removing warnings 2003-05-02 13:07:14 +00:00
tipaul
5a54bfc1ae *** empty log message *** 2003-05-02 13:05:08 +00:00
rangi
76b467c900 renewbook is used by renewscript.pl
Making sure characters are escaped in the database insert
2003-04-30 22:55:54 +00:00
tipaul
22567447ce *** empty log message *** 2003-04-29 16:51:15 +00:00
tipaul
26543b430e really proud of this commit :-)
z3950 search and import seems to works fine.
Let me explain how :
* a "search z3950" button is added in the addbiblio template.
* when clicked, a popup appears and z3950/search.pl is called
* z3950/search.pl calls addz3950search in the DB
* the z3950 daemon retrieve the records and stores them in z3950results AND in marc_breeding table.
* as long as there as searches pending, the popup auto refresh every 2 seconds, and says how many searches are pending.
* when the user clicks on a z3950 result => the parent popup is called with the requested biblio, and auto-filled

Note :
* character encoding support : (It's a nightmare...) In the z3950servers table, a "encoding" column has been added. You can put "UNIMARC" or "USMARC" in this column. Depending on this, the char_decode in C4::Biblio.pm replaces marc-char-encode by an iso 8859-1 encoding. Note that in the breeding import this value has been added too, for a better support.
* the marc_breeding and z3950* tables have been modified : they have an encoding column and the random z3950 number is stored too for convenience => it's the key I use to list only requested biblios in the popup.
2003-04-29 16:48:25 +00:00
tipaul
a3c119a356 z3950 support is coming...
* adding a syntax column in z3950 table = this column will say wether the z3950 must be called with PerferedRecordsyntax => USMARC or PerferedRecordsyntax => UNIMARC. I tried some french UNIMARC z3950 servers, and some only send USMARC, some only UNIMARC, some can answer with both.
Note this is a 1st draft. More to follow (today ? I hope).
2003-04-29 08:09:42 +00:00
tipaul
e5bbeace3d Those fixes solves the "internal server error" with MARC::Record 1.12.
It was due to an illegal contruction in Koha : we tried to retrive subfields from <10 tags.
That's not possible. MARC::Record accepted this in 0.93 version, but it was fixed after.
Now, the construct/retrieving is OK !
2003-04-28 13:07:14 +00:00
tipaul
4b18c35c6f fix for #410 2003-04-24 18:28:40 +00:00
tipaul
e565c001ee some fixes 2003-04-24 16:29:09 +00:00
tipaul
d215d11c3d fix for 361 2003-04-24 16:28:47 +00:00
tipaul
e57535b581 fix for #297 and some others bugs 2003-04-23 12:20:26 +00:00
tipaul
a118eeacfc 1st draft for z3950 client import.
moving Breeding farm script to a perl package C4/Breeding.pm
2003-04-22 12:22:52 +00:00
tipaul
7d34ac8ec4 *** empty log message *** 2003-04-11 08:41:06 +00:00
tipaul
88867f1426 Fix some bugs :
* worked in 1.9.0, but not in 1.9.1 :
- modif of a biblio didn't work
- empty fields where not shown when modifying a biblio. empty fields managed by the library (ie in tab 0->9 in MARC parameter table) MUST be entered, even if not presented.

* did not work before :
- repeatable subfields now works correctly. Enter 2 subfields separated by | and they will be splitted during saving.
- dropped the last subfield of the MARC form :-(

Internal changes :
- MARCmodbiblio now works by deleting and recreating the biblio. It's not perf optimized, but MARC is a "do_something_impossible_to_trace" standard, so, it's the best solution. not a problem for me, as biblio are rarely modified.
Note the MARCdelbiblio has been rewritted to enable deletion of a biblio WITHOUT deleting items.
2003-04-10 13:56:02 +00:00
tipaul
533c38dc8f fix for #229 2003-04-08 11:30:55 +00:00
tipaul
844797459f fix for #187 2003-04-07 14:05:24 +00:00
wolfpac444
e4d7a39bab Fixed the dates in aqbudget.pl 2003-04-05 03:19:33 +00:00
tipaul
e60f831e1f last commits before 1.9.1 2003-04-04 08:40:44 +00:00
wolfpac444
6b0a39e5bb Fixed bug #250 2003-04-04 08:04:16 +00:00
wolfpac444
a5587ab3a2 Added Paul's changes to the version that should be current. I have been having problems with my version reverting back to an old
one.
2003-04-03 01:28:28 +00:00
tipaul
cc35b709e1 small fix to avoid empty list when itemtypes does'nt exist in DB 2003-04-01 13:19:55 +00:00
tipaul
452e65166c fixes 2003-04-01 12:26:43 +00:00
tipaul
674c150697 small improvment 2003-04-01 12:26:02 +00:00
wolfpac444
16f422a8f7 Bug fixes 2003-03-29 00:02:24 +00:00
wolfpac444
4dd0e8d2fb Here we go again... 2003-03-28 23:08:30 +00:00
wolfpac444
ca0bf13bd0 Fixed bug #241 2003-03-28 23:03:51 +00:00
wolfpac444
333e222461 *** empty log message *** 2003-03-26 04:42:56 +00:00
wolfpac444
14809df133 *** empty log message *** 2003-03-26 04:42:56 +00:00
wolfpac444
00d780e00e Hmm.. having problems getting my changes to Date.pm saved... 2003-03-26 04:09:06 +00:00
wolfpac444
20da23088a Added format_date_in_iso function. 2003-03-26 03:57:10 +00:00
wolfpac444
28be0337c5 Fixed problems with non-US date such as 28/10/1983. 2003-03-26 03:46:20 +00:00
wolfpac444
feb424a443 Module to format dates in the correct manner. 2003-03-26 02:48:59 +00:00
tipaul
86631c1a8e fix for bug #54 2003-03-19 21:37:21 +00:00
tipaul
3205a1a3ff reindenting & code cleaning 2003-03-19 21:03:32 +00:00
tipaul
feae3136b4 adding checkdigit parameter that choose how to check the members cardnumber.
At the moment :
* none = no checking
* katipo = checked as before
2003-03-18 10:58:19 +00:00
tipaul
9658d683f6 pod updating 2003-03-11 15:14:03 +00:00
tipaul
b9fbe0083f *** empty log message *** 2003-03-10 15:19:33 +00:00
tipaul
1b0620652e * moving generic functions to Koha.pm
* improvement of SearchMarc.pm
* bugfixes
* code cleaning
2003-03-07 16:35:42 +00:00
tipaul
f953c4a169 adding "interface" parameter : /intranet-tmpl or /opac-tmpl 2003-03-04 17:49:50 +00:00
tipaul
4b2c43a9a9 bugfix for bookseller forgot and minor sql improvement 2003-03-03 17:37:34 +00:00
tipaul
867a82398e migrating to prepare (?) execute($var) structure 2003-03-03 17:36:32 +00:00
tipaul
69a3b7e8ae small bugfix 2003-02-28 16:29:11 +00:00
tipaul
fe8746a471 * moving prepare / execute to ? form.
* some # cleaning
* little bugfix.
* road to 1.9.2 => acquisition and cataloguing merging
2003-02-27 16:51:59 +00:00
wolfpac444
4e3888e2ec Fixed the subject search. 2003-02-21 02:25:03 +00:00
wolfpac444
c3c3f27ec7 *** empty log message *** 2003-02-19 01:33:52 +00:00
wolfpac444
4d88a09509 Removed the unecessary $dbh argument from being passed.
Resolved a few minor FIXMEs.
2003-02-19 01:01:06 +00:00
wolfpac444
04ce9b04f1 Cleaned up the FIXME issues. 2003-02-19 00:39:18 +00:00
tipaul
fa0f51d9c2 Support for 000 -> 010 fields.
Those fields doesn't have subfields.
In koha, we will use a specific "trick" : fields <10 will have a "virtual" subfield : "@".
Note it's only virtual : when rebuilding the MARC::Record, the koha API handle correctly "@" subfields => the resulting MARC record has a 00x field without subfield.
2003-02-12 11:01:04 +00:00
tipaul
8d75bf9568 Support for 000 -> 010 fields.
Those fields doesn't have subfields.
In koha, we will use a specific "trick" : fields <10 will have a "virtual" subfield : "@".
Note it's only virtual : when rebuilding the MARC::Record, the koha API handle correctly "@" subfields => the resulting MARC record has a 00x field without subfield.
2003-02-12 11:01:01 +00:00
tipaul
bd9239fee1 removing unused sub 2003-02-10 13:37:08 +00:00
acli
7d7deb7b36 Moved the cardnumber generation logic out of memberentry.pl; new module
C4::Members created to hold this logic

Fixed syntax error in newimember.pl
Make newimember.pl use the cardnumber generation logic (bug 206)
Updated newimember.pl to use get_template_and_user
Other minor mods to newimember.pl; new tab size noted
2003-02-10 07:14:16 +00:00
acli
ac6592a669 Fixed completely wrong logic in my boolean_preference function 2003-02-10 06:37:00 +00:00
acli
be5f5273fa Tentatively export the "internal" function CalcReserveFee ; opac-reserves
uses it

Noted correct tab size
2003-02-06 07:41:28 +00:00
acli
47aa996a11 Forgot to take out debugging code 2003-02-06 07:07:54 +00:00
acli
850a3e41f6 Use the new C4::Boolean module and the new C4::Auth::boolean_parameter
function to test for boolean values in parameters
2003-02-06 06:35:26 +00:00
acli
6157f1842b Convenience function to check for 1/0/true/false/on/off/yes/no 2003-02-06 06:15:00 +00:00
acli
8f722b5829 POD elaboration for checkauth() (esp. regarding "$flagsrequired") 2003-02-06 06:13:59 +00:00
acli
fc5d0e3961 Explicitly declare dependency on HTML::Template
If checkauth() detects a permission problem (e.g., in untemplated scripts),
this is necessary for the code (that displays the error message) to run
(otherwise Perl dies with a very cryptic, confusing error message)
2003-02-06 05:04:36 +00:00
acli
6ac450b83b Converted a few SQL statements to use ? to fix a few strange SQL errors
Noted correct tab size
2003-02-05 10:05:02 +00:00
acli
88dcb0a314 Changed the 3 "this does nothing" lines to set the flag. Is this right? 2003-02-05 07:55:42 +00:00
acli
f475af255f Implemented fixes for bug 170
1. Circ2::returnbook will throw an exception if $branch is undef
2. branch/printer-getting code is modularized into getbranch and getprinter
   with correct logic from circulation.pl (temporarily put into Circ2.pm)
3. circulation.pl and returns.pl modified to use above functions

Noted correct tab sizes for the files; returns.pl partially reformatted to
conform to the dominant correct tab size

Handle non-latin1 charsets for returns.pl
2003-02-05 06:28:56 +00:00
tonnesen
f58bb6afe0 Removing +1y expiry time from cookies so that cookies expire when the browser
exits.
2003-02-04 17:57:10 +00:00
acli
f1ae358bcd Reverted to using s/// instead of quotemeta for title/author/illustrator,
to avoid quoting spaces (which results in most titles/authors etc. becoming
unsearchable) (Bug 197)
2003-02-04 04:44:35 +00:00
acli
b5ecefd485 Minor factoring in C4/Biblio.pm, plus change to export the per-tag
'mandatory' property to a per-subfield 'tag_mandatory' template parameter,
so that addbiblio.tmpl can distinguish between mandatory subfields in a
mandatory tag and mandatory subfields in an optional tag

Not-minor factoring in acqui.simple/addbiblio.pl to make the if-else blocks
smaller, and to add some POD; need further testing for this

Added function to check if a MARC subfield name is "koha-internal" (instead
of checking it for 'lib' and 'tag' everywhere); temporarily added to Koha.pm

Use above function in acqui.simple/additem.pl and search.marc/search.pl
2003-02-03 18:46:00 +00:00
acli
8f62498205 Updated module location 2003-02-03 07:23:14 +00:00
acli
32b87866dd Minor code cleanup
(Implemented some simple FIXME's in C4/Search.pm)
2003-02-03 02:15:43 +00:00
acli
16d67236c2 Distinguish between On Loan, Item Lost, and Withdrawn, instead of saying
just "not available".  Cf. Bug 112
2003-02-02 08:47:01 +00:00
acli
e9858a2910 Moved C4/Charset.pm to C4/Interface/CGI/Output.pm 2003-02-02 07:19:29 +00:00
acli
52a5fd4bbd Moved C4/Charset.pm to C4/Interface/CGI/Output.pm
Create output_html_with_http_headers function to contain the "print $query
->header(-type => guesstype...),..." call. This is in preparation for
non-HTML output (e.g., text/xml) and charset conversion before output in
the future.

Created C4/Interface/CGI/Template.pm to hold convenience functions specific
to the CGI interface using HTML::Template

Modified moremembers.pl to make the "sex" field localizable for languages
where M and F doesn't make sense
2003-02-02 07:18:37 +00:00
tipaul
c23d07724e search on MARC datas.
first draft
2003-01-28 14:56:39 +00:00
tipaul
d8c2e556ce fixing a sql query not using prepare(?) & execute($var) method 2003-01-28 14:53:30 +00:00
tipaul
c0c8f96121 fixing MARCmodbiblio API and reindenting code 2003-01-28 14:50:04 +00:00
tipaul
4cbb08cd5e bugfix #168 + "breedingsearch" sub added+ "isbnsearch" (used only in acqui.simple, should disappear soon) now works on title and isbn 2003-01-28 14:46:50 +00:00
acli
47fcb64527 Temporary patch for bug 182 2003-01-26 04:37:17 +00:00
acli
ef50ee5217 Use ? for an SQL query to prevent SQL syntax errors 2003-01-25 20:05:20 +00:00
tipaul
8392f92ec0 adding char_decode to decode MARC21 or UNIMARC extended chars 2003-01-23 12:22:37 +00:00
acli
b242ad44ec Removed scoping-related perl warnings 2003-01-20 07:38:54 +00:00
acli
5d52c8bf49 Removed scoping-related perl warnings
Factored similar code in getborrowernumber
"i.e." in one comment should be "e.g."
2003-01-20 07:38:23 +00:00
acli
2e7bb9a106 Removed perl warning 2003-01-20 07:35:31 +00:00
acli
ea50c2acb6 Preliminary fix of the CGI.pm problem of always assuming that everything is
in ISO-8859-1.

A new C4::Charset module (tentative name) has been created to guess the
charset of a piece of HTML markup. The CGI programs will be modified to use
this module as they are encountered during translation.
2003-01-19 06:15:44 +00:00
acli
6bdd53ded8 Added < to the filenames of open() calls 2003-01-19 06:13:27 +00:00
tipaul
95791d11cf last bugfix before releasing 1.3.3. Not trully a bugfix (see release notes) 2003-01-06 13:31:01 +00:00
tipaul
40d6ddb383 checks that the config file passed in parameter exist, otherwise, uses the default one (/etc/koha.conf)
useful in upgradedb2marc.pl script.
* if this script is called during installation, uses /etc/koha.conf.tmp
* if it's called manually (after installation), uses /etc/koha.conf, as the tmp file is no more here :-)
2002-12-20 13:54:31 +00:00
tipaul
6098d9c4eb little modif in gettemplate.
auto-replaces theme and lang template variable.
This is useful if you have images in your template :
<img src="/<TMPL_VAR name="theme">/<TMPL_VAR name="lang">/images/picture.gif>
or
<img src="/<TMPL_VAR name="theme">/images/picture.gif>
in the case of a non-language dependant image.

Before this fix, gettemplate only replaced a variable called themelang, which was useful for language dependant images, but didn't work with theme-only images.
Note the previous behaviour is still activated (ie : themelang still works)
2002-12-20 08:35:19 +00:00
hdl
16c57f0a75 Templating reservereport et shelves. 2002-12-19 18:55:40 +00:00
hdl
9d8857f344 Templating reports.pl
This might be of no use... Since it is never called and seems obsolete.
2002-12-19 15:22:18 +00:00