Commit graph

464 commits

Author SHA1 Message Date
tipaul
b9fbe0083f *** empty log message *** 2003-03-10 15:19:33 +00:00
tipaul
1b0620652e * moving generic functions to Koha.pm
* improvement of SearchMarc.pm
* bugfixes
* code cleaning
2003-03-07 16:35:42 +00:00
tipaul
f953c4a169 adding "interface" parameter : /intranet-tmpl or /opac-tmpl 2003-03-04 17:49:50 +00:00
tipaul
4b2c43a9a9 bugfix for bookseller forgot and minor sql improvement 2003-03-03 17:37:34 +00:00
tipaul
867a82398e migrating to prepare (?) execute($var) structure 2003-03-03 17:36:32 +00:00
tipaul
69a3b7e8ae small bugfix 2003-02-28 16:29:11 +00:00
tipaul
fe8746a471 * moving prepare / execute to ? form.
* some # cleaning
* little bugfix.
* road to 1.9.2 => acquisition and cataloguing merging
2003-02-27 16:51:59 +00:00
wolfpac444
4e3888e2ec Fixed the subject search. 2003-02-21 02:25:03 +00:00
wolfpac444
c3c3f27ec7 *** empty log message *** 2003-02-19 01:33:52 +00:00
wolfpac444
4d88a09509 Removed the unecessary $dbh argument from being passed.
Resolved a few minor FIXMEs.
2003-02-19 01:01:06 +00:00
wolfpac444
04ce9b04f1 Cleaned up the FIXME issues. 2003-02-19 00:39:18 +00:00
tipaul
fa0f51d9c2 Support for 000 -> 010 fields.
Those fields doesn't have subfields.
In koha, we will use a specific "trick" : fields <10 will have a "virtual" subfield : "@".
Note it's only virtual : when rebuilding the MARC::Record, the koha API handle correctly "@" subfields => the resulting MARC record has a 00x field without subfield.
2003-02-12 11:01:04 +00:00
tipaul
8d75bf9568 Support for 000 -> 010 fields.
Those fields doesn't have subfields.
In koha, we will use a specific "trick" : fields <10 will have a "virtual" subfield : "@".
Note it's only virtual : when rebuilding the MARC::Record, the koha API handle correctly "@" subfields => the resulting MARC record has a 00x field without subfield.
2003-02-12 11:01:01 +00:00
tipaul
bd9239fee1 removing unused sub 2003-02-10 13:37:08 +00:00
acli
7d7deb7b36 Moved the cardnumber generation logic out of memberentry.pl; new module
C4::Members created to hold this logic

Fixed syntax error in newimember.pl
Make newimember.pl use the cardnumber generation logic (bug 206)
Updated newimember.pl to use get_template_and_user
Other minor mods to newimember.pl; new tab size noted
2003-02-10 07:14:16 +00:00
acli
ac6592a669 Fixed completely wrong logic in my boolean_preference function 2003-02-10 06:37:00 +00:00
acli
be5f5273fa Tentatively export the "internal" function CalcReserveFee ; opac-reserves
uses it

Noted correct tab size
2003-02-06 07:41:28 +00:00
acli
47aa996a11 Forgot to take out debugging code 2003-02-06 07:07:54 +00:00
acli
850a3e41f6 Use the new C4::Boolean module and the new C4::Auth::boolean_parameter
function to test for boolean values in parameters
2003-02-06 06:35:26 +00:00
acli
6157f1842b Convenience function to check for 1/0/true/false/on/off/yes/no 2003-02-06 06:15:00 +00:00
acli
8f722b5829 POD elaboration for checkauth() (esp. regarding "$flagsrequired") 2003-02-06 06:13:59 +00:00
acli
fc5d0e3961 Explicitly declare dependency on HTML::Template
If checkauth() detects a permission problem (e.g., in untemplated scripts),
this is necessary for the code (that displays the error message) to run
(otherwise Perl dies with a very cryptic, confusing error message)
2003-02-06 05:04:36 +00:00
acli
6ac450b83b Converted a few SQL statements to use ? to fix a few strange SQL errors
Noted correct tab size
2003-02-05 10:05:02 +00:00
acli
88dcb0a314 Changed the 3 "this does nothing" lines to set the flag. Is this right? 2003-02-05 07:55:42 +00:00
acli
f475af255f Implemented fixes for bug 170
1. Circ2::returnbook will throw an exception if $branch is undef
2. branch/printer-getting code is modularized into getbranch and getprinter
   with correct logic from circulation.pl (temporarily put into Circ2.pm)
3. circulation.pl and returns.pl modified to use above functions

Noted correct tab sizes for the files; returns.pl partially reformatted to
conform to the dominant correct tab size

Handle non-latin1 charsets for returns.pl
2003-02-05 06:28:56 +00:00
tonnesen
f58bb6afe0 Removing +1y expiry time from cookies so that cookies expire when the browser
exits.
2003-02-04 17:57:10 +00:00
acli
f1ae358bcd Reverted to using s/// instead of quotemeta for title/author/illustrator,
to avoid quoting spaces (which results in most titles/authors etc. becoming
unsearchable) (Bug 197)
2003-02-04 04:44:35 +00:00
acli
b5ecefd485 Minor factoring in C4/Biblio.pm, plus change to export the per-tag
'mandatory' property to a per-subfield 'tag_mandatory' template parameter,
so that addbiblio.tmpl can distinguish between mandatory subfields in a
mandatory tag and mandatory subfields in an optional tag

Not-minor factoring in acqui.simple/addbiblio.pl to make the if-else blocks
smaller, and to add some POD; need further testing for this

Added function to check if a MARC subfield name is "koha-internal" (instead
of checking it for 'lib' and 'tag' everywhere); temporarily added to Koha.pm

Use above function in acqui.simple/additem.pl and search.marc/search.pl
2003-02-03 18:46:00 +00:00
acli
8f62498205 Updated module location 2003-02-03 07:23:14 +00:00
acli
32b87866dd Minor code cleanup
(Implemented some simple FIXME's in C4/Search.pm)
2003-02-03 02:15:43 +00:00
acli
16d67236c2 Distinguish between On Loan, Item Lost, and Withdrawn, instead of saying
just "not available".  Cf. Bug 112
2003-02-02 08:47:01 +00:00
acli
e9858a2910 Moved C4/Charset.pm to C4/Interface/CGI/Output.pm 2003-02-02 07:19:29 +00:00
acli
52a5fd4bbd Moved C4/Charset.pm to C4/Interface/CGI/Output.pm
Create output_html_with_http_headers function to contain the "print $query
->header(-type => guesstype...),..." call. This is in preparation for
non-HTML output (e.g., text/xml) and charset conversion before output in
the future.

Created C4/Interface/CGI/Template.pm to hold convenience functions specific
to the CGI interface using HTML::Template

Modified moremembers.pl to make the "sex" field localizable for languages
where M and F doesn't make sense
2003-02-02 07:18:37 +00:00
tipaul
c23d07724e search on MARC datas.
first draft
2003-01-28 14:56:39 +00:00
tipaul
d8c2e556ce fixing a sql query not using prepare(?) & execute($var) method 2003-01-28 14:53:30 +00:00
tipaul
c0c8f96121 fixing MARCmodbiblio API and reindenting code 2003-01-28 14:50:04 +00:00
tipaul
4cbb08cd5e bugfix #168 + "breedingsearch" sub added+ "isbnsearch" (used only in acqui.simple, should disappear soon) now works on title and isbn 2003-01-28 14:46:50 +00:00
acli
47fcb64527 Temporary patch for bug 182 2003-01-26 04:37:17 +00:00
acli
ef50ee5217 Use ? for an SQL query to prevent SQL syntax errors 2003-01-25 20:05:20 +00:00
tipaul
8392f92ec0 adding char_decode to decode MARC21 or UNIMARC extended chars 2003-01-23 12:22:37 +00:00
acli
b242ad44ec Removed scoping-related perl warnings 2003-01-20 07:38:54 +00:00
acli
5d52c8bf49 Removed scoping-related perl warnings
Factored similar code in getborrowernumber
"i.e." in one comment should be "e.g."
2003-01-20 07:38:23 +00:00
acli
2e7bb9a106 Removed perl warning 2003-01-20 07:35:31 +00:00
acli
ea50c2acb6 Preliminary fix of the CGI.pm problem of always assuming that everything is
in ISO-8859-1.

A new C4::Charset module (tentative name) has been created to guess the
charset of a piece of HTML markup. The CGI programs will be modified to use
this module as they are encountered during translation.
2003-01-19 06:15:44 +00:00
acli
6bdd53ded8 Added < to the filenames of open() calls 2003-01-19 06:13:27 +00:00
tipaul
95791d11cf last bugfix before releasing 1.3.3. Not trully a bugfix (see release notes) 2003-01-06 13:31:01 +00:00
tipaul
40d6ddb383 checks that the config file passed in parameter exist, otherwise, uses the default one (/etc/koha.conf)
useful in upgradedb2marc.pl script.
* if this script is called during installation, uses /etc/koha.conf.tmp
* if it's called manually (after installation), uses /etc/koha.conf, as the tmp file is no more here :-)
2002-12-20 13:54:31 +00:00
tipaul
6098d9c4eb little modif in gettemplate.
auto-replaces theme and lang template variable.
This is useful if you have images in your template :
<img src="/<TMPL_VAR name="theme">/<TMPL_VAR name="lang">/images/picture.gif>
or
<img src="/<TMPL_VAR name="theme">/images/picture.gif>
in the case of a non-language dependant image.

Before this fix, gettemplate only replaced a variable called themelang, which was useful for language dependant images, but didn't work with theme-only images.
Note the previous behaviour is still activated (ie : themelang still works)
2002-12-20 08:35:19 +00:00
hdl
16c57f0a75 Templating reservereport et shelves. 2002-12-19 18:55:40 +00:00
hdl
9d8857f344 Templating reports.pl
This might be of no use... Since it is never called and seems obsolete.
2002-12-19 15:22:18 +00:00
tipaul
80a37bdd4a small but important bugfix (fixes a problem in export) 2002-12-16 15:08:50 +00:00
tipaul
4b9af7f1ff 1st draft of marc export 2002-12-13 16:22:04 +00:00
tipaul
a067d70c35 code cleaning 2002-12-13 10:36:22 +00:00
tipaul
4d315418f2 YAB ! (Yet Another Bugfix) => related to biblio modif
(some warning cleaning too)
2002-12-12 21:26:35 +00:00
tipaul
dd696c61e8 adding authentification with Auth.pm and
MAJOR BUGFIX on marc biblio modification
2002-12-12 16:34:41 +00:00
tipaul
b0d0dddfac authentification bugfix :
the api in pod-auth.pm has "type => 'opac' "parameter.
If called from intranet, should be type => 'intranet'.
Output.pm checked for type existed, and not it's value. Now, Output compares checks for type value.
If type='intranet', then the intranet template is called, else it's an opac template.
Finlay, please validate this commit.
2002-12-10 15:52:49 +00:00
tipaul
60c769f326 removing warnings 2002-12-10 13:42:00 +00:00
tipaul
9b6d589336 fugfixes from Dombes Abbey work 2002-12-10 13:30:03 +00:00
rangi
bc9b0aca44 Added a note that this module is slated to be removed 2002-12-07 04:38:56 +00:00
finlayt
2ee268c632 This is essentially the Auth.pm coming from the rel-1-2 branch. It is quite different from the old one, but shouldnt break any existing code. 2002-12-04 04:32:35 +00:00
tipaul
5c67993c8f road to 1.3.2
various bugfixes, improvments, and migration from acquisition.pm to biblio.pm
2002-11-19 12:31:34 +00:00
tipaul
73e37063d5 road to 1.3.2 :
* many bugfixes
* adding value_builder : you can map a subfield in the marc_subfield_structure to a sub stored in "value_builder" directory. In this directory you can create screen used to build values with any method. In this commit is a 1st draft of the builder for 100$a unimarc french subfield, which is composed of 35 digits, with 12 differents values (only the 4th first are provided for instance)
2002-11-12 16:39:14 +00:00
tipaul
e11872aeb1 road to 1.3.2 :
* many bugfixes
* adding value_builder : you can map a subfield in the marc_subfield_structure to a sub stored in "value_builder" directory. In this directory you can create screen used to build values with any method. In this commit is a 1st draft of the builder for 100$a unimarc french subfield, which is composed of 35 digits, with 12 differents values (only the 4th first are provided for instance)
2002-11-12 15:58:43 +00:00
tonnesen
c16a952963 Merging from rel-1-2 to trunk 2002-10-28 20:02:57 +00:00
tipaul
94b6b3a6c1 Road to 1.3.2
* bugfixes and improvements
2002-10-25 10:58:26 +00:00
tonnesen
08d26bcc75 Removing ReserveWaiting call pending further discussion... 2002-10-24 20:09:29 +00:00
tonnesen
7aeb26593b Merging changes from rel-1-2 into trunk (circulation module only) 2002-10-24 18:30:17 +00:00
arensb
fbb774f115 Fixed "no title" warning when generating HTML documentation from POD. 2002-10-24 12:09:01 +00:00
tonnesen
a0df2d5ea3 Added a couple of tests. 2002-10-24 04:12:10 +00:00
tonnesen
d0a060afb5 Added some more functionality to Shelf.pm (including the ability to actually
create a new shelf) and started a test script (Shelf.t)
2002-10-23 23:32:47 +00:00
tonnesen
263f5ecd46 First shot at a Shelf module. I'd appreciate comments on this. It contains
perldoc documentation describing the interface to date.
2002-10-23 22:21:09 +00:00
arensb
15a05e968f Updated a FIXME comment. 2002-10-16 12:45:15 +00:00
arensb
aa3a88a76c Added and updated some FIXME comments. 2002-10-16 12:44:25 +00:00
arensb
15d6ecc822 Added some FIXME comments. 2002-10-16 12:42:29 +00:00
tipaul
6d578747a9 removing Acquisition.pm
deleting unused code in biblio.pm, rewriting POD and answering most FIXME comments
2002-10-15 13:39:17 +00:00
tipaul
c4892ded4d merging arens + my modifs/bugfixes 2002-10-14 07:40:04 +00:00
finlayt
6800d04813 added small fix to UpdateReserve that fixes a bug coming from the calles from moremember.pl 2002-10-14 04:22:25 +00:00
arensb
eff606ba56 Replaced expressions of the form "$x = $x <op> $y" with "$x <op>= $y".
Thus, $x = $x+2 becomes $x += 2, and so forth.
2002-10-13 11:32:14 +00:00
arensb
24b7b9a73d Removed trailing whitespace. 2002-10-13 09:31:35 +00:00
arensb
89ed0f29f6 Removed unused finalizer. 2002-10-13 08:34:49 +00:00
arensb
fddab26c2e Deleted unused variables.
Removed trailing whitespace.
2002-10-13 08:27:49 +00:00
arensb
7197a3735b Added magic RCS comment.
Removed trailing whitespace.
2002-10-13 07:31:21 +00:00
arensb
d5c8d40e23 Deleted unused variables.
Removed trailing whitespace.
2002-10-13 06:37:54 +00:00
arensb
73bcde4fa1 Added magic RCS comment.
Added some FIXME comments explaining why I didn't write a POD.
Removed unused finalizer.
2002-10-13 06:29:37 +00:00
arensb
a3118241ed Added magic RCS comment.
Added some FIXME comments.
Added some explanatory comments.
Removed trailing whitespace.
Deleted unused variables.
Added POD.
Removed unused finalizer.
2002-10-13 06:28:49 +00:00
arensb
c572ee3b11 Added magic RCS comment.
Added some FIXME comments.
Added some explanatory comments.
Removed trailing whitespace.
Deleted unused variables.
Added POD.
Removed unused finalizer.
2002-10-13 06:22:48 +00:00
arensb
f96a21551d Added magic RCS comment.
Added some FIXME comments.
Deleted unused variables.
Added POD.
Removed unused finalizer.
2002-10-13 06:20:22 +00:00
arensb
048e1fdfe1 Added magic RCS comment.
Removed a lying comment.
Removed unused global variables.
Added POD.
Added some FIXME comments.
Added some explanatory comments.
Removed unused finalizer.
2002-10-13 06:18:42 +00:00
arensb
198d27dd88 Added magic RCS string.
Added some FIXME comments.
Removed unused finalizer.
2002-10-13 06:15:08 +00:00
arensb
4779119226 Added magic RCS string.
Added a FIXME comment.
Removed unused finalizer.
2002-10-13 06:14:10 +00:00
arensb
3660bc647a Removed bogus #! line (this isn't a script!)
Removed unused global variables.
Added POD.
Added some explanatory comments.
Added some FIXME comments.
2002-10-13 06:13:23 +00:00
arensb
6e4f0b9fb7 Added magic RCS comment.
Removed declarations for nonexistent variables.
Added some FIXME comments.
Removed unused finalizer.
2002-10-13 06:12:00 +00:00
arensb
bc9257875b Added partial POD (but I don't understand reserves well enough to
continue).
Added magic RCS comment.
Added some explanatory comments.
Removed trailing whitespace.
Added some FIXME comments.
Moved comments in first column to where they wouldn't obscure the
indentation.
Removed unused finalizer.
2002-10-13 06:09:26 +00:00
arensb
3a92eb7781 Added some FIXME comments. 2002-10-13 06:05:59 +00:00
arensb
6da9869463 Added a FIXME comment. 2002-10-13 06:03:38 +00:00
arensb
118907bcdd Added some FIXME comments.
Added RCS magic comment.
Removed unused finalizer.
2002-10-13 06:03:03 +00:00
arensb
c7f9fb2b99 Added some FIXME comments. 2002-10-13 05:56:10 +00:00
arensb
3e5e5e0303 Added a partial POD.
Wrote some FIXME comments explaining why I'm not going to write any
more PODs.
Added some other FIXME comments.
2002-10-13 05:52:46 +00:00
arensb
5c91d43a43 Added some FIXME comments. 2002-10-13 05:49:13 +00:00
arensb
125a9fafcf Added some FIXME comments. 2002-10-12 07:31:35 +00:00
arensb
5ff7515d5b Turn off authentication entirely if systempreference "insecure" is set
to "yes".
2002-10-12 06:12:39 +00:00
arensb
57bc667d07 Got rid of the dependency on Set::Scalar. Yay! One fewer package that
the user has to install!
Redid the way SQL queries are built up, to make it more readable and
maintainable.
Removed a couple of unused variables.
Got rid of some un-Perl-like bogosity.
2002-10-12 05:43:03 +00:00
arensb
13d93ef115 Added a FIXME comment. 2002-10-11 13:06:52 +00:00
arensb
f981e30f4a Gutted.
Every function in this module is now obsolete. Removed just about
everything.
The name "Database" might still be reused, though the next time
something gets added, it should probably be called v2.0.
2002-10-11 12:52:11 +00:00
arensb
70d8c21450 Removed bogus unused variables at the top.
Prettified @EXPORT list.
(bug fix): Added missing semicolon.
2002-10-11 12:42:08 +00:00
arensb
70c08fd084 Replaced &requireDBI with C4::Context->dbh, thus making the "use
Database" statement unnecessary.
Fixed POD up a bit.
2002-10-11 12:40:50 +00:00
arensb
52d2d7bf92 Removed trailing whitespace that was messing up the POD. 2002-10-11 12:39:34 +00:00
arensb
cd8203d8d8 Added FIXME comment. This file is obsolete, right? 2002-10-11 12:36:44 +00:00
arensb
e744903393 Updated FIXME comment. This file is obsolete, right? 2002-10-11 12:36:26 +00:00
arensb
81ec28f127 Replaced &requireDBI with C4::Context->dbh 2002-10-11 12:34:53 +00:00
arensb
99fdc7afa0 Cleaned things up a bit. 2002-10-11 03:24:29 +00:00
arensb
61d632bf8a Removed &systemprefs. It is no longer used. 2002-10-11 03:14:51 +00:00
arensb
ddcc85bfc2 Use C4::Context->preference instead of &systemprefs or explicit SQL
calls to get an entry from the systempreferences table.
2002-10-11 03:14:03 +00:00
arensb
527fdc97e0 Made code a bit more Perl-ish. 2002-10-10 14:51:14 +00:00
tipaul
b47c3c7627 bugfixes 2002-10-10 14:48:25 +00:00
tipaul
ae8bd1dbf8 cleaning code 2002-10-10 14:47:00 +00:00
tipaul
9d31145bf2 merging 1.2 and bugfixes for auth and login 2002-10-10 10:07:34 +00:00
arensb
afa8db75fc Added some FIXMEs.
Made code more Perlish.
(bug fix): Allow whitespace in $HTTP_ACCEPT_LANGUAGE (Konqueror uses
", " as language separator).
2002-10-10 05:32:20 +00:00
arensb
657643c67d Added whitespace to make the POD work.
Added author.
2002-10-10 04:47:54 +00:00
arensb
94d2f6ea1f Added whitespace to make the POD work. 2002-10-10 04:44:28 +00:00
arensb
4c345d156a Fixed a few problems with POD. 2002-10-10 04:43:44 +00:00
arensb
d00793f8a1 Simplified references. 2002-10-10 04:42:35 +00:00
arensb
ef8cf295eb Added whitespace to make the POD work.
Removed references, added author.
2002-10-10 04:41:05 +00:00
arensb
95e2b3d1e6 Removed reference to Perl in POD. It should be obvious. 2002-10-10 04:34:51 +00:00
arensb
fa62f577cf Added whitespace to make the POD work.
Simplified references.
Added author email address.
2002-10-10 04:34:20 +00:00
arensb
668b558887 Fixed FIXMEs.
Removed reference to Perl in POD. It should be obvious.
2002-10-10 04:33:25 +00:00
arensb
9f09e01c07 Simplified references. 2002-10-10 04:32:44 +00:00
arensb
e4a482ac3d Fixed FIXMEs.
Removed reference to Perl. It should be obvious.
2002-10-10 04:32:06 +00:00
arensb
fa873de1fd Added whitespace to make the POD work.
Simplified references.
2002-10-10 04:29:39 +00:00
arensb
2f9a3a5bec Removed trailing whitespace that was breaking the POD. 2002-10-09 15:25:03 +00:00
arensb
3344f22bb7 Added POD.
Added a bunch of FIXMEs.
Trimmed trailing whitespace.
2002-10-09 14:17:49 +00:00
arensb
594987f486 Fixed missing bracket in POD. 2002-10-09 14:14:08 +00:00
arensb
99298f3d92 Added some FIXMEs. 2002-10-09 14:13:31 +00:00
arensb
7dcba2d082 Fixed FIXMEs in the POD. 2002-10-09 14:13:01 +00:00
arensb
3e7a102268 Added a couple of comments. 2002-10-09 14:04:49 +00:00
tipaul
dd1fd87846 road to 1.3.1 : viewing MARC biblio 2002-10-07 14:04:26 +00:00
arensb
fe98e2768b Removed unnecessary "use" line. 2002-10-07 00:51:55 +00:00
arensb
09fbb5e9d7 Added POD and some comments. 2002-10-07 00:51:22 +00:00
arensb
888c451d3d Added a FIXME comment. 2002-10-07 00:50:33 +00:00
arensb
21f62b0c03 Added a POD of sorts. 2002-10-07 00:48:50 +00:00
arensb
d00f624169 Added some FIXME comments. 2002-10-07 00:45:25 +00:00
arensb
695eb3b4b6 Removed unnecessary "use" line. 2002-10-07 00:44:23 +00:00
arensb
e551a3b888 Added a FIXME comment. 2002-10-07 00:35:44 +00:00
arensb
acaffcf53e Added POD and some comments. 2002-10-07 00:34:24 +00:00
arensb
f32b071f5c Fixed typo in synopsis. 2002-10-07 00:33:50 +00:00
arensb
3d22e58550 Fixed some bogosity.
Added some FIXMEs.
2002-10-05 23:59:40 +00:00
arensb
c3a1bd7117 Replaced several prepare()/execute()/finish() sequences with do(). 2002-10-05 23:57:39 +00:00
arensb
45c739791e Added "preference" method, for fetching a single value from
systempreferences (which is all most scripts need).
2002-10-05 23:55:00 +00:00
arensb
6421ecc986 Added a couple of FIXME comments. 2002-10-05 17:17:20 +00:00
arensb
ba786212eb Switched new functions to using C4::Context. 2002-10-05 16:55:09 +00:00