Commit graph

10031 commits

Author SHA1 Message Date
Joe Atzberger
f4ec623939 Cleanup - admin scripts
Fixed useless redirect statements that weren't even printed.
Removed unused javascript and script variables;
Removed sth->finish.  Use get instead of post on "cancel" button (no data to post).
Reduce duplicative variables (e.g. scriptname and script_name).

Many other problems are still in the scripts, including use of META-REFRESH instead of
redirect, and the whole idea of redirecting back to the same page for no valid reason.
We should be able to formulate the right response on THIS pass, not ask the browser to start over.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-12 09:58:07 -05:00
Garry Collum
4ec6c7b10d Bug 2889: Removed unused toggle variable from pcard-member-search.pl. Added table highlighting to .tmpl.
Removed unused toggle variable form pcard-member-search.pl.

Added highlighting to pcard-members-search.tmpl and fixed some XHMTL errors.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-12 09:58:05 -05:00
Garry Collum
7f28053a65 Bug 2889: Removed toggle variable from aqbudget.tmpl. Used template variable __odd__ instead.
Removed toggle variable from aqbudget.pl and aqbudget.tmpl. Used template variable __odd__ instead.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-11 06:10:58 -05:00
f306efb2c0 Add +(" ")+ to make few strings translatable (with Paul & Galen fix)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-11 06:10:55 -05:00
e616e6d9cd Adding 10,000th commit to the history
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-11 06:10:53 -05:00
Garry Collum
63b339a729 Bug 2889: Added template __odd__ variable to letter.tmpl
Used __odd__ variable instead of toggle in letter.tmpl.  No toggle variable was defined in letter.pl.

The table in letter.tmpl uses jquery for highlighting so the above may not be necessary, unless javascript is turned off.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-11 06:10:52 -05:00
Garry Collum
368681f9dd Bug 2889: Removed toggle variable from categorie.pl and categorie.tmpl.
Removed toggle variable from categorie.pl and categorie.tmpl.  Used template __odd__variable in categorie.tmpl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-11 06:10:50 -05:00
Garry Collum
d5904a0835 Bug 2889: Removed toggle variable from aqbookfund.pl and aqbookfund.tmpl.
Removed toggle variable from aqbookfund.pl and aqbookfund.tmpl. Used template __odd__ variable in aqbookfund.tmpl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-11 06:10:47 -05:00
Joe Atzberger
dcf25a5b44 Cleanup authtypes and currency .pl and .tmpl
Removed unused javascript.  Enabled warnings.  Use common $dbh.
Removed sth->finish calls.  Removed toggle code.  Added row highlight where
none had been implemented.  Added some HTML escaping in TMPL.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-11 06:10:45 -05:00
Garry Collum
ccb39e40de Bug 2889: Removed toggle variables from z3950servers.pl and .tmpl
Removed toggle variables from z3950servers.pl and z3950servers.tmpl.  Used template __odd__variable instead.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-11 06:10:42 -05:00
Garry Collum
b776266faa Bug 2889: Added highlighting to smart-rules.tmpl
Removed unused toggle variable form smart-rules.pl and added highlighting to smart-rules.tmpl through template __odd__.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-11 06:10:41 -05:00
Garry Collum
0b3f75183b Bug 2889: Removed toggle variable from roadtype.pl and .tmpl.
Removed toggle variable from roadtype.pl and roadtype.tmpl.  Corrected typo in class definition in roadtype.tmpl and add highlighting through the templated __odd__ variable.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-11 06:10:39 -05:00
Galen Charlton
2d880c73d1 removing disused C4::Serials functions
The following functions are no longer in use:

* old_newsubscription
* old_modsubscription
* old_getserials

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-09 09:31:12 -05:00
Galen Charlton
8aedc8f53f removing disused script
serials/subscription-copy.pl had been removed
in commit 8c78ff5aa5 but
for some reason had been accidentally restored in
a subsequent commit.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-09 09:31:12 -05:00
d4f6022e43 Bug 3316 - Improve last 3 issues displayed on OPAC detail page
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-09 09:17:24 -05:00
c4fbe27a44 Escaping HTML in the search results in the Librarian interface
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-09 09:00:32 -05:00
Garry Collum
7f555830aa Bug 2889: Removed toggle variable from itemtypes.tmpl. (resubmittal)
Removed toggle variable from itemtypes.tmpl and itemtypes.pl.  Used the __odd__ template variable instead.

Resubmittal - first patch contained a typo.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-09 09:00:29 -05:00
Nahuel ANGELINETTI
9dc44fefaf (bug #3304) fix notices trigger with diacritics in categorycodes
This just utf8::encode the $key if needed to permit categorycodes with diacritics.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-08 17:51:31 -05:00
Galen Charlton
ecdf595208 bug 3314: remove disused scripts and API functions
The distributedto column of the subscription table is
no longer used, having been replaced by the serials
routing list table.  This patch removes two C4::Serials
functions and a script and template, none of which were
reachable by current code:

C4::Serials::GetDistributedTo()
C4::Serials::SetDistributedTo()
koha-tmpl/intranet-tmpl/prog/en/modules/serials/distributedto.tmpl
serials/distributedto.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-08 17:03:05 -05:00
Brian Harrington
6a2d9ffcf2 Bug 3313, bulkauthimport.pl skips MARC21 subdivision records.
This patch adds the MARC21 subdivsion record tags (18x) to the
block which recognizes and assigns authtypecodes to imported
authority records.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-08 17:03:03 -05:00
Galen Charlton
e92b346f89 fixed bug resulting in invalid XHTML
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-08 16:57:47 -05:00
Garry Collum
48f958fb19 Bug 2889: Removed toggle variable from overduerules.tmpl - added __odd__
Removed toggle variable from overduerules.pl and overduerules.tmpl. Used template variable __odd__ instead.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-08 16:47:58 -05:00
Garry Collum
8767fa765b Bug 2889: Added shading for alternating rows to authorised_values.tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-08 16:47:56 -05:00
Garry Collum
fc8b7c27bb Bug 2889: Removed toggle variable from koha2marclinks.tmpl. Used template __odd__ variable.
Removed toggle variable from koha2marclinks.tmpl and koh2marclinks.pl.  Used template __odd__ variable instead.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-08 16:47:55 -05:00
Garry Collum
c09bdabaf4 Bug 2889: Removed toggle variable from currency.tmpl. Used template __odd__ instead.
Removed toggle variable from currency.tmpl and currency.pl.  Used template __odd_ variable instead.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-08 16:47:53 -05:00
Galen Charlton
527898f6f3 fix XHTML error
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-08 11:07:37 -05:00
Matthias Meusburger
0a2a13ca13 bug 3292: in opac branchcode should be replaced with name
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-08 11:03:46 -05:00
Galen Charlton
58920538f1 bug 2505: enable warnings in C4::Breeding
* also start to standardize ISBN normalization

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-07 20:09:25 -05:00
Galen Charlton
d199488f09 bug 2505: enable warnings in C4::Log
Also corrected several links to viewlog.pl that
didn't take into account the recent renaming
of one of its parameters from 'module' to 'modules'

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-07 20:09:24 -05:00
Galen Charlton
1455d663d6 bug 2505: enable warnings in call number normalization modules
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-07 20:09:23 -05:00
Galen Charlton
7ce6822973 removed incorrect module import
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-07 20:09:22 -05:00
Galen Charlton
27c2b318ef bug 2505: enable warnings in C4/Input.pm
Also removed POD containing disused function
checkvalidisbn.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-07 20:09:20 -05:00
Galen Charlton
ed014edad7 bug 2505: enable warnings in C4::ImportBatch and C4::Matcher
Also fix issues with normalizing ISBNs and the default
normalizer in C4::Matcher.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-07 20:09:19 -05:00
Galen Charlton
c53c9ff8c6 bug 3303: removed references to news_channels*
Removed routines in C4/NewsChannels.pm that refered
to missing database tables news_channels and news_channel_categories.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-07 20:09:18 -05:00
Galen Charlton
456e2a65b3 bug 3302: removed disused references to opac_electronic
Removed routines in C4/NewsChannels.pm that refer to
a missing opac_electronic table.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-07 20:09:17 -05:00
Galen Charlton
7bd4980db7 bug 2505: enabled warnings in C4::NewsChannels
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-07 20:09:16 -05:00
Galen Charlton
a244ff6671 bug 2505: turn on warnings in seven modules
C4::XSLT
C4::VirtualShelves
C4::Review
C4::Output
C4::Boolean
C4::Charset
C4::Stats

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-07 20:09:16 -05:00
Galen Charlton
62ab2a77c4 additional cleanup in GetItemsInfo()
* remove unused variable
* moved declaration of $count_reseves

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-07 14:32:58 -05:00
David Birmingham
86ec07d50b Removed a buggy conditional if that resulted in an incorrect item status
Previous conditional check with if ($restype) is not needed because a true
result for one item will result in subsqeuent items defaulting to this true
value.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-07 14:22:21 -05:00
Galen Charlton
ea42477090 bug 3299: fix setting renewal due date explicitly
When renewing a loan from the patron details page, setting
the renewal due date now works again.  Broken by patch
for bug 2770.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-07 13:17:08 -05:00
Galen Charlton
da51de184c bug 2926: fix staging import hang
Fixes a hang of the staging import tool when it
attempts to process a MARC21 record that claims
that it's UTF-8 when it is not.  The staging import
will now attempt to fix the character encoding of such
records.

Also added a FIXME to bulkmarcimport.pl, which because
of its use of MARC::Batch will skip over such records -
better than the original hang of the staging import, but
worse than the staging import's new ability to fix such
records.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-07 13:17:06 -05:00
Galen Charlton
bea8db3072 bug 3278: move three sysprefs to Staff client tab
* viewMARC
* viewISBN
* viewLabeledMARC

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-07 13:17:04 -05:00
Galen Charlton
3f4641bf30 bug 3201: missing090field.pl - skip bad bibs
Patch courtesy of G. Henry <henry@cmi.univ-mrs.fr>

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-07 13:17:01 -05:00
Galen Charlton
8b3655025d bug 2737: fixed typo in MARC21 008 plugin
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-07 13:16:59 -05:00
Garry Collum
165f06c68b Bug 3081: Add description for category code.
Adds the category code to the description in "my personal details" in opac.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-07 13:07:41 -05:00
Henri-Damien LAURENT
89b537273d bug 3097: statistics on itemcount not working
replacing issues.itemnumber by statistics.itemnumber
since issues was not included in the query.
All statistics on circulation for item count were zeroed.

[RM note: specifically, this patch fixes the results
 when you set the 'cell value' to 'count unique items']

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-06 18:43:48 -05:00
Joe Atzberger
c90dd8b512 Cleanup branches.pl and .tmpl
Remove entire subs that were unused.  Remove "toggle" code.
Comment out unconditional warn.
Remove inaccurate comments regarding long-fixed bugs and obsolete processes.
Remove unused variables.
Added "dialog message" div around MESSAGE8.

NOTE: all printer functions currently useless, unfixed by this patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-06 15:19:15 -05:00
Colin Campbell
af12a82e40 (bug #3197) Fix errors in markup causing validation errors
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-06 14:43:03 -05:00
Chris Cormack
863a918104 Adding 3.0.2 release to history
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-06 14:30:38 -05:00
Garry Collum
1335c417e4 Bug 3300: Fixes XHTML errors in viewlog.tmpl
Corrects a couple of missing ids associated with labels, and removes an extra </div> that appears because or the inclusion of intranet-bottom.inc

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-06-06 14:30:36 -05:00