Commit graph

10256 commits

Author SHA1 Message Date
f6519d10e3 Hide z39.50 search button for users without cataloging privileges.
This also simplifies the display of the z39.50 search button on the search results page. It's overkill to use a YUI button when there are already simpler standard buttons in use in the same area.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-12 21:14:24 -04:00
5c8d1a82c6 Adding some style to the OPAC search results page's "highlight" link
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-12 21:14:12 -04:00
2402601988 Fix for Bug 3256, "Long email address cut off in patron windows"
This fix tweaks the overflow settings for the email address and adds an image of an elipsis as the background, giving the appearance that the text is being truncated.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-12 21:13:59 -04:00
Garry Collum
90d1248a1b Bug 2505: Enabled warnings in opac-userupdate.pl
Enabled warnings.  Corrected all resulting warnings by initializing variables.

Some fixes and enhancements possibly related to Bug: 1153 - Existing B_address now shows in the resulting email. Birthdate now appears in the email using the System's default format. If the patron changes data in the form data took place the FIELD name now appears as uppercase in the resulting email.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-11 20:45:57 -04:00
Henri-Damien LAURENT
731b82f764 3519 : mergeauthority and authority edition were not synched
mergeauthority and ModAuthority were working on two separate directories.
So that no authority would ever be merged via cronjob or commandline script
when MergeAuthoritiesOnUpdate is disable

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-11 19:30:14 -04:00
d5da1cace0 future hold request followup 4 - date controls
Fixed the calendar control for selecting the request
date in staff and OPAC so that user can explicitly
select current date and all days in the future.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-11 19:23:40 -04:00
7242939cf4 future hold request followup 3 - build_holdsqueue
Fixed the holds queue job so that it correctly
ignores hold requests that are not yet scheduled
to be filled.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-11 19:23:40 -04:00
4ecaa1f9bd future hold request followup 2 - fix queries
Clarify when it is necessary to add a
'reservedate <= CURRENT_DATE()' clause.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-11 19:23:40 -04:00
e96c821ad7 future hold request followup 1 - updatedatabase
Fix so that syspref description is populated after
a database updated.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-11 19:23:39 -04:00
Michael Hafen
0458639566 Allow the reserve date to be set on holds - sysprefs
This is the two system preferences controlling this feature, and the
updatedatabase addition using db verion 3.01.00.040

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-11 18:02:30 -04:00
Michael Hafen
74a4f29236 Allow the reserve date to be set on holds
This adds to the interface and code the ability to set the reserve date when
requesting a hold.

Resubmit.  Sorry, I formatted it from the wrong branch.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-11 18:02:26 -04:00
Colin Campbell
c1d4bb641b Bug 3522 Refactor Create Update Delete letter for consistency and readability
Fixed inconsistent usuage of primary key in delete
Refactored:
Moved operations to separate subroutines to clarify data flow
Removed unnecessary redirects to self
Renamed confusingly named else variable passed to template
Other changes for code clarity
NB Outstanding:
database reading/writing should live in appropriate module
not duplicate it here.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-11 17:51:43 -04:00
7f7dfa0a11 bug 3520: fix crash when adding or editing items
Fix the following crash when adding or editing an
item record in the staff interface:

Can't call method "append_fields" on an undefined value at
/usr/local/share/perl/5.10.0/MARC/File/SAX.pm line 92.
 at /usr/local/share/perl/5.10.0/MARC/File/SAX.pm line 92

This crash appears only if a version of MARC::File::XML
greater than 0.88 is installed, and was triggered by
C4::Biblio::TransformHtmlToXml() failing to create a valid
MARCXML blob, which must include a <record> element.

This patch also fixes the indicator values generated by
TransformHtmlToXml(), setting them to " " instead of
"" when no indicator value is supplied.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-11 10:51:03 -04:00
ae5b76c89b bug 2157: add ability to 'clean' staged record batches
batches, it is now possible to 'clean' a batch by
removing all bib and item records staged in the batch.  This
has the effect of helping to reduce database space used
by old import batches as well as removing staged records
from the cataloging reservoir search.  Note that 'cleaning'
a batch affects only the copies of the records that were staged;
if the batch was committed, cleaning the batch does not
affect any bibs and items that were committed into the catalog.

Also note that once you clean a committed batch of records, it is
impossible to undo the previous commit operation.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-10 20:34:55 -04:00
f202faba18 bug 2505: enable warnings in tools/manage-marc-import.pl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-10 20:34:50 -04:00
Michael Hafen
bf723f8480 bugfix opac-user stomps mylibraryfirst value in quick search label
the system preference mylibraryfirst is exported by Auth containing the logged
in users branchcode.  It is also exported as the value of the syspref by
opac-user.pl.  The effect is that when mylibraryfirst is on and the user
logged in the text label for the OPAC quick search instead of displaying
'Search (in [branchcode] only)' shows 'Search (in 1 only)'.  Other user pages
are uneffected.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-10 20:34:46 -04:00
9f6098e8b9 Showing "more searches" menu options when JavaScript is disabled (Bug 3517)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-10 20:34:42 -04:00
833794cf3d Adding the koha-commits list to the history 2009-08-10 22:25:15 +12:00
Kyle M Hall
f41971eadf Reverse Payment - Allows any payment to be 'undone' while retaining a record of said payment. Useful for accidental double-payments.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-09 22:23:33 -04:00
Garry Collum
3c27773a41 Bug 3292: Fix to display Branch names instead of branch codes in opac serial's displays.
Fixes display of branch name in opac-full-serial-issues.tmpl and opac-serial-issues.tmpl.  Also enables zebra striping in opac-serial-issues.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-09 22:18:29 -04:00
Garry Collum
508bd2baf1 Bug 2505: Enabled warnings in opac-addbybiblionumber.pl and opac-alert-subscribe.pl
Enabled warnings and fixed unintialized variables in opac-alert-subscribe.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-09 22:18:26 -04:00
Henri-Damien LAURENT
7006c555ac _remove_stopwords in C4::Search had some issues
For some reason, it would not really do an exact match on stopwords but would also prune some other part of words

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-09 15:28:17 -04:00
Nahuel ANGELINETTI
5e4d69484c (bug #3513) fix xhtml in marc detail
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-09 15:21:35 -04:00
Garry Collum
1ab0497f7e Bug 2505: Enabled warnings in opac-serial-issues.pl and opac-showmarc.pl
Enabled warnings and also fixed resulting 'unintialized value' warning in opac-showmarc.pl.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-09 15:15:10 -04:00
Joe Atzberger
e18de9d605 Cleanup docs, typos, style etc.
Unused variable removed.  Weirdness with empty position in
assignment list also removed.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-09 13:23:16 -04:00
Joe Atzberger
41d3e534d2 Fix Maintenance page.
Without this, the mainenance page would not display because of:
Cannot use undefined value as a HASH reference in C4/Auth.pm

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-09 13:08:43 -04:00
Garry Collum
881f977cb9 Bug 3450: RSS feed link for a tag search incorrect.
Adds the tag parameter to the RSS feed link if the results of a query are retrieved from a tag in opac.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-09 13:08:41 -04:00
Garry Collum
1922efff85 Bug 2505: Enabled warnings in opac_ISBDdetail.pl, opac-modrequest.pl, and opac-tags_subject.pl.
Enabling warnings in these files did not generate any warnings in the logs when tested.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-09 13:08:38 -04:00
Nahuel ANGELINETTI
47ecf39e75 (bug #3497) show publication year, or copyrightdate
This change the shelf view in opac, to show publication year, in the column "Year"(that was previously copyrightdate), and is there is no publication year, show copyright date.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-05 20:11:00 -04:00
Nahuel ANGELINETTI
45761d67cb (bug #3505) fix 210c and 225a unimarc's plugins
This fix the 2 plugins, make 225a to work with koha 3.0, and fix 210c to be xhtml valid

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-05 20:10:42 -04:00
Nahuel ANGELINETTI
9a56d61d1f (bugs #3502) search on available items in unimarc
this add a "w" index, that allow to search on available items only

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-04 19:44:31 -04:00
5cd357e76c bug 3465: enhance DB update reporting by web installer
This enhances the web installer so that messages from updatedatabase.pl will
be displayed to the user running a database update.  Messages printed to STDOUT
will be displayed as the update report, while messages printed to STDERR will
be displayed as update errors.

This patch introduces  a new module dependency, IPC::Cmd.
IPC::Cmd lets one run an external program such as updatedatabase.pl and easily
capture STDERR and STDOUT for further munging.  IPC::Cmd is core in Perl 5.10
and stable in Perl 5.8.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-04 06:15:40 -04:00
56c72ab972 bug 3467 followup: fix test for item found
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-03 21:25:27 -04:00
Kyle M Hall
9f3ecc8a29 Quick Spine Label Printer - Minors fixes
This new version of the patch does away with the need for 2 spinelabel css files.

This patch address two points brought up:
[1] (minor) if an item is not found, it should say so and return to
spinelabel-home.pl, not show an empty label
[2] (minor) can the print button be excluded from the printout?

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-03 21:18:40 -04:00
J. David Bavousett
eb849c690a Created database-tidying cron script
This little script establishes a framework for database cleanup on some regular
schedule.  Initial implementation provides for brute truncation of the sessions
table, and selective-by-age cleanup of the zebraqueue.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-02 11:25:44 -04:00
Chris Cormack
c8f7e64d35 Adding new committer to history
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-02 11:11:22 -04:00
Garry Collum
4cb2c16587 Bug 3466: Fixes xhtml errors in opac-shelves.tmpl.
Addendum to bug 3466.  opac-shelves.tmpl contained the same xhtml error as shelves.tmpl, if the user is viewing the public list a orphaned table row (<tr>) is present.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-02 11:11:10 -04:00
Garry Collum
67085930ca Bug 2553: Alphabetizes branches and item-type drop-down lists in opac-topissues.pl.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-02 11:11:08 -04:00
dbd6128715 DB rev 038>039 (for real, this time)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-02 11:08:16 -04:00
fabede22cc textual cleanup of new quick spine label code
* perltidy
* added license header to source files

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-02 11:08:16 -04:00
57be4114d8 quell warning on NULL item fields
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-02 11:08:16 -04:00
5d0f29090b removed unneeded module imports
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-02 11:08:16 -04:00
636bb72702 quick spoine label followup: sysprefs
* Added missed SpineLabelAutoPrint to updatedatabase;
  this preference controls whether labels generated
  by the new quick spine label tool are printed automatically
* put SpineLabelAutoPrint and SpineLabelFormat in the
  Cataloging section of the syspref editor
* set height and width for the SpineLabelFormat textarea
  in the syspref editor

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-02 11:08:16 -04:00
97b0448eeb bumping quick spine label printing to DBrev 039
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-02 11:08:15 -04:00
Kyle M Hall
6860310e96 Quick Spine Label Printer
This is a small tool for quickly printing spine labels using dedicated label printers.
It is located in the Tools page as Quick Spine Label Creator.
The system preference SpineLabelFormat defines which fields will be displayed.
The pref SpineLabelAutoPrint will make the print dialog pop up automatically.
The CSS file spinelabel.css controls all presentation for the labels.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-01 10:47:13 -04:00
b35b727924 DB rev 038->039
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-01 09:59:35 -04:00
23b63ff978 bug 3440 followup: tweak updatedatabase.pl
[1] Removed POD: not a bad idea, but if we do it,
    there should be more substance to the messages
[2] Improved description of change
[3] Removed extra 'my' qualifier.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-01 09:59:29 -04:00
Sébastien Hinderer
7fa051d837 bug 3440: C4/Branch.pm: the branch{zip,city,country,url,notes} rows should be taken into account during Add and Mod operations.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-01 09:44:32 -04:00
Sébastien Hinderer
1ac250ea27 bug 3440: Modifies branches script and template so that the newly added rows are taken into account.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-01 09:44:22 -04:00
Sébastien Hinderer
9d34a4caa1 bug 3440: Database structure modification.
Adds 5 columns to the `branches` table: `branchzip`, `branchcity`,
`branchcountry`, `branchurl` and `branchnote`.
I/O operations for these fields are not included.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
2009-08-01 09:43:44 -04:00